mgmt-core, ignore invalid url in location, as this header usually not used in ARM, but could be used by other purposes (Azure#18442)

Author: weidongxu-microsoft

sdk/core/azure-core-management/src/main/java/com/azure/core/management/implementation/polling/Util.java

@@ -21,7 +21,7 @@ class Util {
      * @return the Azure-AsyncOperation header value if exists, null otherwise
      */
     static URL getAzureAsyncOperationUrl(HttpHeaders headers, ClientLogger logger) {
-        return getUrl("Azure-AsyncOperation", headers, logger);
+        return getUrl("Azure-AsyncOperation", headers, logger, false);
     }
 
     /**
@@ -32,7 +32,7 @@ static URL getAzureAsyncOperationUrl(HttpHeaders headers, ClientLogger logger) {
      * @return the Location header value if exists, null otherwise
      */
     static URL getLocationUrl(HttpHeaders headers, ClientLogger logger) {
-        return getUrl("Location", headers, logger);
+        return getUrl("Location", headers, logger, true);
     }
 
     /**
@@ -43,14 +43,18 @@ static URL getLocationUrl(HttpHeaders headers, ClientLogger logger) {
      * @param logger the logger
      * @return the URL value of the given header, null if header does not exists.
      */
-    static URL getUrl(String urlHeaderName, HttpHeaders headers, ClientLogger logger) {
+    static URL getUrl(String urlHeaderName, HttpHeaders headers, ClientLogger logger, boolean ignoreException) {
         String value = headers.getValue(urlHeaderName);
         if (value != null) {
             try {
                 return new URL(value);
             } catch (MalformedURLException me) {
-                throw logger.logExceptionAsError(new RuntimeException("Malformed value '" + value
-                    + "' for URL header: '" + urlHeaderName + "'.", me));
+                String message = "Malformed value '" + value + "' for URL header: '" + urlHeaderName + "'.";
+                if (ignoreException) {
+                    logger.logExceptionAsError(new RuntimeException(message, me));
+                } else {
+                    throw logger.logExceptionAsError(new RuntimeException(message, me));
+                }
             }
         }
         return null;

sdk/core/azure-core-management/src/test/java/com/azure/core/management/implementation/polling/UtilTests.java

@@ -0,0 +1,42 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.azure.core.management.implementation.polling;
+
+import com.azure.core.http.HttpHeaders;
+import com.azure.core.util.logging.ClientLogger;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+import java.net.MalformedURLException;
+import java.net.URL;
+
+public class UtilTests {
+
+    private final ClientLogger logger = new ClientLogger(UtilTests.class);
+
+    @Test
+    public void testGetURL() throws MalformedURLException {
+        String asyncOpUrl = "https://management.azure.com/subscriptions/###/providers/Microsoft.Network/locations/eastus/operations/###";
+        String locationUrl = "https://management.azure.com/subscriptions/###/resourceGroups/rg86829b7a87d74/providers/Microsoft.Search/searchServices/ss3edfb54d";
+
+        HttpHeaders headers = new HttpHeaders();
+        headers.put("Azure-AsyncOperation", asyncOpUrl);
+        headers.put("Location", locationUrl);
+
+        Assertions.assertEquals(new URL(asyncOpUrl), Util.getAzureAsyncOperationUrl(headers, logger));
+        Assertions.assertEquals(new URL(locationUrl), Util.getLocationUrl(headers, logger));
+    }
+
+    @Test
+    public void testGetMalformedURL() {
+        HttpHeaders asyncOpHeaders = new HttpHeaders();
+        asyncOpHeaders.put("Azure-AsyncOperation", "invalidUrl");
+        Assertions.assertThrows(RuntimeException.class, () -> Util.getAzureAsyncOperationUrl(asyncOpHeaders, logger));
+
+        // malformed URL in location will be ignored
+        HttpHeaders locationHeaders = new HttpHeaders();
+        locationHeaders.put("Location", "invalidUrl");
+        Assertions.assertNull(Util.getLocationUrl(locationHeaders, logger));
+    }
+}