Allow http in SAS policy. (Azure#18408)

* do not require https in sas policy

* Revert "do not require https in sas policy"

This reverts commit 07ee3b2.

* option to not require https policy.

Author: kasobol-msft

sdk/core/azure-core/src/main/java/com/azure/core/http/policy/AzureSasCredentialPolicy.java

@@ -14,29 +14,42 @@
 
 /**
  * Pipeline policy that uses an {@link AzureSasCredential} to set the shared access signature for a request.
- * <p>
- * Requests sent with this pipeline policy are required to use {@code HTTPS}. If the request isn't using {@code HTTPS}
- * an exception will be thrown to prevent leaking the shared access signature.
  */
 public final class AzureSasCredentialPolicy implements HttpPipelinePolicy {
     private final AzureSasCredential credential;
+    private final boolean requireHttps;
 
     /**
      * Creates a policy that uses the passed {@link AzureSasCredential} to append sas to query string.
+     * <p>
+     * Requests sent with this pipeline policy are required to use {@code HTTPS}.
+     * If the request isn't using {@code HTTPS}
+     * an exception will be thrown to prevent leaking the shared access signature.
      *
      * @param credential The {@link AzureSasCredential} containing the shared access signature to use.
      * @throws NullPointerException If {@code credential} is {@code null}.
      */
     public AzureSasCredentialPolicy(AzureSasCredential credential) {
-        Objects.requireNonNull(credential, "'credential' cannot be null.");
+        this(credential, true);
+    }
 
+    /**
+     * Creates a policy that uses the passed {@link AzureSasCredential} to append sas to query string.
+     *
+     * @param credential The {@link AzureSasCredential} containing the shared access signature to use.
+     * @param requireHttps A flag indicating whether {@code HTTPS} is required.
+     * @throws NullPointerException If {@code credential} is {@code null}.
+     */
+    public AzureSasCredentialPolicy(AzureSasCredential credential, boolean requireHttps) {
+        Objects.requireNonNull(credential, "'credential' cannot be null.");
         this.credential = credential;
+        this.requireHttps = requireHttps;
     }
 
     @Override
     public Mono<HttpResponse> process(HttpPipelineCallContext context, HttpPipelineNextPolicy next) {
         HttpRequest httpRequest = context.getHttpRequest();
-        if ("http".equals(httpRequest.getUrl().getProtocol())) {
+        if (requireHttps && "http".equals(httpRequest.getUrl().getProtocol())) {
             return Mono.error(new IllegalStateException(
                 "Shared access signature credentials require HTTPS to prevent leaking the shared access signature."));
         }

sdk/core/azure-core/src/test/java/com/azure/core/credential/CredentialsTests.java

@@ -113,7 +113,7 @@ public void sasCredentialsTest(String signature, String url, String expectedUrl)
     }
 
     @Test
-    public void sasCredentialsHTTPSchemeTest() throws Exception {
+    public void sasCredentialsRequireHTTPSSchemeTest() throws Exception {
         AzureSasCredential credential = new AzureSasCredential("foo");
 
         final HttpPipeline pipeline = new HttpPipelineBuilder()
@@ -126,4 +126,23 @@ public void sasCredentialsHTTPSchemeTest() throws Exception {
             .expectErrorMessage("Shared access signature credentials require HTTPS to prevent leaking the shared access signature.")
             .verify();
     }
+
+    @Test
+    public void sasCredentialsDoNotRequireHTTPSchemeTest() throws Exception {
+        AzureSasCredential credential = new AzureSasCredential("foo");
+
+        HttpPipelinePolicy auditorPolicy =  (context, next) -> {
+            String actualUrl = context.getHttpRequest().getUrl().toString();
+            Assertions.assertEquals("http://localhost?foo", actualUrl);
+            return next.process();
+        };
+
+        final HttpPipeline pipeline = new HttpPipelineBuilder()
+            .httpClient(new NoOpHttpClient())
+            .policies(new AzureSasCredentialPolicy(credential, false), auditorPolicy)
+            .build();
+
+        HttpRequest request = new HttpRequest(HttpMethod.GET, new URL("http://localhost"));
+        pipeline.send(request).block();
+    }
 }