Skip to content

Commit 276c40e

Browse files
authored
Mgmt-Lite: update suffix parameters during runtime (Azure#17861)
* update suffix parameters * set changeable parameter to None first to guarantee it would be updated first * fix typo
1 parent d639c94 commit 276c40e

File tree

2 files changed

+28
-6
lines changed

2 files changed

+28
-6
lines changed

eng/mgmt/automation/generate.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@ def parse_args() -> argparse.Namespace:
325325
action = 'store_true',
326326
help = 'Do compile after generation or not',
327327
)
328+
parser.add_argument('--suffix', help = 'Suffix for namespace and artifact')
328329
parser.add_argument(
329330
'--auto-commit-external-change',
330331
action = 'store_true',
@@ -340,6 +341,20 @@ def parse_args() -> argparse.Namespace:
340341
return parser.parse_args()
341342

342343

344+
def update_parameters(suffix):
345+
# update changeable parameters in parameters.py
346+
global SUFFIX, NAMESPACE_SUFFIX, ARTIFACT_SUFFIX, NAMESPACE_FORMAT, ARTIFACT_FORMAT, OUTPUT_FOLDER_FORMAT
347+
348+
SUFFIX = suffix
349+
350+
NAMESPACE_SUFFIX = '.{0}'.format(SUFFIX) if SUFFIX else ''
351+
ARTIFACT_SUFFIX = '-{0}'.format(SUFFIX) if SUFFIX else ''
352+
NAMESPACE_FORMAT = 'com.azure.resourcemanager.{{0}}{0}'.format(
353+
NAMESPACE_SUFFIX)
354+
ARTIFACT_FORMAT = 'azure-resourcemanager-{{0}}{0}'.format(ARTIFACT_SUFFIX)
355+
OUTPUT_FOLDER_FORMAT = 'sdk/{{0}}/{0}'.format(ARTIFACT_FORMAT)
356+
357+
343358
def valid_service(service: str):
344359
return re.sub('[^a-z0-9_]', '', service.lower())
345360

@@ -458,6 +473,7 @@ def sdk_automation(input_file: str, output_file: str):
458473

459474
def main():
460475
args = vars(parse_args())
476+
update_parameters(args.get('suffix'))
461477

462478
if args.get('config'):
463479
return sdk_automation(args['config'][0], args['config'][1])

eng/mgmt/automation/parameters.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,24 @@
11
#!/usr/bin/env python3
22

3+
# changeable parameters
4+
# use update logic in generate.py#update_parameters
5+
# set to None first to guarantee it would be updated
6+
SUFFIX = None
7+
8+
NAMESPACE_SUFFIX = None
9+
ARTIFACT_SUFFIX = None
10+
NAMESPACE_FORMAT = None
11+
ARTIFACT_FORMAT = None
12+
OUTPUT_FOLDER_FORMAT = None
13+
14+
# Constant parameters
315
SDK_ROOT = '../../../' # related to file dir
416
AUTOREST_CORE_VERSION = '3.0.6327'
517
AUTOREST_JAVA = '@autorest/java@4.0.5'
618
DEFAULT_VERSION = '1.0.0-beta.1'
7-
SUFFIX = None # 'generated'
819
GROUP_ID = 'com.azure.resourcemanager'
920
API_SPECS_FILE = 'api-specs.yaml'
1021

11-
NAMESPACE_SUFFIX = '.{0}'.format(SUFFIX) if SUFFIX else ''
12-
ARTIFACT_SUFFIX = '-{0}'.format(SUFFIX) if SUFFIX else ''
13-
NAMESPACE_FORMAT = 'com.azure.resourcemanager.{{0}}{0}'.format(NAMESPACE_SUFFIX)
14-
ARTIFACT_FORMAT = 'azure-resourcemanager-{{0}}{0}'.format(ARTIFACT_SUFFIX)
15-
OUTPUT_FOLDER_FORMAT = 'sdk/{{0}}/{0}'.format(ARTIFACT_FORMAT)
1622
CI_FILE_FORMAT = 'sdk/{0}/ci.yml'
1723
POM_FILE_FORMAT = 'sdk/{0}/pom.xml'
1824
README_FORMAT = 'specification/{0}/resource-manager/readme.md'

0 commit comments

Comments
 (0)