Skip to content

Commit 17d6ca1

Browse files
authored
Update the scripts to not trigger pipeline for each patched SDK (Azure#27554)
Also, fix a regression in update_version.py file.
1 parent fa61d30 commit 17d6ca1

File tree

2 files changed

+9
-13
lines changed

2 files changed

+9
-13
lines changed

eng/scripts/bomhelpers.ps1

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -96,15 +96,15 @@ function GetPipelineName([string]$ArtifactId, [string]$ArtifactDirPath) {
9696
}
9797

9898
function TriggerPipeline($PatchInfos, $BranchName) {
99-
$distinctPipelineNames = $PatchInfos | ForEach-Object { $_.PipelineName } | Get-Unique -AsString
100-
$distinctPipelineNames | ForEach-Object {
101-
Write-Output "Triggering pipeline $_"
102-
$cmdOutput = az pipelines run -o json --name ""$_"" --organization "https://dev.azure.com/azure-sdk" --project "internal" --branch ""$BranchName""
103-
if($LASTEXITCODE) {
104-
LogError "Could not trigger the run for the pipeline $_"
105-
exit $LASTEXITCODE
106-
}
107-
}
99+
# $distinctPipelineNames = $PatchInfos | ForEach-Object { $_.PipelineName } | Get-Unique -AsString
100+
# $distinctPipelineNames | ForEach-Object {
101+
# Write-Output "Triggering pipeline $_"
102+
# $cmdOutput = az pipelines run -o json --name ""$_"" --organization "https://dev.azure.com/azure-sdk" --project "internal" --branch ""$BranchName""
103+
# if($LASTEXITCODE) {
104+
# LogError "Could not trigger the run for the pipeline $_"
105+
# exit $LASTEXITCODE
106+
# }
107+
# }
108108
}
109109

110110
function GetBranchName($ArtifactId) {

eng/versioning/update_versions.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,6 @@ def update_versions(update_type, version_map, ext_dep_map, target_file, skip_rea
114114
if module:
115115
new_include_version = module.string_for_allowlist_include()
116116
newline = re.sub(external_dependency_include_regex, new_include_version, line)
117-
else:
118-
continue
119117
except AttributeError:
120118
raise ValueError('Module: {0} does not have an external dependency version.\nFile={1}\nLine={2}'.format(module_name, target_file, line))
121119
else:
@@ -124,8 +122,6 @@ def update_versions(update_type, version_map, ext_dep_map, target_file, skip_rea
124122
if module:
125123
new_version = module.external_dependency
126124
newline = re.sub(external_dependency_version_regex, new_version, line)
127-
else:
128-
continue
129125
except AttributeError:
130126
raise ValueError('Module: {0} does not have an external dependency version.\nFile={1}\nLine={2}'.format(module_name, target_file, line))
131127
else:

0 commit comments

Comments
 (0)