Optimize ModelHelper and Use Class Wrapper instead of Copying (Azure#26008)

Optimize ModelHelper and Use Class Wrapper instead of Copying

Author: alzimmermsft

eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml

@@ -755,6 +755,7 @@
   <Match>
     <Or>
       <Class name="com.azure.core.util.paging.PagedFluxCoreJavaDocCodeSnippets"/>
+      <Class name="com.azure.storage.blob.implementation.models.BlobPropertiesInternalDownload"/>
     </Or>
     <Bug pattern="NP_LOAD_OF_KNOWN_NULL_VALUE,
     SIC_INNER_SHOULD_BE_STATIC_ANON,
@@ -1330,7 +1331,7 @@
     <Method name="init"/>
     <Bug pattern="REC_CATCH_EXCEPTION"/>
   </Match>
-  
+
   <Match>
     <Class name="com.azure.cosmos.encryption.EncryptionCosmosAsyncContainer"/>
     <Method name="decryptResponseAsync"/>
@@ -1908,7 +1909,7 @@
     <Method name="subscribe"/>
     <Bug pattern="DE_MIGHT_IGNORE"/>
   </Match>
-  
+
   <!-- Exception is ignored by design which indicate that non-parsable id -->
   <Match>
     <Class name="com.azure.cosmos.implementation.ResourceId"/>

sdk/storage/azure-storage-blob-nio/README.md

@@ -194,7 +194,7 @@ to guarantee that the data is available to be read.
 try (OutputStream os = Files.newOutputStream(filePath)) {
     os.write(0);
 }
-``` 
+```
 
 ### Copy a file
 

sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobUrlParts.java

@@ -407,7 +407,7 @@ private static void parseIpUrl(URL url, BlobUrlParts parts) {
             path = path.substring(1);
         }
 
-        String[] pathPieces = path.split("/", 3);
+        String[] pathPieces = ModelHelper.FORWARD_SLASH.split(path, 3);
         parts.setAccountName(pathPieces[0]);
 
         if (pathPieces.length >= 3) {

sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/implementation/accesshelpers/BlobDownloadHeadersConstructorProxy.java

@@ -0,0 +1,59 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.azure.storage.blob.implementation.accesshelpers;
+
+import com.azure.storage.blob.implementation.models.BlobsDownloadHeaders;
+import com.azure.storage.blob.models.BlobDownloadHeaders;
+
+/**
+ * Helper class to access private values of {@link BlobDownloadHeaders} across package boundaries.
+ */
+public final class BlobDownloadHeadersConstructorProxy {
+    private static BlobDownloadHeadersConstructorAccessor accessor;
+
+    private BlobDownloadHeadersConstructorProxy() { }
+
+    /**
+     * Type defining the methods to set the non-public properties of a {@link BlobDownloadHeadersConstructorAccessor}
+     * instance.
+     */
+    public interface BlobDownloadHeadersConstructorAccessor {
+        /**
+         * Creates a new instance of {@link BlobDownloadHeaders} backed by an internal instance of
+         * {@link BlobsDownloadHeaders}.
+         *
+         * @param internalHeaders The internal headers.
+         * @return A new instance of {@link BlobDownloadHeaders}.
+         */
+        BlobDownloadHeaders create(BlobsDownloadHeaders internalHeaders);
+    }
+
+    /**
+     * The method called from {@link BlobDownloadHeaders} to set it's accessor.
+     *
+     * @param accessor The accessor.
+     */
+    public static void setAccessor(final BlobDownloadHeadersConstructorAccessor accessor) {
+        BlobDownloadHeadersConstructorProxy.accessor = accessor;
+    }
+
+    /**
+     * Creates a new instance of {@link BlobDownloadHeaders} backed by an internal instance of
+     * {@link BlobsDownloadHeaders}.
+     *
+     * @param internalHeaders The internal headers.
+     * @return A new instance of {@link BlobDownloadHeaders}.
+     */
+    public static BlobDownloadHeaders create(BlobsDownloadHeaders internalHeaders) {
+        // This looks odd but is necessary, it is possible to engage the access helper before anywhere else in the
+        // application accesses BlobDownloadHeaders which triggers the accessor to be configured. So, if the accessor
+        // is null this effectively pokes the class to set up the accessor.
+        if (accessor == null) {
+            new BlobDownloadHeaders();
+        }
+
+        assert accessor != null;
+        return accessor.create(internalHeaders);
+    }
+}

sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/implementation/accesshelpers/BlobPropertiesConstructorProxy.java

@@ -0,0 +1,60 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.azure.storage.blob.implementation.accesshelpers;
+
+import com.azure.storage.blob.implementation.models.BlobPropertiesInternal;
+import com.azure.storage.blob.models.BlobProperties;
+
+/**
+ * Helper class to access private values of {@link BlobProperties} across package boundaries.
+ */
+public final class BlobPropertiesConstructorProxy {
+    private static BlobPropertiesConstructorAccessor accessor;
+
+    private BlobPropertiesConstructorProxy() {
+    }
+
+    /**
+     * Interface defining the methods that access non-public APIs of a {@link BlobProperties} instance.
+     */
+    public interface BlobPropertiesConstructorAccessor {
+        /**
+         * Creates a new instance of {@link BlobProperties} backed by an internal instance of
+         * {@link BlobPropertiesInternal}.
+         *
+         * @param internalProperties The internal properties.
+         * @return A new instance of {@link BlobProperties}.
+         */
+        BlobProperties create(BlobPropertiesInternal internalProperties);
+    }
+
+    /**
+     * The method called from the static initializer of {@link BlobProperties} to set it's accessor.
+     *
+     * @param accessor The {@link BlobProperties} accessor.
+     */
+    public static void setAccessor(final BlobPropertiesConstructorAccessor accessor) {
+        BlobPropertiesConstructorProxy.accessor = accessor;
+    }
+
+    /**
+     * Creates a new instance of {@link BlobProperties} backed by an internal instance of
+     * {@link BlobPropertiesInternal}.
+     *
+     * @param internalProperties The internal properties.
+     * @return A new instance of {@link BlobProperties}.
+     */
+    public static BlobProperties create(BlobPropertiesInternal internalProperties) {
+        // This looks odd but is necessary, it is possible to engage the access helper before anywhere else in the
+        // application accesses BlobDownloadHeaders which triggers the accessor to be configured. So, if the accessor
+        // is null this effectively pokes the class to set up the accessor.
+        if (accessor == null) {
+            new BlobProperties(null, null, null, 0, null, null, null, null, null, null, null, null, null, null, null,
+            null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null);
+        }
+
+        assert accessor != null;
+        return accessor.create(internalProperties);
+    }
+}