Skip to content

Commit 0471720

Browse files
AikoBBAigerim Beishenbekova
andauthored
Reverting unwanted changes in spotbugs-exclude.xml & checkstyle-suppressions.xml (Azure#25362)
Co-authored-by: Aigerim Beishenbekova <aigerimb@DESKTOP-D4IJIGC.redmond.corp.microsoft.com>
1 parent 60f92e8 commit 0471720

File tree

2 files changed

+29
-1
lines changed

2 files changed

+29
-1
lines changed

eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444

4545
<!-- Fields tenantId, clientId and clientSecret are not set in all constructors. -->
4646
<suppress checks="com.azure.tools.checkstyle.checks.EnforceFinalFieldsCheck" files="com.azure.security.keyvault.jca.implementation.KeyVaultClient"/>
47-
47+
4848
<!-- Fields defaultTrustManager and keyStore might be set more than once. -->
4949
<suppress checks="com.azure.tools.checkstyle.checks.EnforceFinalFieldsCheck" files="com.azure.security.keyvault.jca.KeyVaultTrustManager"/>
5050

@@ -510,6 +510,7 @@ the main ServiceBusClientBuilder. -->
510510
<suppress checks="MethodName" files="com.azure.spring.data.gremlin.common.GremlinConfig.java"/>
511511

512512
<suppress checks="MethodName" files="com.azure.spring.integration.core.api.CheckpointConfig.java"/>
513+
<suppress checks="MethodName" files="com.azure.spring.integration.core.api.BatchConsumerConfig.java"/>
513514
<suppress checks="MethodName" files="com.azure.spring.integration.servicebus.ServiceBusClientConfig.java"/>
514515

515516
<!-- Checkstyle suppressions for azure.spring.data.cosmos package -->

eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1310,6 +1310,13 @@
13101310
<Bug pattern="REC_CATCH_EXCEPTION"/>
13111311
</Match>
13121312

1313+
<!-- Exception is required to handle when getting java version -->
1314+
<Match>
1315+
<Class name="com.azure.cosmos.implementation.Utils"/>
1316+
<Method name="getJavaVersion"/>
1317+
<Bug pattern="REC_CATCH_EXCEPTION"/>
1318+
</Match>
1319+
13131320
<!-- Exception is required to handle and fallback to default pair -->
13141321
<Match>
13151322
<Class name="com.azure.cosmos.implementation.ResourceId"/>
@@ -1883,6 +1890,13 @@
18831890
<Bug pattern="DE_MIGHT_IGNORE"/>
18841891
</Match>
18851892

1893+
<!-- Exception in AutoCloseable.close is ignored -->
1894+
<Match>
1895+
<Class name="com.azure.core.tracing.opentelemetry.OpenTelemetryHttpPolicy$ScalarPropagatingMono"/>
1896+
<Method name="subscribe"/>
1897+
<Bug pattern="DE_MIGHT_IGNORE"/>
1898+
</Match>
1899+
18861900
<!-- Exception is ignored by design which indicate that non-parsable id -->
18871901
<Match>
18881902
<Class name="com.azure.cosmos.implementation.ResourceId"/>
@@ -2414,6 +2428,10 @@
24142428
<Method name="~(get|post)"/>
24152429
<Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
24162430
</Match>
2431+
<Match>
2432+
<Class name="com.azure.security.keyvault.jca.implementation.KeyVaultPrivateKey"/>
2433+
<Bug pattern="SE_BAD_FIELD"/>
2434+
</Match>
24172435

24182436
<!-- Returning a new copy of the object is not necessary for queuing system use cases.
24192437
Client do not change content of message once message is created. Array copy would degrade the performance.
@@ -2499,4 +2517,13 @@
24992517
<Method name="getServiceVersions"/>
25002518
<Bug pattern="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE"/>
25012519
</Match>
2520+
2521+
<Match>
2522+
<Class name="~com\.azure\.search.*"/>
2523+
<Or>
2524+
<Field name="odataType"/>
2525+
<Field name="type"/>
2526+
</Or>
2527+
<Bug pattern="URF_UNREAD_FIELD"/>
2528+
</Match>
25022529
</FindBugsFilter>

0 commit comments

Comments
 (0)