Comments & rename to clarify blocklist behavior

Author: anthony-c-martin

generator/autogenlist.ts

@@ -8,8 +8,7 @@ import { postProcessor as policyProcessor } from './processors/Microsoft.Authori
 import { postProcessor as securityInsightsPostProcessor } from './processors/Microsoft.SecurityInsights';
 import { lowerCaseEquals } from './utils';
 
-// Going forwards, providers are onboarded by default.
-// The providers listed here are the only ones **not** onboarded.
+// New providers are onboarded by default. The providers listed here are the only ones **not** onboarded.
 const disabledProviders: AutoGenConfig[] = [
     {
         basePath: 'advisor/resource-manager',
@@ -71,6 +70,12 @@ const disabledProviders: AutoGenConfig[] = [
         namespace: 'Microsoft.DataProtection',
         disabledForAutogen: true,
     },
+    {
+        // Disabled as the swagger spec contains a type ("DateTimeRfc1123") which autorest is unable to parse: https://github.com/Azure/autorest.azureresourceschema/issues/71
+        basePath: 'domainservices/resource-manager',
+        namespace: 'Microsoft.AAD',
+        disabledForAutogen: true,
+    },
     {
         basePath: 'dfp/resource-manager',
         namespace: 'Microsoft.Dynamics365Fraudprotection',
@@ -484,10 +489,6 @@ const autoGenList: AutoGenConfig[] = [
         basePath: 'EnterpriseKnowledgeGraph/resource-manager',
         namespace: 'Microsoft.EnterpriseKnowledgeGraph',
     },
-    {
-        basePath: 'domainservices/resource-manager',
-        namespace: 'Microsoft.AAD',
-    },
     {
         basePath: 'eventhub/resource-manager',
         namespace: 'Microsoft.EventHub',

generator/constants.ts

@@ -34,24 +34,12 @@ export const generatedSchemasTemplatePath = path.join(__dirname, 'resources/auto
 export const autorestCoreVersion = '3.0.6374';
 export const azureresourceschemaVersion = '3.0.92';
 
-// paths in this list won't even appear in list-basepaths
-export const blocklist = [
+// paths in this list won't even appear in list-basepaths. 
+// This list should only contain spec paths that should DEFINITELY be excluded from generation.
+// For now - that should just be Azure Stack providers, and deprecated providers.
+export const excludedBasePathPrefixes = [
     /* Azure Stack resource providers */
-    'azsadmin/resource-manager/azurebridge',
-    'azsadmin/resource-manager/backup',
-    'azsadmin/resource-manager/commerce',
-    'azsadmin/resource-manager/compute',
-    'azsadmin/resource-manager/containerregistry',
-    'azsadmin/resource-manager/deployment',
-    'azsadmin/resource-manager/fabric',
-    'azsadmin/resource-manager/gallery',
-    'azsadmin/resource-manager/infrastructureinsights',
-    'azsadmin/resource-manager/keyvault',
-    'azsadmin/resource-manager/network',
-    'azsadmin/resource-manager/storage',
-    'azsadmin/resource-manager/subscriptions',
-    'azsadmin/resource-manager/update',
-    'azsadmin/resource-manager/user-subscriptions',
+    'azsadmin/',
     /* Microsoft.CustomerInsights is deprecated */
-    'customer-insights/resource-manager',
+    'customer-insights/',
 ];

generator/specs.ts

@@ -54,7 +54,7 @@ export async function generateBasePaths(localPath: string) {
     return filePaths
         .map(p => p.substring(0, p.lastIndexOf(path.sep)))
         .map(getBasePathString.bind(null, localPath))
-        .filter(p => !isBlocklisted(p));
+        .filter(p => !isExcludedBasePath(p));
 }
 
 export function getBasePathString(localPath: string, basePath: string) {
@@ -70,8 +70,10 @@ export function getPackageString(readme: string) {
         .find((_, index, obj) => index > 0 && obj[index - 1] === 'specification');
 }
 
-function isBlocklisted(basePath: string) {
-    return constants.blocklist.includes(basePath);
+function isExcludedBasePath(basePath: string) {
+    return constants.excludedBasePathPrefixes
+        .map(prefix => prefix.toLowerCase())
+        .some(prefix => basePath.toLowerCase().startsWith(prefix));
 }
 
 export async function prepareReadme(readme: string, autoGenConfig?: AutoGenConfig) {