Skip to content

Commit d9b8d2e

Browse files
authored
Merge pull request #612 from juniwang/master
include more properties in SignalR Resource
2 parents 17d92d8 + 6e0aa94 commit d9b8d2e

File tree

2 files changed

+50
-1
lines changed

2 files changed

+50
-1
lines changed

schemas/2018-10-01/Microsoft.SignalRService.json

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,46 @@
130130
"hostNamePrefix": {
131131
"type": "string",
132132
"description": "Prefix for the hostName of the SignalR service. Retained for future use.\r\nThe hostname will be of format: <hostNamePrefix>.service.signalr.net."
133+
},
134+
"features": {
135+
"type": "array",
136+
"description": "List of SignalR featureFlags. e.g. ServiceMode.\r\n\r\nFeatureFlags that are not included in the parameters for the update operation will not be modified.\r\nAnd the response will only include featureFlags that are explicitly set. \r\nWhen a featureFlag is not explicitly set, SignalR service will use its globally default value. \r\nBut keep in mind, the default value doesn't mean \"false\". It varies in terms of different FeatureFlags.",
137+
"items": {
138+
"$ref": "#/definitions/SignalRFeature"
139+
}
133140
}
134141
},
135142
"description": "Settings used to provision or configure the resource."
143+
},
144+
"SignalRFeature": {
145+
"description": "Feature of a SignalR resource, which controls the SignalR runtime behavior.",
146+
"required": [
147+
"flag",
148+
"value"
149+
],
150+
"type": "object",
151+
"properties": {
152+
"flag": {
153+
"description": "Kind of feature. Required.",
154+
"enum": [
155+
"ServiceMode"
156+
],
157+
"type": "string"
158+
},
159+
"value": {
160+
"description": "Value of the feature flag. See Azure SignalR service document https://docs.microsoft.com/en-us/azure/azure-signalr/ for allowed values.",
161+
"maxLength": 128,
162+
"minLength": 1,
163+
"type": "string"
164+
},
165+
"properties": {
166+
"description": "Optional properties related to this feature.",
167+
"type": "object",
168+
"additionalProperties": {
169+
"type": "string"
170+
}
171+
}
172+
}
136173
}
137174
}
138175
}

tests/2018-10-01/Microsoft.SignalRService.tests.json

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,13 @@
1515
"from": "test"
1616
},
1717
"properties": {
18-
"hostNamePrefix": "signalr-free-westus"
18+
"hostNamePrefix": "signalr-free-westus",
19+
"features": [
20+
{
21+
"flag": "ServiceMode",
22+
"value": "Default"
23+
}
24+
]
1925
}
2026
}
2127
},
@@ -35,6 +41,12 @@
3541
"region": "EastUS"
3642
},
3743
"properties": {
44+
"features": [
45+
{
46+
"flag": "ServiceMode",
47+
"value": "Serverless"
48+
}
49+
]
3850
}
3951
}
4052
}

0 commit comments

Comments
 (0)