Skip to content

Conversation

@m7md7sien
Copy link
Contributor

Description

Tools Evaluators Fix: Check input tool_definitions for built-in tools to handle Agent v2 case

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copilot AI review requested due to automatic review settings November 26, 2025 15:26
@m7md7sien m7md7sien requested a review from a team as a code owner November 26, 2025 15:26
@github-actions github-actions bot added the Evaluation Issues related to the client library for Azure AI Evaluation label Nov 26, 2025
Copilot finished reviewing on behalf of m7md7sien November 26, 2025 15:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the tool evaluators that was preventing them from correctly handling built-in tool definitions provided by Agent v2. The fix removes an overly restrictive type check when validating that tool calls have corresponding tool definitions.

Key Changes

  • Simplified tool definition lookup in _extract_needed_tool_definitions method by removing the type restriction
  • Allows matching tool definitions by name alone, regardless of their type field value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Evaluation Issues related to the client library for Azure AI Evaluation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants