Azure
diff --git a/‎.github/CODEOWNERS‎
Lines changed: 4 additions & 2 deletions b/‎.github/CODEOWNERS‎
Lines changed: 4 additions & 2 deletions
diff --git a/‎README.md‎
Lines changed: 4 additions & 0 deletions b/‎README.md‎
Lines changed: 4 additions & 0 deletions
diff --git a/‎eng/common/scripts/Detect-Api-Changes.ps1‎
Lines changed: 6 additions & 9 deletions b/‎eng/common/scripts/Detect-Api-Changes.ps1‎
Lines changed: 6 additions & 9 deletions
diff --git a/‎eng/common/testproxy/docker-start-proxy.ps1‎
Lines changed: 2 additions & 2 deletions b/‎eng/common/testproxy/docker-start-proxy.ps1‎
Lines changed: 2 additions & 2 deletions
diff --git a/‎eng/guardian-tools/policheck/PolicheckExclusions.xml‎
Lines changed: 12 additions & 0 deletions b/‎eng/guardian-tools/policheck/PolicheckExclusions.xml‎
Lines changed: 12 additions & 0 deletions
diff --git a/‎eng/pipelines/aggregate-reports.yml‎
Lines changed: 100 additions & 55 deletions b/‎eng/pipelines/aggregate-reports.yml‎
Lines changed: 100 additions & 55 deletions
diff --git a/‎eng/pipelines/templates/steps/auth-dev-feed.yml‎
Lines changed: 1 addition & 1 deletion b/‎eng/pipelines/templates/steps/auth-dev-feed.yml‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎eng/pipelines/templates/steps/verify-autorest.yml‎
Lines changed: 1 addition & 0 deletions b/‎eng/pipelines/templates/steps/verify-autorest.yml‎
Lines changed: 1 addition & 0 deletions
diff --git a/‎eng/tox/allowed_pylint_failures.py‎
Lines changed: 2 additions & 1 deletion b/‎eng/tox/allowed_pylint_failures.py‎
Lines changed: 2 additions & 1 deletion
diff --git a/‎eng/tox/tox.ini‎
Lines changed: 3 additions & 0 deletions b/‎eng/tox/tox.ini‎
Lines changed: 3 additions & 0 deletions
@@ -17,7 +17,7 @@
 # Service team
 ####
 # PRLabel: %Azure.Identity
-/sdk/identity/                                                       @chlowell @mccoyp @schaabs
+/sdk/identity/                                                       @chlowell @mccoyp @schaabs @xiangyan99
 
 # PRLabel: %Event Hubs
 /sdk/eventhub/                                                       @annatisch @yunhaoling @swathipil @rakshith91
@@ -39,6 +39,8 @@
 
 # PRLabel: %Communication
 /sdk/communication/                                                  @acsdevx-msft
+/sdk/communication/azure-communication-phonenumbers/                 @RoyHerrod @danielav7 @whisper6284 @AlonsoMondal
+/sdk/communication/azure-communication-sms/                          @RoyHerrod @arifibrahim4
 
 # PRLabel: %KeyVault
 /sdk/keyvault/                                                       @schaabs @chlowell @mccoyp @YalinLi0312
@@ -101,7 +103,7 @@
 /sdk/servicebus/                                                     @annatisch @yunhaoling @swathipil @rakshith91
 
 # PRLabel: %Synapse
-/sdk/synapse/                                                        @aim-for-better @idear1203
+/sdk/synapse/                                                        @wonner @idear1203 @xiangyan99
 
 # PRLabel: %EngSys
 /sdk/template/                                                       @Azure/azure-sdk-eng
 
@@ -4,6 +4,10 @@
 
 This repository is for active development of the Azure SDK for Python. For consumers of the SDK we recommend visiting our [public developer docs](https://docs.microsoft.com/python/azure/) or our versioned [developer docs](https://azure.github.io/azure-sdk-for-python).
 
+## _Disclaimer_
+
+_Azure SDK Python packages support for Python 2.7 is ending 01 January 2022. For more information and questions, please refer to https://github.com/Azure/azure-sdk-for-python/issues/20691_
+
 ## Getting started
 
 For your convenience, each service has a separate set of libraries that you can choose to use instead of one, large Azure package. To get started with a specific library, see the `README.md` (or `README.rst`) file located in the library's project folder.
 
@@ -16,7 +16,7 @@ Param (
 )
 
 # Submit API review request and return status whether current revision is approved or pending or failed to create review
-function Submit-Request($filePath)
+function Submit-Request($filePath, $packageName)
 {
     $repoName = $RepoFullName
     if (!$repoName) {
@@ -29,6 +29,7 @@ function Submit-Request($filePath)
     $query.Add('commitSha', $CommitSha)
     $query.Add('repoName', $repoName)
     $query.Add('pullRequestNumber', $PullRequestNumber)
+    $query.Add('packageName', $packageName)
     $uri = [System.UriBuilder]$APIViewUri
     $uri.query = $query.toString()
     Write-Host "Request URI: $($uri.Uri.OriginalString)"
@@ -71,6 +72,7 @@ function Log-Input-Params()
     Write-Host "Language: $($Language)"
     Write-Host "Commit SHA: $($CommitSha)"
     Write-Host "Repo Name: $($RepoFullName)"
+    Write-Host "Package Name: $($PackageName)"
 }
 
 . (Join-Path $PSScriptRoot common.ps1)
@@ -95,7 +97,7 @@ foreach ($artifact in $ArtifactList)
         if (Should-Process-Package -pkgPath $pkgPath -packageName $artifact.name)
         {
             $filePath = $pkgPath.Replace($ArtifactPath , "").Replace("\", "/")
-            $respCode = Submit-Request -filePath $filePath
+            $respCode = Submit-Request -filePath $filePath -packageName $artifact.name
             if ($respCode -ne '200')
             {
                 $responses[$artifact.name] = $respCode
@@ -108,12 +110,7 @@ foreach ($artifact in $ArtifactList)
     }
 }
 
-if ($responses)
+foreach($pkg in $responses.keys)
 {
-    # Will update this with a link to wiki on how to resolve
-    Write-Warning "API change detection failed for following packages. Please check above for package level error details."
-    foreach($pkg in $responses.keys)
-    {
-        Write-Host "$pkg failed with $($responses[$pkg]) code"
-    }
+    Write-Host "API detection request status for $($pkg) : $($responses[$pkg])"
 }
@@ -25,7 +25,7 @@ catch {
     Write-Error "Please check your docker invocation and try running the script again."
 }
 
-$SELECTED_IMAGE_TAG = "1084681"
+$SELECTED_IMAGE_TAG = "1108695"
 $CONTAINER_NAME = "ambitious_azsdk_test_proxy"
 $LINUX_IMAGE_SOURCE = "azsdkengsys.azurecr.io/engsys/testproxy-lin:${SELECTED_IMAGE_TAG}"
 $WINDOWS_IMAGE_SOURCE = "azsdkengsys.azurecr.io/engsys/testproxy-win:${SELECTED_IMAGE_TAG}"
@@ -80,4 +80,4 @@ if ($Mode -eq "stop"){
             docker container stop $CONTAINER_NAME
         }
     }
-}
+}
@@ -0,0 +1,12 @@
+<PoliCheckExclusions>
+<!-- All strings must be UPPER CASE -->
+<!-- Each of these exclusions is a folder name - if \[name]\ exists in the file path, it will be skipped -->
+<!--<Exclusion Type="FolderPathFull">ABC|XYZ</Exclusion>-->
+<!-- Each of these exclusions is a folder name - if any folder or file starts with "\[name]", it will be 
+skipped -->
+<!--<Exclusion Type="FolderPathStart">ABC|XYZ</Exclusion>-->
+<!-- Each of these file types will be completely skipped for the entire scan -->
+<!--<Exclusion Type="FileType">.ABC|.XYZ</Exclusion>-->
+<!-- The specified file names will be skipped during the scan regardless which folder they are in -->
+<!--<Exclusion Type="FileName">ABC.TXT|XYZ.CS</Exclusion>-->
+</PoliCheckExclusions>
@@ -8,60 +8,105 @@ pr:
     include:
       - eng/pipelines/aggregate-reports.yml
 
-jobs:
-- job: 'ValidateDependencies'
-  variables:
+pool:
+  name: azsdk-pool-mms-win-2019-general
+  vmImage: MMS2019
+
+variables:
   - template: ./templates/variables/globals.yml
 
-  pool:
-    name: azsdk-pool-mms-win-2019-general
-    vmImage: MMS2019
-
-  steps:
-  - template: /eng/pipelines/templates/steps/analyze_dependency.yml
-
-  - task: AzureFileCopy@2
-    displayName: 'Upload dependency report'
-    condition: and(succeededOrFailed(), eq(variables['System.TeamProject'], 'internal'))
-    inputs:
-      sourcePath: '$(Build.ArtifactStagingDirectory)/reports'
-      azureSubscription: 'Azure SDK Artifacts'
-      destination: AzureBlob
-      storage: azuresdkartifacts
-      containerName: 'azure-sdk-for-python'
-      blobPrefix: dependencies
-
-  - task: PowerShell@2
-    displayName: "Verify Repository Resource Refs"
-    inputs:
-      pwsh: true
-      workingDirectory: $(Build.SourcesDirectory)
-      filePath: eng/common/scripts/Verify-Resource-Ref.ps1
-
-  - task: securedevelopmentteam.vss-secure-development-tools.build-task-credscan.CredScan@3
-    displayName: 'Run CredScan'
-    condition: succeededOrFailed()
-    inputs:
-      suppressionsFile: 'eng\CredScanSuppression.json'
-  - task: securedevelopmentteam.vss-secure-development-tools.build-task-postanalysis.PostAnalysis@2
-    displayName: 'Post Analysis'
-    condition: succeededOrFailed()
-    inputs:
-      GdnBreakAllTools: false
-      GdnBreakGdnToolCredScan: true
-      GdnBreakGdnToolCredScanSeverity: Error
-      GdnBreakBaselineFiles: $(Build.SourcesDirectory)\eng\python.gdnbaselines
-      GdnBreakBaselines: baseline
-      # Used for generating baseline file.
-      # GdnBreakOutputBaselineFile: python
-      # GdnBreakOutputBaseline: baseline
-    continueOnError: true
-  - task: securedevelopmentteam.vss-secure-development-tools.build-task-publishsecurityanalysislogs.PublishSecurityAnalysisLogs@3
-    displayName: 'Publish Security Analysis Logs'
-    continueOnError: true
-    condition: succeededOrFailed()
-  - template: ../common/pipelines/templates/steps/verify-links.yml
-    parameters:
-      Directory: ""
-      CheckLinkGuidance: $true
-      Condition: succeededOrFailed()
+stages:
+  - stage: ValidateDependencies
+    displayName: Validate Dependencies
+
+    jobs:
+      - job: ValidateDependencies
+        timeoutInMinutes: 120
+        steps:
+
+          - template: /eng/pipelines/templates/steps/analyze_dependency.yml
+
+          - task: AzureFileCopy@2
+            displayName: 'Upload dependency report'
+            condition: and(succeededOrFailed(), eq(variables['System.TeamProject'], 'internal'))
+            inputs:
+              sourcePath: '$(Build.ArtifactStagingDirectory)/reports'
+              azureSubscription: 'Azure SDK Artifacts'
+              destination: AzureBlob
+              storage: azuresdkartifacts
+              containerName: 'azure-sdk-for-python'
+              blobPrefix: dependencies
+
+          - task: PowerShell@2
+            displayName: "Verify Repository Resource Refs"
+            inputs:
+              pwsh: true
+              workingDirectory: $(Build.SourcesDirectory)
+              filePath: eng/common/scripts/Verify-Resource-Ref.ps1
+
+          - template: ../common/pipelines/templates/steps/verify-links.yml
+            parameters:
+              Directory: ""
+              CheckLinkGuidance: $true
+              Condition: succeededOrFailed()
+
+  - stage: ComplianceTools
+    displayName: Compliance Tools
+    dependsOn: []
+
+    jobs:
+      - job: ComplianceTools
+        timeoutInMinutes: 120
+        steps:
+          - task: securedevelopmentteam.vss-secure-development-tools.build-task-credscan.CredScan@3
+            displayName: 'Run CredScan'
+            condition: succeededOrFailed()
+            inputs:
+              suppressionsFile: 'eng\CredScanSuppression.json'
+
+          - task: securedevelopmentteam.vss-secure-development-tools.build-task-postanalysis.PostAnalysis@2
+            displayName: 'Post Analysis'
+            condition: succeededOrFailed()
+            inputs:
+              GdnBreakAllTools: false
+              GdnBreakGdnToolCredScan: true
+              GdnBreakGdnToolCredScanSeverity: Error
+              GdnBreakBaselineFiles: $(Build.SourcesDirectory)\eng\python.gdnbaselines
+              GdnBreakBaselines: baseline
+              # Used for generating baseline file.
+              # GdnBreakOutputBaselineFile: python
+              # GdnBreakOutputBaseline: baseline
+            continueOnError: true
+
+          - pwsh: |
+              azcopy copy "https://azuresdkartifacts.blob.core.windows.net/policheck/PythonPoliCheckExclusion.mdb?$(azuresdk-policheck-blob-SAS)" `
+              "$(Build.BinariesDirectory)"
+            displayName: 'Download PoliCheck Exclusion Database'
+            condition: succeededOrFailed()
+
+          - task: securedevelopmentteam.vss-secure-development-tools.build-task-policheck.PoliCheck@2
+            displayName: 'Run PoliCheck'
+            inputs:
+              targetType: F
+              targetArgument: '$(Build.SourcesDirectory)'
+              result: PoliCheck.sarif
+              optionsFC: 0
+              optionsXS: 1
+              optionsPE: 1|2|3|4
+              optionsRulesDBPath: "$(Build.BinariesDirectory)/PythonPoliCheckExclusion.mdb"
+              optionsUEPATH: "$(Build.SourcesDirectory)/eng/guardian-tools/policheck/PolicheckExclusions.xml"
+            condition: succeededOrFailed()
+
+          - task: securedevelopmentteam.vss-secure-development-tools.build-task-postanalysis.PostAnalysis@2
+            displayName: 'Post Analysis (PoliCheck)'
+            inputs:
+              GdnBreakAllTools: false
+              GdnBreakGdnToolPoliCheck: true
+              GdnBreakGdnToolPoliCheckSeverity: Warning
+            condition: succeededOrFailed()
+            continueOnError: true
+
+          - task: securedevelopmentteam.vss-secure-development-tools.build-task-publishsecurityanalysislogs.PublishSecurityAnalysisLogs@3
+            displayName: 'Publish Security Analysis Logs'
+            continueOnError: true
+            condition: succeededOrFailed()
@@ -23,4 +23,4 @@ steps:
     displayName: 'Pip Authenticate to feed'
     inputs:
       artifactFeeds: $(DevFeedName)
-      onlyAddExtraIndex: true
+      onlyAddExtraIndex: false
@@ -34,6 +34,7 @@ steps:
 
     - task: PythonScript@0
       displayName: 'Verify autorest'
+      continueOnError: true
       inputs:
         scriptPath: 'scripts/devops_tasks/verify_autorest.py'
         arguments: >-
 
@@ -58,5 +58,6 @@
     "azure-messaging-nspkg",
     "azure-agrifood-farming",
     "azure-eventhub",
-    "azure-ai-language-questionanswering"
+    "azure-ai-language-questionanswering",
+    "azure-ai-language-conversations"
 ]
@@ -43,6 +43,7 @@ platform = linux: linux
 passenv = *
 setenv =
   SPHINX_APIDOC_OPTIONS=members,undoc-members,inherited-members
+  PIP_EXTRA_INDEX_URL=https://pypi.python.org/simple
 deps = {[base]deps}
 changedir = {toxinidir}
 install_command = python -m pip install {opts} {packages} --cache-dir {toxinidir}/../.tox_pip_cache_{envname}
@@ -225,6 +226,7 @@ changedir =
   {toxinidir}
 passenv = *
 setenv =
+  {[testenv]setenv}
   DEPENDENCY_TYPE=Latest
 commands =
     {[deptestcommands]commands}
@@ -240,6 +242,7 @@ deps =
 changedir = {toxinidir}
 passenv = *
 setenv =
+  {[testenv]setenv}
   DEPENDENCY_TYPE=Minimum
 commands =
     {[deptestcommands]commands}
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ Param (`
`16`	`16`	`)`
`17`	`17`
`18`	`18`	`# Submit API review request and return status whether current revision is approved or pending or failed to create review`
`19`		`-function Submit-Request($filePath)`
	`19`	`+function Submit-Request($filePath, $packageName)`
`20`	`20`	`{`
`21`	`21`	`$repoName = $RepoFullName`
`22`	`22`	`if (!$repoName) {`
`@@ -29,6 +29,7 @@ function Submit-Request($filePath)`
`29`	`29`	`$query.Add('commitSha', $CommitSha)`
`30`	`30`	`$query.Add('repoName', $repoName)`
`31`	`31`	`$query.Add('pullRequestNumber', $PullRequestNumber)`
	`32`	`+ $query.Add('packageName', $packageName)`
`32`	`33`	`$uri = [System.UriBuilder]$APIViewUri`
`33`	`34`	`$uri.query = $query.toString()`
`34`	`35`	`Write-Host "Request URI: $($uri.Uri.OriginalString)"`
`@@ -71,6 +72,7 @@ function Log-Input-Params()`
`71`	`72`	`Write-Host "Language: $($Language)"`
`72`	`73`	`Write-Host "Commit SHA: $($CommitSha)"`
`73`	`74`	`Write-Host "Repo Name: $($RepoFullName)"`
	`75`	`+ Write-Host "Package Name: $($PackageName)"`
`74`	`76`	`}`
`75`	`77`
`76`	`78`	`. (Join-Path $PSScriptRoot common.ps1)`
`@@ -95,7 +97,7 @@ foreach ($artifact in $ArtifactList)`
`95`	`97`	`if (Should-Process-Package -pkgPath $pkgPath -packageName $artifact.name)`
`96`	`98`	`{`
`97`	`99`	`$filePath = $pkgPath.Replace($ArtifactPath , "").Replace("\", "/")`
`98`		`- $respCode = Submit-Request -filePath $filePath`
	`100`	`+ $respCode = Submit-Request -filePath $filePath -packageName $artifact.name`
`99`	`101`	`if ($respCode -ne '200')`
`100`	`102`	`{`
`101`	`103`	`$responses[$artifact.name] = $respCode`
`@@ -108,12 +110,7 @@ foreach ($artifact in $ArtifactList)`
`108`	`110`	`}`
`109`	`111`	`}`
`110`	`112`
`111`		`-if ($responses)`
	`113`	`+foreach($pkg in $responses.keys)`
`112`	`114`	`{`
`113`		`- # Will update this with a link to wiki on how to resolve`
`114`		`- Write-Warning "API change detection failed for following packages. Please check above for package level error details."`
`115`		`- foreach($pkg in $responses.keys)`
`116`		`- {`
`117`		`- Write-Host "$pkg failed with $($responses[$pkg]) code"`
`118`		`- }`
	`115`	`+ Write-Host "API detection request status for $($pkg) : $($responses[$pkg])"`
`119`	`116`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ catch {`
`25`	`25`	`Write-Error "Please check your docker invocation and try running the script again."`
`26`	`26`	`}`
`27`	`27`
`28`		`-$SELECTED_IMAGE_TAG = "1084681"`
	`28`	`+$SELECTED_IMAGE_TAG = "1108695"`
`29`	`29`	`$CONTAINER_NAME = "ambitious_azsdk_test_proxy"`
`30`	`30`	`$LINUX_IMAGE_SOURCE = "azsdkengsys.azurecr.io/engsys/testproxy-lin:${SELECTED_IMAGE_TAG}"`
`31`	`31`	`$WINDOWS_IMAGE_SOURCE = "azsdkengsys.azurecr.io/engsys/testproxy-win:${SELECTED_IMAGE_TAG}"`
`@@ -80,4 +80,4 @@ if ($Mode -eq "stop"){`
`80`	`80`	`docker container stop $CONTAINER_NAME`
`81`	`81`	`}`
`82`	`82`	`}`
`83`		`-}`
	`83`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -58,5 +58,6 @@`
`58`	`58`	`"azure-messaging-nspkg",`
`59`	`59`	`"azure-agrifood-farming",`
`60`	`60`	`"azure-eventhub",`
`61`		`- "azure-ai-language-questionanswering"`
	`61`	`+ "azure-ai-language-questionanswering",`
	`62`	`+ "azure-ai-language-conversations"`
`62`	`63`	`]`