Skip to content

Validate resolveArmResources API coverage for resource detection replacement #54204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Validate resolveArmResources API coverage for resource detection replacement #54204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9e33d69
Initial plan
Copilot Nov 28, 2025
4ed8a25
Add documentation for resolveArmResources API investigation and limit…
Copilot Nov 28, 2025
73e7465
Add test to demonstrate resolveArmResources API bug with multiple sin…
Copilot Dec 1, 2025
39b4461
Add comprehensive test file to validate resolveArmResources API coverage
Copilot Dec 1, 2025
4def006
Document resolveArmResources API limitations with version info
Copilot Dec 1, 2025
28ae6a0
Add tests demonstrating resolveArmResources API bugs 2-5 with existin…
Copilot Dec 1, 2025
6a123ff
Merge resolve-arm-resources-bug.test.ts into validation test file
Copilot Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions eng/packages/http-client-csharp-mgmt/emitter/src/resource-detection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.

// NOTE: This resource detection implementation uses decorator-based parsing to identify
// ARM resource operations. A future enhancement is to replace this with the
// resolveArmResources API from @azure-tools/typespec-azure-resource-manager.
// See: https://github.com/Azure/typespec-azure/blob/main/packages/typespec-azure-resource-manager/src/resource.ts
//
// Current limitation: The resolveArmResources API does not properly handle multiple
// singleton resources (e.g., when both Employee and CurrentEmployee are defined with
// different @singleton keys, only one is returned). This needs to be fixed in the
// TypeSpec ARM library before the replacement can be completed.

import {
CodeModel,
CSharpEmitterContext,
Expand Down
Loading