add guid validation (#22535)

Author: Mohamed Shaban

sdk/translation/Azure.AI.Translation.Document/src/ClientCommon.cs

@@ -0,0 +1,34 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System;
+
+namespace Azure.AI.Translation.Document
+{
+    internal static class ClientCommon
+    {
+        /// <summary>
+        /// Used as part of argument validation. Attempts to create a <see cref="Guid"/> from a <c>string</c> and
+        /// throws an <see cref="ArgumentException"/> in case of failure.
+        /// </summary>
+        /// <param name="possibleGuid">The identifier to be parsed into a <see cref="Guid"/>.</param>
+        /// <param name="paramName">The original parameter name of the <paramref name="possibleGuid"/>. Used to create exceptions in case of failure.</param>
+        /// <returns>The <see cref="Guid"/> instance created from the <paramref name="possibleGuid"/>.</returns>
+        /// <exception cref="ArgumentException">Thrown when parsing fails.</exception>
+        public static Guid ValidateModelId(string possibleGuid, string paramName)
+        {
+            Guid guid;
+
+            try
+            {
+                guid = new Guid(possibleGuid);
+            }
+            catch (Exception ex) when (ex is FormatException || ex is OverflowException)
+            {
+                throw new ArgumentException($"The {paramName} must be a valid GUID.", paramName, ex);
+            }
+
+            return guid;
+        }
+    }
+}

sdk/translation/Azure.AI.Translation.Document/src/DocumentTranslationOperation.cs

@@ -145,7 +145,8 @@ protected DocumentTranslationOperation()
         /// <param name="client">The client used to check for completion.</param>
         public DocumentTranslationOperation(string translationId, DocumentTranslationClient client)
         {
-            Id = translationId;
+            var parsedTranslationId = ClientCommon.ValidateModelId(translationId, nameof(translationId));
+            Id = parsedTranslationId.ToString();
             _serviceClient = client._serviceRestClient;
             _diagnostics = client._clientDiagnostics;
         }
@@ -326,7 +327,8 @@ public virtual Response<DocumentStatus> GetDocumentStatus(string documentId, Can
 
             try
             {
-                return _serviceClient.GetDocumentStatus(new Guid(Id), new Guid(documentId), cancellationToken);
+                var parsedDocumentId = ClientCommon.ValidateModelId(documentId, nameof(documentId));
+                return _serviceClient.GetDocumentStatus(new Guid(Id), parsedDocumentId, cancellationToken);
             }
             catch (Exception e)
             {
@@ -347,7 +349,8 @@ public virtual async Task<Response<DocumentStatus>> GetDocumentStatusAsync(strin
 
             try
             {
-                return await _serviceClient.GetDocumentStatusAsync(new Guid(Id), new Guid(documentId), cancellationToken).ConfigureAwait(false);
+                var parsedDocumentId = ClientCommon.ValidateModelId(documentId, nameof(documentId));
+                return await _serviceClient.GetDocumentStatusAsync(new Guid(Id), parsedDocumentId, cancellationToken).ConfigureAwait(false);
             }
             catch (Exception e)
             {