[Event Hubs] Release Prep + Partition Key Tests (#30391)

* [Event Hubs] Release Prep + Partition Key

The focus of these changes is to ensure that the partition key is correctly
considered for all publishing scenarios; some overloads were not setting
the key during message conversion, causing round-robin routing to be applied.

Author: jsquire

sdk/eventhub/Azure.Messaging.EventHubs/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Release History
 
-## 5.8.0-beta.1 (Unreleased)
+## 5.7.2 (2022-08-09)
 
 ### Acknowledgments
 

sdk/eventhub/Azure.Messaging.EventHubs/src/Azure.Messaging.EventHubs.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <Description>Azure Event Hubs is a highly scalable publish-subscribe service that can ingest millions of events per second and stream them to multiple consumers.  This client library allows for both publishing and consuming events using Azure Event Hubs. For more information about Event Hubs, see https://azure.microsoft.com/en-us/services/event-hubs/</Description>
-    <Version>5.8.0-beta.1</Version>
+    <Version>5.7.2</Version>
     <!--The ApiCompatVersion is managed automatically and should not generally be modified manually.-->
     <ApiCompatVersion>5.7.1</ApiCompatVersion>
     <PackageTags>Azure;Event Hubs;EventHubs;.NET;AMQP;IoT;$(PackageCommonTags)</PackageTags>

sdk/eventhub/Azure.Messaging.EventHubs/tests/Amqp/AmqpProducerTests.cs

@@ -1180,7 +1180,7 @@ public async Task SendEnumerableUsesThePartitionKey()
         [TestCase(null)]
         [TestCase("")]
         [TestCase("someKey")]
-        public async Task SendEnumerableCreatesTheAmqpMessageFromTheEnumerable(string partitonKey)
+        public async Task SendEnumerableCreatesTheAmqpMessageFromTheEnumerable(string partitionKey)
         {
             var amqpMessages = default(IReadOnlyCollection<AmqpMessage>);
             var events = new List<EventData> { new EventData(new byte[] { 0x15 }) };
@@ -1200,13 +1200,13 @@ public async Task SendEnumerableCreatesTheAmqpMessageFromTheEnumerable(string pa
                 .Callback<IReadOnlyCollection<AmqpMessage>, string, CancellationToken>((messages, key, token) => amqpMessages = messages)
                 .Returns(Task.CompletedTask);
 
-            await producer.Object.SendAsync(events, new SendEventOptions { PartitionKey = partitonKey }, CancellationToken.None);
+            await producer.Object.SendAsync(events, new SendEventOptions { PartitionKey = partitionKey }, CancellationToken.None);
 
             Assert.That(amqpMessages, Is.Not.Null, "The AMQP messages should have been set.");
             Assert.That(amqpMessages.Count, Is.EqualTo(events.Count), "An AMQP message should exist for each source event.");
 
-            using var batchMessage = converter.CreateBatchFromEvents(events, partitonKey);
-            using var amqpSourceMessage = converter.CreateBatchFromMessages(amqpMessages);
+            using var batchMessage = converter.CreateBatchFromEvents(events, partitionKey);
+            using var amqpSourceMessage = converter.CreateBatchFromMessages(amqpMessages, partitionKey);
 
             Assert.That(amqpSourceMessage.SerializedMessageSize, Is.EqualTo(batchMessage.SerializedMessageSize), "The serialized size of the messages should match.");
         }
@@ -1556,11 +1556,11 @@ public async Task SendBatchUsesThePartitionKey()
         [TestCase(null)]
         [TestCase("")]
         [TestCase("someKey")]
-        public async Task SendBatchCreatesTheAmqpMessageFromTheBatch(string partitonKey)
+        public async Task SendBatchCreatesTheAmqpMessageFromTheBatch(string partitionKey)
         {
             var amqpMessages = default(IReadOnlyCollection<AmqpMessage>);
             var expectedMaximumSize = 512;
-            var options = new CreateBatchOptions { PartitionKey = partitonKey };
+            var options = new CreateBatchOptions { PartitionKey = partitionKey };
             var retryPolicy = new BasicRetryPolicy(new EventHubsRetryOptions { TryTimeout = TimeSpan.FromSeconds(17) });
             var converter = new AmqpMessageConverter();
 
@@ -1600,8 +1600,8 @@ public async Task SendBatchCreatesTheAmqpMessageFromTheBatch(string partitonKey)
             Assert.That(amqpMessages, Is.Not.Null, "The AMQP messages should have been set.");
             Assert.That(amqpMessages.Count, Is.EqualTo(messages.Count), "An AMQP message should exist for each source event.");
 
-            using var batchMessage = converter.CreateBatchFromMessages(messages, partitonKey);
-            using var amqpSourceMessage = converter.CreateBatchFromMessages(amqpMessages);
+            using var batchMessage = converter.CreateBatchFromMessages(messages, partitionKey);
+            using var amqpSourceMessage = converter.CreateBatchFromMessages(amqpMessages, partitionKey);
 
             Assert.That(amqpSourceMessage.SerializedMessageSize, Is.EqualTo(batchMessage.SerializedMessageSize), "The serialized size of the messages should match.");
         }