change IsNullOrEmpty to IsNullorWhiteSpace (#24319)

Author: vishweshbankwar

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/HttpHelper.cs

@@ -225,8 +225,8 @@ internal static string GetDbDependencyTarget(this AzMonList tagObjects)
         {
             string target = tagObjects.GetDependencyTarget(PartBType.Db);
             string dbName = AzMonList.GetTagValue(ref tagObjects, SemanticConventions.AttributeDbName)?.ToString();
-            bool isTargetEmpty = string.IsNullOrEmpty(target);
-            bool isDbNameEmpty = string.IsNullOrEmpty(dbName);
+            bool isTargetEmpty = string.IsNullOrWhiteSpace(target);
+            bool isDbNameEmpty = string.IsNullOrWhiteSpace(dbName);
             if (!isTargetEmpty && !isDbNameEmpty)
             {
                 target = $"{target} | {dbName}";
@@ -264,7 +264,7 @@ internal static string GetDependencyTarget(this AzMonList tagObjects, PartBType
             }
 
             var peerService = AzMonList.GetTagValue(ref tagObjects, SemanticConventions.AttributePeerService)?.ToString();
-            if (!string.IsNullOrEmpty(peerService))
+            if (!string.IsNullOrWhiteSpace(peerService))
             {
                 target = peerService;
                 return target;
@@ -273,7 +273,7 @@ internal static string GetDependencyTarget(this AzMonList tagObjects, PartBType
             if (type == PartBType.Http)
             {
                 var httpHost = AzMonList.GetTagValue(ref tagObjects, SemanticConventions.AttributeHttpHost)?.ToString();
-                if (!string.IsNullOrEmpty(httpHost))
+                if (!string.IsNullOrWhiteSpace(httpHost))
                 {
                     string portSection = $":{defaultPort}";
                     if (httpHost.EndsWith(portSection, StringComparison.OrdinalIgnoreCase))
@@ -288,21 +288,21 @@ internal static string GetDependencyTarget(this AzMonList tagObjects, PartBType
                     return target;
                 }
                 var httpUrl = AzMonList.GetTagValue(ref tagObjects, SemanticConventions.AttributeHttpUrl)?.ToString();
-                if (!string.IsNullOrEmpty(httpUrl) && Uri.TryCreate(httpUrl.ToString(), UriKind.RelativeOrAbsolute, out var uri) && uri.IsAbsoluteUri)
+                if (!string.IsNullOrWhiteSpace(httpUrl) && Uri.TryCreate(httpUrl.ToString(), UriKind.RelativeOrAbsolute, out var uri) && uri.IsAbsoluteUri)
                 {
                     target = uri.Authority;
-                    if (!string.IsNullOrEmpty(target))
+                    if (!string.IsNullOrWhiteSpace(target))
                     {
                         return target;
                     }
                 }
             }
 
             target = tagObjects.GetHostUsingNetPeerAttributes();
-            if (!string.IsNullOrEmpty(target))
+            if (!string.IsNullOrWhiteSpace(target))
             {
                 var netPeerPort = AzMonList.GetTagValue(ref tagObjects, SemanticConventions.AttributeNetPeerPort)?.ToString();
-                if (!string.IsNullOrEmpty(netPeerPort) && netPeerPort != defaultPort)
+                if (!string.IsNullOrWhiteSpace(netPeerPort) && netPeerPort != defaultPort)
                 {
                     target = $"{target}:{netPeerPort}";
                 }
@@ -314,13 +314,13 @@ internal static string GetDependencyTarget(this AzMonList tagObjects, PartBType
 
         internal static string GetHttpDependencyName(this AzMonList tagObjects, string httpUrl)
         {
-            if (string.IsNullOrEmpty(httpUrl))
+            if (string.IsNullOrWhiteSpace(httpUrl))
             {
                 return null;
             }
 
             var httpMethod = AzMonList.GetTagValue(ref tagObjects, SemanticConventions.AttributeHttpMethod)?.ToString();
-            if (!string.IsNullOrEmpty(httpMethod))
+            if (!string.IsNullOrWhiteSpace(httpMethod))
             {
                 if (Uri.TryCreate(httpUrl.ToString(), UriKind.RelativeOrAbsolute, out var uri) && uri.IsAbsoluteUri)
                 {

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/TelemetryPartA.cs

@@ -73,12 +73,12 @@ internal static string GetOperationName(Activity activity, ref AzMonList partBTa
                 var httpRoute = AzMonList.GetTagValue(ref partBTags, SemanticConventions.AttributeHttpRoute)?.ToString();
                 // ASP.NET instrumentation assigns route as {controller}/{action}/{id} which would result in the same name for different operations.
                 // To work around that we will use path from httpUrl.
-                if (!string.IsNullOrEmpty(httpRoute) && !httpRoute.Contains("{controller}"))
+                if (!string.IsNullOrWhiteSpace(httpRoute) && !httpRoute.Contains("{controller}"))
                 {
                     return $"{httpMethod} {httpRoute}";
                 }
                 var httpUrl = AzMonList.GetTagValue(ref partBTags, SemanticConventions.AttributeHttpUrl)?.ToString();
-                if (!string.IsNullOrEmpty(httpUrl) && Uri.TryCreate(httpUrl.ToString(), UriKind.RelativeOrAbsolute, out var uri) && uri.IsAbsoluteUri)
+                if (!string.IsNullOrWhiteSpace(httpUrl) && Uri.TryCreate(httpUrl.ToString(), UriKind.RelativeOrAbsolute, out var uri) && uri.IsAbsoluteUri)
                 {
                     return $"{httpMethod} {uri.AbsolutePath}";
                 }