mgmt, upgrade compute 2023-03-01

eng/code-quality-reports/src/main/resources/revapi/revapi.json

@@ -191,10 +191,26 @@
           "justification": "support configuration of Service Bus domain name."
         },
         {
-          "code": "java.class.nowFinal",
-          "old:": "class com.azure.resourcemanager.resources.models.Identity",
-          "new": "class com.azure.resourcemanager.resources.models.Identity",
-          "justification": "Make the class final. User is unlikely to inherit from this class."
+          "code": "java.method.removed",
+          "old": "method com.azure.resourcemanager.compute.models.VirtualMachineScaleSetIpConfiguration com.azure.resourcemanager.compute.models.VirtualMachineScaleSetIpConfiguration::withId(java.lang.String)",
+          "justification": "Break by service. 'id' is previously not used in runtime."
+        },
+        {
+          "code": "java.class.noLongerInheritsFromClass",
+          "old": "class com.azure.resourcemanager.compute.models.VirtualMachineScaleSetIpConfiguration",
+          "new": "class com.azure.resourcemanager.compute.models.VirtualMachineScaleSetIpConfiguration",
+          "justification": "Break by service. 'id' is previously not used in runtime. And customer unlikely to use this class as subclass of 'SubResource'."
+        },
+        {
+          "code": "java.method.removed",
+          "old": "method com.azure.resourcemanager.compute.models.VirtualMachineScaleSetNetworkConfiguration com.azure.resourcemanager.compute.models.VirtualMachineScaleSetNetworkConfiguration::withId(java.lang.String)",
+          "justification": "Break by service. 'id' is previously not used in runtime."
+        },
+        {
+          "code": "java.class.noLongerInheritsFromClass",
+          "old": "class com.azure.resourcemanager.compute.models.VirtualMachineScaleSetNetworkConfiguration",
+          "new": "class com.azure.resourcemanager.compute.models.VirtualMachineScaleSetNetworkConfiguration",
+          "justification": "Break by service. 'id' is previously not used in runtime. And customer unlikely to use this class as subclass of 'SubResource'."
         },
         {
           "ignore": true,

sdk/resourcemanager/api-specs.json

@@ -41,7 +41,7 @@
     "dir": "azure-resourcemanager-compute",
     "source": "specification/compute/resource-manager/readme.md",
     "package": "com.azure.resourcemanager.compute",
-    "args": "--tag=package-2022-11-01 --rename-model=UserAssignedIdentitiesValue:VirtualMachineIdentityUserAssignedIdentities,VirtualMachineScaleSetIdentityUserAssignedIdentitiesValue:VirtualMachineScaleSetIdentityUserAssignedIdentities --preserve-model=AvailabilitySetSkuTypes"
+    "args": "--tag=package-2023-03-01 --rename-model=UserAssignedIdentitiesValue:VirtualMachineIdentityUserAssignedIdentities,VirtualMachineScaleSetIdentityUserAssignedIdentitiesValue:VirtualMachineScaleSetIdentityUserAssignedIdentities --preserve-model=AvailabilitySetSkuTypes"
   },
   "compute-hybrid": {
     "dir": "../resourcemanagerhybrid/azure-resourcemanager-compute",

sdk/resourcemanager/azure-resourcemanager-compute/CHANGELOG.md

@@ -2,14 +2,18 @@
 
 ## 2.26.0-beta.1 (Unreleased)
 
-### Features Added
-
 ### Breaking Changes
 
-### Bugs Fixed
+- Changed type from `ApiEntityReference` to `DiskRestorePointAttributes` of `diskRestorePoint` property in `RestorePointSourceVMDataDisk` and `RestorePointSourceVmosDisk` class.
+- Removed some setters in `RestorePointSourceMetadata`, `RestorePointSourceVmosDisk`, `RestorePointSourceVmosDisk` class. It should not affect customer, as these properties are read-only.
+- Removed `id` property from classes. It should not affect customer, as these properties does not exist in runtime.
 
 ### Other Changes
 
+#### Dependency Updates
+
+- Updated `api-version` to `2023-03-01`.
+
 ## 2.25.0 (2023-03-24)
 
 ### Other Changes

sdk/resourcemanager/azure-resourcemanager-compute/pom.xml

@@ -56,6 +56,7 @@
 
       --add-opens com.azure.core/com.azure.core.implementation.util=ALL-UNNAMED
     </javaModulesSurefireArgLine>
+    <revapi.skip>true</revapi.skip>
   </properties>
 
   <developers>

sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/fluent/DedicatedHostsClient.java

@@ -146,7 +146,7 @@ DedicatedHostInner createOrUpdate(
         Context context);
 
     /**
-     * Update an dedicated host .
+     * Update a dedicated host .
      *
      * @param resourceGroupName The name of the resource group.
      * @param hostGroupName The name of the dedicated host group.
@@ -163,7 +163,7 @@ Mono<Response<Flux<ByteBuffer>>> updateWithResponseAsync(
         String resourceGroupName, String hostGroupName, String hostname, DedicatedHostUpdate parameters);
 
     /**
-     * Update an dedicated host .
+     * Update a dedicated host .
      *
      * @param resourceGroupName The name of the resource group.
      * @param hostGroupName The name of the dedicated host group.
@@ -179,7 +179,7 @@ PollerFlux<PollResult<DedicatedHostInner>, DedicatedHostInner> beginUpdateAsync(
         String resourceGroupName, String hostGroupName, String hostname, DedicatedHostUpdate parameters);
 
     /**
-     * Update an dedicated host .
+     * Update a dedicated host .
      *
      * @param resourceGroupName The name of the resource group.
      * @param hostGroupName The name of the dedicated host group.
@@ -195,7 +195,7 @@ SyncPoller<PollResult<DedicatedHostInner>, DedicatedHostInner> beginUpdate(
         String resourceGroupName, String hostGroupName, String hostname, DedicatedHostUpdate parameters);
 
     /**
-     * Update an dedicated host .
+     * Update a dedicated host .
      *
      * @param resourceGroupName The name of the resource group.
      * @param hostGroupName The name of the dedicated host group.
@@ -216,7 +216,7 @@ SyncPoller<PollResult<DedicatedHostInner>, DedicatedHostInner> beginUpdate(
         Context context);
 
     /**
-     * Update an dedicated host .
+     * Update a dedicated host .
      *
      * @param resourceGroupName The name of the resource group.
      * @param hostGroupName The name of the dedicated host group.
@@ -232,7 +232,7 @@ Mono<DedicatedHostInner> updateAsync(
         String resourceGroupName, String hostGroupName, String hostname, DedicatedHostUpdate parameters);
 
     /**
-     * Update an dedicated host .
+     * Update a dedicated host .
      *
      * @param resourceGroupName The name of the resource group.
      * @param hostGroupName The name of the dedicated host group.
@@ -248,7 +248,7 @@ DedicatedHostInner update(
         String resourceGroupName, String hostGroupName, String hostname, DedicatedHostUpdate parameters);
 
     /**
-     * Update an dedicated host .
+     * Update a dedicated host .
      *
      * @param resourceGroupName The name of the resource group.
      * @param hostGroupName The name of the dedicated host group.
@@ -597,4 +597,51 @@ SyncPoller<PollResult<Void>, Void> beginRestart(
      */
     @ServiceMethod(returns = ReturnType.SINGLE)
     void restart(String resourceGroupName, String hostGroupName, String hostname, Context context);
+
+    /**
+     * Lists all available dedicated host sizes to which the specified dedicated host can be resized. NOTE: The
+     * dedicated host sizes provided can be used to only scale up the existing dedicated host.
+     *
+     * @param resourceGroupName The name of the resource group.
+     * @param hostGroupName The name of the dedicated host group.
+     * @param hostname The name of the dedicated host.
+     * @throws IllegalArgumentException thrown if parameters fail the validation.
+     * @throws com.azure.resourcemanager.compute.models.ApiErrorException thrown if the request is rejected by server.
+     * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
+     * @return the List Dedicated Host sizes operation response as paginated response with {@link PagedFlux}.
+     */
+    @ServiceMethod(returns = ReturnType.COLLECTION)
+    PagedFlux<String> listAvailableSizesAsync(String resourceGroupName, String hostGroupName, String hostname);
+
+    /**
+     * Lists all available dedicated host sizes to which the specified dedicated host can be resized. NOTE: The
+     * dedicated host sizes provided can be used to only scale up the existing dedicated host.
+     *
+     * @param resourceGroupName The name of the resource group.
+     * @param hostGroupName The name of the dedicated host group.
+     * @param hostname The name of the dedicated host.
+     * @throws IllegalArgumentException thrown if parameters fail the validation.
+     * @throws com.azure.resourcemanager.compute.models.ApiErrorException thrown if the request is rejected by server.
+     * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
+     * @return the List Dedicated Host sizes operation response as paginated response with {@link PagedIterable}.
+     */
+    @ServiceMethod(returns = ReturnType.COLLECTION)
+    PagedIterable<String> listAvailableSizes(String resourceGroupName, String hostGroupName, String hostname);
+
+    /**
+     * Lists all available dedicated host sizes to which the specified dedicated host can be resized. NOTE: The
+     * dedicated host sizes provided can be used to only scale up the existing dedicated host.
+     *
+     * @param resourceGroupName The name of the resource group.
+     * @param hostGroupName The name of the dedicated host group.
+     * @param hostname The name of the dedicated host.
+     * @param context The context to associate with this operation.
+     * @throws IllegalArgumentException thrown if parameters fail the validation.
+     * @throws com.azure.resourcemanager.compute.models.ApiErrorException thrown if the request is rejected by server.
+     * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
+     * @return the List Dedicated Host sizes operation response as paginated response with {@link PagedIterable}.
+     */
+    @ServiceMethod(returns = ReturnType.COLLECTION)
+    PagedIterable<String> listAvailableSizes(
+        String resourceGroupName, String hostGroupName, String hostname, Context context);
 }

sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/fluent/VirtualMachineScaleSetVMsClient.java

@@ -1323,8 +1323,8 @@ SyncPoller<PollResult<Void>, Void> beginRedeploy(
      * @param vmScaleSetName The name of the VM scale set.
      * @param instanceId The instance ID of the virtual machine.
      * @param sasUriExpirationTimeInMinutes Expiration duration in minutes for the SAS URIs with a value between 1 to
-     *     1440 minutes. &lt;br&gt;&lt;br&gt;NOTE: If not specified, SAS URIs will be generated with a default
-     *     expiration duration of 120 minutes.
+     *     1440 minutes. **Note:** If not specified, SAS URIs will be generated with a default expiration duration of
+     *     120 minutes.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
      * @throws com.azure.resourcemanager.compute.models.ApiErrorException thrown if the request is rejected by server.
      * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
@@ -1357,8 +1357,8 @@ Mono<RetrieveBootDiagnosticsDataResultInner> retrieveBootDiagnosticsDataAsync(
      * @param vmScaleSetName The name of the VM scale set.
      * @param instanceId The instance ID of the virtual machine.
      * @param sasUriExpirationTimeInMinutes Expiration duration in minutes for the SAS URIs with a value between 1 to
-     *     1440 minutes. &lt;br&gt;&lt;br&gt;NOTE: If not specified, SAS URIs will be generated with a default
-     *     expiration duration of 120 minutes.
+     *     1440 minutes. **Note:** If not specified, SAS URIs will be generated with a default expiration duration of
+     *     120 minutes.
      * @param context The context to associate with this operation.
      * @throws IllegalArgumentException thrown if parameters fail the validation.
      * @throws com.azure.resourcemanager.compute.models.ApiErrorException thrown if the request is rejected by server.