Skip to content

Conversation

@weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Apr 19, 2023

Suppress breaking changes from CRP Azure/azure-rest-api-specs#22885

  • 225e444
    This change is unlikely to break customer that directly uses the model, as "id" was a mistake in the first place, and backend will not provide nor process it.

Live test pass

Manual change:

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 19, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-resourcemanager-compute

@weidongxu-microsoft
Copy link
Member Author

weidongxu-microsoft commented Apr 19, 2023

We may need to skip revapi: https://dev.azure.com/azure-sdk/public/_build/results?buildId=2711147&view=logs&jobId=b70e5e73-bbb6-5567-0939-8415943fadb9&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=68a849d6-f425-5f38-d450-7e2c3d1df885

Yeah, updated changelog. Seems the one of type change is the real break (other setter likely not used by backend in the first place).

Hope azure-resourcemanager is good. Would want to avoid adding more suppressions.

@weidongxu-microsoft weidongxu-microsoft changed the title mgmt, upgrade compute mgmt, upgrade compute 2023-03-01 Apr 19, 2023
@weidongxu-microsoft weidongxu-microsoft self-assigned this Apr 19, 2023
@weidongxu-microsoft weidongxu-microsoft added the Mgmt This issue is related to a management-plane library. label Apr 19, 2023
@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review April 19, 2023 06:48
@weidongxu-microsoft weidongxu-microsoft merged commit e9e916a into Azure:main Apr 20, 2023
@weidongxu-microsoft weidongxu-microsoft deleted the mgmt_upgrade-compute branch April 20, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants