Regenerate IoT Hub control plane to match latest swagger #23768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of these changes appear to be from how autorest generates the code now vs the last time it generated, but the important part is that the isVerified flag in CertificateProperties.java is no longer write-only Azure/azure-rest-api-specs#15722
timtay-microsoft
requested review from
ChenTanyi,
haolingdong-msft,
qwordy,
weidongxu-microsoft and
yungezz
as code owners
Member
|
@timtay-microsoft You need a Java 11 runtime in PATH to enable the formatter. Without it your code likely will not pass checkstyle. |
qwordy
reviewed
Aug 26, 2021
| * @param resourceGroupName Name of the resource group containing the IoT hub resource. | ||
| * @param failoverInput Region to failover to. Must be the Azure paired region. Get the value from the secondary | ||
| * location in the locations property. To learn more, see https://aka.ms/manualfailover/region. | ||
| * @param failoverInput Region to failover to. Must be the Azure paired region. Get the value from the secondary location in the locations property. To learn more, see https://aka.ms/manualfailover/region. |
Member
There was a problem hiding this comment.
Line is too long. Old version is better.
Member
Author
There was a problem hiding this comment.
This went back to the old version after I regenerated with a Java 11 path instead of a Java 8 path
qwordy
approved these changes
Aug 26, 2021
Member
Author
Looks like it. I went ahead and regenerated with Java 11 and the change list is now as small as I would expect for such a small swagger change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these changes appear to be from how autorest formats the code now vs the last time it generated, but the important part is that the isVerified flag in CertificateProperties.java is no longer write-only
This is the swagger change that is being captured by this pr:
Azure/azure-rest-api-specs#15722