From e6f65e659dc523de2eff08df9750ffc0200ef191 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Thu, 23 Feb 2023 10:25:12 -0800 Subject: [PATCH 01/26] added Archive Resource --- .../2023-01-01-preview/containerregistry.json | 784 +++++++++++++++++- 1 file changed, 774 insertions(+), 10 deletions(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json index b9650dfe88c8..feada199ee3b 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json @@ -15,6 +15,607 @@ "application/json" ], "paths": { + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives": { + "get": { + "tags": [ + "Archives" + ], + "description": "Lists all archives for the specified container registry and repository type.", + "operationId": "ArchiList", + "parameters": [ + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/RegistryNameParameter" + }, + { + "name": "packageType", + "in": "path", + "description": "The archive repository type.", + "required": true, + "type": "string" + } + ], + "responses": { + "200": { + "description": "The request was successful; the request was well-formed and received properly.", + "schema": { + "$ref": "#/definitions/ArchiveListResult" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + }, + "x-ms-examples": { + "ArchiveList": { + "$ref": "./examples/ArchiveList.json" + } + }, + "x-ms-pageable": { + "nextLinkName": "nextLink" + } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives/{archiveName}": { + "get": { + "tags": [ + "Archives" + ], + "description": "Gets the properties of the archive.", + "operationId": "ArchiGet", + "parameters": [ + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/RegistryNameParameter" + }, + { + "name": "packageType", + "in": "path", + "description": "The archive repository type.", + "required": true, + "type": "string" + }, + { + "name": "archiveName", + "in": "path", + "description": "The archive name.", + "required": true, + "type": "string" + } + ], + "responses": { + "200": { + "description": "The request was successful; the request was well-formed and received properly.", + "schema": { + "$ref": "#/definitions/Archive" + } + }, + "default": { + "description": "Error response describing why the operation failed. If the resource does not exist, 404 (Not found) is returned.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + }, + "x-ms-examples": { + "ArchiveGet": { + "$ref": "./examples/ArchiveGet.json" + } + } + }, + "put": { + "tags": [ + "Archives" + ], + "description": "Creates a archive for a container registry with the specified parameters.", + "operationId": "ArchiCreate", + "parameters": [ + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/RegistryNameParameter" + }, + { + "name": "packageType", + "in": "path", + "description": "The archive repository type.", + "required": true, + "type": "string" + }, + { + "name": "archiveName", + "in": "path", + "description": "The archive name.", + "required": true, + "type": "string" + }, + { + "name": "archiveCreateParameters", + "in": "body", + "description": "The parameters for creating a archive.", + "required": true, + "schema": { + "$ref": "#/definitions/Archive" + } + } + ], + "responses": { + "200": { + "description": "The request was successful; the operation has completed successfully.", + "schema": { + "$ref": "#/definitions/Archive" + } + }, + "201": { + "description": "The request was successful; the operation will complete asynchronously.", + "schema": { + "$ref": "#/definitions/Archive" + }, + "headers": { + "Azure-AsyncOperation": { + "type": "string" + } + } + }, + "default": { + "description": "Error response describing why the operation failed. If any of the input parameters are invalid, 400 (Bad Request) is returned. If the request cannot be processed due to a conflict in the request, 409 (Conflict) is returned.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + }, + "x-ms-examples": { + "ArchiveCreate": { + "$ref": "./examples/ArchiveCreate.json" + } + }, + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options": { + "final-state-via": "azure-async-operation" + } + }, + "delete": { + "tags": [ + "Archives" + ], + "description": "Deletes a archive from a container registry.", + "operationId": "ArchiDelete", + "parameters": [ + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/RegistryNameParameter" + }, + { + "name": "packageType", + "in": "path", + "description": "The archive repository type.", + "required": true, + "type": "string" + }, + { + "name": "archiveName", + "in": "path", + "description": "The archive name.", + "required": true, + "type": "string" + } + ], + "responses": { + "200": { + "description": "The request was successful; the request was well-formed and received properly." + }, + "202": { + "description": "The request was successful; the operation will complete asynchronously.", + "headers": { + "Location": { + "type": "string" + } + } + }, + "204": { + "description": "The archive does not exist in the subscription." + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + }, + "x-ms-examples": { + "ArchiveDelete": { + "$ref": "./examples/ArchiveDelete.json" + } + }, + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options": { + "final-state-via": "location" + } + }, + "patch": { + "tags": [ + "Archives" + ], + "description": "Updates a archive for a container registry with the specified parameters.", + "operationId": "ArchiUpdate", + "parameters": [ + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/RegistryNameParameter" + }, + { + "name": "packageType", + "in": "path", + "description": "The archive repository type.", + "required": true, + "type": "string" + }, + { + "name": "archiveName", + "in": "path", + "description": "The archive name.", + "required": true, + "type": "string" + }, + { + "name": "archiveUpdateParameters", + "in": "body", + "description": "The parameters for updating a archive.", + "required": true, + "schema": { + "$ref": "#/definitions/ArchiveUpdateParameters" + } + } + ], + "responses": { + "200": { + "description": "The request was successful; the operation has completed successfully.", + "schema": { + "$ref": "#/definitions/Archive" + } + }, + "201": { + "description": "The request was successful; the operation will complete asynchronously.", + "schema": { + "$ref": "#/definitions/Archive" + }, + "headers": { + "Azure-AsyncOperation": { + "type": "string" + } + } + }, + "default": { + "description": "Error response describing why the operation failed. If any of the input parameters are invalid, 400 (Bad Request) is returned. If the request cannot be processed due to a conflict in the request, 409 (Conflict) is returned.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + }, + "x-ms-examples": { + "ArchiveUpdate": { + "$ref": "./examples/ArchiveUpdate.json" + } + }, + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options": { + "final-state-via": "azure-async-operation" + } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{repositoryType}/archives/{archiveName}/versions": { + "get": { + "tags": [ + "ArchiveVersions" + ], + "description": "Lists all archive versions for the specified container registry, repository type and archive name.", + "operationId": "ArchiList", + "parameters": [ + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/RegistryNameParameter" + }, + { + "name": "repositoryType", + "in": "path", + "description": "The archive repository type.", + "required": true, + "type": "string" + }, + { + "name": "archiveName", + "in": "path", + "description": "The archive name.", + "required": true, + "type": "string" + } + ], + "responses": { + "200": { + "description": "The request was successful; the request was well-formed and received properly.", + "schema": { + "$ref": "#/definitions/ArchiveVersionListResult" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + }, + "x-ms-examples": { + "ArchiveVersionList": { + "$ref": "./examples/ArchiveVersionList.json" + } + }, + "x-ms-pageable": { + "nextLinkName": "nextLink" + } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{repositoryType}/archives/{archiveName}/versions/{archiveVersionName}": { + "get": { + "tags": [ + "ArchiveVersions" + ], + "description": "Gets the properties of the archive version.", + "operationId": "ArchiGet", + "parameters": [ + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/RegistryNameParameter" + }, + { + "name": "repositoryType", + "in": "path", + "description": "The archive repository type.", + "required": true, + "type": "string" + }, + { + "name": "archiveName", + "in": "path", + "description": "The archive name.", + "required": true, + "type": "string" + }, + { + "name": "archiveVersionName", + "in": "path", + "description": "The archive version name.", + "required": true, + "type": "string" + } + ], + "responses": { + "200": { + "description": "The request was successful; the request was well-formed and received properly.", + "schema": { + "$ref": "#/definitions/ArchiveVersion" + } + }, + "default": { + "description": "Error response describing why the operation failed. If the resource does not exist, 404 (Not found) is returned.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + }, + "x-ms-examples": { + "ArchiveVersionGet": { + "$ref": "./examples/ArchiveVersionGet.json" + } + } + }, + "put": { + "tags": [ + "ArchiveVersions" + ], + "description": "Creates a archive for a container registry with the specified parameters.", + "operationId": "ArchiCreate", + "parameters": [ + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/RegistryNameParameter" + }, + { + "name": "repositoryType", + "in": "path", + "description": "The archive repository type.", + "required": true, + "type": "string" + }, + { + "name": "archiveName", + "in": "path", + "description": "The archive name.", + "required": true, + "type": "string" + }, + { + "name": "archiveVersionName", + "in": "path", + "description": "The archive version name.", + "required": true, + "type": "string" + } + ], + "responses": { + "200": { + "description": "The request was successful; the operation has completed successfully.", + "schema": { + "$ref": "#/definitions/ArchiveVersion" + } + }, + "201": { + "description": "The request was successful; the operation will complete asynchronously.", + "schema": { + "$ref": "#/definitions/ArchiveVersion" + }, + "headers": { + "Azure-AsyncOperation": { + "type": "string" + } + } + }, + "default": { + "description": "Error response describing why the operation failed. If any of the input parameters are invalid, 400 (Bad Request) is returned. If the request cannot be processed due to a conflict in the request, 409 (Conflict) is returned.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + }, + "x-ms-examples": { + "ArchiveVersionCreate": { + "$ref": "./examples/ArchiveVersionCreate.json" + } + }, + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options": { + "final-state-via": "azure-async-operation" + } + }, + "delete": { + "tags": [ + "ArchiveVersions" + ], + "description": "Deletes a archive version from a container registry.", + "operationId": "ArchiDelete", + "parameters": [ + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/RegistryNameParameter" + }, + { + "name": "repositoryType", + "in": "path", + "description": "The archive repository type.", + "required": true, + "type": "string" + }, + { + "name": "archiveName", + "in": "path", + "description": "The archive name.", + "required": true, + "type": "string" + }, + { + "name": "archiveVersionName", + "in": "path", + "description": "The archive version name.", + "required": true, + "type": "string" + } + ], + "responses": { + "200": { + "description": "The request was successful; the request was well-formed and received properly." + }, + "202": { + "description": "The request was successful; the operation will complete asynchronously.", + "headers": { + "Location": { + "type": "string" + } + } + }, + "204": { + "description": "The archive does not exist in the subscription." + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "#/definitions/ErrorResponse" + } + } + }, + "x-ms-examples": { + "ArchiveVersionDelete": { + "$ref": "./examples/ArchiveVersionDelete.json" + } + }, + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options": { + "final-state-via": "location" + } + } + }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/cacheRules": { "get": { "tags": [ @@ -3583,25 +4184,25 @@ } }, "definitions": { - "CacheRulesListResult": { - "description": "The result of a request to list cache rules for a container registry.", + "ArchiveListResult": { + "description": "The result of a request to list archives for a container registry.", "type": "object", "properties": { "value": { - "description": "The list of cache rules.", + "description": "The list of archives. Since this list may be incomplete, the nextLink field should be used to request the next list of distributions.", "type": "array", "items": { - "$ref": "#/definitions/CacheRule" + "$ref": "#/definitions/Archive" } }, "nextLink": { - "description": "If provided, client must use NextLink URI to request next list of cache rules.", + "description": "The URI that can be used to request the next list of archives.", "type": "string" } } }, - "CacheRule": { - "description": "An object that represents a cache rule for a container registry.", + "Archive": { + "description": "An object that represents a archive for a container registry.", "type": "object", "allOf": [ { @@ -3610,8 +4211,8 @@ ], "properties": { "properties": { - "$ref": "#/definitions/CacheRuleProperties", - "description": "The properties of the cache rule.", + "$ref": "#/definitions/ArchiveProperties", + "description": "The properties of the archive.", "x-ms-client-flatten": true } } @@ -3637,6 +4238,169 @@ } } }, + "ArchiveProperties": { + "description": "The properties of a archive.", + "type": "object", + "properties": { + "packageSource": { + "$ref": "#/definitions/ArchivePackageSourceProperties", + "description": "The package source of the archive." + }, + "publishedVersion": { + "description": "The published version of the archive.", + "type": "string" + }, + "provisioningState": { + "description": "The provisioning state of the archive at the time the operation was called.", + "enum": [ + "Creating", + "Updating", + "Deleting", + "Succeeded", + "Failed", + "Canceled" + ], + "type": "string", + "readOnly": true, + "x-ms-enum": { + "name": "ProvisioningState", + "modelAsString": true + } + } + } + }, + "ArchivePackageSourceProperties": { + "description": "The properties of the archive package source.", + "type": "object", + "properties": { + "type": { + "description": "The type of package source for a archive.", + "type": "string" + }, + "url": { + "description": "The external repository url.", + "type": "string" + }, + "distributionName": { + "description": "Upstream Debian/RPM distribution Name.", + "type": "string" + } + } + }, + "ArchiveUpdateParameters": { + "description": "The parameters for updating a archive.", + "type": "object", + "properties": { + "properties": { + "$ref": "#/definitions/ArchiveUpdateProperties", + "description": "The properties of the connected registry update parameters.", + "x-ms-client-flatten": true + } + } + }, + "ArchiveUpdateProperties": { + "description": "The properties of a archive.", + "type": "object", + "properties": { + "publishedVersion": { + "description": "The published version of the archive.", + "type": "string" + } + } + }, + "ArchiveVersionListResult": { + "description": "The result of a request to list export pipelines for a container registry.", + "type": "object", + "properties": { + "value": { + "description": "The list of export pipelines. Since this list may be incomplete, the nextLink field should be used to request the next list of export pipelines.", + "type": "array", + "items": { + "$ref": "#/definitions/ArchiveVersion" + } + }, + "nextLink": { + "description": "The URI that can be used to request the next list of pipeline runs.", + "type": "string" + } + } + }, + "ArchiveVersion": { + "description": "An object that represents an export pipeline for a container registry.", + "type": "object", + "allOf": [ + { + "$ref": "#/definitions/ProxyResource" + } + ], + "properties": { + "properties": { + "$ref": "#/definitions/ArchiveVersionProperties", + "description": "The properties of the archive.", + "x-ms-client-flatten": true + } + } + }, + "ArchiveVersionProperties": { + "description": "The properties of an export pipeline.", + "type": "object", + "properties": { + "provisioningState": { + "description": "The provisioning state of the archive at the time the operation was called.", + "enum": [ + "Creating", + "Updating", + "Deleting", + "Succeeded", + "Failed", + "Canceled" + ], + "type": "string", + "readOnly": true, + "x-ms-enum": { + "name": "ProvisioningState", + "modelAsString": true + } + }, + "archiveVersionErrorMessage": { + "description": "The detailed error message for the archive version in the case of failure.", + "type": "string" + } + } + }, + "CacheRulesListResult": { + "description": "The result of a request to list cache rules for a container registry.", + "type": "object", + "properties": { + "value": { + "description": "The list of cache rules.", + "type": "array", + "items": { + "$ref": "#/definitions/CacheRule" + } + }, + "nextLink": { + "description": "If provided, client must use NextLink URI to request next list of cache rules.", + "type": "string" + } + } + }, + "CacheRule": { + "description": "An object that represents a cache rule for a container registry.", + "type": "object", + "allOf": [ + { + "$ref": "#/definitions/ProxyResource" + } + ], + "properties": { + "properties": { + "$ref": "#/definitions/CacheRuleProperties", + "description": "The properties of the cache rule.", + "x-ms-client-flatten": true + } + } + }, "CacheRuleProperties": { "description": "The properties of a cache rule.", "type": "object", @@ -7289,4 +8053,4 @@ ] } ] -} +} \ No newline at end of file From cc3d207ebce8b1978d45b007c8ba80f18362d088 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Thu, 23 Feb 2023 10:52:29 -0800 Subject: [PATCH 02/26] fix Package type --- .../2023-01-01-preview/containerregistry.json | 124 ++++-------------- 1 file changed, 22 insertions(+), 102 deletions(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json index feada199ee3b..60220637e815 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json @@ -36,11 +36,7 @@ "$ref": "#/parameters/RegistryNameParameter" }, { - "name": "packageType", - "in": "path", - "description": "The archive repository type.", - "required": true, - "type": "string" + "$ref": "#/parameters/PackageTypeParameter" } ], "responses": { @@ -88,18 +84,10 @@ "$ref": "#/parameters/RegistryNameParameter" }, { - "name": "packageType", - "in": "path", - "description": "The archive repository type.", - "required": true, - "type": "string" + "$ref": "#/parameters/PackageTypeParameter" }, { - "name": "archiveName", - "in": "path", - "description": "The archive name.", - "required": true, - "type": "string" + "$ref": "#/parameters/ArchiveNameParameter" } ], "responses": { @@ -142,18 +130,10 @@ "$ref": "#/parameters/RegistryNameParameter" }, { - "name": "packageType", - "in": "path", - "description": "The archive repository type.", - "required": true, - "type": "string" + "$ref": "#/parameters/PackageTypeParameter" }, { - "name": "archiveName", - "in": "path", - "description": "The archive name.", - "required": true, - "type": "string" + "$ref": "#/parameters/ArchiveNameParameter" }, { "name": "archiveCreateParameters", @@ -220,18 +200,10 @@ "$ref": "#/parameters/RegistryNameParameter" }, { - "name": "packageType", - "in": "path", - "description": "The archive repository type.", - "required": true, - "type": "string" + "$ref": "#/parameters/PackageTypeParameter" }, { - "name": "archiveName", - "in": "path", - "description": "The archive name.", - "required": true, - "type": "string" + "$ref": "#/parameters/ArchiveNameParameter" } ], "responses": { @@ -286,18 +258,10 @@ "$ref": "#/parameters/RegistryNameParameter" }, { - "name": "packageType", - "in": "path", - "description": "The archive repository type.", - "required": true, - "type": "string" + "$ref": "#/parameters/PackageTypeParameter" }, { - "name": "archiveName", - "in": "path", - "description": "The archive name.", - "required": true, - "type": "string" + "$ref": "#/parameters/ArchiveNameParameter" }, { "name": "archiveUpdateParameters", @@ -345,7 +309,7 @@ } } }, - "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{repositoryType}/archives/{archiveName}/versions": { + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives/{archiveName}/versions": { "get": { "tags": [ "ArchiveVersions" @@ -366,18 +330,10 @@ "$ref": "#/parameters/RegistryNameParameter" }, { - "name": "repositoryType", - "in": "path", - "description": "The archive repository type.", - "required": true, - "type": "string" + "$ref": "#/parameters/PackageTypeParameter" }, { - "name": "archiveName", - "in": "path", - "description": "The archive name.", - "required": true, - "type": "string" + "$ref": "#/parameters/ArchiveNameParameter" } ], "responses": { @@ -404,7 +360,7 @@ } } }, - "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{repositoryType}/archives/{archiveName}/versions/{archiveVersionName}": { + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives/{archiveName}/versions/{archiveVersionName}": { "get": { "tags": [ "ArchiveVersions" @@ -425,25 +381,13 @@ "$ref": "#/parameters/RegistryNameParameter" }, { - "name": "repositoryType", - "in": "path", - "description": "The archive repository type.", - "required": true, - "type": "string" + "$ref": "#/parameters/PackageTypeParameter" }, { - "name": "archiveName", - "in": "path", - "description": "The archive name.", - "required": true, - "type": "string" + "$ref": "#/parameters/ArchiveNameParameter" }, { - "name": "archiveVersionName", - "in": "path", - "description": "The archive version name.", - "required": true, - "type": "string" + "$ref": "#/parameters/ArchiveVersionNameParameter" } ], "responses": { @@ -486,25 +430,13 @@ "$ref": "#/parameters/RegistryNameParameter" }, { - "name": "repositoryType", - "in": "path", - "description": "The archive repository type.", - "required": true, - "type": "string" + "$ref": "#/parameters/PackageTypeParameter" }, { - "name": "archiveName", - "in": "path", - "description": "The archive name.", - "required": true, - "type": "string" + "$ref": "#/parameters/ArchiveNameParameter" }, { - "name": "archiveVersionName", - "in": "path", - "description": "The archive version name.", - "required": true, - "type": "string" + "$ref": "#/parameters/ArchiveVersionNameParameter" } ], "responses": { @@ -562,25 +494,13 @@ "$ref": "#/parameters/RegistryNameParameter" }, { - "name": "repositoryType", - "in": "path", - "description": "The archive repository type.", - "required": true, - "type": "string" + "$ref": "#/parameters/PackageTypeParameter" }, { - "name": "archiveName", - "in": "path", - "description": "The archive name.", - "required": true, - "type": "string" + "$ref": "#/parameters/ArchiveNameParameter" }, { - "name": "archiveVersionName", - "in": "path", - "description": "The archive version name.", - "required": true, - "type": "string" + "$ref": "#/parameters/ArchiveVersionNameParameter" } ], "responses": { From e79bbd0b802e9759a12ff5e735f6d5899ad730a7 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Thu, 23 Feb 2023 11:09:30 -0800 Subject: [PATCH 03/26] fix missing parameter --- .../2023-01-01-preview/containerregistry.json | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json index 60220637e815..63787bfaae10 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json @@ -7932,6 +7932,30 @@ "type": "string", "x-ms-parameter-location": "method" }, + "PackageTypeParameter": { + "name": "packageType", + "in": "path", + "description": "The type of the package repository.", + "required": true, + "type": "string", + "x-ms-parameter-location": "method" + }, + "ArchiveNameParameter": { + "name": "archiveName", + "in": "path", + "description": "The name of the archive resource.", + "required": true, + "type": "string", + "x-ms-parameter-location": "method" + }, + "ArchiveVersionNameParameter": { + "name": "archiveVersionName", + "in": "path", + "description": "The name of the archive version resource.", + "required": true, + "type": "string", + "x-ms-parameter-location": "method" + }, "CredentialSetNameParameter": { "name": "credentialSetName", "in": "path", From 41ffe3f44927a8b64dac321b240ee3a41b048559 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Thu, 23 Feb 2023 11:48:44 -0800 Subject: [PATCH 04/26] added pattern matching. --- .../preview/2023-01-01-preview/containerregistry.json | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json index 63787bfaae10..677e73281178 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json @@ -7938,6 +7938,9 @@ "description": "The type of the package repository.", "required": true, "type": "string", + "maxLength": 50, + "minLength": 5, + "pattern": "^[a-zA-Z]*$", "x-ms-parameter-location": "method" }, "ArchiveNameParameter": { @@ -7946,6 +7949,9 @@ "description": "The name of the archive resource.", "required": true, "type": "string", + "maxLength": 50, + "minLength": 5, + "pattern": "^[a-zA-Z0-9-]*$", "x-ms-parameter-location": "method" }, "ArchiveVersionNameParameter": { @@ -7954,6 +7960,9 @@ "description": "The name of the archive version resource.", "required": true, "type": "string", + "maxLength": 50, + "minLength": 5, + "pattern": "^[a-zA-Z0-9-]*$", "x-ms-parameter-location": "method" }, "CredentialSetNameParameter": { From 7056f7a67b9f3b2714e6791f9fd97ff971e06a74 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Thu, 23 Feb 2023 15:11:21 -0800 Subject: [PATCH 05/26] Fix the Operation tag --- .../2023-01-01-preview/containerregistry.json | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json index 677e73281178..73b54c5dccfa 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json @@ -21,7 +21,7 @@ "Archives" ], "description": "Lists all archives for the specified container registry and repository type.", - "operationId": "ArchiList", + "operationId": "Archives_List", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" @@ -69,7 +69,7 @@ "Archives" ], "description": "Gets the properties of the archive.", - "operationId": "ArchiGet", + "operationId": "Archives_Get", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" @@ -115,7 +115,7 @@ "Archives" ], "description": "Creates a archive for a container registry with the specified parameters.", - "operationId": "ArchiCreate", + "operationId": "Archives_Create", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" @@ -185,7 +185,7 @@ "Archives" ], "description": "Deletes a archive from a container registry.", - "operationId": "ArchiDelete", + "operationId": "Archives_Delete", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" @@ -243,7 +243,7 @@ "Archives" ], "description": "Updates a archive for a container registry with the specified parameters.", - "operationId": "ArchiUpdate", + "operationId": "Archives_Update", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" @@ -315,7 +315,7 @@ "ArchiveVersions" ], "description": "Lists all archive versions for the specified container registry, repository type and archive name.", - "operationId": "ArchiList", + "operationId": "ArchiveVersions_List", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" @@ -366,7 +366,7 @@ "ArchiveVersions" ], "description": "Gets the properties of the archive version.", - "operationId": "ArchiGet", + "operationId": "ArchiveVersions_Get", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" @@ -415,7 +415,7 @@ "ArchiveVersions" ], "description": "Creates a archive for a container registry with the specified parameters.", - "operationId": "ArchiCreate", + "operationId": "ArchiveVersions_Create", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" @@ -479,7 +479,7 @@ "ArchiveVersions" ], "description": "Deletes a archive version from a container registry.", - "operationId": "ArchiDelete", + "operationId": "ArchiveVersions_Delete", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v4/types.json#/parameters/ApiVersionParameter" From dd9eb8600e0b8e26d6561d30a628a61f15ca9f5a Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Thu, 23 Feb 2023 16:27:58 -0800 Subject: [PATCH 06/26] Added example for Archive List and Archive GET --- .../examples/ArchiveList.json | 40 +++++++++++++++++++ .../examples/ArchivesGet.json | 37 +++++++++++++++++ 2 files changed, 77 insertions(+) create mode 100644 specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveList.json create mode 100644 specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchivesGet.json diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveList.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveList.json new file mode 100644 index 000000000000..f16d18ec7a7e --- /dev/null +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveList.json @@ -0,0 +1,40 @@ +{ + "parameters": { + "api-version": "2023-01-01-preview", + "subscriptionId": "00000000-0000-0000-0000-000000000000", + "resourceGroupName": "myResourceGroup", + "registryName": "myRegistry", + "packageType": "myPackageType" + }, + "responses": { + "200": { + "body": { + "value": [ + { + "id": "string", + "name": "string", + "type": "string", + "systemData": { + "createdBy": "string", + "createdByType": "User", + "createdAt": "2023-02-24T00:22:47.311Z", + "lastModifiedBy": "string", + "lastModifiedByType": "User", + "lastModifiedAt": "2023-02-24T00:22:47.311Z" + }, + "properties": { + "packageSource": { + "type": "string", + "url": "string", + "distributionName": "string" + }, + "publishedVersion": "string", + "provisioningState": "Creating" + } + } + ], + "nextLink": "string" + } + } + } +} diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchivesGet.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchivesGet.json new file mode 100644 index 000000000000..c53ec9871e00 --- /dev/null +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchivesGet.json @@ -0,0 +1,37 @@ +{ + "parameters": { + "api-version": "2023-01-01-preview", + "subscriptionId": "00000000-0000-0000-0000-000000000000", + "resourceGroupName": "myResourceGroup", + "registryName": "myRegistry", + "packageType": "myPackageType", + "archiveName": "myArchiveName " + }, + "responses": { + "200": { + "body": { + "type": "Microsoft.ContainerRegistry/registries/packages/archives", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/packages/myPackageType/archives/myArchiveName", + "name": "myArchiveName", + "systemData": { + "createdBy": "string", + "createdByType": "User", + "createdAt": "2023-02-24T00:13:46.836Z", + "lastModifiedBy": "string", + "lastModifiedByType": "User", + "lastModifiedAt": "2023-02-24T00:13:46.836Z" + }, + "properties": { + "packageSource": { + "type": "string", + "url": "string", + "distributionName": "string" + }, + "publishedVersion": "string", + "provisioningState": "Creating" + } + } + } + } +} + From 803dd71e7ba18f63e3b09921004197b3d87925ee Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Mon, 5 Jun 2023 20:51:40 -0700 Subject: [PATCH 07/26] Fixe itteration 1. --- .../2023-01-01-preview/containerregistry.json | 14 ++++++++------ .../examples/{ArchivesGet.json => ArchiveGet.json} | 3 +-- .../2023-01-01-preview/examples/ArchiveList.json | 3 +-- 3 files changed, 10 insertions(+), 10 deletions(-) rename specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/{ArchivesGet.json => ArchiveGet.json} (93%) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json index 73b54c5dccfa..7f68c0689914 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json @@ -20,7 +20,7 @@ "tags": [ "Archives" ], - "description": "Lists all archives for the specified container registry and repository type.", + "description": "Lists all archives for the specified container registry and package type.", "operationId": "Archives_List", "parameters": [ { @@ -4170,6 +4170,12 @@ "description": "The published version of the archive.", "type": "string" }, + "repositoryEndpointPrefix": { + "type": "string" + }, + "repositoryEndpoint": { + "type": "string" + }, "provisioningState": { "description": "The provisioning state of the archive at the time the operation was called.", "enum": [ @@ -4200,10 +4206,6 @@ "url": { "description": "The external repository url.", "type": "string" - }, - "distributionName": { - "description": "Upstream Debian/RPM distribution Name.", - "type": "string" } } }, @@ -7935,7 +7937,7 @@ "PackageTypeParameter": { "name": "packageType", "in": "path", - "description": "The type of the package repository.", + "description": "The type of the package resource.", "required": true, "type": "string", "maxLength": 50, diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchivesGet.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveGet.json similarity index 93% rename from specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchivesGet.json rename to specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveGet.json index c53ec9871e00..6c37ecbe4619 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchivesGet.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveGet.json @@ -24,8 +24,7 @@ "properties": { "packageSource": { "type": "string", - "url": "string", - "distributionName": "string" + "url": "string" }, "publishedVersion": "string", "provisioningState": "Creating" diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveList.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveList.json index f16d18ec7a7e..e42307b21c85 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveList.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveList.json @@ -25,8 +25,7 @@ "properties": { "packageSource": { "type": "string", - "url": "string", - "distributionName": "string" + "url": "string" }, "publishedVersion": "string", "provisioningState": "Creating" From deaedffcf98b32685135dd161169f310dafc3550 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Fri, 9 Jun 2023 16:20:32 -0700 Subject: [PATCH 08/26] Added Debian Archive Resource too. --- .../2023-01-01-preview/containerregistry.json | 151 ++++++++++++------ 1 file changed, 98 insertions(+), 53 deletions(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json index 7f68c0689914..0ac01108ccd7 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json @@ -4131,30 +4131,25 @@ ], "properties": { "properties": { - "$ref": "#/definitions/ArchiveProperties", "description": "The properties of the archive.", + "allOf": [ + { + "$ref": "#/definitions/ArchiveProperties" + }, + { + "$ref": "#/definitions/DebianArchiveProperties" + } + ], "x-ms-client-flatten": true } } }, - "InnerErrorDescription": { - "description": "inner error.", - "required": [ - "code", - "message" - ], + "ErrorResponse": { + "description": "An error response from the Azure Container Registry service.", "properties": { - "code": { - "description": "error code.", - "type": "string" - }, - "message": { - "description": "error message.", - "type": "string" - }, - "target": { - "description": "target of the particular error.", - "type": "string" + "error": { + "$ref": "#/definitions/ErrorResponseBody", + "description": "Azure container registry build API error body." } } }, @@ -4163,8 +4158,16 @@ "type": "object", "properties": { "packageSource": { - "$ref": "#/definitions/ArchivePackageSourceProperties", - "description": "The package source of the archive." + "description": "The package source of the archive.", + "allOf": [ + { + "$ref": "#/definitions/ArchivePackageSourceProperties" + }, + { + "$ref": "#/definitions/DebianArchivePackageSourceProperties" + } + ], + "x-ms-client-flatten": true }, "publishedVersion": { "description": "The published version of the archive.", @@ -5100,44 +5103,33 @@ }, "readOnly": true }, - "ErrorResponseBody": { - "description": "An error response from the Azure Container Registry service.", - "required": [ - "code", - "message" + "DebianArchiveProperties": { + "description": "The properties of the Debian package Archive.", + "type": "object", + "allOf": [ + { + "$ref": "#/definitions/ArchiveProperties" + } ], "properties": { - "code": { - "description": "error code.", - "type": "string" - }, - "message": { - "description": "error message.", - "type": "string" - }, - "target": { - "description": "target of the particular error.", + "distributionName": { + "description": "Debian distribution Name.", "type": "string" - }, - "details": { - "description": "an array of additional nested error response info objects, as described by this contract.", - "type": "array", - "items": { - "$ref": "#/definitions/InnerErrorDescription" - }, - "x-ms-identifiers": [ - "message", - "target" - ] } } }, - "ErrorResponse": { - "description": "An error response from the Azure Container Registry service.", + "DebianArchivePackageSourceProperties": { + "description": "The properties of the archive package source.", + "type": "object", + "allOf": [ + { + "$ref": "#/definitions/ArchivePackageSourceProperties" + } + ], "properties": { - "error": { - "$ref": "#/definitions/ErrorResponseBody", - "description": "Azure container registry build API error body." + "distributionName": { + "description": "Upstream Debian distribution Name.", + "type": "string" } } }, @@ -7808,6 +7800,59 @@ } } } + }, + "ErrorResponseBody": { + "description": "An error response from the Azure Container Registry service.", + "required": [ + "code", + "message" + ], + "properties": { + "code": { + "description": "error code.", + "type": "string" + }, + "message": { + "description": "error message.", + "type": "string" + }, + "target": { + "description": "target of the particular error.", + "type": "string" + }, + "details": { + "description": "an array of additional nested error response info objects, as described by this contract.", + "type": "array", + "items": { + "$ref": "#/definitions/InnerErrorDescription" + }, + "x-ms-identifiers": [ + "message", + "target" + ] + } + } + }, + "InnerErrorDescription": { + "description": "inner error.", + "required": [ + "code", + "message" + ], + "properties": { + "code": { + "description": "error code.", + "type": "string" + }, + "message": { + "description": "error message.", + "type": "string" + }, + "target": { + "description": "target of the particular error.", + "type": "string" + } + } } }, "parameters": { @@ -7951,7 +7996,7 @@ "description": "The name of the archive resource.", "required": true, "type": "string", - "maxLength": 50, + "maxLength": 200, "minLength": 5, "pattern": "^[a-zA-Z0-9-]*$", "x-ms-parameter-location": "method" @@ -7962,7 +8007,7 @@ "description": "The name of the archive version resource.", "required": true, "type": "string", - "maxLength": 50, + "maxLength": 200, "minLength": 5, "pattern": "^[a-zA-Z0-9-]*$", "x-ms-parameter-location": "method" From fdea4f562408e2dc86c505be43c0977d4c305712 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Fri, 9 Jun 2023 16:59:25 -0700 Subject: [PATCH 09/26] Add missing examples --- .../examples/ArchiveCreate.json | 37 ++++++++++++ .../examples/ArchiveDelete.json | 19 ++++++ .../examples/ArchiveUpdate.json | 58 +++++++++++++++++++ .../examples/ArchiveVersionCreate.json | 25 ++++++++ .../examples/ArchiveVersionDelete.json | 20 +++++++ .../examples/ArchiveVersionGet.json | 33 +++++++++++ .../examples/ArchiveVersionList.json | 36 ++++++++++++ 7 files changed, 228 insertions(+) create mode 100644 specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json create mode 100644 specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveDelete.json create mode 100644 specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json create mode 100644 specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json create mode 100644 specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionDelete.json create mode 100644 specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionGet.json create mode 100644 specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionList.json diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json new file mode 100644 index 000000000000..83272e6d53fd --- /dev/null +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json @@ -0,0 +1,37 @@ +{ + "parameters": { + "api-version": "2023-01-01-preview", + "subscriptionId": "00000000-0000-0000-0000-000000000000", + "resourceGroupName": "myResourceGroup", + "registryName": "myRegistry", + "packageType": "rpm" + "archiveName": "myArchiveName", + "archiveCreateParameters ": { + { + "properties": { + "packageSource": "string", + "publishedVersion": "string", + "repositoryEndpointPrefix": "string", + "repositoryEndpoint": "string" + } + } + } + }, + "responses": { + "200": { + "body": { + "type": "Microsoft.ContainerRegistry/registries/archives", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/archives/myArchiveName", + "name": "myArchiveName", + "properties": { + "packageSource": "string", + "publishedVersion": "string", + "repositoryEndpointPrefix": "string", + "repositoryEndpoint": "string", + "provisioningState": "Succeeded" + } + } + } + } + +} \ No newline at end of file diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveDelete.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveDelete.json new file mode 100644 index 000000000000..0ef1160bfc23 --- /dev/null +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveDelete.json @@ -0,0 +1,19 @@ +{ + "parameters": { + "api-version": "2023-01-01-preview", + "subscriptionId": "00000000-0000-0000-0000-000000000000", + "resourceGroupName": "myResourceGroup", + "registryName": "myRegistry", + "packageType": "myPackageType" + "archiveName": "myArchiveName" + }, + "responses": { + "200": {}, + "202": { + "headers": { + "Location": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/packages/myPackageType/archives/myArchiveName/operationStatuses/archive-00000000-0000-0000-0000-000000000000?api-version=2023-01-01-preview" + } + }, + "204": {} + } +} diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json new file mode 100644 index 000000000000..80792d003d2a --- /dev/null +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json @@ -0,0 +1,58 @@ +{ + "parameters": { + "api-version": "2023-01-01-preview", + "subscriptionId": "00000000-0000-0000-0000-000000000000", + "resourceGroupName": "myResourceGroup", + "registryName": "myRegistry", + "packageType" : "myPackageType", + "archiveName": "myArchiveName ", + "archiveUpdateParameters": { + "properties": { + "publishedVersion": "string" + } + } + }, + "responses": { + "200": { + "body": { + "type": "Microsoft.ContainerRegistry/registries/packages/archives", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/packages/myPackageType/archives/myArchiveName", + "name": "myArchiveName", + "systemData": { + "createdBy": "string", + "createdByType": "User", + "createdAt": "2023-06-09T23:41:38.720Z", + "lastModifiedBy": "string", + "lastModifiedByType": "User", + "lastModifiedAt": "2023-06-09T23:41:38.720Z" + }, + "properties": { + "packageSource": "string", + "publishedVersion": "string", + "repositoryEndpointPrefix": "string", + "repositoryEndpoint": "string", + "provisioningState": "Creating", + "distributionName": "string" + } + } + }, + "201": { + "headers": { + "Azure-AsyncOperation": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/packages/myPackageType/archives/myArchiveName/operationStatuses/archive-00000000-0000-0000-0000-000000000000?api-version=2023-01-01-preview" + }, + "body": { + "type": "Microsoft.ContainerRegistry/registries/packages/archives", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/packages/myPackageType/archives/myArchiveName", + "name": "myArchiveName", + "properties": { + "packageSource": "string", + "publishedVersion": "string", + "repositoryEndpointPrefix": "string", + "repositoryEndpoint": "string", + "provisioningState": "Creating", + "distributionName": "string" + } + } + } + } +} diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json new file mode 100644 index 000000000000..d65bc2fb5192 --- /dev/null +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json @@ -0,0 +1,25 @@ +{ + "parameters": { + "api-version": "2023-01-01-preview", + "subscriptionId": "00000000-0000-0000-0000-000000000000", + "resourceGroupName": "myResourceGroup", + "registryName": "myRegistry", + "packageType": "rpm" + "archiveName": "myArchiveName ", + "archiveVersionName ": "myArchiveVersionName" + }, + "responses": { + "200": { + "body": { + "type": "Microsoft.ContainerRegistry/registries/archives", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/archives/myArchiveName/versions/myArchiveVersionName", + "name": "myArchiveVersionName", + "properties": { + "provisioningState": "Succeeded", + "myArchiveVersionName": "string", + } + } + } + } + +} \ No newline at end of file diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionDelete.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionDelete.json new file mode 100644 index 000000000000..36bbab0a9fa0 --- /dev/null +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionDelete.json @@ -0,0 +1,20 @@ +{ + "parameters": { + "api-version": "2023-01-01-preview", + "subscriptionId": "00000000-0000-0000-0000-000000000000", + "resourceGroupName": "myResourceGroup", + "registryName": "myRegistry", + "packageType": "myPackageType" + "archiveName": "myArchiveName", + "archiveVersionName": "myArchiveVersionName", + }, + "responses": { + "200": {}, + "202": { + "headers": { + "Location": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/packages/myPackageType/archives/myArchiveName/versions/myArchiveVersionName/operationStatuses/archive-00000000-0000-0000-0000-000000000000?api-version=2023-01-01-preview" + } + }, + "204": {} + } +} diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionGet.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionGet.json new file mode 100644 index 000000000000..d6d1bf8a6f47 --- /dev/null +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionGet.json @@ -0,0 +1,33 @@ +{ + "parameters": { + "api-version": "2023-01-01-preview", + "subscriptionId": "00000000-0000-0000-0000-000000000000", + "resourceGroupName": "myResourceGroup", + "registryName": "myRegistry", + "packageType": "rpm", + "archiveName": "myArchiveName", + "archiveVersionName": "myArchiveVersionName" + }, + "responses": { + "200": { + "body": { + "type": "Microsoft.ContainerRegistry/registries/packages/archives", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/packages/rpm/archives/myArchiveName/versions/myArchiveVersionName", + "name": "myArchiveName", + "systemData": { + "createdBy": "string", + "createdByType": "User", + "createdAt": "2023-02-24T00:13:46.836Z", + "lastModifiedBy": "string", + "lastModifiedByType": "User", + "lastModifiedAt": "2023-02-24T00:13:46.836Z" + }, + "properties": { + "provisioningState": "Creating", + "archiveVersionErrorMessage": "string" + } + } + } + } +} + diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionList.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionList.json new file mode 100644 index 000000000000..2510d3962ba6 --- /dev/null +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionList.json @@ -0,0 +1,36 @@ +{ + "parameters": { + "api-version": "2023-01-01-preview", + "subscriptionId": "00000000-0000-0000-0000-000000000000", + "resourceGroupName": "myResourceGroup", + "registryName": "myRegistry", + "packageType": "myPackageType", + "archiveName": "myArchiveName", + }, + "responses": { + "200": { + "body": { + "value": [ + { + "id": "string", + "name": "string", + "type": "string", + "systemData": { + "createdBy": "string", + "createdByType": "User", + "createdAt": "2023-02-24T00:22:47.311Z", + "lastModifiedBy": "string", + "lastModifiedByType": "User", + "lastModifiedAt": "2023-02-24T00:22:47.311Z" + }, + "properties": { + "provisioningState": "Creating", + "archiveVersionErrorMessage": "string" + } + } + ], + "nextLink": "string" + } + } + } +} From 3cd0ad4cfe36a72eff5232d1a99a9c048efde6c4 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Fri, 9 Jun 2023 17:16:17 -0700 Subject: [PATCH 10/26] Fixed type as enum --- .../preview/2023-01-01-preview/containerregistry.json | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json index 0ac01108ccd7..fe8fa243a043 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json @@ -4204,7 +4204,14 @@ "properties": { "type": { "description": "The type of package source for a archive.", - "type": "string" + "enum": [ + "remote" + ], + "type": "string", + "x-ms-enum": { + "name": "PackageSourceType", + "modelAsString": true + } }, "url": { "description": "The external repository url.", From acb7db5b01fca9ee2c47f14bbdcd4dd19079663d Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Fri, 9 Jun 2023 17:26:49 -0700 Subject: [PATCH 11/26] Fix example --- .../preview/2023-01-01-preview/examples/ArchiveCreate.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json index 83272e6d53fd..7a6205f7943a 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json @@ -4,7 +4,7 @@ "subscriptionId": "00000000-0000-0000-0000-000000000000", "resourceGroupName": "myResourceGroup", "registryName": "myRegistry", - "packageType": "rpm" + "packageType": "rpm", "archiveName": "myArchiveName", "archiveCreateParameters ": { { From af4a0d83221a3be381c935e85021b98d87e81c21 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Fri, 9 Jun 2023 17:52:48 -0700 Subject: [PATCH 12/26] Fix response code for the controllers. --- .../2023-01-01-preview/containerregistry.json | 36 ++----------------- .../examples/ArchiveCreate.json | 1 - .../examples/ArchiveUpdate.json | 18 ---------- 3 files changed, 3 insertions(+), 52 deletions(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json index fe8fa243a043..e057a7695214 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json @@ -147,22 +147,11 @@ ], "responses": { "200": { - "description": "The request was successful; the operation has completed successfully.", + "description": "ARM update operation completed successfully.", "schema": { "$ref": "#/definitions/Archive" } }, - "201": { - "description": "The request was successful; the operation will complete asynchronously.", - "schema": { - "$ref": "#/definitions/Archive" - }, - "headers": { - "Azure-AsyncOperation": { - "type": "string" - } - } - }, "default": { "description": "Error response describing why the operation failed. If any of the input parameters are invalid, 400 (Bad Request) is returned. If the request cannot be processed due to a conflict in the request, 409 (Conflict) is returned.", "schema": { @@ -174,10 +163,6 @@ "ArchiveCreate": { "$ref": "./examples/ArchiveCreate.json" } - }, - "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options": { - "final-state-via": "azure-async-operation" } }, "delete": { @@ -280,17 +265,6 @@ "$ref": "#/definitions/Archive" } }, - "201": { - "description": "The request was successful; the operation will complete asynchronously.", - "schema": { - "$ref": "#/definitions/Archive" - }, - "headers": { - "Azure-AsyncOperation": { - "type": "string" - } - } - }, "default": { "description": "Error response describing why the operation failed. If any of the input parameters are invalid, 400 (Bad Request) is returned. If the request cannot be processed due to a conflict in the request, 409 (Conflict) is returned.", "schema": { @@ -302,10 +276,6 @@ "ArchiveUpdate": { "$ref": "./examples/ArchiveUpdate.json" } - }, - "x-ms-long-running-operation": true, - "x-ms-long-running-operation-options": { - "final-state-via": "azure-async-operation" } } }, @@ -441,13 +411,13 @@ ], "responses": { "200": { - "description": "The request was successful; the operation has completed successfully.", + "description": "ARM update operation completed successfully.", "schema": { "$ref": "#/definitions/ArchiveVersion" } }, "201": { - "description": "The request was successful; the operation will complete asynchronously.", + "description": "ARM create operation completed successfully.", "schema": { "$ref": "#/definitions/ArchiveVersion" }, diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json index 7a6205f7943a..9554fa5599f9 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json @@ -33,5 +33,4 @@ } } } - } \ No newline at end of file diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json index 80792d003d2a..560de4a44e33 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json @@ -35,24 +35,6 @@ "distributionName": "string" } } - }, - "201": { - "headers": { - "Azure-AsyncOperation": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/packages/myPackageType/archives/myArchiveName/operationStatuses/archive-00000000-0000-0000-0000-000000000000?api-version=2023-01-01-preview" - }, - "body": { - "type": "Microsoft.ContainerRegistry/registries/packages/archives", - "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/packages/myPackageType/archives/myArchiveName", - "name": "myArchiveName", - "properties": { - "packageSource": "string", - "publishedVersion": "string", - "repositoryEndpointPrefix": "string", - "repositoryEndpoint": "string", - "provisioningState": "Creating", - "distributionName": "string" - } - } } } } From aca806d981bb7aa9bc4cd5c0853d2d4711332edc Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Fri, 9 Jun 2023 18:00:51 -0700 Subject: [PATCH 13/26] Fix Archive Create example --- .../preview/2023-01-01-preview/examples/ArchiveCreate.json | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json index 9554fa5599f9..2792ab326b0f 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json @@ -6,15 +6,13 @@ "registryName": "myRegistry", "packageType": "rpm", "archiveName": "myArchiveName", - "archiveCreateParameters ": { - { + "archiveCreateParameters": { "properties": { "packageSource": "string", "publishedVersion": "string", "repositoryEndpointPrefix": "string", "repositoryEndpoint": "string" } - } } }, "responses": { From 1deb0f1b6aaeef8f05c8b4d9950b1274fff45d7e Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Fri, 9 Jun 2023 18:11:36 -0700 Subject: [PATCH 14/26] Fixed repository endpoint to be readonly --- .../2023-01-01-preview/containerregistry.json | 3 ++- .../examples/ArchiveDelete.json | 2 +- .../examples/ArchiveVersionCreate.json | 20 +++++++++++++++---- .../examples/ArchiveVersionDelete.json | 2 +- 4 files changed, 20 insertions(+), 7 deletions(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json index e057a7695214..fe6b503f8fb3 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json @@ -4147,7 +4147,8 @@ "type": "string" }, "repositoryEndpoint": { - "type": "string" + "type": "string", + "readOnly": true }, "provisioningState": { "description": "The provisioning state of the archive at the time the operation was called.", diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveDelete.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveDelete.json index 0ef1160bfc23..a094d9351d7b 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveDelete.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveDelete.json @@ -4,7 +4,7 @@ "subscriptionId": "00000000-0000-0000-0000-000000000000", "resourceGroupName": "myResourceGroup", "registryName": "myRegistry", - "packageType": "myPackageType" + "packageType": "myPackageType", "archiveName": "myArchiveName" }, "responses": { diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json index d65bc2fb5192..ad847570008f 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json @@ -11,12 +11,24 @@ "responses": { "200": { "body": { - "type": "Microsoft.ContainerRegistry/registries/archives", - "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/archives/myArchiveName/versions/myArchiveVersionName", + "type": "Microsoft.ContainerRegistry/registries/packages/archives/versions", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/packages/rpm/archives/myArchiveName/versions/myArchiveVersionName", "name": "myArchiveVersionName", "properties": { - "provisioningState": "Succeeded", - "myArchiveVersionName": "string", + "provisioningState": "Succeeded" + } + } + }, + "201": { + "headers": { + "Azure-AsyncOperation": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/packages/rpm/archives/myArchiveName/versions/myArchiveVersionName/operationStatuses/archoveversion-00000000-0000-0000-0000-000000000000?api-version=2023-01-01-preview" + }, + "body": { + "type": "Microsoft.ContainerRegistry/registries/packages/archives/versions", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/packages/rpm/archives/myArchiveName/versions/myArchiveVersionName", + "name": "myCacheRule", + "properties": { + "provisioningState": "Succeeded" } } } diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionDelete.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionDelete.json index 36bbab0a9fa0..1b59601abd38 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionDelete.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionDelete.json @@ -4,7 +4,7 @@ "subscriptionId": "00000000-0000-0000-0000-000000000000", "resourceGroupName": "myResourceGroup", "registryName": "myRegistry", - "packageType": "myPackageType" + "packageType": "myPackageType", "archiveName": "myArchiveName", "archiveVersionName": "myArchiveVersionName", }, From 82f9ceef68e2e2e28b74eff7b2b7213a61a860b4 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Fri, 9 Jun 2023 18:18:32 -0700 Subject: [PATCH 15/26] Bringing back 201 status of Create Archive operation to make ARM swagger lint verification happy --- .../2023-01-01-preview/containerregistry.json | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json index fe6b503f8fb3..e47ec361639b 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json @@ -152,6 +152,17 @@ "$ref": "#/definitions/Archive" } }, + "201": { + "description": "ARM create operation completed successfully.", + "schema": { + "$ref": "#/definitions/Archive" + }, + "headers": { + "Azure-AsyncOperation": { + "type": "string" + } + } + }, "default": { "description": "Error response describing why the operation failed. If any of the input parameters are invalid, 400 (Bad Request) is returned. If the request cannot be processed due to a conflict in the request, 409 (Conflict) is returned.", "schema": { @@ -163,6 +174,10 @@ "ArchiveCreate": { "$ref": "./examples/ArchiveCreate.json" } + }, + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options": { + "final-state-via": "azure-async-operation" } }, "delete": { From ead1224932a20d360409cbfb31d4e3432c06fe34 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Fri, 9 Jun 2023 18:30:04 -0700 Subject: [PATCH 16/26] Fix the examples --- .../2023-01-01-preview/examples/ArchiveVersionCreate.json | 2 +- .../2023-01-01-preview/examples/ArchiveVersionDelete.json | 2 +- .../preview/2023-01-01-preview/examples/ArchiveVersionList.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json index ad847570008f..055e6895911e 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json @@ -4,7 +4,7 @@ "subscriptionId": "00000000-0000-0000-0000-000000000000", "resourceGroupName": "myResourceGroup", "registryName": "myRegistry", - "packageType": "rpm" + "packageType": "rpm", "archiveName": "myArchiveName ", "archiveVersionName ": "myArchiveVersionName" }, diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionDelete.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionDelete.json index 1b59601abd38..f7921b18ee0f 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionDelete.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionDelete.json @@ -6,7 +6,7 @@ "registryName": "myRegistry", "packageType": "myPackageType", "archiveName": "myArchiveName", - "archiveVersionName": "myArchiveVersionName", + "archiveVersionName": "myArchiveVersionName" }, "responses": { "200": {}, diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionList.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionList.json index 2510d3962ba6..fc3cc13e247e 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionList.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionList.json @@ -5,7 +5,7 @@ "resourceGroupName": "myResourceGroup", "registryName": "myRegistry", "packageType": "myPackageType", - "archiveName": "myArchiveName", + "archiveName": "myArchiveName" }, "responses": { "200": { From 0084bebc709459502248d0c6d3ef1771c4d22594 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Fri, 9 Jun 2023 18:46:44 -0700 Subject: [PATCH 17/26] fix examples --- .../2023-01-01-preview/containerregistry.json | 2 +- .../examples/ArchiveCreate.json | 20 +++++++++++++++++-- .../examples/ArchiveGet.json | 2 +- .../examples/ArchiveUpdate.json | 2 +- .../examples/ArchiveVersionCreate.json | 4 ++-- 5 files changed, 23 insertions(+), 7 deletions(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json index e47ec361639b..78320034605c 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json @@ -7979,7 +7979,7 @@ "required": true, "type": "string", "maxLength": 50, - "minLength": 5, + "minLength": 3, "pattern": "^[a-zA-Z]*$", "x-ms-parameter-location": "method" }, diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json index 2792ab326b0f..042b82bd34a4 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json @@ -10,13 +10,29 @@ "properties": { "packageSource": "string", "publishedVersion": "string", - "repositoryEndpointPrefix": "string", - "repositoryEndpoint": "string" + "repositoryEndpointPrefix": "string" } } }, "responses": { "200": { + "body": { + "type": "Microsoft.ContainerRegistry/registries/archives", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/packages/rpm/archives/myArchiveName", + "name": "myArchiveName", + "properties": { + "packageSource": "string", + "publishedVersion": "string", + "repositoryEndpointPrefix": "string", + "repositoryEndpoint": "string", + "provisioningState": "Succeeded" + } + } + }, + "201": { + "headers": { + "Azure-AsyncOperation": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/packages/rpm/archives/myArchiveName/operationStatuses/archive-00000000-0000-0000-0000-000000000000?api-version=2023-01-01-preview" + }, "body": { "type": "Microsoft.ContainerRegistry/registries/archives", "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/archives/myArchiveName", diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveGet.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveGet.json index 6c37ecbe4619..0955ad1e2e16 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveGet.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveGet.json @@ -5,7 +5,7 @@ "resourceGroupName": "myResourceGroup", "registryName": "myRegistry", "packageType": "myPackageType", - "archiveName": "myArchiveName " + "archiveName": "myArchiveName" }, "responses": { "200": { diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json index 560de4a44e33..f360cb937145 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json @@ -5,7 +5,7 @@ "resourceGroupName": "myResourceGroup", "registryName": "myRegistry", "packageType" : "myPackageType", - "archiveName": "myArchiveName ", + "archiveName": "myArchiveName", "archiveUpdateParameters": { "properties": { "publishedVersion": "string" diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json index 055e6895911e..fc0e4f7a83b3 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveVersionCreate.json @@ -5,8 +5,8 @@ "resourceGroupName": "myResourceGroup", "registryName": "myRegistry", "packageType": "rpm", - "archiveName": "myArchiveName ", - "archiveVersionName ": "myArchiveVersionName" + "archiveName": "myArchiveName", + "archiveVersionName": "myArchiveVersionName" }, "responses": { "200": { From 731798959288aede3c229c6019adefcb885525d3 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Mon, 12 Jun 2023 14:00:24 -0700 Subject: [PATCH 18/26] Supressing Error response lint error --- specification/containerregistry/resource-manager/readme.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/specification/containerregistry/resource-manager/readme.md b/specification/containerregistry/resource-manager/readme.md index 0ca4fc079bac..963dbe04751c 100644 --- a/specification/containerregistry/resource-manager/readme.md +++ b/specification/containerregistry/resource-manager/readme.md @@ -36,6 +36,10 @@ These settings apply only when `--tag=package-2023-01-preview-only` is specified ```yaml $(tag) == 'package-2023-01-preview-only' input-file: - Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +suppressions: + - code: LroErrorContent + reason: The Error object is shared between all controllers. Changing the Error object will require refactoring all the controllers. + from: Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json ``` ### Tag: package-2023-01-preview From f5da4b09f305e355289d9a910d4a4fd59c6f4545 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Mon, 12 Jun 2023 14:42:32 -0700 Subject: [PATCH 19/26] Fix sdk build error --- .../2023-01-01-preview/containerregistry.json | 21 +++---------------- .../examples/ArchiveUpdate.json | 3 +-- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json index 78320034605c..3fde8ab2932c 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json @@ -4116,15 +4116,8 @@ ], "properties": { "properties": { + "$ref": "#/definitions/ArchiveProperties", "description": "The properties of the archive.", - "allOf": [ - { - "$ref": "#/definitions/ArchiveProperties" - }, - { - "$ref": "#/definitions/DebianArchiveProperties" - } - ], "x-ms-client-flatten": true } } @@ -4143,16 +4136,8 @@ "type": "object", "properties": { "packageSource": { - "description": "The package source of the archive.", - "allOf": [ - { - "$ref": "#/definitions/ArchivePackageSourceProperties" - }, - { - "$ref": "#/definitions/DebianArchivePackageSourceProperties" - } - ], - "x-ms-client-flatten": true + "$ref": "#/definitions/ArchivePackageSourceProperties", + "description": "The package source of the archive." }, "publishedVersion": { "description": "The published version of the archive.", diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json index f360cb937145..c01f6775efe1 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json @@ -31,8 +31,7 @@ "publishedVersion": "string", "repositoryEndpointPrefix": "string", "repositoryEndpoint": "string", - "provisioningState": "Creating", - "distributionName": "string" + "provisioningState": "Creating" } } } From ad3cae3c43bda8d460396c4d0229bc9d83a6a009 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Mon, 12 Jun 2023 14:53:22 -0700 Subject: [PATCH 20/26] Fix the examples --- .../2023-01-01-preview/examples/ArchiveCreate.json | 10 ++++++++-- .../2023-01-01-preview/examples/ArchiveUpdate.json | 5 ++++- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json index 042b82bd34a4..6812b5041728 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json @@ -21,7 +21,10 @@ "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/packages/rpm/archives/myArchiveName", "name": "myArchiveName", "properties": { - "packageSource": "string", + "packageSource": { + "type": "remote", + "url": "string" + }, "publishedVersion": "string", "repositoryEndpointPrefix": "string", "repositoryEndpoint": "string", @@ -38,7 +41,10 @@ "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.ContainerRegistry/registries/myRegistry/archives/myArchiveName", "name": "myArchiveName", "properties": { - "packageSource": "string", + "packageSource": { + "type": "remote", + "url": "string" + }, "publishedVersion": "string", "repositoryEndpointPrefix": "string", "repositoryEndpoint": "string", diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json index c01f6775efe1..c5b40b334e2f 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveUpdate.json @@ -27,7 +27,10 @@ "lastModifiedAt": "2023-06-09T23:41:38.720Z" }, "properties": { - "packageSource": "string", + "packageSource": { + "type": "remote", + "url": "string" + }, "publishedVersion": "string", "repositoryEndpointPrefix": "string", "repositoryEndpoint": "string", From 7e288936f29e60b34843a3e6bfc628f1159cf6fe Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Mon, 12 Jun 2023 14:59:39 -0700 Subject: [PATCH 21/26] validate Archive create example --- .../preview/2023-01-01-preview/examples/ArchiveCreate.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json index 6812b5041728..52d88c87a950 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-01-01-preview/examples/ArchiveCreate.json @@ -8,7 +8,10 @@ "archiveName": "myArchiveName", "archiveCreateParameters": { "properties": { - "packageSource": "string", + "packageSource": { + "type": "remote", + "url": "string" + }, "publishedVersion": "string", "repositoryEndpointPrefix": "string" } From e6f34d5d4499057636b73864dd331e9a8df26b1d Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Mon, 12 Jun 2023 15:09:32 -0700 Subject: [PATCH 22/26] Add supression message --- .../containerregistry/resource-manager/readme.md | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/specification/containerregistry/resource-manager/readme.md b/specification/containerregistry/resource-manager/readme.md index 963dbe04751c..16478ace9054 100644 --- a/specification/containerregistry/resource-manager/readme.md +++ b/specification/containerregistry/resource-manager/readme.md @@ -36,10 +36,6 @@ These settings apply only when `--tag=package-2023-01-preview-only` is specified ```yaml $(tag) == 'package-2023-01-preview-only' input-file: - Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json -suppressions: - - code: LroErrorContent - reason: The Error object is shared between all controllers. Changing the Error object will require refactoring all the controllers. - from: Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json ``` ### Tag: package-2023-01-preview @@ -410,3 +406,12 @@ See configuration in [readme.go.md](./readme.go.md) ## Java See configuration in [readme.java.md](./readme.java.md) + +### Suppress rules that might be fixed + +``` yaml +suppressions: + - code: LroErrorContent + reason: The Error object is shared between all controllers. Changing the Error object will require refactoring all the controllers. + from: Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +``` \ No newline at end of file From 11063bbe8a5584493116706c35d17b7c4bb51db5 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Mon, 12 Jun 2023 15:33:04 -0700 Subject: [PATCH 23/26] Supress error --- specification/containerregistry/resource-manager/readme.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/specification/containerregistry/resource-manager/readme.md b/specification/containerregistry/resource-manager/readme.md index 16478ace9054..f83105a3e6f0 100644 --- a/specification/containerregistry/resource-manager/readme.md +++ b/specification/containerregistry/resource-manager/readme.md @@ -36,6 +36,11 @@ These settings apply only when `--tag=package-2023-01-preview-only` is specified ```yaml $(tag) == 'package-2023-01-preview-only' input-file: - Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json +directive: + - where: + - $.paths + suppress: + - LroErrorContent ``` ### Tag: package-2023-01-preview @@ -413,5 +418,4 @@ See configuration in [readme.java.md](./readme.java.md) suppressions: - code: LroErrorContent reason: The Error object is shared between all controllers. Changing the Error object will require refactoring all the controllers. - from: Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json ``` \ No newline at end of file From 8c77ab37332b6207172da7fa754055e6234b194d Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Mon, 12 Jun 2023 15:55:36 -0700 Subject: [PATCH 24/26] The supression should finally work. --- .../containerregistry/resource-manager/readme.md | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/specification/containerregistry/resource-manager/readme.md b/specification/containerregistry/resource-manager/readme.md index f83105a3e6f0..440ac969813e 100644 --- a/specification/containerregistry/resource-manager/readme.md +++ b/specification/containerregistry/resource-manager/readme.md @@ -41,6 +41,7 @@ directive: - $.paths suppress: - LroErrorContent + reason: The Error object is shared between all controllers. Changing the Error object will require refactoring all the controllers. Temporarily suppressing linter errors and will be fixed later. ``` ### Tag: package-2023-01-preview @@ -410,12 +411,4 @@ See configuration in [readme.go.md](./readme.go.md) ## Java -See configuration in [readme.java.md](./readme.java.md) - -### Suppress rules that might be fixed - -``` yaml -suppressions: - - code: LroErrorContent - reason: The Error object is shared between all controllers. Changing the Error object will require refactoring all the controllers. -``` \ No newline at end of file +See configuration in [readme.java.md](./readme.java.md) \ No newline at end of file From 6241c31c1e1e03359fbce04f040fe472c9c184f3 Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Mon, 12 Jun 2023 16:11:15 -0700 Subject: [PATCH 25/26] Supress LroErrorContent --- .../containerregistry/resource-manager/readme.md | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/specification/containerregistry/resource-manager/readme.md b/specification/containerregistry/resource-manager/readme.md index 440ac969813e..2bd33f7c7ea3 100644 --- a/specification/containerregistry/resource-manager/readme.md +++ b/specification/containerregistry/resource-manager/readme.md @@ -41,7 +41,6 @@ directive: - $.paths suppress: - LroErrorContent - reason: The Error object is shared between all controllers. Changing the Error object will require refactoring all the controllers. Temporarily suppressing linter errors and will be fixed later. ``` ### Tag: package-2023-01-preview @@ -411,4 +410,13 @@ See configuration in [readme.go.md](./readme.go.md) ## Java -See configuration in [readme.java.md](./readme.java.md) \ No newline at end of file +See configuration in [readme.java.md](./readme.java.md) + +## Suppression + +``` yaml +directive: + - suppress: LroErrorContent + from: Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json + reason: The Error object is shared between all controllers. Changing the Error object will require refactoring all the controllers. Temporarily suppressing linter errors and will be fixed later. +``` \ No newline at end of file From d0847561eb2f769001dc61c566d83498a080fd7d Mon Sep 17 00:00:00 2001 From: Jitendra Kumar Date: Mon, 12 Jun 2023 16:31:04 -0700 Subject: [PATCH 26/26] Add supression for LroErrorContent --- .../containerregistry/resource-manager/readme.md | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/specification/containerregistry/resource-manager/readme.md b/specification/containerregistry/resource-manager/readme.md index 2bd33f7c7ea3..6c92c6d468ab 100644 --- a/specification/containerregistry/resource-manager/readme.md +++ b/specification/containerregistry/resource-manager/readme.md @@ -36,11 +36,6 @@ These settings apply only when `--tag=package-2023-01-preview-only` is specified ```yaml $(tag) == 'package-2023-01-preview-only' input-file: - Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json -directive: - - where: - - $.paths - suppress: - - LroErrorContent ``` ### Tag: package-2023-01-preview @@ -412,11 +407,11 @@ See configuration in [readme.go.md](./readme.go.md) See configuration in [readme.java.md](./readme.java.md) -## Suppression + +### Suppress rules that might be fixed ``` yaml -directive: - - suppress: LroErrorContent - from: Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json - reason: The Error object is shared between all controllers. Changing the Error object will require refactoring all the controllers. Temporarily suppressing linter errors and will be fixed later. +suppressions: + - code: LroErrorContent + reason: The Error object is shared between all controllers. Changing the Error object will require refactoring all the controllers. ``` \ No newline at end of file