Skip to content

[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview #21671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jianyexi merged 5 commits into from
Dec 22, 2022
Merged

[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview #21671

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
88aeac0
Fix s360 alerts for properties being returned in GET but not exising …
neeerajaakula Nov 28, 2022
37b8cf8
Prettier fix
neeerajaakula Nov 28, 2022
e6a71bc
Fix model validation error for long running operation response missin…
neeerajaakula Nov 28, 2022
805f2c3
removed default value for array as it breaks the arm template schema …
neeerajaakula Dec 21, 2022
42e9e42
removed default value for array for managed hsm virtual network rule …
neeerajaakula Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...nager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/DeletedManagedHsm_Purge.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
"api-version": "2021-04-01-preview"
},
"responses": {
"202": {}
"202": {
"headers": {
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
}
}
}
}
3 changes: 3 additions & 0 deletions ...ger/Microsoft.KeyVault/preview/2021-04-01-preview/examples/ManagedHsm_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
},
"responses": {
"202": {
"headers": {
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
},
"body": {
"properties": {
"tenantId": "00000000-0000-0000-0000-000000000000",
Expand Down
6 changes: 5 additions & 1 deletion ...rce-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/ManagedHsm_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@
},
"responses": {
"200": {},
"202": {},
"202": {
"headers": {
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
}
},
"204": {}
}
}
34 changes: 27 additions & 7 deletions ...n/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,13 @@
"description": "Request successful. Resource does not exist."
},
"202": {
"description": "Accepted and the operation will complete asynchronously."
"description": "Accepted and the operation will complete asynchronously.",
"headers": {
"Location": {
"description": "The URI to poll for completion status.",
"type": "string"
}
}
},
"200": {
"description": "Delete successful."
Expand Down Expand Up @@ -524,7 +530,13 @@
],
"responses": {
"202": {
"description": "Accepted and the operation will complete asynchronously."
"description": "Accepted and the operation will complete asynchronously.",
"headers": {
"Location": {
"description": "The URI to poll for completion status.",
"type": "string"
}
}
},
"default": {
"description": "The error response describing why the operation failed.",
Expand Down Expand Up @@ -873,7 +885,11 @@
"description": "Create a new managed HSM pool. This is the default option."
}
]
}
},
"x-ms-mutability": [
"create",
"update"
]
},
"statusMessage": {
"readOnly": true,
Expand Down Expand Up @@ -1177,7 +1193,8 @@
"x-ms-enum": {
"name": "NetworkRuleBypassOptions",
"modelAsString": true
}
},
"default": "AzureServices"
},
"defaultAction": {
"type": "string",
Expand All @@ -1189,21 +1206,24 @@
"x-ms-enum": {
"name": "NetworkRuleAction",
"modelAsString": true
}
},
"default": "Allow"
},
"ipRules": {
"type": "array",
"items": {
"$ref": "#/definitions/MHSMIPRule"
},
"description": "The list of IP address rules."
"description": "The list of IP address rules.",
"default": []
},
"virtualNetworkRules": {
"type": "array",
"items": {
"$ref": "#/definitions/MHSMVirtualNetworkRule"
},
"description": "The list of virtual network rules."
"description": "The list of virtual network rules.",
"default": []
}
},
"description": "A set of rules governing the network accessibility of a managed hsm pool."
Expand Down
6 changes: 5 additions & 1 deletion ...nager/Microsoft.KeyVault/preview/2021-06-01-preview/examples/DeletedManagedHsm_Purge.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
"api-version": "2021-06-01-preview"
},
"responses": {
"202": {}
"202": {
"headers": {
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
}
}
}
}
3 changes: 3 additions & 0 deletions ...ger/Microsoft.KeyVault/preview/2021-06-01-preview/examples/ManagedHsm_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
},
"responses": {
"202": {
"headers": {
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
},
"body": {
"properties": {
"tenantId": "00000000-0000-0000-0000-000000000000",
Expand Down
6 changes: 5 additions & 1 deletion ...rce-manager/Microsoft.KeyVault/preview/2021-06-01-preview/examples/ManagedHsm_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@
},
"responses": {
"200": {},
"202": {},
"202": {
"headers": {
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
}
},
"204": {}
}
}
34 changes: 27 additions & 7 deletions ...n/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-06-01-preview/managedHsm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,13 @@
"description": "Request successful. Resource does not exist."
},
"202": {
"description": "Accepted and the operation will complete asynchronously."
"description": "Accepted and the operation will complete asynchronously.",
"headers": {
"Location": {
"description": "The URI to poll for completion status.",
"type": "string"
}
}
},
"200": {
"description": "Delete successful."
Expand Down Expand Up @@ -524,7 +530,13 @@
],
"responses": {
"202": {
"description": "Accepted and the operation will complete asynchronously."
"description": "Accepted and the operation will complete asynchronously.",
"headers": {
"Location": {
"description": "The URI to poll for completion status.",
"type": "string"
}
}
},
"default": {
"description": "The error response describing why the operation failed.",
Expand Down Expand Up @@ -873,7 +885,11 @@
"description": "Create a new managed HSM pool. This is the default option."
}
]
}
},
"x-ms-mutability": [
"create",
"update"
]
},
"statusMessage": {
"readOnly": true,
Expand Down Expand Up @@ -1177,7 +1193,8 @@
"x-ms-enum": {
"name": "NetworkRuleBypassOptions",
"modelAsString": true
}
},
"default": "AzureServices"
},
"defaultAction": {
"type": "string",
Expand All @@ -1189,21 +1206,24 @@
"x-ms-enum": {
"name": "NetworkRuleAction",
"modelAsString": true
}
},
"default": "Allow"
},
"ipRules": {
"type": "array",
"items": {
"$ref": "#/definitions/MHSMIPRule"
},
"description": "The list of IP address rules."
"description": "The list of IP address rules.",
"default": []
},
"virtualNetworkRules": {
"type": "array",
"items": {
"$ref": "#/definitions/MHSMVirtualNetworkRule"
},
"description": "The list of virtual network rules."
"description": "The list of virtual network rules.",
"default": []
}
},
"description": "A set of rules governing the network accessibility of a managed hsm pool."
Expand Down
6 changes: 5 additions & 1 deletion ...nager/Microsoft.KeyVault/preview/2021-11-01-preview/examples/DeletedManagedHsm_Purge.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
"api-version": "2021-11-01-preview"
},
"responses": {
"202": {}
"202": {
"headers": {
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
}
}
}
}
3 changes: 3 additions & 0 deletions ...ger/Microsoft.KeyVault/preview/2021-11-01-preview/examples/ManagedHsm_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
},
"responses": {
"202": {
"headers": {
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
},
"body": {
"properties": {
"tenantId": "00000000-0000-0000-0000-000000000000",
Expand Down
6 changes: 5 additions & 1 deletion ...rce-manager/Microsoft.KeyVault/preview/2021-11-01-preview/examples/ManagedHsm_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@
},
"responses": {
"200": {},
"202": {},
"202": {
"headers": {
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
}
},
"204": {}
}
}
34 changes: 27 additions & 7 deletions ...n/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-11-01-preview/managedHsm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,13 @@
"description": "Request successful. Resource does not exist."
},
"202": {
"description": "Accepted and the operation will complete asynchronously."
"description": "Accepted and the operation will complete asynchronously.",
"headers": {
"Location": {
"description": "The URI to poll for completion status.",
"type": "string"
}
}
},
"200": {
"description": "Delete successful."
Expand Down Expand Up @@ -524,7 +530,13 @@
],
"responses": {
"202": {
"description": "Accepted and the operation will complete asynchronously."
"description": "Accepted and the operation will complete asynchronously.",
"headers": {
"Location": {
"description": "The URI to poll for completion status.",
"type": "string"
}
}
},
"default": {
"description": "The error response describing why the operation failed.",
Expand Down Expand Up @@ -873,7 +885,11 @@
"description": "Create a new managed HSM pool. This is the default option."
}
]
}
},
"x-ms-mutability": [
"create",
"update"
]
},
"statusMessage": {
"readOnly": true,
Expand Down Expand Up @@ -1177,7 +1193,8 @@
"x-ms-enum": {
"name": "NetworkRuleBypassOptions",
"modelAsString": true
}
},
"default": "AzureServices"
},
"defaultAction": {
"type": "string",
Expand All @@ -1189,21 +1206,24 @@
"x-ms-enum": {
"name": "NetworkRuleAction",
"modelAsString": true
}
},
"default": "Allow"
},
"ipRules": {
"type": "array",
"items": {
"$ref": "#/definitions/MHSMIPRule"
},
"description": "The list of IP address rules."
"description": "The list of IP address rules.",
"default": []
},
"virtualNetworkRules": {
"type": "array",
"items": {
"$ref": "#/definitions/MHSMVirtualNetworkRule"
},
"description": "The list of virtual network rules."
"description": "The list of virtual network rules.",
"default": []
}
},
"description": "A set of rules governing the network accessibility of a managed hsm pool."
Expand Down
6 changes: 5 additions & 1 deletion ...source-manager/Microsoft.KeyVault/stable/2021-10-01/examples/DeletedManagedHsm_Purge.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
"api-version": "2021-10-01"
},
"responses": {
"202": {}
"202": {
"headers": {
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
}
}
}
}
3 changes: 3 additions & 0 deletions ...urce-manager/Microsoft.KeyVault/stable/2021-10-01/examples/ManagedHsm_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
},
"responses": {
"202": {
"headers": {
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
},
"body": {
"properties": {
"tenantId": "00000000-0000-0000-0000-000000000000",
Expand Down
6 changes: 5 additions & 1 deletion ...ult/resource-manager/Microsoft.KeyVault/stable/2021-10-01/examples/ManagedHsm_Delete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@
},
"responses": {
"200": {},
"202": {},
"202": {
"headers": {
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
}
},
"204": {}
}
}
Loading