{AzureNetwork} fixes Azure/azure-rest-api-specs#20256 #21288

navba-MSFT · 2022-10-26T08:39:40Z

fixes #20256

This swagger definition is defining property applicationGatewayIpConfigurations,

"applicationGatewayIpConfigurations": {
          "type": "array",
          "items": {
            "$ref": "./applicationGateway.json#/definitions/ApplicationGatewayIPConfiguration"
          },
          "description": "Application gateway IP configurations of virtual network resource."
        }

but actual rest api returned applicationGatewayIPConfigurations, the P is upper case while in swagger it is lower case

{
  "name": "subnet-agw",
  "id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/virtualNetworks/<vnet-name>/subnets/subnet-agw",
  "properties": {
      "applicationGatewayIPConfigurations": [
          {
              "id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/applicationGateways/<agw-name>/gatewayIPConfigurations/appGatewayIpConfig"
          }
      ]
  },
  "type": "Microsoft.Network/virtualNetworks/subnets"
}

please update correspondingly

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

fixes #20256 This swagger definition is defining property applicationGatewayIpConfigurations, ``` "applicationGatewayIpConfigurations": { "type": "array", "items": { "$ref": "./applicationGateway.json#/definitions/ApplicationGatewayIPConfiguration" }, "description": "Application gateway IP configurations of virtual network resource." } ``` but actual rest api returned applicationGatewayIPConfigurations, the P is upper case while in swagger it is lower case ``` { "name": "subnet-agw", "id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/virtualNetworks/<vnet-name>/subnets/subnet-agw", "properties": { "applicationGatewayIPConfigurations": [ { "id": "/subscriptions/<sub-id>/resourceGroups/<rg-name>/providers/Microsoft.Network/applicationGateways/<agw-name>/gatewayIPConfigurations/appGatewayIpConfig" } ] }, "type": "Microsoft.Network/virtualNetworks/subnets" } ```

openapi-workflow-bot · 2022-10-26T08:39:43Z

Hi, @navba-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-10-26T08:39:44Z

Swagger Validation Report

️❌BreakingChange: 18 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.2)]	new version	base version
virtualNetwork.json	2020-08-01(20dd37e)	2020-08-01(main)
virtualNetwork.json	2020-11-01(20dd37e)	2020-11-01(main)
virtualNetwork.json	2021-02-01(20dd37e)	2021-02-01(main)
virtualNetwork.json	2021-03-01(20dd37e)	2021-03-01(main)
virtualNetwork.json	2021-05-01(20dd37e)	2021-05-01(main)
virtualNetwork.json	2021-08-01(20dd37e)	2021-08-01(main)

Rule	Message
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'applicationGatewayIpConfigurations' renamed or removed? New: Microsoft.Network/stable/2020-08-01/virtualNetwork.json#L1399:7 Old: Microsoft.Network/stable/2020-08-01/virtualNetwork.json#L1399:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'applicationGatewayIpConfigurations' renamed or removed? New: Microsoft.Network/stable/2020-11-01/virtualNetwork.json#L1399:7 Old: Microsoft.Network/stable/2020-11-01/virtualNetwork.json#L1399:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'applicationGatewayIpConfigurations' renamed or removed? New: Microsoft.Network/stable/2021-02-01/virtualNetwork.json#L1416:7 Old: Microsoft.Network/stable/2021-02-01/virtualNetwork.json#L1416:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'applicationGatewayIpConfigurations' renamed or removed? New: Microsoft.Network/stable/2021-03-01/virtualNetwork.json#L1416:7 Old: Microsoft.Network/stable/2021-03-01/virtualNetwork.json#L1416:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'applicationGatewayIpConfigurations' renamed or removed? New: Microsoft.Network/stable/2021-05-01/virtualNetwork.json#L1428:7 Old: Microsoft.Network/stable/2021-05-01/virtualNetwork.json#L1428:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'applicationGatewayIpConfigurations' renamed or removed? New: Microsoft.Network/stable/2021-08-01/virtualNetwork.json#L1428:7 Old: Microsoft.Network/stable/2021-08-01/virtualNetwork.json#L1428:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'applicationGatewayIPConfigurations' in response that was not found in the old version. New: Microsoft.Network/stable/2020-08-01/virtualNetwork.json#L1399:7 Old: Microsoft.Network/stable/2020-08-01/virtualNetwork.json#L1399:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'applicationGatewayIPConfigurations' in response that was not found in the old version. New: Microsoft.Network/stable/2020-11-01/virtualNetwork.json#L1399:7 Old: Microsoft.Network/stable/2020-11-01/virtualNetwork.json#L1399:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'applicationGatewayIPConfigurations' in response that was not found in the old version. New: Microsoft.Network/stable/2021-02-01/virtualNetwork.json#L1416:7 Old: Microsoft.Network/stable/2021-02-01/virtualNetwork.json#L1416:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'applicationGatewayIPConfigurations' in response that was not found in the old version. New: Microsoft.Network/stable/2021-03-01/virtualNetwork.json#L1416:7 Old: Microsoft.Network/stable/2021-03-01/virtualNetwork.json#L1416:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'applicationGatewayIPConfigurations' in response that was not found in the old version. New: Microsoft.Network/stable/2021-05-01/virtualNetwork.json#L1428:7 Old: Microsoft.Network/stable/2021-05-01/virtualNetwork.json#L1428:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'applicationGatewayIPConfigurations' in response that was not found in the old version. New: Microsoft.Network/stable/2021-08-01/virtualNetwork.json#L1428:7 Old: Microsoft.Network/stable/2021-08-01/virtualNetwork.json#L1428:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'applicationGatewayIPConfigurations' that was not found in the old version. New: Microsoft.Network/stable/2020-08-01/virtualNetwork.json#L1399:7 Old: Microsoft.Network/stable/2020-08-01/virtualNetwork.json#L1399:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'applicationGatewayIPConfigurations' that was not found in the old version. New: Microsoft.Network/stable/2020-11-01/virtualNetwork.json#L1399:7 Old: Microsoft.Network/stable/2020-11-01/virtualNetwork.json#L1399:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'applicationGatewayIPConfigurations' that was not found in the old version. New: Microsoft.Network/stable/2021-02-01/virtualNetwork.json#L1416:7 Old: Microsoft.Network/stable/2021-02-01/virtualNetwork.json#L1416:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'applicationGatewayIPConfigurations' that was not found in the old version. New: Microsoft.Network/stable/2021-03-01/virtualNetwork.json#L1416:7 Old: Microsoft.Network/stable/2021-03-01/virtualNetwork.json#L1416:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'applicationGatewayIPConfigurations' that was not found in the old version. New: Microsoft.Network/stable/2021-05-01/virtualNetwork.json#L1428:7 Old: Microsoft.Network/stable/2021-05-01/virtualNetwork.json#L1428:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'applicationGatewayIPConfigurations' that was not found in the old version. New: Microsoft.Network/stable/2021-08-01/virtualNetwork.json#L1428:7 Old: Microsoft.Network/stable/2021-08-01/virtualNetwork.json#L1428:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️🔄LintDiff inProgress [Detail]

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️❌~[Staging] SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️❌ModelValidation: 30 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2020-08-01/virtualNetwork.json#L66:22 ExampleUrl: stable/2020-08-01/examples/VirtualNetworkDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2020-08-01/virtualNetwork.json#L418:22 ExampleUrl: stable/2020-08-01/examples/SubnetDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2020-08-01/virtualNetwork.json#L633:22 ExampleUrl: stable/2020-08-01/examples/SubnetPrepareNetworkPolicies.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2020-08-01/virtualNetwork.json#L700:22 ExampleUrl: stable/2020-08-01/examples/SubnetUnprepareNetworkPolicies.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2020-08-01/virtualNetwork.json#L922:22 ExampleUrl: stable/2020-08-01/examples/VirtualNetworkPeeringDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2020-11-01/virtualNetwork.json#L66:22 ExampleUrl: stable/2020-11-01/examples/VirtualNetworkDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2020-11-01/virtualNetwork.json#L418:22 ExampleUrl: stable/2020-11-01/examples/SubnetDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2020-11-01/virtualNetwork.json#L633:22 ExampleUrl: stable/2020-11-01/examples/SubnetPrepareNetworkPolicies.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2020-11-01/virtualNetwork.json#L700:22 ExampleUrl: stable/2020-11-01/examples/SubnetUnprepareNetworkPolicies.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2020-11-01/virtualNetwork.json#L922:22 ExampleUrl: stable/2020-11-01/examples/VirtualNetworkPeeringDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-02-01/virtualNetwork.json#L66:22 ExampleUrl: stable/2021-02-01/examples/VirtualNetworkDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-02-01/virtualNetwork.json#L418:22 ExampleUrl: stable/2021-02-01/examples/SubnetDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-02-01/virtualNetwork.json#L633:22 ExampleUrl: stable/2021-02-01/examples/SubnetPrepareNetworkPolicies.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-02-01/virtualNetwork.json#L700:22 ExampleUrl: stable/2021-02-01/examples/SubnetUnprepareNetworkPolicies.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-02-01/virtualNetwork.json#L922:22 ExampleUrl: stable/2021-02-01/examples/VirtualNetworkPeeringDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-03-01/virtualNetwork.json#L66:22 ExampleUrl: stable/2021-03-01/examples/VirtualNetworkDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-03-01/virtualNetwork.json#L418:22 ExampleUrl: stable/2021-03-01/examples/SubnetDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-03-01/virtualNetwork.json#L633:22 ExampleUrl: stable/2021-03-01/examples/SubnetPrepareNetworkPolicies.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-03-01/virtualNetwork.json#L700:22 ExampleUrl: stable/2021-03-01/examples/SubnetUnprepareNetworkPolicies.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-03-01/virtualNetwork.json#L922:22 ExampleUrl: stable/2021-03-01/examples/VirtualNetworkPeeringDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-05-01/virtualNetwork.json#L66:22 ExampleUrl: stable/2021-05-01/examples/VirtualNetworkDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-05-01/virtualNetwork.json#L421:22 ExampleUrl: stable/2021-05-01/examples/SubnetDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-05-01/virtualNetwork.json#L636:22 ExampleUrl: stable/2021-05-01/examples/SubnetPrepareNetworkPolicies.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-05-01/virtualNetwork.json#L703:22 ExampleUrl: stable/2021-05-01/examples/SubnetUnprepareNetworkPolicies.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-05-01/virtualNetwork.json#L925:22 ExampleUrl: stable/2021-05-01/examples/VirtualNetworkPeeringDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-08-01/virtualNetwork.json#L66:22 ExampleUrl: stable/2021-08-01/examples/VirtualNetworkDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-08-01/virtualNetwork.json#L421:22 ExampleUrl: stable/2021-08-01/examples/SubnetDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-08-01/virtualNetwork.json#L636:22 ExampleUrl: stable/2021-08-01/examples/SubnetPrepareNetworkPolicies.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-08-01/virtualNetwork.json#L703:22 ExampleUrl: stable/2021-08-01/examples/SubnetUnprepareNetworkPolicies.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2021-08-01/virtualNetwork.json#L925:22 ExampleUrl: stable/2021-08-01/examples/VirtualNetworkPeeringDelete.json

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️❌SpellCheck: 12 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` HowToFix	Unknown word (Unprepares), please fix the error or add words to ./custom-words.txt path: Microsoft.Network/stable/2020-08-01/virtualNetwork.json#L661:25
`❌` HowToFix	Unknown word (Unpreparing), please fix the error or add words to ./custom-words.txt path: Microsoft.Network/stable/2020-08-01/virtualNetwork.json#L702:29
`❌` HowToFix	Unknown word (Unprepares), please fix the error or add words to ./custom-words.txt path: Microsoft.Network/stable/2020-11-01/virtualNetwork.json#L661:25
`❌` HowToFix	Unknown word (Unpreparing), please fix the error or add words to ./custom-words.txt path: Microsoft.Network/stable/2020-11-01/virtualNetwork.json#L702:29
`❌` HowToFix	Unknown word (Unprepares), please fix the error or add words to ./custom-words.txt path: Microsoft.Network/stable/2021-02-01/virtualNetwork.json#L661:25
`❌` HowToFix	Unknown word (Unpreparing), please fix the error or add words to ./custom-words.txt path: Microsoft.Network/stable/2021-02-01/virtualNetwork.json#L702:29
`❌` HowToFix	Unknown word (Unprepares), please fix the error or add words to ./custom-words.txt path: Microsoft.Network/stable/2021-03-01/virtualNetwork.json#L661:25
`❌` HowToFix	Unknown word (Unpreparing), please fix the error or add words to ./custom-words.txt path: Microsoft.Network/stable/2021-03-01/virtualNetwork.json#L702:29
`❌` HowToFix	Unknown word (Unprepares), please fix the error or add words to ./custom-words.txt path: Microsoft.Network/stable/2021-05-01/virtualNetwork.json#L664:25
`❌` HowToFix	Unknown word (Unpreparing), please fix the error or add words to ./custom-words.txt path: Microsoft.Network/stable/2021-05-01/virtualNetwork.json#L705:29
`❌` HowToFix	Unknown word (Unprepares), please fix the error or add words to ./custom-words.txt path: Microsoft.Network/stable/2021-08-01/virtualNetwork.json#L664:25
`❌` HowToFix	Unknown word (Unpreparing), please fix the error or add words to ./custom-words.txt path: Microsoft.Network/stable/2021-08-01/virtualNetwork.json#L705:29

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-10-26T08:39:45Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-js - @azure/arm-network - 31.0.0

+	Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter skipToken
+	Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter top
+	Interface AdminRulesListNextOptionalParams no longer has parameter skipToken
+	Interface AdminRulesListNextOptionalParams no longer has parameter top
+	Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter skipToken
+	Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter top
+	Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken
+	Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter top
+	Interface NetworkGroupsListNextOptionalParams no longer has parameter skipToken
+	Interface NetworkGroupsListNextOptionalParams no longer has parameter top
+	Interface NetworkInterfacesListVirtualMachineScaleSetIpConfigurationsNextOptionalParams no longer has parameter expand
+	Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter skipToken
+	Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter top
+	Interface NetworkManagersListNextOptionalParams no longer has parameter skipToken
+	Interface NetworkManagersListNextOptionalParams no longer has parameter top
+	Interface ScopeConnectionsListNextOptionalParams no longer has parameter skipToken
+	Interface ScopeConnectionsListNextOptionalParams no longer has parameter top
+	Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter skipToken
+	Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter top
+	Interface ServiceTagInformationListNextOptionalParams no longer has parameter noAddressPrefixes
+	Interface ServiceTagInformationListNextOptionalParams no longer has parameter tagName
+	Interface StaticMembersListNextOptionalParams no longer has parameter skipToken
+	Interface StaticMembersListNextOptionalParams no longer has parameter top
+	Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken
+	Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter top
+	Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter skipToken
+	Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter top

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 6b3a64693f4b5e62e5411fd3a2ccdd638af37ebb. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Network [View full logs] [Preview SDK Changes]
- Microsoft.Azure.Management.Network.25.0.0.nupkg
- Microsoft.Azure.Management.Network.25.0.0.symbols.nupkg

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 6b3a64693f4b5e62e5411fd3a2ccdd638af37ebb. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:830
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 830 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cannot force update branch 'sdkAuto/21288/Azure.ResourceManager.Network' as it is the current HEAD of the repository.
Error: cannot force update branch 'sdkAuto/21288/Azure.ResourceManager.Network' as it is the current HEAD of the repository.

️✔️Azure.ResourceManager.Network [View full logs] [Preview SDK Changes]
- Azure.ResourceManager.Network.1.2.0-alpha.20230109.1.nupkg
```
info	[Changelog]
```

❌Azure.ResourceManager.Network [View full logs] Breaking Change Detected

error	Fatal error: cannot force update branch 'sdkAuto/21288/Azure.ResourceManager.Network' as it is the current HEAD of the repository.
error	The following packages are still pending:
error		Azure.ResourceManager.Network
error		Azure.ResourceManager.Network

️❌ azure-sdk-for-python-track2 failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 6b3a64693f4b5e62e5411fd3a2ccdd638af37ebb. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.2.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.2.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.2.0` to update!
cmderr	[automation_generate.sh] npm notice
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️track2_azure-mgmt-network [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		track2_azure-mgmt-network

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 6b3a64693f4b5e62e5411fd3a2ccdd638af37ebb. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-network-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 6b3a64693f4b5e62e5411fd3a2ccdd638af37ebb. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/network/armnetwork [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `ApplicationGatewaySKUNameStandardBasic` added to type alias `ApplicationGatewaySKUName`
info	[Changelog] - New value `ApplicationGatewayTierStandardBasic` added to type alias `ApplicationGatewayTier`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 2 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 6b3a64693f4b5e62e5411fd3a2ccdd638af37ebb. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-network [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-network-31.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Enum KnownApplicationGatewaySkuName has a new value StandardBasic
info	[Changelog]   - Enum KnownApplicationGatewayTier has a new value StandardBasic
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface AdminRuleCollectionsListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface AdminRulesListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface AdminRulesListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface ConnectivityConfigurationsListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface ManagementGroupNetworkManagerConnectionsListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface NetworkGroupsListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface NetworkGroupsListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface NetworkInterfacesListVirtualMachineScaleSetIpConfigurationsNextOptionalParams no longer has parameter expand
info	[Changelog]   - Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface NetworkManagersListBySubscriptionNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface NetworkManagersListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface NetworkManagersListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface ScopeConnectionsListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface ScopeConnectionsListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface SecurityAdminConfigurationsListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface ServiceTagInformationListNextOptionalParams no longer has parameter noAddressPrefixes
info	[Changelog]   - Interface ServiceTagInformationListNextOptionalParams no longer has parameter tagName
info	[Changelog]   - Interface StaticMembersListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface StaticMembersListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface SubscriptionNetworkManagerConnectionsListNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams no longer has parameter top

️🔄 azure-resource-manager-schemas inProgress [Detail]

️❌ azure-powershell failed [Detail]

❌Failed [Logs] Generate from 6b3a64693f4b5e62e5411fd3a2ccdd638af37ebb. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.network [View full logs] [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-10-26T08:39:46Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/network/armnetwork	https://apiview.dev/Assemblies/Review/835e9a4b439b4afdb7a2db31d6c4b567
Java	azure-resourcemanager-network-generated	https://apiview.dev/Assemblies/Review/3b6999fb666f4f39bd5d468a41c64e94
JavaScript	@azure/arm-network	https://apiview.dev/Assemblies/Review/c55d96b7787a4efba93ba9509fb5a037
.Net	Azure.ResourceManager.Network	https://apiview.dev/Assemblies/Review/2f2216202f6541b6abfea420dad2fc3f

openapi-workflow-bot · 2022-10-26T08:56:38Z

Hi @navba-MSFT, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

openapi-workflow-bot · 2022-10-26T08:56:38Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2022-10-26T08:56:38Z

Hi @navba-MSFT, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

lirenhe · 2022-10-28T04:01:04Z

@navba-MSFT, could you also fix the modeling validation errors?

For breaking change, please follow our process:
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

ghost · 2022-11-13T16:02:51Z

Hi, @navba-MSFT. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

navba-MSFT · 2022-11-17T10:18:32Z

Filing a breaking change request

ghost · 2022-12-04T16:03:05Z

Hi, @navba-MSFT. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

navba-MSFT · 2022-12-09T11:34:33Z

Discussing with the Service team to review this

ghost · 2022-12-25T16:03:13Z

Hi, @navba-MSFT. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2023-01-09T05:02:52Z

Hi, @navba-MSFT. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

ghost · 2023-02-05T16:03:10Z

Hi, @navba-MSFT. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

navba-MSFT · 2023-02-13T06:52:49Z

Waiting for the review from Service team

navba-MSFT · 2023-03-02T09:05:55Z

Creating a new PR to fix it in latest version 2022-09-01 . So closing this PR as a duplicate of #22875

navba-MSFT requested a review from MikhailTryakhov as a code owner October 26, 2022 08:39

openapi-assignment-bot bot assigned lirenhe Oct 26, 2022

ghost added the Network label Oct 26, 2022

navba-MSFT added 5 commits October 26, 2022 14:11

Update virtualNetwork.json

93b3d09

Update virtualNetwork.json

4a75af7

Update virtualNetwork.json

c058915

Update virtualNetwork.json

d18c8b9

Update virtualNetwork.json

20dd37e

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure NewApiVersionRequired resource-manager labels Oct 26, 2022

lirenhe added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Oct 28, 2022

ghost added the no-recent-activity label Nov 13, 2022

ghost removed the no-recent-activity label Nov 17, 2022

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 17, 2022

ghost added the no-recent-activity label Dec 4, 2022

ghost removed the no-recent-activity label Dec 9, 2022

ghost added the no-recent-activity label Dec 25, 2022

ghost closed this Jan 9, 2023

navba-MSFT reopened this Jan 9, 2023

ghost removed the no-recent-activity label Jan 9, 2023

ghost added no-recent-activity and removed no-recent-activity labels Feb 5, 2023

navba-MSFT closed this Mar 2, 2023

navba-MSFT deleted the navba-MSFT-patch-2 branch March 2, 2023 09:06

{AzureNetwork} fixes Azure/azure-rest-api-specs#20256 #21288

{AzureNetwork} fixes Azure/azure-rest-api-specs#20256 #21288

Uh oh!

Conversation

navba-MSFT commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Oct 26, 2022

Uh oh!

openapi-pipeline-app bot commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

openapi-workflow-bot bot commented Oct 26, 2022

Uh oh!

openapi-workflow-bot bot commented Oct 26, 2022

Uh oh!

openapi-workflow-bot bot commented Oct 26, 2022

Uh oh!

lirenhe commented Oct 28, 2022

Uh oh!

ghost commented Nov 13, 2022

Uh oh!

navba-MSFT commented Nov 17, 2022

Uh oh!

ghost commented Dec 4, 2022

Uh oh!

navba-MSFT commented Dec 9, 2022

Uh oh!

ghost commented Dec 25, 2022

Uh oh!

ghost commented Jan 9, 2023

Uh oh!

ghost commented Feb 5, 2023

Uh oh!

navba-MSFT commented Feb 13, 2023

Uh oh!

navba-MSFT commented Mar 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

navba-MSFT commented Oct 26, 2022 •

edited

Loading

openapi-pipeline-app bot commented Oct 26, 2022 •

edited

Loading

openapi-pipeline-app bot commented Oct 26, 2022 •

edited

Loading

openapi-pipeline-app bot commented Oct 26, 2022 •

edited

Loading