-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Hub Generated] Review request for Microsoft.Network to add version preview/2021-02-01-preview #21040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lirenhe
merged 18 commits into
Azure:main
from
vineetmimrot:dev-network-Microsoft.Network-2021-02-01-preview
Oct 17, 2022
Merged
[Hub Generated] Review request for Microsoft.Network to add version preview/2021-02-01-preview #21040
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b191bd8
NSP Link API changes
vineetmimrot 9d3ea04
minor fix
vineetmimrot bfbae27
fix errors
vineetmimrot 857cd08
fix error
vineetmimrot 46c5379
fix error
vineetmimrot c681d5b
fix lint error
vineetmimrot 853ac12
skip location from proxy resource
vineetmimrot 105dd1f
fix sdk error
vineetmimrot 04b7f77
fix linter check
vineetmimrot c5e35fa
immutability flag changes
vineetmimrot 824cb7d
removed v2 properties.
vineetmimrot 0f3fbb0
minor fix
vineetmimrot 4dcdab0
removed default value as it is not supported by swagger
vineetmimrot 912bf70
make outbound profile read only
vineetmimrot 9d6705e
minor change
vineetmimrot 576d99c
add x-ms-long-running-operation-options
vineetmimrot 5f9a78b
Fix review comments
vineetmimrot 7bd5234
minor fix
vineetmimrot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
19 changes: 19 additions & 0 deletions
19
...resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkDelete.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "title": "Delete NSP link", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "linkName": "link1" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "202": { | ||
| "headers": { | ||
| "location": "https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/links/{linkName}/operationResults/{operationId}?api-version={api-version}" | ||
| } | ||
| }, | ||
| "204": {} | ||
| } | ||
| } |
38 changes: 38 additions & 0 deletions
38
...rk/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkGet.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "title": "Get NSP Link", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "linkName": "link1" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "name": "link1", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links/link1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/links", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", | ||
| "remotePerimeterGuid": "guid", | ||
| "localInboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "localOutboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "remoteInboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "remoteOutboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "description": "Auto Approved", | ||
| "status": "Approved" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
42 changes: 42 additions & 0 deletions
42
...k/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkList.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "title": "List NSP Links", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "name": "link1", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links/link1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/links", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", | ||
| "remotePerimeterGuid": "guid", | ||
| "localInboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "localOutboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "remoteInboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "remoteOutboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "description": "Auto Approved", | ||
| "status": "Approved" | ||
| } | ||
| } | ||
| ], | ||
| "nextLink": "{baseurl}/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links?api-version=2021-02-01-preview&$skipToken=10" | ||
| } | ||
| } | ||
| } | ||
| } |
69 changes: 69 additions & 0 deletions
69
...rk/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkPut.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| { | ||
| "title": "Create/Update NSP link", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "linkName": "link1", | ||
| "parameters": { | ||
| "properties": { | ||
| "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "name": "link1", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links/link1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/links", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", | ||
| "remotePerimeterGuid": "guid", | ||
| "localInboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "localOutboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "remoteInboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "remoteOutboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "description": "Auto Approved", | ||
| "status": "Approved" | ||
| } | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "name": "link1", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/links/link1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/links", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "autoApprovedRemotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2", | ||
| "remotePerimeterGuid": "guid", | ||
| "localInboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "localOutboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "remoteInboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "remoteOutboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "description": "Auto Approved", | ||
| "status": "Approved" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
18 changes: 18 additions & 0 deletions
18
...ource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReconcile.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "title": "Reconcile NSP link", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "linkName": "link1", | ||
| "parameters": { | ||
| "properties": {} | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": {} | ||
| } | ||
| } | ||
| } |
19 changes: 19 additions & 0 deletions
19
...manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceDelete.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "title": "Delete NSP linkReference", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp2", | ||
| "linkReferenceName": "link1-guid" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "202": { | ||
| "headers": { | ||
| "location": "https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/linkreferences/{linkReferenceName}/operationResults/{operationId}?api-version={api-version}" | ||
| } | ||
| }, | ||
| "204": {} | ||
| } | ||
| } |
38 changes: 38 additions & 0 deletions
38
...ce-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceGet.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "title": "Get NSP LinkReference", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp2", | ||
| "linkReferenceName": "link1-guid" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "name": "link1-guid", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkreferences/link1-guid", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/linkreferences", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", | ||
| "remotePerimeterGuid": "guid", | ||
| "localInboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "localOutboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "remoteInboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "remoteOutboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "description": "Auto Approved", | ||
| "status": "Approved" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
42 changes: 42 additions & 0 deletions
42
...e-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceList.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "title": "List NSP LinkReferences", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp2" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "name": "link1-guid", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkreferences/link1-guid", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/linkreferences", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "remotePerimeterId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", | ||
| "remotePerimeterGuid": "guid", | ||
| "localInboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "localOutboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "remoteInboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "remoteOutboundProfiles": [ | ||
| "*" | ||
| ], | ||
| "description": "Auto Approved", | ||
| "status": "Approved" | ||
| } | ||
| } | ||
| ], | ||
| "nextLink": "{baseurl}/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp2/linkreferences?api-version=2021-02-01-preview&$skipToken=10" | ||
| } | ||
| } | ||
| } | ||
| } |
18 changes: 18 additions & 0 deletions
18
...ager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceReconcile.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "title": "Reconcile NSP linkreference", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "linkReferenceName": "link1-guid", | ||
| "parameters": { | ||
| "properties": {} | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": {} | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.