From 1d17afedb288334f12a7c3b53ca232715bba1a62 Mon Sep 17 00:00:00 2001 From: Samiran Saha Date: Thu, 23 Jun 2022 11:55:11 +0530 Subject: [PATCH 1/3] Swagger Correctness fix(s360): Add aof-back-enabled and authnotrequired settings --- cSpell.json | 1 + .../Microsoft.Cache/stable/2020-12-01/redis.json | 8 ++++++++ .../Microsoft.Cache/stable/2021-06-01/redis.json | 8 ++++++++ 3 files changed, 17 insertions(+) diff --git a/cSpell.json b/cSpell.json index 29052eda6b7e..1f81f5035225 100644 --- a/cSpell.json +++ b/cSpell.json @@ -2,6 +2,7 @@ "version": "0.1", "language": "en", "words": [ + "authnotrequired", "Creds", "partiallycompleted", "subchannel", diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json index fc9dceebed1f..16052be1a887 100644 --- a/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json +++ b/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json @@ -1842,6 +1842,10 @@ "type": "string", "description": "The storage account connection string for storing rdb file" }, + "aof-backup-enabled": { + "type": "string", + "description": "Specifies whether the aof backup is enabled" + }, "aof-storage-connection-string-0": { "type": "string", "description": "First storage account connection string" @@ -1875,6 +1879,10 @@ "type": "string", "description": "Zonal Configuration", "readOnly": true + }, + "authnotrequired": { + "type": "string", + "description": "Specifies whether the authentication is disabled." } }, "additionalProperties": { diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json index 7b85c0d2db31..da94f326c9cc 100644 --- a/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json +++ b/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json @@ -1889,6 +1889,10 @@ "type": "string", "description": "The storage account connection string for storing rdb file" }, + "aof-backup-enabled": { + "type": "string", + "description": "Specifies whether the aof backup is enabled" + }, "aof-storage-connection-string-0": { "type": "string", "description": "First storage account connection string" @@ -1932,6 +1936,10 @@ "type": "string", "description": "Zonal Configuration", "readOnly": true + }, + "authnotrequired": { + "type": "string", + "description": "Specifies whether the authentication is disabled." } }, "additionalProperties": {}, From 13083e25dd51253210982ebf77ccbc4b83c7dd1d Mon Sep 17 00:00:00 2001 From: Samiran Saha Date: Fri, 24 Jun 2022 09:47:47 +0530 Subject: [PATCH 2/3] Fix model validation errors --- .../examples/RedisOperations_List.json | 22 +++++++++++++++++++ .../stable/2020-12-01/redis.json | 5 +++++ .../examples/RedisOperations_List.json | 22 +++++++++++++++++++ .../stable/2021-06-01/redis.json | 5 +++++ 4 files changed, 54 insertions(+) create mode 100644 specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/examples/RedisOperations_List.json create mode 100644 specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/examples/RedisOperations_List.json diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/examples/RedisOperations_List.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/examples/RedisOperations_List.json new file mode 100644 index 000000000000..4ea510400d82 --- /dev/null +++ b/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/examples/RedisOperations_List.json @@ -0,0 +1,22 @@ +{ + "parameters": { + "api-version": "2020-12-01" + }, + "responses": { + "200": { + "body": { + "value": [ + { + "name": "operationName", + "display": { + "provider": "providerName", + "resource": "resourceName", + "operation": "operationName", + "description": "operation description" + } + } + ] + } + } + } +} diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json index 16052be1a887..8d5792a45fa4 100644 --- a/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json +++ b/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json @@ -41,6 +41,11 @@ ], "description": "Lists all of the available REST API operations of the Microsoft.Cache provider.", "operationId": "Operations_List", + "x-ms-examples": { + "RedisOperationsList": { + "$ref": "./examples/RedisOperations_List.json" + } + }, "parameters": [ { "$ref": "#/parameters/ApiVersionParameter" diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/examples/RedisOperations_List.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/examples/RedisOperations_List.json new file mode 100644 index 000000000000..cdb08480dd2d --- /dev/null +++ b/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/examples/RedisOperations_List.json @@ -0,0 +1,22 @@ +{ + "parameters": { + "api-version": "2021-06-01" + }, + "responses": { + "200": { + "body": { + "value": [ + { + "name": "operationName", + "display": { + "provider": "providerName", + "resource": "resourceName", + "operation": "operationName", + "description": "operation description" + } + } + ] + } + } + } +} diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json index da94f326c9cc..86abab341cfc 100644 --- a/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json +++ b/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json @@ -41,6 +41,11 @@ ], "description": "Lists all of the available REST API operations of the Microsoft.Cache provider.", "operationId": "Operations_List", + "x-ms-examples": { + "RedisOperationsList": { + "$ref": "./examples/RedisOperations_List.json" + } + }, "parameters": [ { "$ref": "#/parameters/ApiVersionParameter" From fd4da8fb679b8461572edbbb76519d7cb3353a54 Mon Sep 17 00:00:00 2001 From: Samiran Saha Date: Mon, 27 Jun 2022 13:12:05 +0530 Subject: [PATCH 3/3] Update description for authnotrequired. --- .../Microsoft.Cache/stable/2020-12-01/redis.json | 2 +- .../Microsoft.Cache/stable/2021-06-01/redis.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json index 8d5792a45fa4..f1550168dbb9 100644 --- a/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json +++ b/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json @@ -1887,7 +1887,7 @@ }, "authnotrequired": { "type": "string", - "description": "Specifies whether the authentication is disabled." + "description": "Specifies whether the authentication is disabled. Setting this property is highly discouraged from security point of view." } }, "additionalProperties": { diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json index 86abab341cfc..ff5f6ee2b685 100644 --- a/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json +++ b/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json @@ -1944,7 +1944,7 @@ }, "authnotrequired": { "type": "string", - "description": "Specifies whether the authentication is disabled." + "description": "Specifies whether the authentication is disabled. Setting this property is highly discouraged from security point of view." } }, "additionalProperties": {},