add nullable for most of the optional parameters #19017

ChenTanyi · 2022-05-11T05:34:54Z

Sync from https://github.com/Azure/azure-rest-api-specs-pr/pull/7154

openapi-workflow-bot · 2022-05-11T05:34:57Z

Hi @ChenTanyi, this service has enabled Shift Left. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth.

You can refer to Shift Left Solution Introduction for details.

Please contact service focal @najian contacts or Shift Left Support Channel if need further help.

openapi-pipeline-app · 2022-05-11T05:34:57Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.9.5)
- current:stable/2022-05-01/servicelinker.json compared with base:stable/2022-05-01/servicelinker.json

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- servicelinker/resource-manager/readme.md tag:package-2022-05-01
Linted configuring files (Based on target branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- servicelinker/resource-manager/readme.md tag:package-2022-05-01

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'validatelinker' in:'Linker_Validate'. Consider updating the operationId Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L274
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: connectAsKubernetesCsiDriver Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L475
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isConnectionAvailable Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L909
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetConfiguration Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L361

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

servicelinker/resource-manager/readme.md#package-2022-05-01

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-05-11T05:34:57Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go-track2 - armservicelinker - 0.5.0

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-servicelinker - 1.0.0
❌azure-sdk-for-js - @azure/arm-servicelinker - 2.0.0

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 680ecbfdfd63702f400eb646da9374d46c118b47. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-servicelinker [View full logs] [Preview SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added model AzureResourceType
info	[Changelog]   - Added model TargetServiceType
info	[Changelog]   - Added model ValidateOperationResult

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 680ecbfdfd63702f400eb646da9374d46c118b47. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

️✔️azure-resourcemanager-servicelinker [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 680ecbfdfd63702f400eb646da9374d46c118b47. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armservicelinker [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `AzureResourcePropertiesBase.Type` has been changed from `*Type` to `*AzureResourceType`
info	[Changelog] - Type of `AzureResource.Type` has been changed from `*Type` to `*TargetServiceType`
info	[Changelog] - Type of `AzureKeyVaultProperties.Type` has been changed from `*Type` to `*AzureResourceType`
info	[Changelog] - Type of `ConfluentBootstrapServer.Type` has been changed from `*Type` to `*TargetServiceType`
info	[Changelog] - Type of `ConfluentSchemaRegistry.Type` has been changed from `*Type` to `*TargetServiceType`
info	[Changelog] - Type of `TargetServiceBase.Type` has been changed from `*Type` to `*TargetServiceType`
info	[Changelog] - Const `TypeKeyVault` has been removed
info	[Changelog] - Const `TypeConfluentBootstrapServer` has been removed
info	[Changelog] - Const `ValidationResultStatusFailed` has been removed
info	[Changelog] - Const `TypeConfluentSchemaRegistry` has been removed
info	[Changelog] - Const `TypeAzureResource` has been removed
info	[Changelog] - Function `PossibleTypeValues` has been removed
info	[Changelog] - Field `ValidateResult` of struct `LinkerClientValidateResponse` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `AzureResourceTypeKeyVault`
info	[Changelog] - New const `TargetServiceTypeConfluentBootstrapServer`
info	[Changelog] - New const `TargetServiceTypeAzureResource`
info	[Changelog] - New const `ValidationResultStatusFailure`
info	[Changelog] - New const `TargetServiceTypeConfluentSchemaRegistry`
info	[Changelog] - New function `PossibleAzureResourceTypeValues() []AzureResourceType`
info	[Changelog] - New function `PossibleTargetServiceTypeValues() []TargetServiceType`
info	[Changelog] - New struct `ValidateOperationResult`
info	[Changelog] - New anonymous field `ValidateOperationResult` in struct `LinkerClientValidateResponse`
info	[Changelog]
info	[Changelog] Total 13 breaking change(s), 10 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs] Generate from 680ecbfdfd63702f400eb646da9374d46c118b47. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  WARN deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh]  @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-servicelinker [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-servicelinker-2.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface ValidateOperationResult
info	[Changelog]   - Enum KnownValidationResultStatus has a new value Failure
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Enum KnownValidationResultStatus no longer has value Failed

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 680ecbfdfd63702f400eb646da9374d46c118b47. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️servicelinker [View full logs]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 680ecbfdfd63702f400eb646da9374d46c118b47. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.ServiceLinker [View full logs] [Preview SDK Changes]
- Az.ServiceLinker.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-05-11T05:34:58Z

Hi, @ChenTanyi Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

raych1 · 2022-05-11T06:12:24Z

I can publish the PR successfully, is the error caused by your credentials?
#19018

add nullable for most of the optional parameters

86de845

ChenTanyi requested a review from najian May 11, 2022 05:34

openapi-assignment-bot bot assigned raych1 May 11, 2022

openapi-workflow-bot bot added the ShiftLeftViolation label May 11, 2022

ChenTanyi requested a review from raych1 May 11, 2022 05:36

azure-sdk mentioned this pull request May 11, 2022

[AutoPR armservicelinker] add nullable for most of the optional parameters azure-sdk/azure-sdk-for-go#897

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go-V2 label May 11, 2022

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label May 11, 2022

raych1 closed this May 11, 2022

ChenTanyi deleted the update-servicelinker branch May 11, 2022 06:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add nullable for most of the optional parameters #19017

add nullable for most of the optional parameters #19017

Uh oh!

ChenTanyi commented May 11, 2022

Uh oh!

openapi-workflow-bot bot commented May 11, 2022

Uh oh!

openapi-pipeline-app bot commented May 11, 2022 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented May 11, 2022 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-workflow-bot bot commented May 11, 2022

Uh oh!

raych1 commented May 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

add nullable for most of the optional parameters #19017

add nullable for most of the optional parameters #19017

Uh oh!

Conversation

ChenTanyi commented May 11, 2022

Uh oh!

openapi-workflow-bot bot commented May 11, 2022

Uh oh!

openapi-pipeline-app bot commented May 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented May 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-workflow-bot bot commented May 11, 2022

Uh oh!

raych1 commented May 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

openapi-pipeline-app bot commented May 11, 2022 •

edited

Loading

openapi-pipeline-app bot commented May 11, 2022 •

edited

Loading