-
Notifications
You must be signed in to change notification settings - Fork 5.6k
NSP API changes #18531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
NSP API changes #18531
Changes from 9 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
d3e8231
Add proxy, check members APIs
05bcf88
update
9d82593
check members API fix
94cecaa
Add query by perimeter guid
a3c6dc5
Add NSP reconcile API
fa8330d
code reformat
b4cfbe7
code reformat
ebc9c62
lint fix
cdf85a1
Merge branch 'main' of github.com:Azure/azure-rest-api-specs into swa…
7683182
change description, tags
48ecb3d
NSP schema update, remove displayName, description
03ebf21
prettier fix
73893d8
tags readonly
2ce52f0
remove tags
5bb5d71
Merge branch 'main' of github.com:Azure/azure-rest-api-specs into swa…
c693390
pull from main, conflict resolve
8e6569f
association proxy delete as per merged PR examples
8f2a6d5
review changse, remove 201 from POST and other changes
7e49c8c
Merge branch 'main' of github.com:Azure/azure-rest-api-specs into swa…
a5f6e1d
update
89923e4
Logging Category remove
b2fa4fa
Merge branch 'main' of github.com:Azure/azure-rest-api-specs into swa…
2c1aaea
NSP post 201 fix
054894f
isMember changed to enum from string
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
41 changes: 41 additions & 0 deletions
41
...ce-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NSPCheckMembersPost.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| { | ||
| "title": "Post Network Security Perimeter Check Members", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "networkSecurityPerimeterProfile": "NP1", | ||
| "parameters": { | ||
| "memberDestinations": [ | ||
| { | ||
| "privateLinkResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Sql/servers/resourceName1" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "memberDestinations": [ | ||
| { | ||
| "privateLinkResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Sql/servers/resourceName1", | ||
| "isMember": "no", | ||
| "profile": "" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "memberDestinations": [ | ||
| { | ||
| "privateLinkResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Sql/servers/resourceName1", | ||
| "isMember": "no", | ||
| "profile": "" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
...manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleReconcile.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "title": "Reconcile NSP access rule", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "profileName": "profile1", | ||
| "parameters": { | ||
| "properties": {} | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": {} | ||
| }, | ||
| "201": { | ||
kaushal087 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "body": {} | ||
| } | ||
| } | ||
| } | ||
36 changes: 36 additions & 0 deletions
36
...work/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/QueryNSP.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| { | ||
| "title": "Post Network Security Perimeter Query by GUID", | ||
| "parameters": { | ||
| "location": "centraluseuap", | ||
| "api-version": "2021-02-01-preview", | ||
| "parameters": { | ||
| "networkSecurityPerimeters": [ | ||
| { | ||
| "perimeterGuid": "test" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "networkSecurityPerimeters": [ | ||
| { | ||
| "perimeterGuid": "test", | ||
| "id": "xyz" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "201": { | ||
kaushal087 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "body": { | ||
| "networkSecurityPerimeters": [ | ||
| { | ||
| "perimeterGuid": "test", | ||
| "id": "abcd" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.