From d3e8231c5963b5adb66d12b0b1aa1c9d095c9a8c Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Fri, 1 Apr 2022 00:24:38 +0530 Subject: [PATCH 01/19] Add proxy, check members APIs --- ...workSecurityPerimeterCheckMembersPost.json | 39 +++ .../examples/NspAssociationsProxyDelete.json | 0 .../examples/NspAssociationsProxyGet.json | 0 .../examples/NspAssociationsProxyPut.json | 0 .../networkSecurityPerimeter.json | 259 +++++++++++++++++- 5 files changed, 292 insertions(+), 6 deletions(-) create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterCheckMembersPost.json create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyDelete.json create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyGet.json create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyPut.json diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterCheckMembersPost.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterCheckMembersPost.json new file mode 100644 index 000000000000..516174620022 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterCheckMembersPost.json @@ -0,0 +1,39 @@ +{ + "title": "Post Network Security Perimeter Check Members", + "parameters": { + "api-version": "2021-02-01-preview", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "networkSecurityPerimeterName": "nsp1", + "networkSecurityPerimeterProfile": "NP1", + "parameters": { + "MemberDestinations": [ + {"privatelinkResourceId":"/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Sql/servers/resourceName1"} + ] + } + }, + "responses": { + "200": { + "body": { + "memberDestinations": [ + { + "privateLinkResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Sql/servers/resourceName1", + "isMember": "no", + "profile": "" + } + ] + } + }, + "201": { + "body": { + "memberDestinations": [ + { + "privateLinkResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Sql/servers/resourceName1", + "isMember": "no", + "profile": "" + } + ] + } + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyDelete.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyDelete.json new file mode 100644 index 000000000000..e69de29bb2d1 diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyGet.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyGet.json new file mode 100644 index 000000000000..e69de29bb2d1 diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyPut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyPut.json new file mode 100644 index 000000000000..e69de29bb2d1 diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index be3bd67e7abd..6830e7e19196 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -685,13 +685,127 @@ } } }, - "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/resourceAssociations": { + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/resourceAssociationProxies/{associationName}": { + "parameters": [ + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/NetworkSecurityPerimeterNameParameter" + }, + { + "$ref": "#/parameters/AssociationNameParameter" + } + ], "get": { "tags": [ "NspAssociations" ], - "operationId": "NspAssociations_List", - "description": "Lists the NSP resource associations in the specified perimeter.", + "operationId": "NspAssociations_Get", + "description": "Gets the specified NSP association by name.", + "responses": { + "200": { + "description": "OK - Returns information about the NSP resource association.", + "schema": { + "$ref": "#/definitions/NspAssociation" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspAssociationGet": { + "$ref": "./examples/NspAssociationGet.json" + } + } + }, + "put": { + "tags": [ + "NspAssociations" + ], + "operationId": "NspAssociations_CreateOrUpdate", + "description": "Creates or updates a NSP resource association.", + "parameters": [ + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "#/definitions/NspAssociation" + }, + "description": "Parameters that hold the NspAssociation resource to be created/updated." + } + ], + "responses": { + "200": { + "description": "Updated - Existing resource association is updated. Returns the resource.", + "schema": { + "$ref": "#/definitions/NspAssociation" + } + }, + "201": { + "description": "Create - Returns the NspAssociation resource created.", + "schema": { + "$ref": "#/definitions/NspAssociation" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspAssociationPut": { + "$ref": "./examples/NspAssociationPut.json" + } + } + }, + "delete": { + "tags": [ + "NspAssociations" + ], + "operationId": "NspAssociations_Delete", + "description": "Deletes an NSP association resource.", + "responses": { + "200": { + "description": "Delete Succeed." + }, + "202": { + "description": "Delete in progress." + }, + "204": { + "description": "Request successful. The resource does not exist." + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspAssociationDelete": { + "$ref": "./examples/NspAssociationDelete.json" + } + } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/resourceAssociations": { + "get": { + "tags": [ + "NspAssociationsProxy" + ], + "operationId": "NspAssociationsProxy_List", + "description": "Lists the NSP resource associations proxy.", "x-ms-pageable": { "nextLinkName": "nextLink" }, @@ -717,9 +831,9 @@ ], "responses": { "200": { - "description": "OK - Returns the list of NSP resource associations.", + "description": "OK - Returns the list of NSP resource associations proxy.", "schema": { - "$ref": "#/definitions/NspAssociationsListResult" + "$ref": "#/definitions/NspAssociationsProxyListResult" } }, "default": { @@ -731,7 +845,58 @@ }, "x-ms-examples": { "NspAssociationList": { - "$ref": "./examples/NspAssociationList.json" + "$ref": "./examples/NspAssociationProxyList.json" + } + } + } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/resourceAssociationsProxy": { + "get": { + "tags": [ + "NspAssociationsProxy" + ], + "operationId": "NspAssociationsProxy_List", + "description": "Lists the NSP resource associations proxy.", + "x-ms-pageable": { + "nextLinkName": "nextLink" + }, + "parameters": [ + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/NetworkSecurityPerimeterNameParameter" + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/ListTopParameter" + }, + { + "$ref": "#/parameters/ListSkipTokenParameter" + } + ], + "responses": { + "200": { + "description": "OK - Returns the list of NSP resource associations proxy.", + "schema": { + "$ref": "#/definitions/NspAssociationsProxyListResult" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspAssociationList": { + "$ref": "./examples/NspAssociationProxyList.json" } } } @@ -778,6 +943,68 @@ } } } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/profiles/{networkSecurityPerimeterProfile}/checkMembers": { + "parameters": [ + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/NetworkSecurityPerimeterNameParameter" + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/networkSecurityPerimeterProfileParameter" + } + ], + "post": { + "tags": [ + "NetworkSecurityPerimeters" + ], + "operationId": "NetworkSecurityPerimeters_CheckMembers", + "description": "Action to check members associated to an NSP Profile", + "parameters": [ + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "#/definitions/CheckMembers" + }, + "description": "Parameter supplied to create or update the network security perimeter." + } + ], + "responses": { + "200": { + "description": "Resource Updated. Returns the network security perimeter.", + "schema": { + "$ref": "#/definitions/NetworkSecurityPerimeter" + } + }, + "201": { + "description": "Resource Created. Returns the network security perimeter.", + "schema": { + "$ref": "#/definitions/NetworkSecurityPerimeter" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "Post Check Members": { + "$ref": "./examples/NetworkSecurityPerimeterCheckMembersPost.json" + } + } + } } }, "definitions": { @@ -1177,6 +1404,26 @@ } }, "description": "Properties of the perimeter associable resources." + }, + "CheckMembers": { + "type": "object", + "properties": { + "memberDestinations": { + "type": "array", + "items": {"$ref": "#/definitions/PrivateLinkResourceId"} + } + }, + "description": "Request object for check members API." + }, + "PrivateLinkResourceId": { + "type": "object", + "properties": { + "privateLinkResourceId": { + "type": "string", + "description": "Private Link Resource Id." + } + }, + "description": "Properties of network security perimeter." } }, "parameters": { From 05bcf8867aa81d50ae30a7fdf19d0db0662547e6 Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Wed, 6 Apr 2022 13:57:22 +0530 Subject: [PATCH 02/19] update --- ...workSecurityPerimeterCheckMembersPost.json | 8 ++-- .../examples/NetworkSecurityPerimeterGet.json | 5 ++- .../NetworkSecurityPerimeterList.json | 6 +++ .../NetworkSecurityPerimeterListAll.json | 6 +++ .../examples/NetworkSecurityPerimeterPut.json | 6 +++ .../examples/NspAssociationsProxyDelete.json | 0 .../examples/NspAssociationsProxyGet.json | 0 .../examples/NspAssociationsProxyPut.json | 0 .../networkSecurityPerimeter.json | 41 +++++++++++++------ 9 files changed, 55 insertions(+), 17 deletions(-) delete mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyDelete.json delete mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyGet.json delete mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyPut.json diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterCheckMembersPost.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterCheckMembersPost.json index 516174620022..26adbb59b5ba 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterCheckMembersPost.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterCheckMembersPost.json @@ -7,9 +7,11 @@ "networkSecurityPerimeterName": "nsp1", "networkSecurityPerimeterProfile": "NP1", "parameters": { - "MemberDestinations": [ - {"privatelinkResourceId":"/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Sql/servers/resourceName1"} - ] + "MemberDestinations": [ + { + "privatelinkResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Sql/servers/resourceName1" + } + ] } }, "responses": { diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterGet.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterGet.json index e1873fdf1326..10f2e7d67f19 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterGet.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterGet.json @@ -12,9 +12,12 @@ "name": "nsp1", "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1", "type": "Microsoft.Network/networkSecurityPerimeters", + "tags": {}, + "location": "East US 2 EUAP", "properties": { + "perimeterGuid": "guid", "displayName": "nsp1", - "description": "Test Network Security Periemter", + "description": "Test Network Security Perimeter", "provisioningState": "Succeeded" } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterList.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterList.json index 19d04cb4e59d..b37a6a755b20 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterList.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterList.json @@ -13,7 +13,10 @@ "name": "testNSP1", "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/testNSP1", "type": "Microsoft.Network/networkSecurityPerimeters", + "tags": {}, + "location": "East US 2 EUAP", "properties": { + "perimeterGuid": "guid", "displayName": "TestNetworkSecurityPerimeter1", "description": "Description for TestNetworkSecurityPerimeter1", "provisioningState": "Succeeded" @@ -23,7 +26,10 @@ "name": "testNSP2", "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/testNSP2", "type": "Microsoft.Network/networkSecurityPerimeters", + "tags": {}, + "location": "East US 2 EUAP", "properties": { + "perimeterGuid": "guid", "displayName": "TestNetworkSecurityPerimeter2", "description": "Description for TestNetworkSecurityPerimeter2", "provisioningState": "Succeeded" diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterListAll.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterListAll.json index 74a44f734644..49fa18ab90f2 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterListAll.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterListAll.json @@ -12,7 +12,10 @@ "name": "testNSP1", "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/testNSP1", "type": "Microsoft.Network/networkSecurityPerimeters", + "tags": {}, + "location": "East US 2 EUAP", "properties": { + "perimeterGuid": "guid", "displayName": "TestNetworkSecurityPerimeter1", "description": "Description for TestNetworkSecurityPerimeter1", "provisioningState": "Succeeded" @@ -22,7 +25,10 @@ "name": "testNSP2", "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/testNSP2", "type": "Microsoft.Network/networkSecurityPerimeters", + "tags": {}, + "location": "East US 2 EUAP", "properties": { + "perimeterGuid": "guid", "displayName": "TestNetworkSecurityPerimeter2", "description": "Description for TestNetworkSecurityPerimeter2", "provisioningState": "Succeeded" diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json index ea6f93b08979..a3c79744f84e 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json @@ -18,7 +18,10 @@ "name": "TestNetworkSecurityPerimeter", "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/TestNetworkSecurityPerimeter", "type": "Microsoft.Network/networkSecurityPerimeters", + "tags": {}, + "location": "East US 2 EUAP", "properties": { + "perimeterGuid": "guid", "displayName": "TestNetworkSecurityPerimeter", "description": "Description of TestNetworkSecurityPerimeter", "provisioningState": "Succeeded" @@ -30,7 +33,10 @@ "name": "TestNetworkSecurityPerimeter", "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/TestNetworkSecurityPerimeter", "type": "Microsoft.Network/networkSecurityPerimeters", + "tags": {}, + "location": "East US 2 EUAP", "properties": { + "perimeterGuid": "guid", "displayName": "TestNetworkSecurityPerimeter", "description": "Description of TestNetworkSecurityPerimeter", "provisioningState": "Succeeded" diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyDelete.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyDelete.json deleted file mode 100644 index e69de29bb2d1..000000000000 diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyGet.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyGet.json deleted file mode 100644 index e69de29bb2d1..000000000000 diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyPut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationsProxyPut.json deleted file mode 100644 index e69de29bb2d1..000000000000 diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 6830e7e19196..a556c002b341 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -704,7 +704,7 @@ "tags": [ "NspAssociations" ], - "operationId": "NspAssociations_Get", + "operationId": "NspAssociationsProxy_Get", "description": "Gets the specified NSP association by name.", "responses": { "200": { @@ -730,7 +730,7 @@ "tags": [ "NspAssociations" ], - "operationId": "NspAssociations_CreateOrUpdate", + "operationId": "NspAssociationsProxy_CreateOrUpdate", "description": "Creates or updates a NSP resource association.", "parameters": [ { @@ -773,15 +773,12 @@ "tags": [ "NspAssociations" ], - "operationId": "NspAssociations_Delete", + "operationId": "NspAssociationsProxy_Delete", "description": "Deletes an NSP association resource.", "responses": { "200": { "description": "Delete Succeed." }, - "202": { - "description": "Delete in progress." - }, "204": { "description": "Request successful. The resource does not exist." }, @@ -833,7 +830,7 @@ "200": { "description": "OK - Returns the list of NSP resource associations proxy.", "schema": { - "$ref": "#/definitions/NspAssociationsProxyListResult" + "$ref": "#/definitions/NspAssociationsListResult" } }, "default": { @@ -845,7 +842,7 @@ }, "x-ms-examples": { "NspAssociationList": { - "$ref": "./examples/NspAssociationProxyList.json" + "$ref": "./examples/NspAssociationList.json" } } } @@ -855,7 +852,7 @@ "tags": [ "NspAssociationsProxy" ], - "operationId": "NspAssociationsProxy_List", + "operationId": "NspAssociations_List", "description": "Lists the NSP resource associations proxy.", "x-ms-pageable": { "nextLinkName": "nextLink" @@ -884,7 +881,7 @@ "200": { "description": "OK - Returns the list of NSP resource associations proxy.", "schema": { - "$ref": "#/definitions/NspAssociationsProxyListResult" + "$ref": "#/definitions/NspAssociationsListResult" } }, "default": { @@ -896,7 +893,7 @@ }, "x-ms-examples": { "NspAssociationList": { - "$ref": "./examples/NspAssociationProxyList.json" + "$ref": "./examples/NspAssociationList.json" } } } @@ -959,7 +956,7 @@ "$ref": "./network.json#/parameters/ApiVersionParameter" }, { - "$ref": "#/parameters/networkSecurityPerimeterProfileParameter" + "$ref": "#/parameters/NetworkSecurityPerimeterProfileParameter" } ], "post": { @@ -1016,7 +1013,13 @@ "$ref": "#/definitions/NetworkSecurityPerimeterProperties", "description": "The network security perimeter properties" }, - "etag": { + "tags": { + "type": "object", + "additionalProperties": { + "type": "string" + } + }, + "location": { "readOnly": true, "type": "string", "description": "A unique read-only string that changes whenever the resource is updated." @@ -1075,6 +1078,10 @@ "readOnly": true, "$ref": "./network.json#/definitions/ProvisioningState", "description": "The provisioning state of the scope assignment resource." + }, + "perimeterGuid": { + "type": "string", + "description": "perimeter guid of the network security perimeter." } }, "description": "Properties of network security perimeter." @@ -1485,6 +1492,14 @@ "required": false, "type": "string", "x-ms-parameter-location": "method" + }, + "NetworkSecurityPerimeterProfileParameter": { + "name": "networkSecurityPerimeterProfile", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the network security perimeter profile.", + "x-ms-parameter-location": "method" } } } From 9d82593815bdd5ed8cdab5c3156a715757b20efe Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Wed, 6 Apr 2022 16:10:15 +0530 Subject: [PATCH 03/19] check members API fix --- ...workSecurityPerimeterCheckMembersPost.json | 4 +-- .../networkSecurityPerimeter.json | 27 ++++++++++++------- 2 files changed, 20 insertions(+), 11 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterCheckMembersPost.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterCheckMembersPost.json index 26adbb59b5ba..111ea2f87b36 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterCheckMembersPost.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterCheckMembersPost.json @@ -7,9 +7,9 @@ "networkSecurityPerimeterName": "nsp1", "networkSecurityPerimeterProfile": "NP1", "parameters": { - "MemberDestinations": [ + "memberDestinations": [ { - "privatelinkResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Sql/servers/resourceName1" + "privateLinkResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Sql/servers/resourceName1" } ] } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index a556c002b341..77924391b28a 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -961,7 +961,7 @@ ], "post": { "tags": [ - "NetworkSecurityPerimeters" + "NetworkSecurityPerimetersCheckMembers" ], "operationId": "NetworkSecurityPerimeters_CheckMembers", "description": "Action to check members associated to an NSP Profile", @@ -973,20 +973,20 @@ "schema": { "$ref": "#/definitions/CheckMembers" }, - "description": "Parameter supplied to create or update the network security perimeter." + "description": "Parameter supplied to create or update the network security perimeter check members." } ], "responses": { "200": { "description": "Resource Updated. Returns the network security perimeter.", "schema": { - "$ref": "#/definitions/NetworkSecurityPerimeter" + "$ref": "#/definitions/CheckMembers" } }, "201": { "description": "Resource Created. Returns the network security perimeter.", "schema": { - "$ref": "#/definitions/NetworkSecurityPerimeter" + "$ref": "#/definitions/CheckMembers" } }, "default": { @@ -1417,20 +1417,29 @@ "properties": { "memberDestinations": { "type": "array", - "items": {"$ref": "#/definitions/PrivateLinkResourceId"} + "items": {"$ref": "#/definitions/MemberDestination"} } }, "description": "Request object for check members API." }, - "PrivateLinkResourceId": { + "MemberDestination": { "type": "object", "properties": { "privateLinkResourceId": { "type": "string", - "description": "Private Link Resource Id." + "description": "Private link resource Id." + }, + "isMember": { + "readOnly": true, + "type": "string", + "description": "yes/no, if it is member or not." + }, + "profile": { + "readOnly": true, + "type": "string", + "description": "Network security perimeter profile." } - }, - "description": "Properties of network security perimeter." + } } }, "parameters": { From 94cecaa470d986a5697f7d3f5e42e69f9945ae65 Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Wed, 6 Apr 2022 18:39:54 +0530 Subject: [PATCH 04/19] Add query by perimeter guid --- ...bersPost.json => NSPCheckMembersPost.json} | 0 .../2021-02-01-preview/examples/QueryNSP.json | 36 ++++++++ .../networkSecurityPerimeter.json | 89 +++++++++++++++++-- 3 files changed, 119 insertions(+), 6 deletions(-) rename specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/{NetworkSecurityPerimeterCheckMembersPost.json => NSPCheckMembersPost.json} (100%) create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/QueryNSP.json diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterCheckMembersPost.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NSPCheckMembersPost.json similarity index 100% rename from specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterCheckMembersPost.json rename to specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NSPCheckMembersPost.json diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/QueryNSP.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/QueryNSP.json new file mode 100644 index 000000000000..463ae9a684b3 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/QueryNSP.json @@ -0,0 +1,36 @@ +{ + "title": "Post Network Security Perimeter Query by GUID", + "parameters": { + "location": "centraluseuap", + "api-version": "2021-02-01-preview", + "parameters": { + "networkSecurityPerimeters": [ + { + "perimeterGuid": "test" + } + ] + } + }, + "responses": { + "200": { + "body": { + "networkSecurityPerimeters": [ + { + "perimeterGuid": "test", + "id": "xyz" + } + ] + } + }, + "201": { + "body": { + "networkSecurityPerimeters": [ + { + "perimeterGuid": "test", + "id": "abcd" + } + ] + } + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 77924391b28a..3b4bd4eb5276 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -910,11 +910,7 @@ "$ref": "./network.json#/parameters/SubscriptionIdParameter" }, { - "name": "location", - "in": "path", - "required": true, - "type": "string", - "description": "The location of the where the association is present." + "$ref": "#/parameters/LocationParameter" }, { "$ref": "./network.json#/parameters/ApiVersionParameter" @@ -998,7 +994,57 @@ }, "x-ms-examples": { "Post Check Members": { - "$ref": "./examples/NetworkSecurityPerimeterCheckMembersPost.json" + "$ref": "./examples/NSPCheckMembersPost.json" + } + } + } + }, + "/providers/Microsoft.Network/locations/{location}/queryNetworkSecurityPerimeter": { + "parameters": [ + { + "$ref": "#/parameters/LocationParameter" + } + ], + "post": { + "tags": [ + "QueryNetworkSecurityPerimeters" + ], + "operationId": "NetworkSecurityPerimeters_Query", + "description": "Action to query network security parameter", + "parameters": [ + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "#/definitions/QueryNSPReqRes" + }, + "description": "Parameter supplied to query network security parameter." + } + ], + "responses": { + "200": { + "description": "Resource Updated. Returns the network security perimeter.", + "schema": { + "$ref": "#/definitions/QueryNSPReqRes" + } + }, + "201": { + "description": "Resource Created. Returns the network security perimeter.", + "schema": { + "$ref": "#/definitions/QueryNSPReqRes" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "Post Check Members": { + "$ref": "./examples/QueryNSP.json" } } } @@ -1440,6 +1486,30 @@ "description": "Network security perimeter profile." } } + }, + "QueryNSPReqRes": { + "type": "object", + "properties": { + "networkSecurityPerimeters": { + "type": "array", + "items": {"$ref": "#/definitions/QueryNSPObj"} + } + }, + "description": "Request object for query NSP." + }, + "QueryNSPObj": { + "type": "object", + "properties": { + "perimeterGuid": { + "type": "string", + "description": "Perimeter guid of NSP." + }, + "id": { + "readOnly": true, + "type": "string", + "description": "Id of NSP." + } + } } }, "parameters": { @@ -1509,6 +1579,13 @@ "type": "string", "description": "The name of the network security perimeter profile.", "x-ms-parameter-location": "method" + }, + "LocationParameter": { + "name": "location", + "in": "path", + "required": true, + "type": "string", + "description": "The location of network security perimeter." } } } From a3c6dc573cf06121fc612ac99bd629d5931fc3ec Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Thu, 7 Apr 2022 01:35:05 +0530 Subject: [PATCH 05/19] Add NSP reconcile API --- .../examples/NspAccessRuleReconcile.json | 23 ++++++ .../networkSecurityPerimeter.json | 71 +++++++++++++++++++ 2 files changed, 94 insertions(+) create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleReconcile.json diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleReconcile.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleReconcile.json new file mode 100644 index 000000000000..752365dc4009 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleReconcile.json @@ -0,0 +1,23 @@ +{ + "title": "Reconcile NSP access rule", + "parameters": { + "api-version": "2021-02-01-preview", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "networkSecurityPerimeterName": "nsp1", + "profileName": "profile1", + "parameters": { + "properties": {} + } + }, + "responses": { + "200": { + "body": { + } + }, + "201": { + "body": { + } + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 3b4bd4eb5276..d5500f07abc4 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1048,6 +1048,71 @@ } } } + }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/profiles/{profileName}/accessRules/{accessRuleName}/reconcile": { + "parameters": [ + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/NetworkSecurityPerimeterNameParameter" + }, + { + "$ref": "#/parameters/ProfileNameParameter" + }, + { + "$ref": "#/parameters/AccessRuleNameParameter" + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + } + ], + "post": { + "tags": [ + "NspAccessRulesReconcile" + ], + "operationId": "NspAccessRulesReconcile_Post", + "description": "Reconcile NSP access rules", + "parameters": [ + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "#/definitions/NspAccessRuleReconcile" + }, + "description": "Parameters for NSP access rule reconcile" + } + ], + "responses": { + "200": { + "description": "Reconcile NSP access rule.", + "schema": { + "$ref": "#/definitions/NspAccessRuleReconcile" + } + }, + "201": { + "description": "Reconcile NSP access rule.", + "schema": { + "$ref": "#/definitions/NspAccessRuleReconcile" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspAccessRulePut": { + "$ref": "./examples/NspAccessRuleReconcile.json" + } + } + } } }, "definitions": { @@ -1510,6 +1575,12 @@ "description": "Id of NSP." } } + }, + "NspAccessRuleReconcile": { + "type": "object", + "properties": { + }, + "description": "Request object for NSP reconcile." } }, "parameters": { From fa8330dd25cdf0a88797afa6497fc58e6f273c17 Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Thu, 7 Apr 2022 01:40:29 +0530 Subject: [PATCH 06/19] code reformat --- .../2021-02-01-preview/networkSecurityPerimeter.json | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index d5500f07abc4..46a6d08293d7 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1528,7 +1528,9 @@ "properties": { "memberDestinations": { "type": "array", - "items": {"$ref": "#/definitions/MemberDestination"} + "items": { + "$ref": "#/definitions/MemberDestination" + } } }, "description": "Request object for check members API." @@ -1557,7 +1559,9 @@ "properties": { "networkSecurityPerimeters": { "type": "array", - "items": {"$ref": "#/definitions/QueryNSPObj"} + "items": { + "$ref": "#/definitions/QueryNSPObj" + } } }, "description": "Request object for query NSP." @@ -1578,8 +1582,7 @@ }, "NspAccessRuleReconcile": { "type": "object", - "properties": { - }, + "properties": {}, "description": "Request object for NSP reconcile." } }, From b4cfbe7cc5342197944a1b87386df5288457a187 Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Thu, 7 Apr 2022 01:47:40 +0530 Subject: [PATCH 07/19] code reformat --- .../2021-02-01-preview/examples/NspAccessRuleReconcile.json | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleReconcile.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleReconcile.json index 752365dc4009..012df5c7bca6 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleReconcile.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleReconcile.json @@ -12,12 +12,10 @@ }, "responses": { "200": { - "body": { - } + "body": {} }, "201": { - "body": { - } + "body": {} } } } From ebc9c62b1df3819bd88d3630980aaa20c872a738 Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Thu, 7 Apr 2022 10:29:49 +0530 Subject: [PATCH 08/19] lint fix --- .../2021-02-01-preview/networkSecurityPerimeter.json | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 46a6d08293d7..d5b5f4338acd 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1530,7 +1530,10 @@ "type": "array", "items": { "$ref": "#/definitions/MemberDestination" - } + }, + "x-ms-identifiers": [ + "privateLinkResourceId" + ] } }, "description": "Request object for check members API." @@ -1659,7 +1662,8 @@ "in": "path", "required": true, "type": "string", - "description": "The location of network security perimeter." + "description": "The location of network security perimeter.", + "x-ms-parameter-location": "method" } } } From 7683182e37d998e9ff102bcd2a1c7b0a0671968e Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Thu, 7 Apr 2022 14:03:19 +0530 Subject: [PATCH 09/19] change description, tags --- .../networkSecurityPerimeter.json | 114 +++++++++--------- 1 file changed, 57 insertions(+), 57 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index d5b5f4338acd..6359ea8419c1 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -685,6 +685,57 @@ } } }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/resourceAssociations": { + "get": { + "tags": [ + "NspAssociations" + ], + "operationId": "NspAssociations_List", + "description": "Lists the NSP resource associations.", + "x-ms-pageable": { + "nextLinkName": "nextLink" + }, + "parameters": [ + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/NetworkSecurityPerimeterNameParameter" + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/ListTopParameter" + }, + { + "$ref": "#/parameters/ListSkipTokenParameter" + } + ], + "responses": { + "200": { + "description": "OK - Returns the list of NSP resource associations.", + "schema": { + "$ref": "#/definitions/NspAssociationsListResult" + } + }, + "default": { + "description": "Error response describing why the operation failed.", + "schema": { + "$ref": "./network.json#/definitions/CloudError" + } + } + }, + "x-ms-examples": { + "NspAssociationList": { + "$ref": "./examples/NspAssociationList.json" + } + } + } + }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/resourceAssociationProxies/{associationName}": { "parameters": [ { @@ -702,7 +753,7 @@ ], "get": { "tags": [ - "NspAssociations" + "NspAssociationsProxy" ], "operationId": "NspAssociationsProxy_Get", "description": "Gets the specified NSP association by name.", @@ -728,7 +779,7 @@ }, "put": { "tags": [ - "NspAssociations" + "NspAssociationsProxy" ], "operationId": "NspAssociationsProxy_CreateOrUpdate", "description": "Creates or updates a NSP resource association.", @@ -771,7 +822,7 @@ }, "delete": { "tags": [ - "NspAssociations" + "NspAssociationsProxy" ], "operationId": "NspAssociationsProxy_Delete", "description": "Deletes an NSP association resource.", @@ -796,64 +847,13 @@ } } }, - "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/resourceAssociations": { + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/resourceAssociationProxies": { "get": { "tags": [ "NspAssociationsProxy" ], "operationId": "NspAssociationsProxy_List", - "description": "Lists the NSP resource associations proxy.", - "x-ms-pageable": { - "nextLinkName": "nextLink" - }, - "parameters": [ - { - "$ref": "./network.json#/parameters/SubscriptionIdParameter" - }, - { - "$ref": "#/parameters/ResourceGroupNameParameter" - }, - { - "$ref": "#/parameters/NetworkSecurityPerimeterNameParameter" - }, - { - "$ref": "./network.json#/parameters/ApiVersionParameter" - }, - { - "$ref": "#/parameters/ListTopParameter" - }, - { - "$ref": "#/parameters/ListSkipTokenParameter" - } - ], - "responses": { - "200": { - "description": "OK - Returns the list of NSP resource associations proxy.", - "schema": { - "$ref": "#/definitions/NspAssociationsListResult" - } - }, - "default": { - "description": "Error response describing why the operation failed.", - "schema": { - "$ref": "./network.json#/definitions/CloudError" - } - } - }, - "x-ms-examples": { - "NspAssociationList": { - "$ref": "./examples/NspAssociationList.json" - } - } - } - }, - "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/resourceAssociationsProxy": { - "get": { - "tags": [ - "NspAssociationsProxy" - ], - "operationId": "NspAssociations_List", - "description": "Lists the NSP resource associations proxy.", + "description": "Lists the NSP resource associations.", "x-ms-pageable": { "nextLinkName": "nextLink" }, @@ -879,7 +879,7 @@ ], "responses": { "200": { - "description": "OK - Returns the list of NSP resource associations proxy.", + "description": "OK - Returns the list of NSP resource associations.", "schema": { "$ref": "#/definitions/NspAssociationsListResult" } From 48ecb3d2bcdd33aea2f65aa4ef0c2c602af5b6bf Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Thu, 7 Apr 2022 14:23:58 +0530 Subject: [PATCH 10/19] NSP schema update, remove displayName, description --- .../examples/NetworkSecurityPerimeterGet.json | 2 -- .../examples/NetworkSecurityPerimeterList.json | 4 ---- .../examples/NetworkSecurityPerimeterListAll.json | 4 ---- .../examples/NetworkSecurityPerimeterPut.json | 6 ------ .../2021-02-01-preview/networkSecurityPerimeter.json | 8 -------- 5 files changed, 24 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterGet.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterGet.json index 10f2e7d67f19..9fdab4ecb57b 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterGet.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterGet.json @@ -16,8 +16,6 @@ "location": "East US 2 EUAP", "properties": { "perimeterGuid": "guid", - "displayName": "nsp1", - "description": "Test Network Security Perimeter", "provisioningState": "Succeeded" } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterList.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterList.json index b37a6a755b20..19ecf72ad2c5 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterList.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterList.json @@ -17,8 +17,6 @@ "location": "East US 2 EUAP", "properties": { "perimeterGuid": "guid", - "displayName": "TestNetworkSecurityPerimeter1", - "description": "Description for TestNetworkSecurityPerimeter1", "provisioningState": "Succeeded" } }, @@ -30,8 +28,6 @@ "location": "East US 2 EUAP", "properties": { "perimeterGuid": "guid", - "displayName": "TestNetworkSecurityPerimeter2", - "description": "Description for TestNetworkSecurityPerimeter2", "provisioningState": "Succeeded" } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterListAll.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterListAll.json index 49fa18ab90f2..8194a82e5b4b 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterListAll.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterListAll.json @@ -16,8 +16,6 @@ "location": "East US 2 EUAP", "properties": { "perimeterGuid": "guid", - "displayName": "TestNetworkSecurityPerimeter1", - "description": "Description for TestNetworkSecurityPerimeter1", "provisioningState": "Succeeded" } }, @@ -29,8 +27,6 @@ "location": "East US 2 EUAP", "properties": { "perimeterGuid": "guid", - "displayName": "TestNetworkSecurityPerimeter2", - "description": "Description for TestNetworkSecurityPerimeter2", "provisioningState": "Succeeded" } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json index a3c79744f84e..054cc722c361 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json @@ -7,8 +7,6 @@ "networkSecurityPerimeterName": "nsp1", "parameters": { "properties": { - "displayName": "TestNetworkSecurityPerimeter", - "description": "Description of TestNetworkSecurityPerimeter" } } }, @@ -22,8 +20,6 @@ "location": "East US 2 EUAP", "properties": { "perimeterGuid": "guid", - "displayName": "TestNetworkSecurityPerimeter", - "description": "Description of TestNetworkSecurityPerimeter", "provisioningState": "Succeeded" } } @@ -37,8 +33,6 @@ "location": "East US 2 EUAP", "properties": { "perimeterGuid": "guid", - "displayName": "TestNetworkSecurityPerimeter", - "description": "Description of TestNetworkSecurityPerimeter", "provisioningState": "Succeeded" } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 6359ea8419c1..7371719448be 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1177,14 +1177,6 @@ "NetworkSecurityPerimeterProperties": { "type": "object", "properties": { - "displayName": { - "type": "string", - "description": "A friendly name for the network security perimeter." - }, - "description": { - "type": "string", - "description": "A description of the network security perimeter." - }, "provisioningState": { "readOnly": true, "$ref": "./network.json#/definitions/ProvisioningState", From 03ebf212840a798aca17b589028a76fa8e8a82f4 Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Thu, 7 Apr 2022 15:33:29 +0530 Subject: [PATCH 11/19] prettier fix --- .../examples/NetworkSecurityPerimeterPut.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json index 054cc722c361..9336e4d47489 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json @@ -6,8 +6,7 @@ "resourceGroupName": "rg1", "networkSecurityPerimeterName": "nsp1", "parameters": { - "properties": { - } + "properties": {} } }, "responses": { From 73893d810bb0b02076027714d3206973b03adce5 Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Fri, 8 Apr 2022 18:53:56 +0530 Subject: [PATCH 12/19] tags readonly --- .../preview/2021-02-01-preview/networkSecurityPerimeter.json | 1 + 1 file changed, 1 insertion(+) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 7371719448be..ba02affcb4c0 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1125,6 +1125,7 @@ "description": "The network security perimeter properties" }, "tags": { + "readOnly": true, "type": "object", "additionalProperties": { "type": "string" From 2ce52f0d3fef09b66cba1761698308c8e16b552c Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Wed, 13 Apr 2022 15:35:36 +0530 Subject: [PATCH 13/19] remove tags --- .../2021-02-01-preview/networkSecurityPerimeter.json | 7 ------- 1 file changed, 7 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index ba02affcb4c0..331799a9ed10 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1124,13 +1124,6 @@ "$ref": "#/definitions/NetworkSecurityPerimeterProperties", "description": "The network security perimeter properties" }, - "tags": { - "readOnly": true, - "type": "object", - "additionalProperties": { - "type": "string" - } - }, "location": { "readOnly": true, "type": "string", From 8e6569fa579b329a5b05a4de1898f0be71b4d8c1 Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Tue, 19 Apr 2022 10:34:45 +0530 Subject: [PATCH 14/19] association proxy delete as per merged PR examples --- .../2021-02-01-preview/networkSecurityPerimeter.json | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index ed64f9f16e73..452507a21310 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -840,6 +840,15 @@ "200": { "description": "Delete Succeed." }, + "202": { + "description": "Delete in progress.", + "headers": { + "location": { + "description": "location header", + "type": "string" + } + } + }, "204": { "description": "Request successful. The resource does not exist." }, From 8f2a6d507275d0b824d78ec77ec624e57cbd7980 Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Tue, 26 Apr 2022 12:21:24 +0530 Subject: [PATCH 15/19] review changse, remove 201 from POST and other changes --- .../examples/NSPCheckMembersPost.json | 11 ----- .../examples/NetworkSecurityPerimeterPut.json | 13 ------ .../examples/NspAccessRuleReconcile.json | 3 -- .../examples/NspAssociationProxyDelete.json | 15 +++++++ .../2021-02-01-preview/examples/QueryNSP.json | 10 ----- .../networkSecurityPerimeter.json | 41 ++----------------- 6 files changed, 19 insertions(+), 74 deletions(-) create mode 100644 specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationProxyDelete.json diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NSPCheckMembersPost.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NSPCheckMembersPost.json index 111ea2f87b36..e8dd25d906c5 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NSPCheckMembersPost.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NSPCheckMembersPost.json @@ -25,17 +25,6 @@ } ] } - }, - "201": { - "body": { - "memberDestinations": [ - { - "privateLinkResourceId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Sql/servers/resourceName1", - "isMember": "no", - "profile": "" - } - ] - } } } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json index 9336e4d47489..2ddcc442e815 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json @@ -22,19 +22,6 @@ "provisioningState": "Succeeded" } } - }, - "201": { - "body": { - "name": "TestNetworkSecurityPerimeter", - "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/TestNetworkSecurityPerimeter", - "type": "Microsoft.Network/networkSecurityPerimeters", - "tags": {}, - "location": "East US 2 EUAP", - "properties": { - "perimeterGuid": "guid", - "provisioningState": "Succeeded" - } - } } } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleReconcile.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleReconcile.json index 012df5c7bca6..1272d8682429 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleReconcile.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleReconcile.json @@ -13,9 +13,6 @@ "responses": { "200": { "body": {} - }, - "201": { - "body": {} } } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationProxyDelete.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationProxyDelete.json new file mode 100644 index 000000000000..93f4c5cfce03 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationProxyDelete.json @@ -0,0 +1,15 @@ +{ + "title": "Delete NSP resource association", + "parameters": { + "api-version": "2021-02-01-preview", + "subscriptionId": "subId", + "resourceGroupName": "rg1", + "networkSecurityPerimeterName": "nsp1", + "associationName": "association1", + "operationId": "operationId1" + }, + "responses": { + "200": {}, + "204": {} + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/QueryNSP.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/QueryNSP.json index 463ae9a684b3..634bb645eee7 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/QueryNSP.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/QueryNSP.json @@ -21,16 +21,6 @@ } ] } - }, - "201": { - "body": { - "networkSecurityPerimeters": [ - { - "perimeterGuid": "test", - "id": "abcd" - } - ] - } } } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 452507a21310..0aeea7667527 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -94,13 +94,7 @@ ], "responses": { "200": { - "description": "Resource Updated. Returns the network security perimeter.", - "schema": { - "$ref": "#/definitions/NetworkSecurityPerimeter" - } - }, - "201": { - "description": "Resource Created. Returns the network security perimeter.", + "description": "Resource created. Returns the network security perimeter.", "schema": { "$ref": "#/definitions/NetworkSecurityPerimeter" } @@ -840,15 +834,6 @@ "200": { "description": "Delete Succeed." }, - "202": { - "description": "Delete in progress.", - "headers": { - "location": { - "description": "location header", - "type": "string" - } - } - }, "204": { "description": "Request successful. The resource does not exist." }, @@ -861,7 +846,7 @@ }, "x-ms-examples": { "NspAssociationDelete": { - "$ref": "./examples/NspAssociationDelete.json" + "$ref": "./examples/NspAssociationProxyDelete.json" } } } @@ -988,7 +973,7 @@ "schema": { "$ref": "#/definitions/CheckMembers" }, - "description": "Parameter supplied to create or update the network security perimeter check members." + "description": "Parameter supplied to create the network security perimeter check members." } ], "responses": { @@ -998,12 +983,6 @@ "$ref": "#/definitions/CheckMembers" } }, - "201": { - "description": "Resource Created. Returns the network security perimeter.", - "schema": { - "$ref": "#/definitions/CheckMembers" - } - }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -1048,12 +1027,6 @@ "$ref": "#/definitions/QueryNSPReqRes" } }, - "201": { - "description": "Resource Created. Returns the network security perimeter.", - "schema": { - "$ref": "#/definitions/QueryNSPReqRes" - } - }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -1113,12 +1086,6 @@ "$ref": "#/definitions/NspAccessRuleReconcile" } }, - "201": { - "description": "Reconcile NSP access rule.", - "schema": { - "$ref": "#/definitions/NspAccessRuleReconcile" - } - }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -1127,7 +1094,7 @@ } }, "x-ms-examples": { - "NspAccessRulePut": { + "NspAccessRuleReconcile": { "$ref": "./examples/NspAccessRuleReconcile.json" } } From a5f6e1d406a3c738b039c2c513c2ea79f65e8fb4 Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Tue, 26 Apr 2022 12:31:02 +0530 Subject: [PATCH 16/19] update --- .../2021-02-01-preview/networkSecurityPerimeter.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 0aeea7667527..2e0ee3dd2e59 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -978,7 +978,7 @@ ], "responses": { "200": { - "description": "Resource Updated. Returns the network security perimeter.", + "description": "Check members, nothing is getting created or updated.", "schema": { "$ref": "#/definitions/CheckMembers" } @@ -1022,7 +1022,7 @@ ], "responses": { "200": { - "description": "Resource Updated. Returns the network security perimeter.", + "description": "Query NSP using parameter guid, no resource created or updated.", "schema": { "$ref": "#/definitions/QueryNSPReqRes" } @@ -1035,7 +1035,7 @@ } }, "x-ms-examples": { - "Post Check Members": { + "Post Query NSP": { "$ref": "./examples/QueryNSP.json" } } From 89923e4886967785eeb7feaaa25f917fa8d7f9d9 Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Wed, 27 Apr 2022 00:52:23 +0530 Subject: [PATCH 17/19] Logging Category remove --- .../examples/NspProfileGet.json | 7 +------ .../examples/NspProfileList.json | 14 ++----------- .../examples/NspProfilePut.json | 14 ++----------- .../networkSecurityPerimeter.json | 20 ------------------- 4 files changed, 5 insertions(+), 50 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspProfileGet.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspProfileGet.json index e82a1fe80720..a9cd5d203a92 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspProfileGet.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspProfileGet.json @@ -15,12 +15,7 @@ "type": "Microsoft.Network/networkSecurityPerimeters/profiles", "location": "resource location", "properties": { - "accessRulesVersion": "0", - "enabledLogCategories": [ - { - "name": "NSPOutboundAccessAllowed" - } - ] + "accessRulesVersion": "0" } } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspProfileList.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspProfileList.json index 18410d77a346..cd0492637aa1 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspProfileList.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspProfileList.json @@ -16,12 +16,7 @@ "type": "Microsoft.Network/networkSecurityPerimeters/profiles", "location": "resource location", "properties": { - "accessRulesVersion": "0", - "enabledLogCategories": [ - { - "name": "NSPOutboundAccessDenied" - } - ] + "accessRulesVersion": "0" } }, { @@ -30,12 +25,7 @@ "type": "Microsoft.Network/networkSecurityPerimeters/profiles", "location": "resource location", "properties": { - "accessRulesVersion": "0", - "enabledLogCategories": [ - { - "name": "NSPOutboundAttempt" - } - ] + "accessRulesVersion": "0" } } ], diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspProfilePut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspProfilePut.json index da8dbfdc8669..50da34f76028 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspProfilePut.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspProfilePut.json @@ -18,12 +18,7 @@ "type": "Microsoft.Network/networkSecurityPerimeters/profiles", "location": "East US 2 EUAP", "properties": { - "accessRulesVersion": "0", - "enabledLogCategories": [ - { - "name": "NSPInboundAccessAllowed" - } - ] + "accessRulesVersion": "0" } } }, @@ -34,12 +29,7 @@ "type": "Microsoft.Network/networkSecurityPerimeters/profiles", "location": "East US 2 EUAP", "properties": { - "accessRulesVersion": "0", - "enabledLogCategories": [ - { - "name": "NSPInboundAccessDenied" - } - ] + "accessRulesVersion": "0" } } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 2e0ee3dd2e59..76f49aa35950 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1223,16 +1223,6 @@ "readOnly": true, "type": "string", "description": "Version number that increases with every update to access rules within the profile." - }, - "enabledLogCategories": { - "type": "array", - "items": { - "$ref": "#/definitions/LoggingCategory" - }, - "x-ms-identifiers": [ - "name" - ], - "description": "Gets the enabled log categories." } }, "description": "Properties of NSP profile." @@ -1574,16 +1564,6 @@ "properties": {}, "description": "Request object for NSP reconcile." }, - "LoggingCategory": { - "type": "object", - "properties": { - "name": { - "type": "string", - "description": "The name of the logging category." - } - }, - "description": "Logging Category" - }, "NSPProvisioningState": { "type": "string", "readOnly": true, From 2c1aaea05441d07b5eb8e72892aa2c46d10e0cbd Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Mon, 2 May 2022 16:19:32 +0530 Subject: [PATCH 18/19] NSP post 201 fix --- .../examples/NetworkSecurityPerimeterPut.json | 13 +++++++++++++ .../networkSecurityPerimeter.json | 8 +++++++- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json index 2ddcc442e815..9336e4d47489 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterPut.json @@ -22,6 +22,19 @@ "provisioningState": "Succeeded" } } + }, + "201": { + "body": { + "name": "TestNetworkSecurityPerimeter", + "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/TestNetworkSecurityPerimeter", + "type": "Microsoft.Network/networkSecurityPerimeters", + "tags": {}, + "location": "East US 2 EUAP", + "properties": { + "perimeterGuid": "guid", + "provisioningState": "Succeeded" + } + } } } } diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index 76f49aa35950..a160ff86f3a2 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -94,7 +94,13 @@ ], "responses": { "200": { - "description": "Resource created. Returns the network security perimeter.", + "description": "Resource Updated. Returns the network security perimeter.", + "schema": { + "$ref": "#/definitions/NetworkSecurityPerimeter" + } + }, + "201": { + "description": "Resource Created. Returns the network security perimeter.", "schema": { "$ref": "#/definitions/NetworkSecurityPerimeter" } From 054894ffd4a3790b359a35127161ab8eb3c4dae4 Mon Sep 17 00:00:00 2001 From: Kaushal Kumar Date: Wed, 4 May 2022 15:34:18 +0530 Subject: [PATCH 19/19] isMember changed to enum from string --- .../2021-02-01-preview/networkSecurityPerimeter.json | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json index a160ff86f3a2..028970e7db15 100644 --- a/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json +++ b/specification/network/resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json @@ -1528,9 +1528,17 @@ "description": "Private link resource Id." }, "isMember": { - "readOnly": true, "type": "string", - "description": "yes/no, if it is member or not." + "readOnly": true, + "description": "yes/no, if it is member or not.", + "enum": [ + "yes", + "no" + ], + "x-ms-enum": { + "name": "isMember", + "modelAsString": true + } }, "profile": { "readOnly": true,