From 832ef5a2888af99594b35310ad729c1ca08dc41e Mon Sep 17 00:00:00 2001 From: Adriana Galer Rotaru Date: Mon, 31 Jan 2022 21:43:50 -0500 Subject: [PATCH 1/6] Adding x-ms-identifiers for Advisor --- .../stable/2020-01-01/advisor.json | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json b/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json index 789f65d262af..cd04e7963e7c 100644 --- a/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json +++ b/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json @@ -936,7 +936,10 @@ "type": "array", "items": { "$ref": "#/definitions/DigestConfig" - } + }, + "x-ms-identifiers": [ + "name" + ] } } }, @@ -1164,7 +1167,8 @@ "additionalProperties": { "type": "object" } - } + }, + "x-ms-identifiers": [] }, "remediation": { "description": "The automated way to apply recommendation.", @@ -1259,7 +1263,10 @@ "type": "array", "items": { "$ref": "#/definitions/OperationEntity" - } + }, + "x-ms-identifiers": [ + "name" + ] } } }, From 927f88a3c98faac8c43ca255e1cdaebc053131e4 Mon Sep 17 00:00:00 2001 From: Adriana Galer Rotaru Date: Mon, 31 Jan 2022 22:27:27 -0500 Subject: [PATCH 2/6] adding the preview xms ids --- .../preview/2020-07-01-preview/advisor.json | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/specification/advisor/resource-manager/Microsoft.Advisor/preview/2020-07-01-preview/advisor.json b/specification/advisor/resource-manager/Microsoft.Advisor/preview/2020-07-01-preview/advisor.json index eed5986f67e1..59e6e119799a 100644 --- a/specification/advisor/resource-manager/Microsoft.Advisor/preview/2020-07-01-preview/advisor.json +++ b/specification/advisor/resource-manager/Microsoft.Advisor/preview/2020-07-01-preview/advisor.json @@ -167,7 +167,8 @@ "type": "array", "items": { "$ref": "#/definitions/OperationEntity" - } + }, + "x-ms-identifiers": [ "name" ] } } }, @@ -259,10 +260,12 @@ "type": "array", "items": { "$ref": "#/definitions/scoreEntity" - } + }, + "x-ms-identifiers" : [] } } - } + }, + "x-ms-identifiers": [] }, "advisorScoreEntity": { "description": "The details of Advisor score for a single category.", From 9a5f9288c740d5eb8cd3a201684d31dd20c5c2c0 Mon Sep 17 00:00:00 2001 From: Adriana Galer Rotaru Date: Tue, 1 Feb 2022 12:21:16 -0500 Subject: [PATCH 3/6] reverting preview file changes --- .../preview/2020-07-01-preview/advisor.json | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/specification/advisor/resource-manager/Microsoft.Advisor/preview/2020-07-01-preview/advisor.json b/specification/advisor/resource-manager/Microsoft.Advisor/preview/2020-07-01-preview/advisor.json index 59e6e119799a..eed5986f67e1 100644 --- a/specification/advisor/resource-manager/Microsoft.Advisor/preview/2020-07-01-preview/advisor.json +++ b/specification/advisor/resource-manager/Microsoft.Advisor/preview/2020-07-01-preview/advisor.json @@ -167,8 +167,7 @@ "type": "array", "items": { "$ref": "#/definitions/OperationEntity" - }, - "x-ms-identifiers": [ "name" ] + } } } }, @@ -260,12 +259,10 @@ "type": "array", "items": { "$ref": "#/definitions/scoreEntity" - }, - "x-ms-identifiers" : [] + } } } - }, - "x-ms-identifiers": [] + } }, "advisorScoreEntity": { "description": "The details of Advisor score for a single category.", From e52984958581ad276c912afb0139839e4f2edeea Mon Sep 17 00:00:00 2001 From: Adriana Galer Rotaru Date: Mon, 7 Feb 2022 22:08:02 +0100 Subject: [PATCH 4/6] fix model validation errors --- .../Microsoft.Advisor/stable/2020-01-01/advisor.json | 2 ++ .../stable/2020-01-01/examples/EmptyResponse.json | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json b/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json index cd04e7963e7c..f1125d6f7d19 100644 --- a/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json +++ b/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json @@ -495,6 +495,8 @@ "deprecated": false, "x-ms-pageable": { "nextLinkName": "nextLink" + }, + "x-ms-examples": { } } }, diff --git a/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/EmptyResponse.json b/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/EmptyResponse.json index 8a7a180d0fd7..210aa5a6effe 100644 --- a/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/EmptyResponse.json +++ b/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/EmptyResponse.json @@ -1,7 +1,7 @@ { "parameters": { "subscriptionId": "subscriptionId", - "operationId": "operationGUID", + "operationId": "00000000-0000-0000-0000-000000000000", "api-version": "2020-01-01" }, "responses": { From ea1c7bb7ab9ec148eaaf52718b63dc990b26a444 Mon Sep 17 00:00:00 2001 From: Adriana Galer Rotaru Date: Tue, 8 Feb 2022 22:35:06 +0100 Subject: [PATCH 5/6] prettier fix --- .../Microsoft.Advisor/stable/2020-01-01/advisor.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json b/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json index f1125d6f7d19..566fb823ae6a 100644 --- a/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json +++ b/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json @@ -496,8 +496,7 @@ "x-ms-pageable": { "nextLinkName": "nextLink" }, - "x-ms-examples": { - } + "x-ms-examples": {} } }, "/{resourceUri}/providers/Microsoft.Advisor/recommendations/{recommendationId}": { From d19e5aabacc43756b1d5649cd1133cc03dfdcd78 Mon Sep 17 00:00:00 2001 From: Adriana Galer Rotaru Date: Wed, 9 Feb 2022 20:12:39 +0100 Subject: [PATCH 6/6] revert additional fixes --- .../Microsoft.Advisor/stable/2020-01-01/advisor.json | 3 +-- .../stable/2020-01-01/examples/EmptyResponse.json | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json b/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json index 566fb823ae6a..cd04e7963e7c 100644 --- a/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json +++ b/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json @@ -495,8 +495,7 @@ "deprecated": false, "x-ms-pageable": { "nextLinkName": "nextLink" - }, - "x-ms-examples": {} + } } }, "/{resourceUri}/providers/Microsoft.Advisor/recommendations/{recommendationId}": { diff --git a/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/EmptyResponse.json b/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/EmptyResponse.json index 210aa5a6effe..8a7a180d0fd7 100644 --- a/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/EmptyResponse.json +++ b/specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/EmptyResponse.json @@ -1,7 +1,7 @@ { "parameters": { "subscriptionId": "subscriptionId", - "operationId": "00000000-0000-0000-0000-000000000000", + "operationId": "operationGUID", "api-version": "2020-01-01" }, "responses": {