From 408ce794f6be65cee894bd60d5941cba27259e72 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 13 Oct 2021 20:50:16 -0700 Subject: [PATCH 01/16] Added internal Network RP model and API --- .../2020-03-01-preview/deviceupdate.json | 422 ++++++++++++++++++ ...ndpointConnectionProxy_CreateOrUpdate.json | 65 +++ ...PrivateEndpointConnectionProxy_Delete.json | 14 + .../PrivateEndpointConnectionProxy_Get.json | 43 ++ ...ivateEndpointConnectionProxy_Validate.json | 34 ++ 5 files changed, 578 insertions(+) create mode 100644 specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json create mode 100644 specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Delete.json create mode 100644 specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Get.json create mode 100644 specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index e26935cdd457..47641e11a1c6 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -936,6 +936,206 @@ } } }, + "/subscriptions/{subscriptionId}/providers/{resourceGroupName}/providers/Microsoft.DeviceUpdate/accounts/{accountName}/privateEndpointConnectionProxies/{privateEndpointConnectionProxyId}/validate": { + "post": { + "description": "Validates a private endpoint connection proxy object. (Network RP only)", + "operationId": "PrivateEndpointConnectionProxies_Validate", + "parameters": [ + { + "$ref": "#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/AccountNameParameter" + }, + { + "$ref": "#/parameters/PrivateEndpointConnectionProxyIdParameter" + }, + { + "schema": { + "$ref": "#definitions/PrivateEndpointConnectionProxy" + }, + "in": "body", + "name": "request", + "required": true, + "description": "Private endpoint connection proxy request." + } + ], + "responses": { + "200": { + "description": "Validate private endpoint connection proxy empty response." + }, + "default": { + "description": "Error response describing the reason for operation failure.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse" + } + } + }, + "x-ms-examples": { + "PrivateEndpointConnectionProxyValidate": { + "$ref": "./examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json" + } + }, + "deprecated": false + } + }, + "/subscriptions/{subscriptionId}/providers/{resourceGroupName}/providers/Microsoft.DeviceUpdate/accounts/{accountName}/privateEndpointConnectionProxies/{privateEndpointConnectionProxyId}": { + "get": { + "tags": [ + "PrivateEndpointConnections" + ], + "description": "Get the specified private endpoint connection proxy associated with the device update account.", + "operationId": "PrivateEndpointConnectionProxies_Get", + "parameters": [ + { + "$ref": "#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/AccountNameParameter" + }, + { + "$ref": "#/parameters/PrivateEndpointConnectionProxyIdParameter" + } + ], + "responses": { + "200": { + "description": "The request was successful; the request was well-formed and received properly.", + "schema": { + "$ref": "#/definitions/PrivateEndpointConnectionProxy" + } + }, + "default": { + "description": "Error response describing the reason for operation failure.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse" + } + } + }, + "x-ms-examples": { + "PrivateEndpointConnectionProxyGet": { + "$ref": "./examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Get.json" + } + } + }, + "put": { + "tags": [ + "PrivateEndpointConnectionProxies" + ], + "description": "Creates or updates the specified private endpoint connection proxy resource associated with the device update account.", + "operationId": "PrivateEndpointConnectionProxies_CreateOrUpdate", + "parameters": [ + { + "$ref": "#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/AccountNameParameter" + }, + { + "$ref": "#/parameters/PrivateEndpointConnectionProxyIdParameter" + }, + { + "name": "privateEndpointConnectionProxy", + "in": "body", + "description": "The parameters for creating a private endpoint connection proxy.", + "required": true, + "schema": { + "$ref": "#/definitions/PrivateEndpointConnectionProxy" + } + } + ], + "responses": { + "201": { + "description": "The request was successful; the operation will complete asynchronously.", + "schema": { + "$ref": "#/definitions/PrivateEndpointConnectionProxy" + } + }, + "default": { + "description": "Error response describing the reason for operation failure.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse" + } + } + }, + "x-ms-examples": { + "PrivateEndpointConnectionProxyCreateOrUpdate": { + "$ref": "./examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json" + } + }, + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options": { + "final-state-via": "azure-async-operation" + } + }, + "delete": { + "tags": [ + "PrivateEndpointConnectionProxies" + ], + "description": "Deletes the specified private endpoint connection proxy associated with the device update account.", + "operationId": "PrivateEndpointConnectionProxies_Delete", + "parameters": [ + { + "$ref": "#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/AccountNameParameter" + }, + { + "$ref": "#/parameters/PrivateEndpointConnectionProxyIdParameter" + } + ], + "responses": { + "200": { + "description": "The request was successful; the operation completed synchronously." + }, + "202": { + "description": "The request was successful; the operation will complete asynchronously." + }, + "204": { + "description": "The private endpoint connection does not exist in the subscription." + }, + "default": { + "description": "Error response describing the reason for operation failure.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse" + } + } + }, + "x-ms-examples": { + "PrivateEndpointConnectionProxyDelete": { + "$ref": "./examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Delete.json" + } + }, + "x-ms-long-running-operation": true, + "x-ms-long-running-operation-options": { + "final-state-via": "location" + } + } + }, "/providers/Microsoft.DeviceUpdate/operations": { "get": { "description": "Returns list of operations for Microsoft.DeviceUpdate resource provider.", @@ -1263,6 +1463,220 @@ } } } + }, + "PrivateEndpointConnectionProxy": { + "description": "Private endpoint connection proxy details.", + "type": "object", + "allOf": [ + { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ProxyResource" + } + ], + "properties": { + "properties": { + "description": "Private endpoint connection proxy object properties.", + "x-ms-client-flatten": true, + "$ref": "#/definitions/PrivateEndpointConnectionProxyProperties" + } + }, + "required": [ + "properties" + ] + }, + "PrivateEndpointConnectionProxyProperties": { + "description": "Private endpoint connection proxy object properties.", + "type": "object", + "properties": { + "eTag":{ + "description": "ETag from NRP.", + "type": "string", + "readOnly": true + }, + "remotePrivateEndpoint":{ + "description": "Remote private endpoint details.", + "$ref": "#/definitions/RemotePrivateEndpoint" + } + }, + "required": [ + "properties" + ] + }, + "RemotePrivateEndpoint": { + "description": "Remote private endpoint details.", + "type": "object", + "properties": { + "id":{ + "description": "Remote endpoint resource ID.", + "type": "string", + "readOnly": true + }, + "vnetTrafficTag":{ + "description": "Virtual network traffic tag.", + "type": "string", + "readOnly": true + }, + "manualPrivateLinkServiceConnections":{ + "description": "List of private link service connections that need manual approval.", + "type": "array", + "items": { + "$ref": "#/definitions/PrivateLinkServiceConnection" + } + }, + "privateLinkServiceConnections":{ + "description": "List of automatically approved private link service connections.", + "type": "array", + "items": { + "$ref": "#/definitions/PrivateLinkServiceConnection" + } + }, + "privateLinkServiceProxies":{ + "description": "List of private link service proxies.", + "type": "array", + "items": { + "$ref": "#/definitions/PrivateLinkServiceProxy" + } + }, + "connectionDetails":{ + "description": "List of connection details.", + "type": "array", + "items": { + "$ref": "#/definitions/ConnectionDetails" + } + } + }, + "required": [ + "properties" + ] + }, + "PrivateLinkServiceConnection": { + "description": "Private link service connection details.", + "type": "object", + "properties": { + "name":{ + "description": "Private link service connection name.", + "type": "string", + "readOnly": true + }, + "groupIds":{ + "description": "List of group IDs.", + "type": "array", + "items":{ + "type": "string" + } + }, + "requestMessage":{ + "description": "Request message.", + "type": "string", + "readOnly": true + } + }, + "required": [ + "properties" + ] + }, + "PrivateLinkServiceProxy": { + "description": "Private link service proxy details.", + "type": "object", + "properties": { + "remotePrivateLinkServiceConnectionState": { + "description": "Remote private link service connection state", + "$ref":"../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateLinkServiceConnectionState" + }, + "remotePrivateEndpointConnection":{ + "description": "Remote private endpoint connection details.", + "allOf":[ + { + "$ref": "#/definitions/RemotePrivateEndpointConnection" + } + ] + }, + "groupConnectivityInformation":{ + "description": "Group connectivity information.", + "type": "array", + "items":{ + "$ref": "#/definitions/GroupConnectivityInformation" + } + } + }, + "required": [ + "properties" + ] + }, + "RemotePrivateEndpointConnection":{ + "description": "Remote private endpoint connection details.", + "type": "object", + "properties":{ + "id": { + "description": "Remote private endpoint connection ID.", + "type": "string", + "readOnly": true + } + } + }, + "GroupConnectivityInformation": { + "description": "Group connectivity details.", + "type": "object", + "properties": { + "groupId":{ + "description": "Group ID.", + "type": "string", + "readOnly": true + }, + "memberName":{ + "description": "Member name.", + "type": "string", + "readOnly": true + }, + "customerVisibleFqdns":{ + "description": "List of customer visible FQDNs.", + "type": "array", + "items": { + "type": "string" + } + }, + "internalFqdn":{ + "description": "Internal FQDN.", + "type": "string", + "readOnly": true + } + }, + "required": [ + "properties" + ] + }, + "ConnectionDetails": { + "description": "Private endpoint connection proxy object properties.", + "type": "object", + "properties": { + "id":{ + "description": "Connection details ID.", + "type": "string", + "readOnly": true + }, + "privateIpAddress":{ + "description": "Private IP address.", + "type": "string", + "readOnly": true + }, + "linkIdentifier":{ + "description": "Link ID.", + "type": "string", + "readOnly": true + }, + "groupId":{ + "description": "Group ID.", + "type": "string", + "readOnly": true + }, + "memberName":{ + "description": "Member name.", + "type": "string", + "readOnly": true + } + }, + "required": [ + "properties" + ] } }, "parameters": { @@ -1317,6 +1731,14 @@ "type": "string", "description": "The group ID of the private link resource.", "x-ms-parameter-location": "method" + }, + "PrivateEndpointConnectionProxyIdParameter": { + "name": "privateEndpointConnectionProxyId", + "in": "path", + "required": true, + "type": "string", + "description": "The ID of the private endpoint connection proxy object.", + "x-ms-parameter-location": "method" } } } diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json new file mode 100644 index 000000000000..57242cbcc21d --- /dev/null +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json @@ -0,0 +1,65 @@ +{ + "parameters": { + "subscriptionId": "00000000-0000-0000-0000-000000000000", + "resourceGroupName": "test-rg", + "accountName": "contoso", + "privateEndpointConnectionProxyId": "peexample01", + "api-version": "2020-03-01-preview", + "privateEndpointConnectionProxy": { + "properties": { + "remotePrivateEndpoint": { + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}", + "manualPrivateLinkServiceConnections": [ + { + "name": "{privateEndpointConnectionProxyId}", + "groupIds": [ + "DeviceUpdate" + ], + "requestMessage": "Please approve my connection, thanks." + } + ], + "privateLinkServiceProxies ": [ + { + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}/privateLinkServiceProxies/{plsResourceName}-proxy.{guid}", + "groupConnectivityInformation": [] + } + ] + } + } + } + }, + "responses": { + "201": { + "body": { + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.DeviceUpdate/accounts/contoso/privateEndpointConnectionProxies/peexample01", + "name": "peexample01", + "type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnectionProxies", + "properties": { + "remotePrivateEndpoint": { + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", + "manualPrivateLinkServiceConnections": [ + { + "name": "{plsConnectionName}", + "groupIds": [ + "DeviceUpdate" + ], + "requestMessage": "Please approve my connection, thanks." + } + ], + "privateLinkServiceProxies": [ + { + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}/privateLinkServiceProxies/{plsResourceName}-proxy.{guid}", + "groupConnectivityInformation": [ + { + "groupId": "DeviceUpdate", + "memberName": "adu" + } + ] + } + ] + } + } + } + } + } +} diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Delete.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Delete.json new file mode 100644 index 000000000000..761c0852b686 --- /dev/null +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Delete.json @@ -0,0 +1,14 @@ +{ + "parameters": { + "subscriptionId": "00000000-0000-0000-0000-000000000000", + "resourceGroupName": "test-rg", + "accountName": "contoso", + "privateEndpointConnectionProxyId": "peexample01", + "api-version": "2020-03-01-preview" + }, + "responses": { + "200": {}, + "202": {}, + "204": {} + } +} diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Get.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Get.json new file mode 100644 index 000000000000..263af356d019 --- /dev/null +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Get.json @@ -0,0 +1,43 @@ +{ + "parameters": { + "subscriptionId": "00000000-0000-0000-0000-000000000000", + "resourceGroupName": "test-rg", + "accountName": "contoso", + "privateEndpointConnectionProxyId": "peexample01", + "api-version": "2020-03-01-preview" + }, + "responses": { + "200": { + "body": { + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.DeviceUpdate/accounts/contoso/privateEndpointConnectionProxies/peexample01", + "name": "peexample01", + "type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnectionProxies", + "properties": { + "remotePrivateEndpoint": { + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", + "manualPrivateLinkServiceConnections": [ + { + "name": "{plsConnectionName}", + "groupIds": [ + "DeviceUpdate" + ], + "requestMessage": "Please approve my connection, thanks." + } + ], + "privateLinkServiceProxies": [ + { + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}/privateLinkServiceProxies/{plsResourceName}-proxy.{guid}", + "groupConnectivityInformation": [ + { + "groupId": "DeviceUpdate", + "memberName": "adu" + } + ] + } + ] + } + } + } + } + } +} diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json new file mode 100644 index 000000000000..051029bb522f --- /dev/null +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json @@ -0,0 +1,34 @@ +{ + "parameters": { + "subscriptionId": "00000000-0000-0000-0000-000000000000", + "resourceGroupName": "test-rg", + "accountName": "contoso", + "privateEndpointConnectionProxyId": "peexample01", + "api-version": "2020-03-01-preview", + "privateEndpointConnectionProxy": { + "properties": { + "remotePrivateEndpoint": { + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}", + "manualPrivateLinkServiceConnections": [ + { + "name": "{privateEndpointConnectionProxyId}", + "groupIds": [ + "DeviceUpdate" + ], + "requestMessage": "Please approve my connection, thanks." + } + ], + "privateLinkServiceProxies ": [ + { + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}/privateLinkServiceProxies/{plsResourceName}-proxy.{guid}", + "groupConnectivityInformation": [] + } + ] + } + } + } + }, + "responses": { + "200": {} + } +} From ecc2b1d349ee97ff85804c179583c333c16bda7f Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 13 Oct 2021 21:00:22 -0700 Subject: [PATCH 02/16] Fixed semantic validation error --- .../preview/2020-03-01-preview/deviceupdate.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 47641e11a1c6..0f0e7e4a2e6f 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -958,7 +958,7 @@ }, { "schema": { - "$ref": "#definitions/PrivateEndpointConnectionProxy" + "$ref": "#/definitions/PrivateEndpointConnectionProxy" }, "in": "body", "name": "request", From 7399e1aaabfeb8853ed2ac12c7a67b96ef684ff4 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 13 Oct 2021 21:05:49 -0700 Subject: [PATCH 03/16] prettier run --- .../2020-03-01-preview/deviceupdate.json | 56 +++++++++---------- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 0f0e7e4a2e6f..e212291f154a 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1487,12 +1487,12 @@ "description": "Private endpoint connection proxy object properties.", "type": "object", "properties": { - "eTag":{ + "eTag": { "description": "ETag from NRP.", "type": "string", "readOnly": true }, - "remotePrivateEndpoint":{ + "remotePrivateEndpoint": { "description": "Remote private endpoint details.", "$ref": "#/definitions/RemotePrivateEndpoint" } @@ -1505,38 +1505,38 @@ "description": "Remote private endpoint details.", "type": "object", "properties": { - "id":{ + "id": { "description": "Remote endpoint resource ID.", "type": "string", "readOnly": true }, - "vnetTrafficTag":{ + "vnetTrafficTag": { "description": "Virtual network traffic tag.", "type": "string", "readOnly": true }, - "manualPrivateLinkServiceConnections":{ + "manualPrivateLinkServiceConnections": { "description": "List of private link service connections that need manual approval.", "type": "array", "items": { "$ref": "#/definitions/PrivateLinkServiceConnection" } }, - "privateLinkServiceConnections":{ + "privateLinkServiceConnections": { "description": "List of automatically approved private link service connections.", "type": "array", "items": { "$ref": "#/definitions/PrivateLinkServiceConnection" } }, - "privateLinkServiceProxies":{ + "privateLinkServiceProxies": { "description": "List of private link service proxies.", "type": "array", "items": { "$ref": "#/definitions/PrivateLinkServiceProxy" } }, - "connectionDetails":{ + "connectionDetails": { "description": "List of connection details.", "type": "array", "items": { @@ -1552,19 +1552,19 @@ "description": "Private link service connection details.", "type": "object", "properties": { - "name":{ + "name": { "description": "Private link service connection name.", "type": "string", "readOnly": true }, - "groupIds":{ + "groupIds": { "description": "List of group IDs.", "type": "array", - "items":{ + "items": { "type": "string" } }, - "requestMessage":{ + "requestMessage": { "description": "Request message.", "type": "string", "readOnly": true @@ -1580,20 +1580,20 @@ "properties": { "remotePrivateLinkServiceConnectionState": { "description": "Remote private link service connection state", - "$ref":"../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateLinkServiceConnectionState" + "$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateLinkServiceConnectionState" }, - "remotePrivateEndpointConnection":{ + "remotePrivateEndpointConnection": { "description": "Remote private endpoint connection details.", - "allOf":[ + "allOf": [ { "$ref": "#/definitions/RemotePrivateEndpointConnection" } ] }, - "groupConnectivityInformation":{ + "groupConnectivityInformation": { "description": "Group connectivity information.", "type": "array", - "items":{ + "items": { "$ref": "#/definitions/GroupConnectivityInformation" } } @@ -1602,10 +1602,10 @@ "properties" ] }, - "RemotePrivateEndpointConnection":{ + "RemotePrivateEndpointConnection": { "description": "Remote private endpoint connection details.", "type": "object", - "properties":{ + "properties": { "id": { "description": "Remote private endpoint connection ID.", "type": "string", @@ -1617,24 +1617,24 @@ "description": "Group connectivity details.", "type": "object", "properties": { - "groupId":{ + "groupId": { "description": "Group ID.", "type": "string", "readOnly": true }, - "memberName":{ + "memberName": { "description": "Member name.", "type": "string", "readOnly": true }, - "customerVisibleFqdns":{ + "customerVisibleFqdns": { "description": "List of customer visible FQDNs.", "type": "array", "items": { "type": "string" } }, - "internalFqdn":{ + "internalFqdn": { "description": "Internal FQDN.", "type": "string", "readOnly": true @@ -1648,27 +1648,27 @@ "description": "Private endpoint connection proxy object properties.", "type": "object", "properties": { - "id":{ + "id": { "description": "Connection details ID.", "type": "string", "readOnly": true }, - "privateIpAddress":{ + "privateIpAddress": { "description": "Private IP address.", "type": "string", "readOnly": true }, - "linkIdentifier":{ + "linkIdentifier": { "description": "Link ID.", "type": "string", "readOnly": true }, - "groupId":{ + "groupId": { "description": "Group ID.", "type": "string", "readOnly": true }, - "memberName":{ + "memberName": { "description": "Member name.", "type": "string", "readOnly": true From a6ef876d0d5a6a213318d860557f8141e94cf68d Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 13 Oct 2021 21:16:31 -0700 Subject: [PATCH 04/16] Added list operation for NRP-only proxy type --- .../2020-03-01-preview/deviceupdate.json | 55 +++++++++++++++++++ ...EndpointConnectionProxy_ListByAccount.json | 46 ++++++++++++++++ 2 files changed, 101 insertions(+) create mode 100644 specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_ListByAccount.json diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index e212291f154a..67d9eec847f1 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -936,6 +936,48 @@ } } }, + "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeviceUpdate/accounts/{accountName}/privateEndpointConnectionProxies": { + "get": { + "tags": [ + "PrivateEndpointConnectionProxies" + ], + "description": "List all private endpoint connection proxies in a device update account.", + "operationId": "PrivateEndpointConnectionProxies_ListByAccount", + "parameters": [ + { + "$ref": "#/parameters/ApiVersionParameter" + }, + { + "$ref": "#/parameters/SubscriptionIdParameter" + }, + { + "$ref": "#/parameters/ResourceGroupNameParameter" + }, + { + "$ref": "#/parameters/AccountNameParameter" + } + ], + "responses": { + "200": { + "description": "The request was successful; the request was well-formed and received properly.", + "schema": { + "$ref": "#/definitions/PrivateEndpointConnectionProxyListResult" + } + }, + "default": { + "description": "Error response describing the reason for operation failure.", + "schema": { + "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorResponse" + } + } + }, + "x-ms-examples": { + "PrivateEndpointConnectionList": { + "$ref": "./examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_ListByAccount.json" + } + } + } + }, "/subscriptions/{subscriptionId}/providers/{resourceGroupName}/providers/Microsoft.DeviceUpdate/accounts/{accountName}/privateEndpointConnectionProxies/{privateEndpointConnectionProxyId}/validate": { "post": { "description": "Validates a private endpoint connection proxy object. (Network RP only)", @@ -1464,6 +1506,19 @@ } } }, + "PrivateEndpointConnectionProxyListResult": { + "description": "The available private endpoint connection proxies for an Account (not to be used by anyone, here because of ARM requirements)", + "type": "object", + "properties": { + "value": { + "description": "The list of available private endpoint connection proxies for an Account", + "type": "array", + "items": { + "$ref": "#/definitions/PrivateEndpointConnectionProxy" + } + } + } + }, "PrivateEndpointConnectionProxy": { "description": "Private endpoint connection proxy details.", "type": "object", diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_ListByAccount.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_ListByAccount.json new file mode 100644 index 000000000000..6df6e668a7d2 --- /dev/null +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_ListByAccount.json @@ -0,0 +1,46 @@ +{ + "parameters": { + "subscriptionId": "00000000-0000-0000-0000-000000000000", + "resourceGroupName": "test-rg", + "accountName": "contoso", + "api-version": "2020-03-01-preview" + }, + "responses": { + "200": { + "body": { + "value": [ + { + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.DeviceUpdate/accounts/contoso/privateEndpointConnectionProxies/peexample01", + "name": "peexample01", + "type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnectionProxies", + "properties": { + "remotePrivateEndpoint": { + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", + "manualPrivateLinkServiceConnections": [ + { + "name": "{plsConnectionName}", + "groupIds": [ + "DeviceUpdate" + ], + "requestMessage": "Please approve my connection, thanks." + } + ], + "privateLinkServiceProxies": [ + { + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}/privateLinkServiceProxies/{plsResourceName}-proxy.{guid}", + "groupConnectivityInformation": [ + { + "groupId": "DeviceUpdate", + "memberName": "adu" + } + ] + } + ] + } + } + } + ] + } + } + } +} From 2111e40fe99391fbc949dfec605646a083b59c8f Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 13 Oct 2021 21:21:07 -0700 Subject: [PATCH 05/16] Linter fixes --- .../preview/2020-03-01-preview/deviceupdate.json | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 67d9eec847f1..2e5a0be38311 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -972,9 +972,12 @@ } }, "x-ms-examples": { - "PrivateEndpointConnectionList": { + "PrivateEndpointConnectionProxyList": { "$ref": "./examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_ListByAccount.json" } + }, + "x-ms-pageable": { + "nextLinkName": null } } }, @@ -1516,6 +1519,10 @@ "items": { "$ref": "#/definitions/PrivateEndpointConnectionProxy" } + }, + "nextLink": { + "description": "The URI that can be used to request the next list of private endpoint connection proxies.", + "type": "string" } } }, From f00765fe1b9cf47ba1e32f9b8ab64461297fc127 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 13 Oct 2021 21:25:22 -0700 Subject: [PATCH 06/16] Removed properties requirement --- .../2020-03-01-preview/deviceupdate.json | 20 ++++--------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 2e5a0be38311..5cf757e4e4d5 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1558,10 +1558,7 @@ "description": "Remote private endpoint details.", "$ref": "#/definitions/RemotePrivateEndpoint" } - }, - "required": [ - "properties" - ] + } }, "RemotePrivateEndpoint": { "description": "Remote private endpoint details.", @@ -1605,10 +1602,7 @@ "$ref": "#/definitions/ConnectionDetails" } } - }, - "required": [ - "properties" - ] + } }, "PrivateLinkServiceConnection": { "description": "Private link service connection details.", @@ -1631,10 +1625,7 @@ "type": "string", "readOnly": true } - }, - "required": [ - "properties" - ] + } }, "PrivateLinkServiceProxy": { "description": "Private link service proxy details.", @@ -1659,10 +1650,7 @@ "$ref": "#/definitions/GroupConnectivityInformation" } } - }, - "required": [ - "properties" - ] + } }, "RemotePrivateEndpointConnection": { "description": "Remote private endpoint connection details.", From fde3dd855d42e8d36398f3b82211f5d24ff87f62 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 13 Oct 2021 21:32:49 -0700 Subject: [PATCH 07/16] Removed read-only flags --- .../preview/2020-03-01-preview/deviceupdate.json | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 5cf757e4e4d5..225618abc358 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1566,8 +1566,7 @@ "properties": { "id": { "description": "Remote endpoint resource ID.", - "type": "string", - "readOnly": true + "type": "string" }, "vnetTrafficTag": { "description": "Virtual network traffic tag.", @@ -1610,8 +1609,7 @@ "properties": { "name": { "description": "Private link service connection name.", - "type": "string", - "readOnly": true + "type": "string" }, "groupIds": { "description": "List of group IDs.", @@ -1622,8 +1620,7 @@ }, "requestMessage": { "description": "Request message.", - "type": "string", - "readOnly": true + "type": "string" } } }, From 0673d32a1f8760907c8fad4d36cd0bc3f9528fca Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 13 Oct 2021 21:42:56 -0700 Subject: [PATCH 08/16] Removing required from resources --- .../preview/2020-03-01-preview/deviceupdate.json | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 225618abc358..88dbd0d33b48 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1686,10 +1686,7 @@ "type": "string", "readOnly": true } - }, - "required": [ - "properties" - ] + } }, "ConnectionDetails": { "description": "Private endpoint connection proxy object properties.", @@ -1720,10 +1717,7 @@ "type": "string", "readOnly": true } - }, - "required": [ - "properties" - ] + } } }, "parameters": { From 19569f1d4c8cc1f4cdd7108c648b4faede8a00d8 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 13 Oct 2021 21:51:52 -0700 Subject: [PATCH 09/16] More required properties --- .../2020-03-01-preview/deviceupdate.json | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index 88dbd0d33b48..b516d3747d90 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1539,6 +1539,10 @@ "description": "Private endpoint connection proxy object properties.", "x-ms-client-flatten": true, "$ref": "#/definitions/PrivateEndpointConnectionProxyProperties" + }, + "provisioningState": { + "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", + "description": "The provisioning state of the private endpoint connection proxy resource." } }, "required": [ @@ -1718,6 +1722,21 @@ "readOnly": true } } + }, + "PrivateEndpointConnectionProxyProvisioningState": { + "type": "string", + "readOnly": true, + "description": "The current provisioning state.", + "enum": [ + "Succeeded", + "Creating", + "Deleting", + "Failed" + ], + "x-ms-enum": { + "name": "PrivateEndpointConnectionProxyProvisioningState", + "modelAsString": true + } } }, "parameters": { From a01827d0343665fc8617fc1516512cbed1f94e53 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 13 Oct 2021 22:01:39 -0700 Subject: [PATCH 10/16] More c&p error fixes --- .../preview/2020-03-01-preview/deviceupdate.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index b516d3747d90..f7c2d49aecf6 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1002,13 +1002,13 @@ "$ref": "#/parameters/PrivateEndpointConnectionProxyIdParameter" }, { - "schema": { - "$ref": "#/definitions/PrivateEndpointConnectionProxy" - }, + "name": "privateEndpointConnectionProxy", "in": "body", - "name": "request", + "description": "The parameters for creating a private endpoint connection proxy.", "required": true, - "description": "Private endpoint connection proxy request." + "schema": { + "$ref": "#/definitions/PrivateEndpointConnectionProxy" + } } ], "responses": { From 214e1cd8555365ed500684014ace824787d3904f Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 13 Oct 2021 22:11:47 -0700 Subject: [PATCH 11/16] Added missing property definition for remote proxy --- .../preview/2020-03-01-preview/deviceupdate.json | 4 ++++ .../PrivateEndpointConnectionProxy_CreateOrUpdate.json | 4 ++-- .../PrivateEndpointConnectionProxy_Get.json | 4 ++-- .../PrivateEndpointConnectionProxy_ListByAccount.json | 4 ++-- .../PrivateEndpointConnectionProxy_Validate.json | 2 +- 5 files changed, 11 insertions(+), 7 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index f7c2d49aecf6..aba7f9da5a80 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1632,6 +1632,10 @@ "description": "Private link service proxy details.", "type": "object", "properties": { + "id": { + "description": "NRP resource ID.", + "type": "string" + }, "remotePrivateLinkServiceConnectionState": { "description": "Remote private link service connection state", "$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateLinkServiceConnectionState" diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json index 57242cbcc21d..1b27aa06b171 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json @@ -36,7 +36,7 @@ "type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnectionProxies", "properties": { "remotePrivateEndpoint": { - "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}", "manualPrivateLinkServiceConnections": [ { "name": "{plsConnectionName}", @@ -48,7 +48,7 @@ ], "privateLinkServiceProxies": [ { - "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}/privateLinkServiceProxies/{plsResourceName}-proxy.{guid}", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}/privateLinkServiceProxies/{privateEndpointConnectionProxyId}", "groupConnectivityInformation": [ { "groupId": "DeviceUpdate", diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Get.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Get.json index 263af356d019..72b93aa0907b 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Get.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Get.json @@ -14,7 +14,7 @@ "type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnectionProxies", "properties": { "remotePrivateEndpoint": { - "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}", "manualPrivateLinkServiceConnections": [ { "name": "{plsConnectionName}", @@ -26,7 +26,7 @@ ], "privateLinkServiceProxies": [ { - "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}/privateLinkServiceProxies/{plsResourceName}-proxy.{guid}", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}/privateLinkServiceProxies/{privateEndpointConnectionProxyId}", "groupConnectivityInformation": [ { "groupId": "DeviceUpdate", diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_ListByAccount.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_ListByAccount.json index 6df6e668a7d2..5c1b3f45b264 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_ListByAccount.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_ListByAccount.json @@ -15,7 +15,7 @@ "type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnectionProxies", "properties": { "remotePrivateEndpoint": { - "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}", "manualPrivateLinkServiceConnections": [ { "name": "{plsConnectionName}", @@ -27,7 +27,7 @@ ], "privateLinkServiceProxies": [ { - "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}/privateLinkServiceProxies/{plsResourceName}-proxy.{guid}", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}/privateLinkServiceProxies/{privateEndpointConnectionProxyId}", "groupConnectivityInformation": [ { "groupId": "DeviceUpdate", diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json index 051029bb522f..5437caabd1db 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json @@ -20,7 +20,7 @@ ], "privateLinkServiceProxies ": [ { - "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}/privateLinkServiceProxies/{plsResourceName}-proxy.{guid}", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}/privateLinkServiceProxies/{privateEndpointConnectionProxyId}", "groupConnectivityInformation": [] } ] From 8957c076c06c36358631cf36a5a009f002f0f917 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 13 Oct 2021 22:19:07 -0700 Subject: [PATCH 12/16] Wrong place for provisioning state --- .../preview/2020-03-01-preview/deviceupdate.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index aba7f9da5a80..cde5ba4387aa 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -1539,10 +1539,6 @@ "description": "Private endpoint connection proxy object properties.", "x-ms-client-flatten": true, "$ref": "#/definitions/PrivateEndpointConnectionProxyProperties" - }, - "provisioningState": { - "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", - "description": "The provisioning state of the private endpoint connection proxy resource." } }, "required": [ @@ -1561,6 +1557,10 @@ "remotePrivateEndpoint": { "description": "Remote private endpoint details.", "$ref": "#/definitions/RemotePrivateEndpoint" + }, + "provisioningState": { + "$ref": "#/definitions/PrivateEndpointConnectionProxyProvisioningState", + "description": "The provisioning state of the private endpoint connection proxy resource." } } }, From b5408ca45b4193283936689d1529db7b95fc2e2d Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 13 Oct 2021 22:22:27 -0700 Subject: [PATCH 13/16] Rogue space --- .../PrivateEndpointConnectionProxy_Validate.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json index 5437caabd1db..a06b274c950a 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_Validate.json @@ -18,7 +18,7 @@ "requestMessage": "Please approve my connection, thanks." } ], - "privateLinkServiceProxies ": [ + "privateLinkServiceProxies": [ { "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}/privateLinkServiceProxies/{privateEndpointConnectionProxyId}", "groupConnectivityInformation": [] From af2e02c0ff14a4979823d84a4a1ee56b017146b9 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 13 Oct 2021 22:27:44 -0700 Subject: [PATCH 14/16] Fixed an example --- .../PrivateEndpointConnectionProxy_CreateOrUpdate.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json index 1b27aa06b171..da332174772e 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json @@ -20,7 +20,7 @@ ], "privateLinkServiceProxies ": [ { - "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{peName}/privateLinkServiceProxies/{plsResourceName}-proxy.{guid}", + "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}/privateLinkServiceProxies/{privateEndpointConnectionProxyId}", "groupConnectivityInformation": [] } ] From b7104e47309f5d05cd6526d9e24f21fa69659685 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 13 Oct 2021 23:04:48 -0700 Subject: [PATCH 15/16] Another rogue space --- .../PrivateEndpointConnectionProxy_CreateOrUpdate.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json index da332174772e..6ffd47be39b8 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/PrivateEndpointConnectionProxies/PrivateEndpointConnectionProxy_CreateOrUpdate.json @@ -18,7 +18,7 @@ "requestMessage": "Please approve my connection, thanks." } ], - "privateLinkServiceProxies ": [ + "privateLinkServiceProxies": [ { "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/{privateEndpointConnectionProxyId}/privateLinkServiceProxies/{privateEndpointConnectionProxyId}", "groupConnectivityInformation": [] From 671b796b1560feb131b7a2fa78501e83d481a265 Mon Sep 17 00:00:00 2001 From: Darko Aleksic Date: Wed, 20 Oct 2021 07:26:42 -0700 Subject: [PATCH 16/16] Added internal note to descriptions --- .../preview/2020-03-01-preview/deviceupdate.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json index cde5ba4387aa..d078ed943449 100644 --- a/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json +++ b/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json @@ -941,7 +941,7 @@ "tags": [ "PrivateEndpointConnectionProxies" ], - "description": "List all private endpoint connection proxies in a device update account.", + "description": "(INTERNAL - DO NOT USE) List all private endpoint connection proxies in a device update account.", "operationId": "PrivateEndpointConnectionProxies_ListByAccount", "parameters": [ { @@ -983,7 +983,7 @@ }, "/subscriptions/{subscriptionId}/providers/{resourceGroupName}/providers/Microsoft.DeviceUpdate/accounts/{accountName}/privateEndpointConnectionProxies/{privateEndpointConnectionProxyId}/validate": { "post": { - "description": "Validates a private endpoint connection proxy object. (Network RP only)", + "description": "(INTERNAL - DO NOT USE) Validates a private endpoint connection proxy object.", "operationId": "PrivateEndpointConnectionProxies_Validate", "parameters": [ { @@ -1035,7 +1035,7 @@ "tags": [ "PrivateEndpointConnections" ], - "description": "Get the specified private endpoint connection proxy associated with the device update account.", + "description": "(INTERNAL - DO NOT USE) Get the specified private endpoint connection proxy associated with the device update account.", "operationId": "PrivateEndpointConnectionProxies_Get", "parameters": [ { @@ -1078,7 +1078,7 @@ "tags": [ "PrivateEndpointConnectionProxies" ], - "description": "Creates or updates the specified private endpoint connection proxy resource associated with the device update account.", + "description": "(INTERNAL - DO NOT USE) Creates or updates the specified private endpoint connection proxy resource associated with the device update account.", "operationId": "PrivateEndpointConnectionProxies_CreateOrUpdate", "parameters": [ { @@ -1134,7 +1134,7 @@ "tags": [ "PrivateEndpointConnectionProxies" ], - "description": "Deletes the specified private endpoint connection proxy associated with the device update account.", + "description": "(INTERNAL - DO NOT USE) Deletes the specified private endpoint connection proxy associated with the device update account.", "operationId": "PrivateEndpointConnectionProxies_Delete", "parameters": [ {