Skip to content

Network february release #14333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lirenhe merged 24 commits into from
May 11, 2021
Merged

Network february release #14333

lirenhe merged 24 commits into from
May 11, 2021

Conversation

@MikhailTryakhov
Copy link
Contributor

@MikhailTryakhov MikhailTryakhov commented May 10, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    All of them below:
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

MikhailTryakhov and others added 23 commits March 16, 2021 13:44
@MikhailTryakhov
Adds base for updating Microsoft.Network from version stable/2020-11-…
570033e 
…01 to version 2021-02-01
@MikhailTryakhov
Updates readme
b222885
@MikhailTryakhov
Updates API version in new specs and examples
c2e7068
@matyang22
init (#13496)
d7829b4 
Co-authored-by: matyang222 <matthew.yang@microsoft.com>
@gitlwh
Swagger change for CustomIpPrefix. Adding four new attributes. (#13456)
ab22f19 
* update swagger

* fix apiversion

* fix

* add

Co-authored-by: Weiheng Li <weihl@microsoft.com>
@nschonni
typo: paramter in applicationGateway.json (#13538)
f432c7c
@Khushboo-Baheti
VPN NAT for Virtual Network Gateway feature changes(networkFeb) (#13481)
24b10b5 
* commit1

* commit2

* resolving comments

* pythonMd

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
@guptas14
fix virtual network resource (#13570)
0033a15
@Satya-anshu
Added a new feature FlowTimeoutInMinutes under Virtual Network Proper… (
589749c 
#13519)

* Added a new feature FlowTimeoutInMinutes under Virtual Network Properties

* Updated the type from string to integer, added a non-null example

* Added missing format for 'integer' type
@gitlwh
Add new failedMessage property for CustomIpPrefix (#13607)
46733ce 
* update swagger

* fix apiversion

* fix

* add

* add failedreason property

* update swagger

* fix apiversion

* fix

* add failedreason property

* update

Co-authored-by: Weiheng Li <weihl@microsoft.com>
@arvenka
Added Preferred Routing Gateway Support (#13611)
febc72a
@harics24
Feature: Address space update in peered vNets (#13521)
0b42be6 
* Adding new fields and operation to support the address space update in peered vNets

Adding new fields and operation to support the address space update in peered vNets

* Adding the new query param in the example

As per the review comment, adding the new query param in the example request response of swagger.

* Adding the new query param in examples

Adding the new query param in examples

* Restricting the sync param

Restricting the sync param to hold only true as value. We never need to send false.

Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
@tejasshah7
Remove max file size limit enforcement as it is done in NRP (#13679)
336c1e7
@tejasshah7
Tesha/fix waf policy examples crs version (#13697)
dcc22b3 
* Remove max file size limit enforcement as it is done in NRP

* Update the CRS version in the examples to reflect latest
@Khushboo-Baheti
Fix (#13734)
7bdbb34 
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
@shnaya434
Swagger for NRP's VipSwap operation (#13639)
db58b69 
* Swagger for NRP's VipSwap operation

* Fixing validation errors

* minor fix

* Adding api version
@wdehrich
Remove required (#13969)
cfcb423 
Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
@litchiyangMSFT
Hotfix extended location parameter hierarchy (#13864)
4d7132d 
* add to feb branch

* delete project name reference
@3quanfeng
expose two new client cert properties: validatedCertData, clientCertI…
2f51c3a 
…ssuerDN (#13989)
@bhbhise
adding workloadType property for Baremetal scenarios (#14101)
0d7fa32
@mscorp-buchen
Added bastion sku (#14248)
a42d44d
@guptas14
fix nrp resources based on s360 checks (#14219)
45a3599
@aragar740
Adding Azure Network Manager association to the EffectiveNetworkSecur…
150fe7b 
…ityGroups API (#14265)

* Added Azure Network Manager association to the EffectiveNetworkSecurityGroupAssociation

* Adding example for networkManager response in the EffectiveNSG call
@openapi-workflow-bot
Copy link

openapi-workflow-bot bot commented May 10, 2021

Hi, @MikhailTryakhov Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    This was referenced May 11, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @MikhailTryakhov MikhailTryakhov mentioned this pull request May 11, 2021
    Merged
    10 tasks
    @MikhailTryakhov MikhailTryakhov deleted the network-february-release branch June 28, 2023 21:11
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @lirenhe lirenhe lirenhe approved these changes

    @00Kai0 00Kai0 Awaiting requested review from 00Kai0

    @jsntcy jsntcy Awaiting requested review from jsntcy jsntcy is a code owner

    @msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner

    @qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

    @RAY-316 RAY-316 Awaiting requested review from RAY-316

    @zhangyan133 zhangyan133 Awaiting requested review from zhangyan133

    Assignees

    @lirenhe lirenhe

    Labels

    Approved-Avocado CI-BreakingChange-Go Network

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.