From fd2b99d48adc7a047131f498c988d01a55053497 Mon Sep 17 00:00:00 2001 From: Itai Yankelevsky Date: Tue, 20 Apr 2021 13:07:36 +0300 Subject: [PATCH 1/3] Fix SecurityInsights Go SDK versioning --- .../securityinsights/resource-manager/readme.go.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/specification/securityinsights/resource-manager/readme.go.md b/specification/securityinsights/resource-manager/readme.go.md index d55414e9d34e..cee96c298acb 100644 --- a/specification/securityinsights/resource-manager/readme.go.md +++ b/specification/securityinsights/resource-manager/readme.go.md @@ -14,6 +14,7 @@ go: ```yaml $(go) && $(multiapi) batch: - tag: package-composite-v1 + - tag: package-2021-03-preview-only - tag: package-2019-01-preview-only ``` @@ -23,15 +24,15 @@ These settings apply only when `--tag=package-composite-v1 --go` is specified on Please also specify `--go-sdk-folder=`. ```yaml $(tag) == 'package-composite-v1' && $(go) -output-folder: $(go-sdk-folder)/services/$(namespace)/mgmt/v1.0/$(namespace) +output-folder: $(go-sdk-folder)/services/$(namespace)/mgmt/2020-01-01/$(namespace) ``` ### Tag: package-2021-03-preview-only and go These settings apply only when `--tag=package-2021-03-preview-only --go` is specified on the command line. Please also specify `--go-sdk-folder=`. -```yaml $(tag) == 'package-2019-01-preview-only' && $(go) -output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2019-01-01-preview/$(namespace) +```yaml $(tag) == 'package-2021-03-preview-only' && $(go) +output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2021-03-01-preview/$(namespace) ``` ### Tag: package-2019-01-preview-only and go From f768a303e07228673ccb4f0f83803f98e88b42f4 Mon Sep 17 00:00:00 2001 From: Itai Yankelevsky Date: Tue, 20 Apr 2021 13:19:55 +0300 Subject: [PATCH 2/3] rename stable api version tag --- .../securityinsights/resource-manager/readme.go.md | 8 ++++---- specification/securityinsights/resource-manager/readme.md | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/specification/securityinsights/resource-manager/readme.go.md b/specification/securityinsights/resource-manager/readme.go.md index cee96c298acb..a0030cf49846 100644 --- a/specification/securityinsights/resource-manager/readme.go.md +++ b/specification/securityinsights/resource-manager/readme.go.md @@ -13,17 +13,17 @@ go: ```yaml $(go) && $(multiapi) batch: - - tag: package-composite-v1 + - tag: package-2020-01-only - tag: package-2021-03-preview-only - tag: package-2019-01-preview-only ``` -### Tag: package-composite-v1 and go +### Tag: package-2020-01-only and go -These settings apply only when `--tag=package-composite-v1 --go` is specified on the command line. +These settings apply only when `--tag=package-2020-01-only --go` is specified on the command line. Please also specify `--go-sdk-folder=`. -```yaml $(tag) == 'package-composite-v1' && $(go) +```yaml $(tag) == 'package-2020-01-only' && $(go) output-folder: $(go-sdk-folder)/services/$(namespace)/mgmt/2020-01-01/$(namespace) ``` ### Tag: package-2021-03-preview-only and go diff --git a/specification/securityinsights/resource-manager/readme.md b/specification/securityinsights/resource-manager/readme.md index 2e3d16cc64ba..3c0bd7e5e851 100644 --- a/specification/securityinsights/resource-manager/readme.md +++ b/specification/securityinsights/resource-manager/readme.md @@ -26,14 +26,14 @@ These are the global settings for the SecurityInsights API. ```yaml openapi-type: arm -tag: package-composite-v1 +tag: package-2020-01-only ``` ### Tag: package-composite-v1 -These settings apply only when `--tag=package-composite-v1` is specified on the command line. +These settings apply only when `--tag=package-2020-01-only` is specified on the command line. -```yaml $(tag) == 'package-composite-v1' +```yaml $(tag) == 'package-2020-01-only' input-file: - Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json directive: From e463f7e1eeec6318968c6c7be91129cfcccfd2d1 Mon Sep 17 00:00:00 2001 From: Itai Yankelevsky Date: Thu, 22 Apr 2021 10:11:50 +0300 Subject: [PATCH 3/3] remove 'only' from tags with full functionality --- .../resource-manager/readme.go.md | 25 ++++++------------- .../resource-manager/readme.md | 14 +++++------ 2 files changed, 15 insertions(+), 24 deletions(-) diff --git a/specification/securityinsights/resource-manager/readme.go.md b/specification/securityinsights/resource-manager/readme.go.md index a0030cf49846..5d0a3c224e75 100644 --- a/specification/securityinsights/resource-manager/readme.go.md +++ b/specification/securityinsights/resource-manager/readme.go.md @@ -13,33 +13,24 @@ go: ```yaml $(go) && $(multiapi) batch: - - tag: package-2020-01-only - - tag: package-2021-03-preview-only - - tag: package-2019-01-preview-only + - tag: package-2020-01 + - tag: package-2019-01-preview ``` -### Tag: package-2020-01-only and go +### Tag: package-2020-01 and go -These settings apply only when `--tag=package-2020-01-only --go` is specified on the command line. +These settings apply only when `--tag=package-2020-01 --go` is specified on the command line. Please also specify `--go-sdk-folder=`. -```yaml $(tag) == 'package-2020-01-only' && $(go) +```yaml $(tag) == 'package-2020-01' && $(go) output-folder: $(go-sdk-folder)/services/$(namespace)/mgmt/2020-01-01/$(namespace) ``` -### Tag: package-2021-03-preview-only and go -These settings apply only when `--tag=package-2021-03-preview-only --go` is specified on the command line. -Please also specify `--go-sdk-folder=`. - -```yaml $(tag) == 'package-2021-03-preview-only' && $(go) -output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2021-03-01-preview/$(namespace) -``` - -### Tag: package-2019-01-preview-only and go +### Tag: package-2019-01-preview and go -These settings apply only when `--tag=package-2019-01-preview-only --go` is specified on the command line. +These settings apply only when `--tag=package-2019-01-preview --go` is specified on the command line. Please also specify `--go-sdk-folder=`. -```yaml $(tag) == 'package-2019-01-preview-only' && $(go) +```yaml $(tag) == 'package-2019-01-preview' && $(go) output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2019-01-01-preview/$(namespace) ``` diff --git a/specification/securityinsights/resource-manager/readme.md b/specification/securityinsights/resource-manager/readme.md index 3c0bd7e5e851..5d1ba0604aa9 100644 --- a/specification/securityinsights/resource-manager/readme.md +++ b/specification/securityinsights/resource-manager/readme.md @@ -26,14 +26,14 @@ These are the global settings for the SecurityInsights API. ```yaml openapi-type: arm -tag: package-2020-01-only +tag: package-2020-01 ``` -### Tag: package-composite-v1 +### Tag: package-2020-01 -These settings apply only when `--tag=package-2020-01-only` is specified on the command line. +These settings apply only when `--tag=package-2020-01` is specified on the command line. -```yaml $(tag) == 'package-2020-01-only' +```yaml $(tag) == 'package-2020-01' input-file: - Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json directive: @@ -62,11 +62,11 @@ directive: --- -### Tag: package-2019-01-preview-only +### Tag: package-2019-01-preview -These settings apply only when `--tag=package-2019-01-preview-only` is specified on the command line. +These settings apply only when `--tag=package-2019-01-preview` is specified on the command line. -```yaml $(tag) == 'package-2019-01-preview-only' +```yaml $(tag) == 'package-2019-01-preview' input-file: - Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json directive: