Add minimal TLS version support for the MariaDB service #11779

ThomasDai · 2020-11-23T02:35:56Z

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
December, 2020.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
December, 2020.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2020-11-23T02:35:59Z

Hi, @ThomasDai Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2020-11-23T02:36:00Z

Swagger Validation Report

️❌BreakingChange: 18 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.9)
- original: preview/2018-06-01-preview/mariadb.json <---> new: preview/2018-06-01-preview/mariadb.json
- original: preview/2018-06-01-privatepreview/mariadb.json <---> new: preview/2018-06-01-privatepreview/mariadb.json
- original: stable/2018-06-01/mariadb.json <---> new: stable/2018-06-01/mariadb.json

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'minimalTlsVersion' in response that was not found in the old version. New: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1525:7 Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1511:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'minimalTlsVersion' in response that was not found in the old version. New: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1898:7 Old: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1884:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'minimalTlsVersion' in response that was not found in the old version. New: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1602:7 Old: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1588:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'minimalTlsVersion' that was not found in the old version. New: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1629:7 Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1611:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'minimalTlsVersion' that was not found in the old version. New: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1670:7 Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1648:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'minimalTlsVersion' that was not found in the old version. New: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1695:7 Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1673:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'minimalTlsVersion' that was not found in the old version. New: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1719:7 Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1697:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'minimalTlsVersion' that was not found in the old version. New: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1737:7 Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1715:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'minimalTlsVersion' that was not found in the old version. New: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L2001:7 Old: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1983:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'minimalTlsVersion' that was not found in the old version. New: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L2042:7 Old: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L2020:7

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L66
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L102
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L151
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L194
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L240
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L279
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L315
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L66
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L102
`❌` R4010 - RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.DBforMariaDB/stable/2018-06-01/PerformanceRecommendations.json#L151

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/mariadb/resource-manager/readme.md tag: specification/mariadb/resource-manager/readme.md#tag-package-2020-01-01

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️❌[Staging] SDK Track2 Validation: 2 Errors, 0 Warnings failed [Detail]

The following tags are being changed in this PR

The following errors/warnings are introduced by current PR:

Rule	Message
`❌` PreCheck/DuplicateSchema	"readme":"mariadb/resource-manager/readme.md", "tag":"package-2018-06-01-privatepreview", "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:224" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"mariadb/resource-manager/readme.md", "tag":"package-2018-06-01-privatepreview", "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:228" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` AutorestCore/Exception	"readme":"mariadb/resource-manager/readme.md", "tag":"package-2018-06-01-privatepreview", "details":"Error: Plugin prechecker reported failure."
`❌` PreCheck/DuplicateSchema	"readme":"mariadb/resource-manager/readme.md", "tag":"package-2020-01-01", "details":"Duplicate Schema named CloudError -- properties.error.description: undefined => "Error message" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` AutorestCore/Exception	"readme":"mariadb/resource-manager/readme.md", "tag":"package-2020-01-01", "details":"Error: Plugin prechecker reported failure."
⚠️ PreCheck/PropertyRedeclarationWarning	"readme":"mariadb/resource-manager/readme.md", "tag":"package-2018-06-01-preview", "details":"Schema 'LogFile' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from LogFile"
⚠️ PreCheck/PropertyRedeclarationWarning	"readme":"mariadb/resource-manager/readme.md", "tag":"package-2018-06-01", "details":"Schema 'LogFile' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from LogFile"
⚠️ ?	"readme":"mariadb/resource-manager/readme.md", "tag":"package-2018-06-01", "details":"Operation 'TopQueryStatistics/ListByServer' really should not have a media type (because there should be no body)"
⚠️ ?	"readme":"mariadb/resource-manager/readme.md", "tag":"package-2018-06-01", "details":"Operation 'WaitStatistics/ListByServer' really should not have a media type (because there should be no body)"
⚠️ PreCheck/PropertyRedeclarationWarning	"readme":"mariadb/resource-manager/readme.md", "tag":"package-2018-06-01-privatepreview", "details":"Schema 'LogFile' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from LogFile"
⚠️ PreCheck/PropertyRedeclarationWarning	"readme":"mariadb/resource-manager/readme.md", "tag":"package-2020-01-01", "details":"Schema 'LogFile' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from LogFile"

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2020-11-23T02:36:01Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 349526e. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️mariadb/mgmt/2020-01-01/mariadb [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 60 items here, please refer to log for details.

info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightDataPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `NewServerParametersClientWithBaseURI(string, string) ServerParametersClient`
info	[Changelog] - New function `PossibleQueryPerformanceInsightResetDataResultStateValues() []QueryPerformanceInsightResetDataResultState`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.NotDone() bool`
info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultIterator.NextWithContext(context.Context) error`
info	[Changelog] - New function `RecoverableServersClient.GetResponder(*http.Response) (RecoverableServerResource, error)`
info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsResponder(*http.Response) (ConfigurationListResult, error)`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Response() ServerSecurityAlertPolicyListResult`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.NotDone() bool`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerResponder(*http.Response) (ServerSecurityAlertPolicyListResult, error)`
info	[Changelog] - New function `NewServerParametersClient(string) ServerParametersClient`
info	[Changelog] - New function `RecoverableServerResource.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.List(context.Context, string, string) (PerformanceTierListResult, error)`
info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultPage.Next() error`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServer(context.Context, string, string) (ServerSecurityAlertPolicyListResultPage, error)`
info	[Changelog] - New function `NewServerBasedPerformanceTierClientWithBaseURI(string, string) ServerBasedPerformanceTierClient`
info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightDataSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerComplete(context.Context, string, string) (ServerSecurityAlertPolicyListResultIterator, error)`
info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultIterator.Next() error`
info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurations(context.Context, string, string, ConfigurationListResult) (ServerParametersListUpdateConfigurationsFuture, error)`
info	[Changelog] - New function `NewServerBasedPerformanceTierClient(string) ServerBasedPerformanceTierClient`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Values() []ServerSecurityAlertPolicy`
info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultIterator(ServerSecurityAlertPolicyListResultPage) ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New function `RecoverableServersClient.GetPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `*ServerParametersListUpdateConfigurationsFuture.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `NewRecoverableServersClientWithBaseURI(string, string) RecoverableServersClient`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.Response() ServerSecurityAlertPolicyListResult`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListResponder(*http.Response) (PerformanceTierListResult, error)`
info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultPage(ServerSecurityAlertPolicyListResult, func(context.Context, ServerSecurityAlertPolicyListResult) (ServerSecurityAlertPolicyListResult, error)) ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsPreparer(context.Context, string, string, ConfigurationListResult) (*http.Request, error)`
info	[Changelog] - New struct `QueryPerformanceInsightResetDataResult`
info	[Changelog] - New struct `RecoverableServerProperties`
info	[Changelog] - New struct `RecoverableServerResource`
info	[Changelog] - New struct `RecoverableServersClient`
info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
info	[Changelog] - New struct `ServerParametersClient`
info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerUpdateParametersProperties`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForRestore`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForReplica`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForGeoRestore`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerProperties`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForDefaultCreate`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForCreate`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 81 additive change(s).
info	[Changelog]

️✔️mariadb/mgmt/2018-06-01/mariadb [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 60 items here, please refer to log for details.

info	[Changelog] - New function `NewServerBasedPerformanceTierClientWithBaseURI(string, string) ServerBasedPerformanceTierClient`
info	[Changelog] - New function `RecoverableServersClient.Get(context.Context, string, string) (RecoverableServerResource, error)`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerComplete(context.Context, string, string) (ServerSecurityAlertPolicyListResultIterator, error)`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultPage(ServerSecurityAlertPolicyListResult, func(context.Context, ServerSecurityAlertPolicyListResult) (ServerSecurityAlertPolicyListResult, error)) ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New function `NewServerParametersClient(string) ServerParametersClient`
info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightDataSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultIterator.NextWithContext(context.Context) error`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.Value() ServerSecurityAlertPolicy`
info	[Changelog] - New function `PossibleQueryPerformanceInsightResetDataResultStateValues() []QueryPerformanceInsightResetDataResultState`
info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsResponder(*http.Response) (ConfigurationListResult, error)`
info	[Changelog] - New function `NewServerParametersClientWithBaseURI(string, string) ServerParametersClient`
info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsSender(*http.Request) (ServerParametersListUpdateConfigurationsFuture, error)`
info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightDataPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `*RecoverableServerResource.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultPage.Next() error`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultPage.NextWithContext(context.Context) error`
info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultIterator(ServerSecurityAlertPolicyListResultPage) ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Response() ServerSecurityAlertPolicyListResult`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.List(context.Context, string, string) (PerformanceTierListResult, error)`
info	[Changelog] - New function `RecoverableServersClient.GetResponder(*http.Response) (RecoverableServerResource, error)`
info	[Changelog] - New function `RecoverableServersClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.NotDone() bool`
info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsPreparer(context.Context, string, string, ConfigurationListResult) (*http.Request, error)`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServer(context.Context, string, string) (ServerSecurityAlertPolicyListResultPage, error)`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.NotDone() bool`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerResponder(*http.Response) (ServerSecurityAlertPolicyListResult, error)`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Values() []ServerSecurityAlertPolicy`
info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListResponder(*http.Response) (PerformanceTierListResult, error)`
info	[Changelog] - New function `NewRecoverableServersClient(string) RecoverableServersClient`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResult.IsEmpty() bool`
info	[Changelog] - New function `*ServerParametersListUpdateConfigurationsFuture.UnmarshalJSON([]byte) error`
info	[Changelog] - New struct `QueryPerformanceInsightResetDataResult`
info	[Changelog] - New struct `RecoverableServerProperties`
info	[Changelog] - New struct `RecoverableServerResource`
info	[Changelog] - New struct `RecoverableServersClient`
info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
info	[Changelog] - New struct `ServerParametersClient`
info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForCreate`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForRestore`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerUpdateParametersProperties`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForGeoRestore`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForReplica`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerPropertiesForDefaultCreate`
info	[Changelog] - New field `MinimalTLSVersion` in struct `ServerProperties`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 81 additive change(s).
info	[Changelog]

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 349526e. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-04-13 01:39:15 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-mariadb"
cmderr	[generate.py] 2021-04-13 01:39:15 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-04-13 01:39:15 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.23 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/mariadb/azure-resourcemanager-mariadb --java.namespace=com.azure.resourcemanager.mariadb   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
cmderr	[generate.py] 2021-04-13 01:39:48 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-04-13 01:39:48 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-04-13 01:39:48 INFO [POM][Skip] pom already has module azure-resourcemanager-mariadb
cmderr	[generate.py] 2021-04-13 01:39:48 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-04-13 01:39:48 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-04-13 01:39:48 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-mariadb [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-04-13 01:43:06 DEBUG Got artifact_id: azure-resourcemanager-mariadb
cmderr	[Inst] 2021-04-13 01:43:06 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-04-13 01:43:06 DEBUG Got artifact: azure-resourcemanager-mariadb-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-04-13 01:43:06 DEBUG Got artifact: azure-resourcemanager-mariadb-1.0.0-beta.1.jar
cmderr	[Inst] 2021-04-13 01:43:06 DEBUG Match jar package: azure-resourcemanager-mariadb-1.0.0-beta.1.jar
cmderr	[Inst] 2021-04-13 01:43:06 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/11779/azure-sdk-for-java/azure-resourcemanager-mariadb/azure-resourcemanager-mariadb-1.0.0-beta.1.jar\" -o azure-resourcemanager-mariadb-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-mariadb -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-mariadb-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 349526e. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md

️✔️@azure/arm-mariadb [View full logs] [Release SDK Changes]

azure-arm-mariadb-1.4.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/mariaDBManagementClient.js → ./dist/arm-mariadb.js...
cmderr	[npmPack] created ./dist/arm-mariadb.js in 534ms

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 349526e. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.MariaDB [View full logs] [Release SDK Changes]
```
warn	Skip artifact folder because it doesn't exist: artifacts/packages
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 349526e. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️mariadb [View full logs] [Release Schema Changes]

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 349526e. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-rdbms [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation MariaDBManagementClientOperationsMixin.reset_query_performance_insight_data
info	[Changelog]   - Added operation group ServerParametersOperations
info	[Changelog]   - Added operation group RecoverableServersOperations
info	[Changelog]   - Added operation group ServerBasedPerformanceTierOperations

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

ghost · 2020-11-23T02:36:01Z

Thank you for your contribution ThomasDai! We will review the pull request and get back to you soon.

ghost · 2020-11-23T02:36:11Z

All CLA requirements met.

leniatgh · 2020-11-23T07:11:58Z

/azp run

azure-pipelines · 2020-11-23T07:12:14Z

Azure Pipelines successfully started running 2 pipeline(s).

openapi-workflow-bot · 2020-11-23T07:13:56Z

Hi @ThomasDai, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

ghost · 2020-12-22T15:02:12Z

Hi, ThomasDai. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2021-03-22T03:03:22Z

Hi, @ThomasDai. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee @leni-msft.

openapi-workflow-bot · 2021-04-12T10:46:59Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

add minimal tls version for mariadb

b0cefba

openapi-assignment-bot bot assigned leniatgh Nov 23, 2020

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 23, 2020

openapi-pipeline-app bot added CI-BreakingChange-Python CI-BreakingChange-Go labels Nov 23, 2020

leniatgh added the BreakingChangeReviewRequired label Nov 23, 2020

ghost added the no-recent-activity label Dec 22, 2020

ghost closed this Mar 22, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 9, 2021

ghost removed the no-recent-activity label Apr 9, 2021

leniatgh reopened this Apr 12, 2021

openapi-pipeline-app bot added the NewApiVersionRequired label Apr 12, 2021

openapi-pipeline-app bot removed the CI-BreakingChange-Python label Apr 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add minimal TLS version support for the MariaDB service #11779

Add minimal TLS version support for the MariaDB service #11779

Uh oh!

ThomasDai commented Nov 23, 2020 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Nov 23, 2020

Uh oh!

openapi-pipeline-app bot commented Nov 23, 2020 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Nov 23, 2020 •

edited

Loading

Uh oh!

ghost commented Nov 23, 2020

Uh oh!

ghost commented Nov 23, 2020 •

edited by ghost

Loading

Uh oh!

leniatgh commented Nov 23, 2020

Uh oh!

azure-pipelines bot commented Nov 23, 2020

Uh oh!

openapi-workflow-bot bot commented Nov 23, 2020

Uh oh!

ghost commented Dec 22, 2020

Uh oh!

ghost commented Mar 22, 2021

Uh oh!

openapi-workflow-bot bot commented Apr 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add minimal TLS version support for the MariaDB service #11779

Add minimal TLS version support for the MariaDB service #11779

Uh oh!

Conversation

ThomasDai commented Nov 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Nov 23, 2020

Uh oh!

openapi-pipeline-app bot commented Nov 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Nov 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

ghost commented Nov 23, 2020

Uh oh!

ghost commented Nov 23, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leniatgh commented Nov 23, 2020

Uh oh!

azure-pipelines bot commented Nov 23, 2020

Uh oh!

openapi-workflow-bot bot commented Nov 23, 2020

Uh oh!

ghost commented Dec 22, 2020

Uh oh!

ghost commented Mar 22, 2021

Uh oh!

openapi-workflow-bot bot commented Apr 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ThomasDai commented Nov 23, 2020 •

edited

Loading

openapi-pipeline-app bot commented Nov 23, 2020 •

edited

Loading

openapi-pipeline-app bot commented Nov 23, 2020 •

edited

Loading

ghost commented Nov 23, 2020 •

edited by ghost

Loading