Swagger correctness fixes (#15520)

* Adding 2020-09-Preview same as 11-preview

* fixing lint issue

* fixing model

* fixing model

* fixing model

* pretify fix

* fixing linting

* more linting fix

* fixing swagger correctness

* swagger correctness fixes

* fixing errors

Author: rkapso

specification/billing/resource-manager/Microsoft.Billing/preview/2020-09-01-preview/billingPromotions.json

@@ -47,7 +47,7 @@
           "Promotion, Activate"
         ],
         "responses": {
-          "200": {
+          "202": {
             "description": "The resource has been created",
             "schema": {
               "$ref": "#/definitions/PromotionResponse"
@@ -331,6 +331,10 @@
           "type": "string",
           "description": "Reason in case the subscription is not eligible for promotion."
         },
+        "details": {
+          "type": "string",
+          "description": "Details in case the subscription is not eligible for promotion."
+        },
         "eligibilitySubscriptionId": {
           "type": "string",
           "description": "Subscription Id on which the eligibility check was performed."

specification/billing/resource-manager/Microsoft.Billing/preview/2020-09-01-preview/examples/PromotionActivation.json

@@ -16,7 +16,7 @@
     }
   },
   "responses": {
-    "200": {
+    "202": {
       "body": {
         "id": "/providers/Microsoft.Billing/promotions/ff0f1add-122a-43c1-a2ec-c2277781667d",
         "type": "Microsoft.Billing/promotions",

specification/billing/resource-manager/Microsoft.Billing/preview/2020-09-01-preview/examples/PromotionCheckEligibility.json

@@ -12,6 +12,7 @@
           "name": "WVD 30 percent off",
           "eligible": true,
           "reason": "None",
+          "details": "",
           "eligibilitySubscriptionId": "f6dc64c8-34bb-43d3-96b0-fd2b8c94f1c3",
           "expiryDate": "2021-10-01"
         }

specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-04-01/examples/CalculateReservationOrder.json

@@ -29,6 +29,9 @@
             "currencyCode": "USD",
             "amount": 46.0
           },
+          "netTotal": 0,
+          "taxTotal": 0,
+          "grandTotal": 0,
           "reservationOrderId": "6d9cec54-7de8-abcd-9de7-80f5d634f2d2",
           "skuTitle": "Reserved VM Instance, Standard_D1, US West, 1 Year",
           "skuDescription": "standard_D1",

specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-04-01/examples/GetReservationDetails.json

@@ -21,6 +21,7 @@
             "/subscriptions/98df3792-7962-4f18-8be2-d5576f122de3"
           ],
           "renew": false,
+          "archived": false,
           "renewSource": "/providers/microsoft.capacity/reservationOrders/276e7ae4-84d0-4da6-ab4b-d6b94f3557da/reservations/00238563-7312-4c20-a134-8c030bf938a7",
           "renewDestination": "/providers/microsoft.capacity/reservationOrders/276e7ae4-84d0-4da6-ab4b-d6b94f3557da/reservations/00238563-7312-4c20-a134-8c030bf938a7",
           "billingScopeId": "/subscriptions/19376483-64b8-49e4-a931-d5248828720a",

specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-04-01/reservations.json

@@ -1147,6 +1147,18 @@
             }
           }
         },
+        "netTotal": {
+          "description": "Net total",
+          "type": "number"
+        },
+        "taxTotal": {
+          "description": "Tax total",
+          "type": "number"
+        },
+        "grandTotal": {
+          "description": "Grand Total",
+          "type": "number"
+        },
         "isBillingPartnerManaged": {
           "description": "True if billing is managed by Microsoft Partner. Used only for CSP accounts.",
           "type": "boolean"
@@ -1260,6 +1272,14 @@
         },
         "term": {
           "$ref": "#/definitions/ReservationTerm"
+        },
+        "archived": {
+          "type": "boolean",
+          "description": "Property to determine if a reservation is archived or not"
+        },
+        "capabilities": {
+          "type": "string",
+          "description": "List the Capabilities of a reservation"
         }
       }
     },
@@ -1301,6 +1321,9 @@
         "reservedResourceType": {
           "$ref": "#/definitions/ReservedResourceType"
         },
+        "instanceFlexibility": {
+          "$ref": "#/definitions/InstanceFlexibility"
+        },
         "billingScopeId": {
           "$ref": "#/definitions/BillingScopeId"
         },
@@ -1668,6 +1691,9 @@
         },
         "valid": {
           "type": "boolean"
+        },
+        "reason": {
+          "type": "string"
         }
       }
     },