Skip to content

Commit e0aca4c

Browse files
neeerajaakulaneeerajaakula
authored
[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview (#21671)
* Fix s360 alerts for properties being returned in GET but not exising in PUT requests * Prettier fix * Fix model validation error for long running operation response missing location header * removed default value for array as it breaks the arm template schema creation * removed default value for array for managed hsm virtual network rule as it breaks the arm template schema creation
1 parent d93f638 commit e0aca4c

File tree

17 files changed

+154
-29
lines changed

17 files changed

+154
-29
lines changed

‎specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/DeletedManagedHsm_Purge.json‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
"api-version": "2021-04-01-preview"
77
},
88
"responses": {
9-
"202": {}
9+
"202": {
10+
"headers": {
11+
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
12+
}
13+
}
1014
}
1115
}

‎specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/ManagedHsm_CreateOrUpdate.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@
2727
},
2828
"responses": {
2929
"202": {
30+
"headers": {
31+
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
32+
},
3033
"body": {
3134
"properties": {
3235
"tenantId": "00000000-0000-0000-0000-000000000000",

‎specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/ManagedHsm_Delete.json‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,11 @@
77
},
88
"responses": {
99
"200": {},
10-
"202": {},
10+
"202": {
11+
"headers": {
12+
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
13+
}
14+
},
1115
"204": {}
1216
}
1317
}

‎specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json‎

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,13 @@
190190
"description": "Request successful. Resource does not exist."
191191
},
192192
"202": {
193-
"description": "Accepted and the operation will complete asynchronously."
193+
"description": "Accepted and the operation will complete asynchronously.",
194+
"headers": {
195+
"Location": {
196+
"description": "The URI to poll for completion status.",
197+
"type": "string"
198+
}
199+
}
194200
},
195201
"200": {
196202
"description": "Delete successful."
@@ -524,7 +530,13 @@
524530
],
525531
"responses": {
526532
"202": {
527-
"description": "Accepted and the operation will complete asynchronously."
533+
"description": "Accepted and the operation will complete asynchronously.",
534+
"headers": {
535+
"Location": {
536+
"description": "The URI to poll for completion status.",
537+
"type": "string"
538+
}
539+
}
528540
},
529541
"default": {
530542
"description": "The error response describing why the operation failed.",
@@ -873,7 +885,11 @@
873885
"description": "Create a new managed HSM pool. This is the default option."
874886
}
875887
]
876-
}
888+
},
889+
"x-ms-mutability": [
890+
"create",
891+
"update"
892+
]
877893
},
878894
"statusMessage": {
879895
"readOnly": true,
@@ -1177,7 +1193,8 @@
11771193
"x-ms-enum": {
11781194
"name": "NetworkRuleBypassOptions",
11791195
"modelAsString": true
1180-
}
1196+
},
1197+
"default": "AzureServices"
11811198
},
11821199
"defaultAction": {
11831200
"type": "string",
@@ -1189,7 +1206,8 @@
11891206
"x-ms-enum": {
11901207
"name": "NetworkRuleAction",
11911208
"modelAsString": true
1192-
}
1209+
},
1210+
"default": "Allow"
11931211
},
11941212
"ipRules": {
11951213
"type": "array",

‎specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-06-01-preview/examples/DeletedManagedHsm_Purge.json‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
"api-version": "2021-06-01-preview"
77
},
88
"responses": {
9-
"202": {}
9+
"202": {
10+
"headers": {
11+
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
12+
}
13+
}
1014
}
1115
}

‎specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-06-01-preview/examples/ManagedHsm_CreateOrUpdate.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@
2727
},
2828
"responses": {
2929
"202": {
30+
"headers": {
31+
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
32+
},
3033
"body": {
3134
"properties": {
3235
"tenantId": "00000000-0000-0000-0000-000000000000",

‎specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-06-01-preview/examples/ManagedHsm_Delete.json‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,11 @@
77
},
88
"responses": {
99
"200": {},
10-
"202": {},
10+
"202": {
11+
"headers": {
12+
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
13+
}
14+
},
1115
"204": {}
1216
}
1317
}

‎specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-06-01-preview/managedHsm.json‎

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,13 @@
190190
"description": "Request successful. Resource does not exist."
191191
},
192192
"202": {
193-
"description": "Accepted and the operation will complete asynchronously."
193+
"description": "Accepted and the operation will complete asynchronously.",
194+
"headers": {
195+
"Location": {
196+
"description": "The URI to poll for completion status.",
197+
"type": "string"
198+
}
199+
}
194200
},
195201
"200": {
196202
"description": "Delete successful."
@@ -524,7 +530,13 @@
524530
],
525531
"responses": {
526532
"202": {
527-
"description": "Accepted and the operation will complete asynchronously."
533+
"description": "Accepted and the operation will complete asynchronously.",
534+
"headers": {
535+
"Location": {
536+
"description": "The URI to poll for completion status.",
537+
"type": "string"
538+
}
539+
}
528540
},
529541
"default": {
530542
"description": "The error response describing why the operation failed.",
@@ -873,7 +885,11 @@
873885
"description": "Create a new managed HSM pool. This is the default option."
874886
}
875887
]
876-
}
888+
},
889+
"x-ms-mutability": [
890+
"create",
891+
"update"
892+
]
877893
},
878894
"statusMessage": {
879895
"readOnly": true,
@@ -1177,7 +1193,8 @@
11771193
"x-ms-enum": {
11781194
"name": "NetworkRuleBypassOptions",
11791195
"modelAsString": true
1180-
}
1196+
},
1197+
"default": "AzureServices"
11811198
},
11821199
"defaultAction": {
11831200
"type": "string",
@@ -1189,7 +1206,8 @@
11891206
"x-ms-enum": {
11901207
"name": "NetworkRuleAction",
11911208
"modelAsString": true
1192-
}
1209+
},
1210+
"default": "Allow"
11931211
},
11941212
"ipRules": {
11951213
"type": "array",

‎specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-11-01-preview/examples/DeletedManagedHsm_Purge.json‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
"api-version": "2021-11-01-preview"
77
},
88
"responses": {
9-
"202": {}
9+
"202": {
10+
"headers": {
11+
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
12+
}
13+
}
1014
}
1115
}

‎specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-11-01-preview/examples/ManagedHsm_CreateOrUpdate.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@
2727
},
2828
"responses": {
2929
"202": {
30+
"headers": {
31+
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
32+
},
3033
"body": {
3134
"properties": {
3235
"tenantId": "00000000-0000-0000-0000-000000000000",

0 commit comments

Comments
 (0)