Skip to content

Commit d463274

Browse files
mudit794mudit794
authored
[Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 (#13177)
* Update advisor.json Add additional property * Update GetRecommendationDetail.json * Update ListRecommendations.json * Update GetRecommendationDetail.json * Update advisor.json * move property to botton
1 parent 9cee82c commit d463274

File tree

3 files changed

+149
-6
lines changed

3 files changed

+149
-6
lines changed

‎specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json‎

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,6 +1136,46 @@
11361136
"resourceMetadata": {
11371137
"$ref": "#/definitions/ResourceMetadata",
11381138
"description": "Metadata of resource that was assessed"
1139+
},
1140+
"description": {
1141+
"description": "The detailed description of recommendation.",
1142+
"type": "string"
1143+
},
1144+
"label": {
1145+
"description": "The label of recommendation.",
1146+
"type": "string"
1147+
},
1148+
"learnMoreLink": {
1149+
"description": "The link to learn more about recommendation and generation logic.",
1150+
"type": "string"
1151+
},
1152+
"potentialBenefits": {
1153+
"description": "The potential benefit of implementing recommendation.",
1154+
"type": "string"
1155+
},
1156+
"actions": {
1157+
"description": "The list of recommended actions to implement recommendation.",
1158+
"type": "array",
1159+
"items": {
1160+
"type": "object",
1161+
"additionalProperties": {
1162+
"type": "object"
1163+
}
1164+
}
1165+
},
1166+
"remediation": {
1167+
"description": "The automated way to apply recommendation.",
1168+
"type": "object",
1169+
"additionalProperties": {
1170+
"type": "object"
1171+
}
1172+
},
1173+
"exposedMetadataProperties": {
1174+
"description": "The recommendation metadata properties exposed to customer to provide additional information.",
1175+
"type": "object",
1176+
"additionalProperties": {
1177+
"type": "object"
1178+
}
11391179
}
11401180
}
11411181
},
@@ -1185,6 +1225,21 @@
11851225
"source": {
11861226
"description": "Source from which recommendation is generated",
11871227
"type": "string"
1228+
},
1229+
"action": {
1230+
"description": "The action to view resource.",
1231+
"type": "object",
1232+
"additionalProperties": {
1233+
"type": "object"
1234+
}
1235+
},
1236+
"singular": {
1237+
"description": "The singular user friendly name of resource type. eg: virtual machine",
1238+
"type": "string"
1239+
},
1240+
"plural": {
1241+
"description": "The plural user friendly name of resource type. eg: virtual machines",
1242+
"type": "string"
11881243
}
11891244
}
11901245
},

‎specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/GetRecommendationDetail.json‎

Lines changed: 33 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,41 @@
2020
"problem": "Monitoring agent is not installed on your machines",
2121
"solution": "Monitoring agent should be installed on your machines"
2222
},
23+
"remediation": {
24+
"httpMethod": "POST",
25+
"uri": "uri",
26+
"details": "link to document"
27+
},
2328
"resourceMetadata": {
2429
"resourceId": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/virtualMachines/xyz",
25-
"source": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/virtualMachines/xyz/providers/Microsoft.Security/assessments/assessmentGuid"
26-
}
30+
"source": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/virtualMachines/xyz/providers/Microsoft.Security/assessments/assessmentGuid",
31+
"action": {
32+
"actionType": "Document",
33+
"link": "https://link3",
34+
"caption": "Enable Soft Delete to protect blob data",
35+
"description": "Enable Soft Delete to protect blob data",
36+
"metadata": {
37+
"id": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/virtualMachines/xyz"
38+
}
39+
},
40+
"singular": "Virtual machine",
41+
"plural": "Virtual machines"
42+
},
43+
"actions": [
44+
{
45+
"actionType": "Document",
46+
"link": "https://link1",
47+
"caption": "Enable Soft Delete to protect blob data",
48+
"description": "Enable Soft Delete to protect blob data",
49+
"metadata": {
50+
"id": "/subscriptions/subscriptionId"
51+
}
52+
}
53+
],
54+
"description": "After enabling Soft Delete, deleted data transitions to a soft deleted state instead of being permanently deleted. When data is overwritten, a soft deleted snapshot is generated to save the state of the overwritten data. You can configure the amount of time soft deleted data is recoverable before it permanently expires.",
55+
"label": "Enable Soft Delete",
56+
"learnMoreLink": "https://link2",
57+
"potentialBenefits": "Save and recover your data when blobs or blob snapshots are accidentally overwritten or deleted"
2758
},
2859
"type": "Microsoft.Advisor/recommendations"
2960
}

‎specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/ListRecommendations.json‎

Lines changed: 61 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,44 @@
1919
"impactedValue": "armavset",
2020
"lastUpdated": "2017-02-24T22:24:43.3216408Z",
2121
"risk": "Warning",
22+
"remediation": {
23+
"httpMethod": "POST",
24+
"uri": "uri",
25+
"details": "link to document"
26+
},
2227
"shortDescription": {
2328
"problem": "This availability set is not configured for fault tolerance",
2429
"solution": "To ensure high availability add one or more virtual machines to this availability set"
2530
},
2631
"resourceMetadata": {
27-
"resourceId": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/availabilitysets/abc"
28-
}
32+
"resourceId": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/availabilitysets/abc",
33+
"action": {
34+
"actionType": "Document",
35+
"link": "https://link3",
36+
"caption": "Enable Soft Delete to protect blob data",
37+
"description": "Enable Soft Delete to protect blob data",
38+
"metadata": {
39+
"id": "/subscriptions/subscriptionId"
40+
}
41+
},
42+
"singular": "Availability set",
43+
"plural": "Availability sets"
44+
},
45+
"actions": [
46+
{
47+
"actionType": "Document",
48+
"link": "https://link1",
49+
"caption": "Enable Soft Delete to protect blob data",
50+
"description": "Enable Soft Delete to protect blob data",
51+
"metadata": {
52+
"id": "/subscriptions/subscriptionId"
53+
}
54+
}
55+
],
56+
"description": "After enabling Soft Delete, deleted data transitions to a soft deleted state instead of being permanently deleted. When data is overwritten, a soft deleted snapshot is generated to save the state of the overwritten data. You can configure the amount of time soft deleted data is recoverable before it permanently expires.",
57+
"label": "Enable Soft Delete",
58+
"learnMoreLink": "https://link2",
59+
"potentialBenefits": "Save and recover your data when blobs or blob snapshots are accidentally overwritten or deleted"
2960
},
3061
"type": "Microsoft.Advisor/recommendations"
3162
},
@@ -45,8 +76,34 @@
4576
},
4677
"resourceMetadata": {
4778
"resourceId": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/virtualMachines/xyz",
48-
"source": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/virtualMachines/xyz/providers/Microsoft.Security/assessments/assessmentGuid"
49-
}
79+
"source": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/virtualMachines/xyz/providers/Microsoft.Security/assessments/assessmentGuid",
80+
"action": {
81+
"actionType": "Document",
82+
"link": "https://link3",
83+
"caption": "Enable Soft Delete to protect blob data",
84+
"description": "Enable Soft Delete to protect blob data",
85+
"metadata": {
86+
"id": "/subscriptions/subscriptionId"
87+
}
88+
},
89+
"singular": "Virtual machine",
90+
"plural": "Virtual machines"
91+
},
92+
"actions": [
93+
{
94+
"actionType": "Document",
95+
"link": "https://link1",
96+
"caption": "Enable Soft Delete to protect blob data",
97+
"description": "Enable Soft Delete to protect blob data",
98+
"metadata": {
99+
"id": "/subscriptions/subscriptionId"
100+
}
101+
}
102+
],
103+
"description": "Monitoring agent should be installed on your machines.",
104+
"label": "Enable monitoring agent",
105+
"learnMoreLink": "https://link2",
106+
"potentialBenefits": "Protect and monitor machine"
50107
},
51108
"type": "Microsoft.Advisor/recommendations"
52109
}

0 commit comments

Comments
 (0)