[Hub Generated] Review request for Microsoft.AzureStack to add version stable/2017-06-01 (#11937)

ionuttulai · web-flow · commit c12de2ac6fcd · 2021-01-21T09:46:01.000+08:00
* added default error response where missing and fixed camel case action names

* removed readonly properties from examples

* removed more readonly properties from examples

* remove hard-coded product name from swagger action

* added enable remote management action

* ran npm prettier on new jsong files

* moved remote management action to registrations
diff --git a/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/AzureStack.json b/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/AzureStack.json
@@ -38,6 +38,12 @@
             "schema": {
               "$ref": "#/definitions/OperationList"
             }
+          },
+          "default": {
+            "description": "Error response describing why the operation failed.",
+            "schema": {
+              "$ref": "#/definitions/ErrorResponse"
+            }
           }
         },
         "x-ms-pageable": {
diff --git a/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/CustomerSubscription.json b/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/CustomerSubscription.json
@@ -138,6 +138,12 @@
           },
           "204": {
             "description": "NO CONTENT"
+          },
+          "default": {
+            "description": "Error response describing why the operation failed.",
+            "schema": {
+              "$ref": "AzureStack.json#/definitions/ErrorResponse"
+            }
           }
         }
       },
@@ -178,6 +184,12 @@
             "schema": {
               "$ref": "#/definitions/CustomerSubscription"
             }
+          },
+          "default": {
+            "description": "Error response describing why the operation failed.",
+            "schema": {
+              "$ref": "AzureStack.json#/definitions/ErrorResponse"
+            }
           }
         }
       }
diff --git a/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/Product.json b/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/Product.json
@@ -140,11 +140,17 @@
             "schema": {
               "$ref": "#/definitions/ExtendedProduct"
             }
+          },
+          "default": {
+            "description": "Error response describing why the operation failed.",
+            "schema": {
+              "$ref": "AzureStack.json#/definitions/ErrorResponse"
+            }
           }
         }
       }
     },
-    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.AzureStack/registrations/{registrationName}/products/_all/GetProducts": {
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.AzureStack/registrations/{registrationName}/products/{productName}/getProducts": {
       "post": {
         "x-ms-examples": {
           "Returns a list of products.": {
@@ -166,6 +172,9 @@
           {
             "$ref": "AzureStack.json#/parameters/RegistrationNameParameter"
           },
+          {
+            "$ref": "#/parameters/ProductNameParameter"
+          },
           {
             "$ref": "#/parameters/DeviceConfigurationParameter"
           },
@@ -189,7 +198,7 @@
         }
       }
     },
-    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.AzureStack/registrations/{registrationName}/products/{productName}/GetProduct": {
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.AzureStack/registrations/{registrationName}/products/{productName}/getProduct": {
       "post": {
         "x-ms-examples": {
           "Returns the specified product.": {
diff --git a/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/Registration.json b/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/Registration.json
@@ -178,6 +178,12 @@
             "schema": {
               "$ref": "#/definitions/Registration"
             }
+          },
+          "default": {
+            "description": "Error response describing why the operation failed.",
+            "schema": {
+              "$ref": "AzureStack.json#/definitions/ErrorResponse"
+            }
           }
         }
       },
@@ -257,6 +263,48 @@
             "schema": {
               "$ref": "#/definitions/ActivationKeyResult"
             }
+          },
+          "default": {
+            "description": "Error response describing why the operation failed.",
+            "schema": {
+              "$ref": "AzureStack.json#/definitions/ErrorResponse"
+            }
+          }
+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.AzureStack/registrations/{registrationName}/enableRemoteManagement": {
+      "post": {
+        "x-ms-examples": {
+          "Returns empty response for successful action..": {
+            "$ref": "examples/RemoteManagement/Post.json"
+          }
+        },
+        "tags": [
+          "Registrations"
+        ],
+        "description": "Enables remote management for device under the Azure Stack registration.",
+        "operationId": "Registrations_EnableRemoteManagement",
+        "parameters": [
+          {
+            "$ref": "AzureStack.json#/parameters/SubscriptionIdParameter"
+          },
+          {
+            "$ref": "AzureStack.json#/parameters/ResourceGroupNameParameter"
+          },
+          {
+            "$ref": "AzureStack.json#/parameters/RegistrationNameParameter"
+          }
+        ],
+        "responses": {
+          "200": {
+            "description": "OK"
+          },
+          "default": {
+            "description": "Error response describing why the operation failed.",
+            "schema": {
+              "$ref": "AzureStack.json#/definitions/ErrorResponse"
+            }
           }
         }
       }
diff --git a/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/examples/Product/GetPost.json b/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/examples/Product/GetPost.json
@@ -4,11 +4,7 @@
     "resourceGroup": "azurestack",
     "registrationName": "testregistration",
     "productName": "Microsoft.OSTCExtensions.VMAccessForLinux.1.4.7.1",
-    "api-version": "2017-06-01",
-    "deviceConfiguration": {
-      "identitySystem": "AzureAD",
-      "deviceVersion": "1910.0.0.0"
-    }
+    "api-version": "2017-06-01"
   },
   "responses": {
     "200": {
diff --git a/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/examples/Product/ListPost.json b/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/examples/Product/ListPost.json
@@ -3,11 +3,8 @@
     "subscriptionId": "dd8597b4-8739-4467-8b10-f8679f62bfbf",
     "resourceGroup": "azurestack",
     "registrationName": "testregistration",
-    "api-version": "2017-06-01",
-    "deviceConfiguration": {
-      "identitySystem": "AzureAD",
-      "deviceVersion": "1910.0.0.0"
-    }
+    "productName": "_all",
+    "api-version": "2017-06-01"
   },
   "responses": {
     "200": {
diff --git a/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/examples/Product/UploadLog.json b/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/examples/Product/UploadLog.json
@@ -4,13 +4,7 @@
     "resourceGroup": "azurestack",
     "registrationName": "testregistration",
     "productName": "Microsoft.OSTCExtensions.VMAccessForLinux.1.4.7.1",
-    "api-version": "2017-06-01",
-    "marketplaceProductLogUpdate": {
-      "operation": "Download",
-      "status": "Failed",
-      "error": "ExampleError",
-      "details": "ExampleDetails"
-    }
+    "api-version": "2017-06-01"
   },
   "responses": {
     "200": {
diff --git a/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/examples/RemoteManagement/Post.json b/specification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/examples/RemoteManagement/Post.json
@@ -0,0 +1,11 @@
+{
+  "parameters": {
+    "subscriptionId": "dd8597b4-8739-4467-8b10-f8679f62bfbf",
+    "resourceGroup": "azurestack",
+    "registrationName": "testregistration",
+    "api-version": "2017-06-01"
+  },
+  "responses": {
+    "200": {}
+  }
+}
diff --git a/specification/azurestack/resource-manager/readme.azureresourceschema.md b/specification/azurestack/resource-manager/readme.azureresourceschema.md
@@ -23,5 +23,5 @@ input-file:
   - Microsoft.AzureStack/stable/2017-06-01/Product.json
   - Microsoft.AzureStack/stable/2017-06-01/Registration.json
   - Microsoft.AzureStack/stable/2017-06-01/CustomerSubscription.json
-
+  
 ```

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,12 @@`
`38`	`38`	`"schema": {`
`39`	`39`	`"$ref": "#/definitions/OperationList"`
`40`	`40`	`}`
	`41`	`+ },`
	`42`	`+ "default": {`
	`43`	`+ "description": "Error response describing why the operation failed.",`
	`44`	`+ "schema": {`
	`45`	`+ "$ref": "#/definitions/ErrorResponse"`
	`46`	`+ }`
`41`	`47`	`}`
`42`	`48`	`},`
`43`	`49`	`"x-ms-pageable": {`
Original file line number	Diff line number	Diff line change
`@@ -138,6 +138,12 @@`
`138`	`138`	`},`
`139`	`139`	`"204": {`
`140`	`140`	`"description": "NO CONTENT"`
	`141`	`+ },`
	`142`	`+ "default": {`
	`143`	`+ "description": "Error response describing why the operation failed.",`
	`144`	`+ "schema": {`
	`145`	`+ "$ref": "AzureStack.json#/definitions/ErrorResponse"`
	`146`	`+ }`
`141`	`147`	`}`
`142`	`148`	`}`
`143`	`149`	`},`
`@@ -178,6 +184,12 @@`
`178`	`184`	`"schema": {`
`179`	`185`	`"$ref": "#/definitions/CustomerSubscription"`
`180`	`186`	`}`
	`187`	`+ },`
	`188`	`+ "default": {`
	`189`	`+ "description": "Error response describing why the operation failed.",`
	`190`	`+ "schema": {`
	`191`	`+ "$ref": "AzureStack.json#/definitions/ErrorResponse"`
	`192`	`+ }`
`181`	`193`	`}`
`182`	`194`	`}`
`183`	`195`	`}`
Original file line number	Diff line number	Diff line change
`@@ -140,11 +140,17 @@`
`140`	`140`	`"schema": {`
`141`	`141`	`"$ref": "#/definitions/ExtendedProduct"`
`142`	`142`	`}`
	`143`	`+ },`
	`144`	`+ "default": {`
	`145`	`+ "description": "Error response describing why the operation failed.",`
	`146`	`+ "schema": {`
	`147`	`+ "$ref": "AzureStack.json#/definitions/ErrorResponse"`
	`148`	`+ }`
`143`	`149`	`}`
`144`	`150`	`}`
`145`	`151`	`}`
`146`	`152`	`},`
`147`		`- "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.AzureStack/registrations/{registrationName}/products/_all/GetProducts": {`
	`153`	`+ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.AzureStack/registrations/{registrationName}/products/{productName}/getProducts": {`
`148`	`154`	`"post": {`
`149`	`155`	`"x-ms-examples": {`
`150`	`156`	`"Returns a list of products.": {`
`@@ -166,6 +172,9 @@`
`166`	`172`	`{`
`167`	`173`	`"$ref": "AzureStack.json#/parameters/RegistrationNameParameter"`
`168`	`174`	`},`
	`175`	`+ {`
	`176`	`+ "$ref": "#/parameters/ProductNameParameter"`
	`177`	`+ },`
`169`	`178`	`{`
`170`	`179`	`"$ref": "#/parameters/DeviceConfigurationParameter"`
`171`	`180`	`},`
`@@ -189,7 +198,7 @@`
`189`	`198`	`}`
`190`	`199`	`}`
`191`	`200`	`},`
`192`		`- "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.AzureStack/registrations/{registrationName}/products/{productName}/GetProduct": {`
	`201`	`+ "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.AzureStack/registrations/{registrationName}/products/{productName}/getProduct": {`
`193`	`202`	`"post": {`
`194`	`203`	`"x-ms-examples": {`
`195`	`204`	`"Returns the specified product.": {`