rebased from master

Author: adklinge

.azure-pipelines-preproduction/package-lock.json

@@ -39,4 +39,3 @@ steps:
     repository: $(CONTAINER_REGISTRY_REPOSITORY_NAME)
     tags: |
       latest
-      $(IMAGE_TAG_PREFIX)$(Build.BuildNumber)

.azure-pipelines-preproduction/package.json

@@ -48,6 +48,6 @@ If there are following updates in the PR, ensure to request an approval from API
 - [ ] Updating API in stable version with Breaking Change Validation errors
 - [ ] Updating API(s) in preview over 1 year
 
-**Action**: to initiate an evaluation of the breaking change, create a new intake using the [template for breaking changes](https://msazure.visualstudio.com/One/_workitems/create/Scenario?templateId=d1c215ec-5d6a-4cb3-a193-95ddd0a1ba96&ownerId=85bb92fb-21fe-41ca-9309-47f2c5f57515). Addition details on the process and office hours are on the [Breaking change Wiki](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37684/Breaking-Changes).
+**Action**: to initiate an evaluation of the breaking change, create a new intake using the [template for breaking changes](https://aka.ms/Breakingchangetemplate). Addition details on the process and office hours are on the [Breaking change Wiki](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37684/Breaking-Changes).
 
-Please follow the link to find more details on [PR review process](https://aka.ms/SwaggerPRReview).
+Please follow the link to find more details on [PR review process](https://aka.ms/SwaggerPRReview).

.azure-pipelines/azure-pipelines-data-container.yml

@@ -8,23 +8,46 @@
       - WaitForARMFeedback
     onCheckedComments: "Hi, @${PRAuthor} your PR are labelled with <b> WaitForARMFeedback</b>. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @${PRAssignee} "
 
-- rule:
-    type: checkbox
-    keywords:
-      - "I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow."
-    onCheckedComments: "Hi, @${PRAuthor} Thanks for your PR. I am workflow bot for review process. Here are some small tips. </br> <li> Please ensure to do self-check against checklists in first PR comment.</li> <li> PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging. </li>  <li> If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. [How to fix?](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md)</li></br> Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com"
-
 - rule:
     type: label
     label: BreakingChangeReviewRequired
-    onLabeledComments: "Hi @${PRAuthor}, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow [breaking change policy](https://aka.ms/AzBreakingChangesPolicy) to request breaking change review and approval before proceeding swagger PR review. </br>**Action**: To initiate an evaluation of the breaking change, create a new intake using the [template for breaking changes](https://msazure.visualstudio.com/One/_workitems/create/Scenario?templateId=d1c215ec-5d6a-4cb3-a193-95ddd0a1ba96&ownerId=85bb92fb-21fe-41ca-9309-47f2c5f57515). Addition details on the process and office hours are on the [Breaking change Wiki](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37684/Breaking-Changes).</br> If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback."
+    variables:
+        openapiHub: https://portal.azure-devex-tools.com
+    onLabeledComments: "Hi @${PRAuthor}, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow [breaking change policy](https://aka.ms/AzBreakingChangesPolicy) to request breaking change review and approval before proceeding swagger PR review. </br>**Action**: To initiate an evaluation of the breaking change, create a new intake using the [template for breaking changes](https://aka.ms/Breakingchangetemplate). Addition details on the process and office hours are on the [Breaking change Wiki](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37684/Breaking-Changes).</br> If you want to know the production traffic statistic, please see [ARM Traffic statistic](${openapiHub}/api/pr/query-traffic?pr=${owner}/${repo}/${PRNumber}&days=5). </br> If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback."
 
 - rule:
     type: label
+    repoAllowList:
+      - Azure/azure-rest-api-specs-pr
+    variables:
+      openapiHub: https://portal.azure-devex-tools.com
+      to: Azure/azure-rest-api-specs/master
     label: Approved-OkToMerge
-    onLabeledComments: "Hi @${PRAuthor},Your PR is approved. Congratulations. </br> <li> If your PR is in public repo (azure-rest-api-specs),  PR assignee will merge all updates in the PR shortly afterwards; or pause the PR merge, you need to put on a label <b>DoNotMerge</b> to PR as soon as possible. </li><li>If your PR is in private repo (azure-rest-api-specs-pr),  there won’t be PR merge.  Please refer to this [wiki](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/205/RP-Scenarios-to-Contribute-to-Swagger?anchor=**public-repository-vs.-private-repository**) for further guidance on how to proceed. </li>"
+    onLabeledComments: "Hi @${PRAuthor},Your PR is approved. Congratulations. </br>  <li> Since your PR is in private repo (azure-rest-api-specs-pr),  there won’t be PR merge. If you want to publish the PR to public repo (Azure/azure-rest-api-specs) and get it merged, pls use [OpenAPIHub Publish PR](${openapiHub}/tools/publishpullrequest?pr=${owner}/${repo}/${PRNumber}&to=${to}).</li> <li> For further guidance on how to proceed.  Please refer to this [wiki](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/205/RP-Scenarios-to-Contribute-to-Swagger?anchor=**public-repository-vs.-private-repository**)</li>"
 
 - rule:
     type: label
     label: NewApiVersionRequired
     onLabeledComments: "<b>NewApiVersionRequired reason:</b></br> </br><b>A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support. </b> </br></br> EXAMPLE: if a customer calls a service in the public cloud using <b>api-version=2020-07-27</b>, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.  "
+
+- rule:
+    type: label
+    label: CI-FixRequiredOnFailure
+    onLabeledComments: >- 
+      Hi @${PRAuthor}, Your PR has some issues. Please fix the CI sequentially by following the order of `Avocado, semantic validation, model validation, breaking change, lintDiff`. 
+      <table><tr><th>Task</th><th>How to fix</th><th>Priority</th><th>Support (Microsoft alias)</th></tr>
+      <tr><td>Avocado</td><td>[Fix-Avocado](https://github.com/Azure/avocado)</td><td>High</td><td>ruowan</td></tr>
+      <tr><td>Semantic validation</td><td>[Fix-SemanticValidation-Error](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#semantic-validation)</td><td>High</td><td>raychen, jianyxi</td></tr>
+      <tr><td>Model validation</td><td>[Fix-ModelValidation-Error](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#model-validation)</td><td>High</td><td>raychen,jianyxi</td></tr>
+      <tr><td>LintDiff</td><td>[Fix-LintDiff](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#linter-validation)</td><td>high</td><td>jianyxi, ruoxuan</td></tr></table> 
+      If you need further help, please feedback via [swagger feedback](https://aka.ms/swaggerfeedback)." 
+
+- rule:
+    type: PROpen
+    variables:
+      openapiHub: https://portal.azure-devex-tools.com
+    keywords:
+      - "I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow."
+    onOpenedComments: "Hi, @${PRAuthor} Thanks for your PR. I am workflow bot for review process. Here are some small tips. </br> <li> Please ensure to do self-check against checklists in first PR comment.</li> <li> PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging. </li>   <li> For specs comparison cross API versions,  Use [API Specs Comparison Report Generator](${openapiHub}/tools/diff?pr=${owner}/${repo}/${PRNumber})</li>  <li> If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. [How to fix?](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md)</li></br> Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com"
+
+

.github/PULL_REQUEST_TEMPLATE.md

@@ -2,20 +2,11 @@
 - rule:
     booleanFilterExpression: "needs-triage"
     assignees:
-      - yungezz
-      - erich-wang
       - PhoenixHe-msft
       - raych1
-      - lirenhe
-      - weidongxu-microsoft
-      - ArcturusZhang
-      - xccc-msft
-      - ChenTanyi
-      - fengzhou-msft
-      - njuCZ
       - akning-ms
-      - markcowl
       - leni-msft
-      - qianwens
       - ruowan
+      - jianyexi
+      - zhenglaizhang
 

.github/comment.yml

@@ -20,7 +20,6 @@
     reviewers:
       - anuchandy
       - jhendrixMSFT
-      - lmazuel
       - tjprescott
 
 
@@ -60,7 +59,6 @@
     paths: "specification/compute/**"
     reviewers:
       - ArcturusZhang
-      - fengzhou-msft
       - yungezz
 
 - rule:
@@ -99,7 +97,6 @@
     paths:
       - "specification/storage/**"
     reviewers:
-      - qianwens
       - Juliehzl
 
 
@@ -109,7 +106,6 @@
       - allenjzhang
 - rule:
     paths:
-      - "specification/@(keyvault|notificationhubs)/**"
       - "specification/@(databricks|containerregistry)/**"
     reviewers:
       - fengzhou-msft
@@ -119,7 +115,6 @@
       - "specification/@(containerservice|containerinstance)/**"
     reviewers:
       - PhoenixHe-msft
-      - fengzhou-msft
       - yungezz
 
 - rule:
@@ -140,6 +135,18 @@
       - "specification/web/**"
     reviewers:
       - weidongxu-microsoft
+      
+- rule:
+    paths:
+      - "specification/testbase/**"
+    reviewers:
+      - PhoenixHe-msft
+      
+- rule:
+    paths:
+      - "specification/servicelinker/**"
+    reviewers:
+      - PhoenixHe-msft
 
 - rule:
     paths:
@@ -190,3 +197,4 @@
       - ruowan
       - jianyexi
       - zhenglaizhang
+      - chunyu3

.github/issue_assignment.yml

@@ -78,3 +78,4 @@
 /specification/trafficmanager/ @allencal @hrkulkarmsft
 /specification/web/ @naveedaz @Azure/azure-app-service-control-plane
 /profile/ @shahabhijeet
+/specification/**/*.md @lirenhe

.github/pull_request_assignment.yml

@@ -1,4 +1,4 @@
-A128CBCPAD
+A128CBCPAD
 A192CBCPAD
 A256CBCPAD
 AADDS
@@ -142,6 +142,7 @@ authorizationrules
 authpriv
 authprovider
 authproviders
+Auths
 authsettings
 authsid
 autobackup
@@ -302,12 +303,14 @@ changestate
 CHECKACCESS
 checkmark
 checknameavailability
+checkin
 checkpointing
 CIDR
 CIDRs
 CIFS
 ciphertext
 CISCOASA
+Citus
 claimCondition
 claimType
 clfs
@@ -332,6 +335,7 @@ cloudsimple
 clustermonitoring
 clustername
 CMAF
+CMEK
 Cmdkey
 cmdlet
 CMMI
@@ -587,6 +591,8 @@ Español
 estaba
 Etag
 etags
+Etcd
+etcd
 Ethereum
 evaluateautoscale
 evalue
@@ -692,6 +698,7 @@ getcertificate
 getconsumergroup
 GETCONTENTSUMMARY
 GETFILESTATUS
+getikesas
 getissuers
 getitems
 getjob
@@ -862,6 +869,7 @@ jobpreparation
 jobpreparationandreleasetaskstatus
 jobrelease
 jobschedule
+jobscheduler
 jobschedules
 johnc
 johnsmith
@@ -1013,7 +1021,9 @@ mbaldwin
 Mbps
 MCAS
 MDATP
+mebibytes
 mediaservices
+Meru
 Mesos
 messagingplan
 Metada
@@ -1057,6 +1067,7 @@ MSAZR
 MSAZRDE
 MSAZRUSGO
 MSCONCAT
+mscv
 MSGETACLSTATUS
 MSGETFILESTATUS
 msix
@@ -1227,6 +1238,7 @@ paramref
 PARAVIRTUAL
 partnertopic
 Passthrough
+passwd
 patternanyentities
 patternrule
 patternrules
@@ -1253,6 +1265,7 @@ Phonetik
 phplogging
 phraselist
 phraselists
+Pids
 pipelineruns
 PITR
 pixelated
@@ -1311,6 +1324,7 @@ privatepreview
 projectable
 propogation
 Protectable
+ProviderHub
 provisioner
 provisioningservices
 provisioningState
@@ -1393,6 +1407,7 @@ regeneratekey
 regeneratekeys
 regexentities
 regexes
+regionality
 regionalized
 regionproposals
 registeredidentities
@@ -1407,6 +1422,8 @@ remediate
 remediated
 Remediations
 remoteloginsettings
+remoterendering
+remoterenderingvm
 remoteuser
 REMOVEACL
 REMOVEACLENTRIES
@@ -1691,6 +1708,7 @@ subfolders
 subinquireditemcount
 sublist
 sublists
+submount
 subnames
 subnet
 subnet's
@@ -1714,6 +1732,7 @@ subword
 subwords
 sudoer
 suggesters
+suid
 Superfresh
 superset
 supportedimages
@@ -1791,6 +1810,7 @@ tooltips
 topqueries
 topquery
 TPEG
+tpgs
 traceback
 traceparent
 traceroute
@@ -2043,3 +2063,6 @@ tpgs
 ProviderHub
 checkin
 regionality
+Resource
+Metastores
+maintenancewindows