You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE/control_plane_template.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -20,7 +20,7 @@ If you need further help with anything, see `Getting help` section below.
20
20
21
21
What's the purpose of this PR? Check all that apply. This is **mandatory**!
22
22
23
-
-[ ] New API version. (Such PR should have been generated with [OpenAPI Hub](https://aka.ms/openapihub), per [this wiki doc](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version).)
23
+
-[ ] New API version. (Such PR should have been generated with [OpenAPI Hub](https://aka.ms/openapihub)).
24
24
-[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
25
25
-[ ] Update existing version to fix swagger quality issues in S360.
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+3-11Lines changed: 3 additions & 11 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -48,11 +48,7 @@ Because the first rule is to avoid breaking changes and because we want APIs to
48
48
49
49
## Coding Style
50
50
51
-
REST APIs for Azure should be defined using the [OpenAPI v2](https://github.com/OAI/OpenAPI-Specification/blob/main/versions/2.0.md) or [Cadl](https://aka.ms/cadl/rpaas-start)format.
52
-
53
-
The REST API should also adhere to the conventions documented in the [Azure API Style Guide](https://github.com/Azure/azure-api-style-guide/blob/main/openapi-style-guide.md).
54
-
55
-
You can use the [Spectral linter](https://meta.stoplight.io/docs/spectral/674b27b261c3c-overview) with our [Spectral ruleset](https://github.com/Azure/azure-api-style-guide#how-to-use-the-spectral-ruleset) to check conformance with OpenAPI v2 and the Style Guide.
51
+
All new services should use [TypeSpec](https://aka.ms/typespec/azure) to create their REST API definition. If you are working on an existing service, you should consider converting your existing REST API definition to TypeSpec. Services that use TypeSpec to describe their REST API should include both the TypeSpec source and generated OpenAPI in the specs repo.
56
52
57
53
## Directory Structure
58
54
@@ -69,7 +65,7 @@ If you want to contribute to the repository, follow these steps:
69
65
5. Resolve any issues flagged by the [Pull Request checks](#pull-request-checks).
70
66
6. Contact the ARM API Review board or Azure API Stewardship team to request PR review.
71
67
72
-
Microsoft employees can try out the experience at [OpenAPI Hub](https://aka.ms/openapihub) for [adding a new API version using OpenAPI Hub](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version).
68
+
Microsoft employees can use [OpenAPI Hub](https://aka.ms/openapihub) for adding a new API version.
73
69
74
70
## Pull Request Checks
75
71
@@ -93,8 +89,4 @@ When any of these PR checks fails it will post a comment to the PR with links to
93
89
There is also the [CI Fix Guide](https://aka.ms/ci-fix) that describes how to fix common PR check failures.
94
90
95
91
## Internal Contribution Guide
96
-
For management plane, please refer to https://aka.ms/rpguidelines;
97
-
98
-
For data-plane, please refer to [Guide to design and creation of Data Plane REST API and Client Libraries](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/591/Guide-to-design-and-creation-of-Data-Plane-REST-API-and-Client-Libraries);
99
-
100
-
For contribution access to spec repos, please refer to [Public repo vs. Private repo: To get write access](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/202/Overall-Process-of-Management-Plane-SDK-Onboarding?anchor=2.-create/update-the-openapi-specifications%2C-and-launch-swagger-pr-review)
92
+
[Create high-level Azure REST API design](https://eng.ms/docs/products/azure-developer-experience/design/api-design)
This page is intended to answer questions frequently asked during Azure Swagger PR review.
3
+
This page is intended to answer questions frequently asked during Azure API spec PR review.
4
4
5
-
1.[I am new to Swagger/OpenAPI, How should I start?](#Onboard)
5
+
1.[I am new to API specs, where should I start?](#Onboard)
6
6
2.[How to fix validation failure?](#validation)
7
-
3.[How to generate SDK from Swagger?](#SDK)
7
+
3.[How to generate SDK from API specs?](#SDK)
8
8
4.[How to generate document](#doc)
9
9
5.[How to generate swagger examples](#examplegen)
10
-
6.[If need further help, who can we contact?](#contact)
11
10
12
-
## How to onboard PR review Process?<aname="Onboard"></a>
13
-
If you are new to Swagger/OpenAPI, you can refer to this [document](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/80/Getting-started-with-OpenAPI-specifications)
11
+
## How to onboard to API spec PR review Process?<aname="Onboard"></a>
12
+
If you are new to API spec, you can refer to this [document](https://eng.ms/docs/products/azure-developer-experience/design/api-specs/api-specs#create-your-rest-api-definition)
14
13
15
-
If you are new to Swagger PR review process, you can refer to this [flowchart](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/212/Swagger-PR-Review)
16
-
17
-
You can refer to this [document](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/49/Request-Access-to-Azure-SDK-repos) to get read permission to submit PR.
14
+
You can refer to this [document](https://eng.ms/docs/products/azure-developer-experience/onboard/access) to get read permission to submit PR.
18
15
19
16
## How to fix validation failure?<aname="validation"></a>
20
17
| Validation | Description | How to fix |
@@ -30,16 +27,11 @@ You can refer to this [document](https://dev.azure.com/azure-sdk/internal/_wiki/
30
27
Refer to [Document](https://aka.ms/ci-fix) for how to run these tools locally
31
28
32
29
## How to generate SDK from Swagger?<aname="SDK"></a>
33
-
If you are working in the public repository,SDK generation is triggered as soon as your OpenAPI specification (a.k.a swagger) PR is created/committed/merged in to the azure-rest-api-specs repository.
34
-
35
-
If you are working in the private repository, please refer to this [document](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/81/Management-Plane-SDK-generation) to manually generate SDKs of different languages, including Python, Java, Go, C#, Js etc.
30
+
Refer to this [document](https://eng.ms/docs/products/azure-developer-experience/develop/sdk-generate).
36
31
37
32
38
33
## How to generate Document from Swagger?<aname="doc"></a>
39
-
Refer to [document](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/79/Generation-of-docs-on-docs.microsoft.com)
34
+
Refer to [document](https://eng.ms/docs/products/azure-developer-experience/design/api-docs)
40
35
41
36
## How to generate examples from Swagger?<aname="examplegen"></a>
42
-
Refer to [Swagger-Example-Generation](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/393/Swagger-Example-Generation)
43
-
44
-
## If need further help, who can we contact?<aname="contact"></a>
45
-
If any other help need, Please send a mail to vscswagger@microsoft.com
37
+
Refer to [Swagger-Example-Generation](https://github.com/Azure/oav/blob/develop/documentation/example-generation.md)
Copy file name to clipboardExpand all lines: documentation/ci-fix.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -51,7 +51,7 @@ oav validate-example <swagger-spec-path>
51
51
Please see [readme](https://github.com/Azure/oav/blob/bd04e228b4181c53769ed88e561dec5212e77253/README.md) for how to install or run tool in details.
52
52
Or you can run it in [OpenAPI Hub](https://portal.azure-devex-tools.com/tools/static-validation/static/errors/default).
53
53
Refer to [Semantic and Model Violations Reference](https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/Semantic-and-Model-Violations-Reference.md) for detailed description of validations and how-to-fix guidance.
54
-
Refer to [Swagger-Example-Generation](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/393/Swagger-Example-Generation) for example automatic generation.
54
+
Refer to [Swagger-Example-Generation](https://github.com/Azure/oav/blob/develop/documentation/example-generation.md) for example automatic generation.
55
55
56
56
## Semantic Validation
57
57
@@ -126,7 +126,7 @@ If you see `Swagger ApiDocPreview ` check fail with a failure [like this one](ht
Then refer to [this TSG](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/79/Generation-of-docs-on-learn.microsoft.com?anchor=%22swagger-apidocpreview%22-build-is-failing).
129
+
Refer to [troubleshoothing REST API documentation](https://eng.ms/docs/products/azure-developer-experience/design/api-docs-troubleshooting).
Copy file name to clipboardExpand all lines: documentation/onboard-dpg-in-sdkautomation/README.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -18,7 +18,7 @@ __Description:__
18
18
2. If you have added a comment, which contains autorest configuration, and run `/azp run` in the spec PR, the autorest configuration in the comment will be used to generate SDK.
19
19
Otherwise, pipeline will try to find autorest configuration file in sdk repository. If found, use the autorest configuration file to generate SDK. If not found, pipeline will stop.
20
20
- Please refer to [Add autorest configuration in spec comment](./add-autorest-configuration-for-dataplane-sdk.md) on how to add autorest configuration in spec comment.
21
-
3. SDK and ApiView will be generated in spec CI pipeline, and you can find them in spec PR comment. Please refer to the [Guide of Reviewing the Api Design/Definition](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/591/Guide-to-design-and-creation-of-Data-Plane-REST-API-and-Client-Libraries?anchor=ii.-review-the-api-design/definition) to review the API definition.
21
+
3. SDK and ApiView will be generated in spec CI pipeline, and you can find them in spec PR comment. Refer to the [Get your PR merged](https://eng.ms/docs/products/azure-developer-experience/design/api-specs-pr/api-specs-pr?tabs=dataplane) for next steps.
22
22
4. If any change needed, please update the autorest configuration in spec PR comment and regenerate the SDK by adding a comment `/azp run` to swagger PR.
Copy file name to clipboardExpand all lines: documentation/openapi-authoring-automated-guidelines.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -20,7 +20,7 @@ We request OpenAPI(Swagger) spec authoring be assigned to engineers who have an
20
20
*[Rule Descriptions](#rule-descriptions)
21
21
22
22
## Error vs Warning
23
-
- Rules with severity "Error" have to be addressed for the OpenAPI(swagger) spec to be approved by the reviewers. If there is a strong reason for why the rule cannot be addressed in an OpenAPI(swagger) spec it will be a permanent exception, then [suppression process](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process) must be followed.
23
+
- Rules with severity "Error" have to be addressed for the OpenAPI(swagger) spec to be approved by the reviewers. If there is a strong reason for why the rule cannot be addressed in an OpenAPI(swagger) spec it will be a permanent exception, then [suppression process](https://aka.ms/pr-suppressions) must be followed.
24
24
25
25
- Rules with severity "Warning" are either strong recommendations made by Azure developer experience team for better SDK/Documentation experience or they point out something to evaluate, for example, the warning for booleans asks the user to evaluate whether the property should be a boolean or not.
**Output Message** : The parameters should be kept in the same order as they present in the path.
3547
3547
3548
-
**Description**: The rule is to ensure the parameters in the same order as they are ranked in the path. Since it can introduce a breaking change when updating parameter order, for services that have already shipped public versions, you may request to suppress the rule following the process documented here: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process
3548
+
**Description**: The rule is to ensure the parameters in the same order as they are ranked in the path. Since it can introduce a breaking change when updating parameter order, for services that have already shipped public versions, you may request to suppress the rule following the process documented here: https://aka.ms/pr-suppressions
0 commit comments