Skip to content

Commit 5bca310

Browse files
[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview (#19767)
* Updated the managed hsm resource manager spec to include two additional properties for private endpoint connection item * Update managed hsm private endpoint connection item in mhsm spec for latest api version * Address LRO_RESPONSE_HEADER violation for managed hsm Long running operations that are annotated with x-ms-long-running-operation:true must return location header or azure-AsyncOperation in response. Added the missing location header for managed hsm update command as well as to the corresponding examples.
1 parent 4247c95 commit 5bca310

File tree

8 files changed

+73
-0
lines changed

8 files changed

+73
-0
lines changed

specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/ManagedHsm_Update.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@
4343
}
4444
},
4545
"202": {
46+
"headers": {
47+
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
48+
},
4649
"body": {
4750
"properties": {
4851
"tenantId": "00000000-0000-0000-0000-000000000000",

specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/managedHsm.json

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,12 @@
132132
"responses": {
133133
"202": {
134134
"description": "Accepted and the operation will complete asynchronously.",
135+
"headers": {
136+
"Location": {
137+
"description": "The URI to poll for completion status.",
138+
"type": "string"
139+
}
140+
},
135141
"schema": {
136142
"$ref": "#/definitions/ManagedHsm"
137143
}
@@ -1228,6 +1234,14 @@
12281234
},
12291235
"MHSMPrivateEndpointConnectionItem": {
12301236
"properties": {
1237+
"id": {
1238+
"type": "string",
1239+
"description": "Id of private endpoint connection."
1240+
},
1241+
"etag": {
1242+
"type": "string",
1243+
"description": "Modified whenever there is a change in the state of private endpoint connection."
1244+
},
12311245
"properties": {
12321246
"$ref": "#/definitions/MHSMPrivateEndpointConnectionProperties",
12331247
"x-ms-client-flatten": true,

specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-06-01-preview/managedHsm.json

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,12 @@
132132
"responses": {
133133
"202": {
134134
"description": "Accepted and the operation will complete asynchronously.",
135+
"headers": {
136+
"Location": {
137+
"description": "The URI to poll for completion status.",
138+
"type": "string"
139+
}
140+
},
135141
"schema": {
136142
"$ref": "#/definitions/ManagedHsm"
137143
}
@@ -1228,6 +1234,14 @@
12281234
},
12291235
"MHSMPrivateEndpointConnectionItem": {
12301236
"properties": {
1237+
"id": {
1238+
"type": "string",
1239+
"description": "Id of private endpoint connection."
1240+
},
1241+
"etag": {
1242+
"type": "string",
1243+
"description": "Modified whenever there is a change in the state of private endpoint connection."
1244+
},
12311245
"properties": {
12321246
"$ref": "#/definitions/MHSMPrivateEndpointConnectionProperties",
12331247
"x-ms-client-flatten": true,

specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-11-01-preview/examples/ManagedHsm_Update.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@
4343
}
4444
},
4545
"202": {
46+
"headers": {
47+
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
48+
},
4649
"body": {
4750
"properties": {
4851
"tenantId": "00000000-0000-0000-0000-000000000000",

specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-11-01-preview/managedHsm.json

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,12 @@
132132
"responses": {
133133
"202": {
134134
"description": "Accepted and the operation will complete asynchronously.",
135+
"headers": {
136+
"Location": {
137+
"description": "The URI to poll for completion status.",
138+
"type": "string"
139+
}
140+
},
135141
"schema": {
136142
"$ref": "#/definitions/ManagedHsm"
137143
}
@@ -1228,6 +1234,14 @@
12281234
},
12291235
"MHSMPrivateEndpointConnectionItem": {
12301236
"properties": {
1237+
"id": {
1238+
"type": "string",
1239+
"description": "Id of private endpoint connection."
1240+
},
1241+
"etag": {
1242+
"type": "string",
1243+
"description": "Modified whenever there is a change in the state of private endpoint connection."
1244+
},
12311245
"properties": {
12321246
"$ref": "#/definitions/MHSMPrivateEndpointConnectionProperties",
12331247
"x-ms-client-flatten": true,

specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2021-10-01/examples/ManagedHsm_Update.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@
4343
}
4444
},
4545
"202": {
46+
"headers": {
47+
"Location": "https://some.endpoint.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/hsm-group/providers/Microsoft.KeyVault/managedHSMs/hsm1?api-version=2022-07-01&kv-operation=abJjb2RkIjoiAGVsZXRlTWFuYWdlZEhzbUFzeW5jYm9"
48+
},
4649
"body": {
4750
"properties": {
4851
"tenantId": "00000000-0000-0000-0000-000000000000",

specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2021-10-01/managedHsm.json

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,12 @@
132132
"responses": {
133133
"202": {
134134
"description": "Accepted and the operation will complete asynchronously.",
135+
"headers": {
136+
"Location": {
137+
"description": "The URI to poll for completion status.",
138+
"type": "string"
139+
}
140+
},
135141
"schema": {
136142
"$ref": "#/definitions/ManagedHsm"
137143
}
@@ -1241,6 +1247,14 @@
12411247
},
12421248
"MHSMPrivateEndpointConnectionItem": {
12431249
"properties": {
1250+
"id": {
1251+
"type": "string",
1252+
"description": "Id of private endpoint connection."
1253+
},
1254+
"etag": {
1255+
"type": "string",
1256+
"description": "Modified whenever there is a change in the state of private endpoint connection."
1257+
},
12441258
"properties": {
12451259
"$ref": "#/definitions/MHSMPrivateEndpointConnectionProperties",
12461260
"x-ms-client-flatten": true,

specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2022-07-01/managedHsm.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1305,6 +1305,14 @@
13051305
},
13061306
"MHSMPrivateEndpointConnectionItem": {
13071307
"properties": {
1308+
"id": {
1309+
"type": "string",
1310+
"description": "Id of private endpoint connection."
1311+
},
1312+
"etag": {
1313+
"type": "string",
1314+
"description": "Modified whenever there is a change in the state of private endpoint connection."
1315+
},
13081316
"properties": {
13091317
"$ref": "#/definitions/MHSMPrivateEndpointConnectionProperties",
13101318
"x-ms-client-flatten": true,

0 commit comments

Comments
 (0)