[Hub Generated] Review request for Microsoft.ResourceHealth to add version stable/2020-05-01 (#19956)

tim-tau · web-flow · commit 54851dc584dd · 2022-09-15T10:07:07.000+08:00
* Fixing swagger to match actual responses

* Fixing azure-sdk-for-net-track2

* Adding custom words

* Fixing linting errors
diff --git a/custom-words.txt b/custom-words.txt
@@ -2714,6 +2714,8 @@ Skolt
 Thangmi
 Tuvan
 Uyghur
+occured
+Occured
 Paramter
 Spza
 metallb
diff --git a/specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/stable/2020-05-01/ResourceHealth.json b/specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/stable/2020-05-01/ResourceHealth.json
@@ -414,7 +414,7 @@
               "description": "When the resource's availabilityState is Unavailable and the reasonType is not User Initiated, it provides the date and time for when the issue is expected to be resolved.",
               "format": "date-time"
             },
-            "occurredTime": {
+            "occuredTime": {
               "type": "string",
               "description": "Timestamp for when last change in health status occurred.",
               "format": "date-time"
@@ -440,7 +440,7 @@
               "type": "object",
               "description": "An annotation describing a change in the availabilityState to Available from Unavailable with a reasonType of type Unplanned",
               "properties": {
-                "unavailableOccurredTime": {
+                "unavailableOccuredTime": {
                   "type": "string",
                   "description": "Timestamp for when the availabilityState changed to Unavailable",
                   "format": "date-time"
@@ -450,21 +450,23 @@
                   "description": "Timestamp when the availabilityState changes to Available.",
                   "format": "date-time"
                 },
-                "unavailabilitySummary": {
+                "unavailableSummary": {
                   "type": "string",
                   "description": "Brief description of cause of the resource becoming unavailable."
                 }
               }
             },
             "recommendedActions": {
               "type": "array",
+              "x-ms-identifiers": [],
               "description": "Lists actions the user can take based on the current availabilityState of the resource.",
               "items": {
                 "$ref": "#/definitions/recommendedAction"
               }
             },
             "serviceImpactingEvents": {
               "type": "array",
+              "x-ms-identifiers": [],
               "description": "Lists the service impacting events that may be affecting the health of the resource.",
               "items": {
                 "$ref": "#/definitions/serviceImpactingEvent"
@@ -475,9 +477,11 @@
       }
     },
     "operationListResult": {
+      "type": "object",
       "properties": {
         "value": {
           "type": "array",
+          "x-ms-identifiers": [],
           "items": {
             "$ref": "#/definitions/operation"
           },
@@ -491,6 +495,7 @@
     },
     "operation": {
       "description": "Operation available in the resourcehealth resource provider.",
+      "type": "object",
       "properties": {
         "name": {
           "type": "string",
@@ -631,26 +636,20 @@
       "description": "Error details.",
       "type": "object",
       "properties": {
-        "error": {
-          "type": "object",
-          "description": "The error object.",
-          "properties": {
-            "code": {
-              "description": "The error code.",
-              "type": "string",
-              "readOnly": true
-            },
-            "message": {
-              "description": "The error message.",
-              "type": "string",
-              "readOnly": true
-            },
-            "details": {
-              "description": "The error details.",
-              "type": "string",
-              "readOnly": true
-            }
-          }
+        "code": {
+          "description": "The error code.",
+          "type": "string",
+          "readOnly": true
+        },
+        "message": {
+          "description": "The error message.",
+          "type": "string",
+          "readOnly": true
+        },
+        "details": {
+          "description": "The error details.",
+          "type": "string",
+          "readOnly": true
         }
       }
     }
diff --git a/specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/stable/2020-05-01/examples/AvailabilityStatus_GetByResource.json b/specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/stable/2020-05-01/examples/AvailabilityStatus_GetByResource.json
@@ -18,7 +18,7 @@
           "reasonType": "Unplanned",
           "reasonChronicity": "Persistent",
           "detailedStatus": "Disk problems are preventing us from automatically recovering your virtual machine",
-          "occurredTime": "2016-03-29T09:12:00Z",
+          "occuredTime": "2016-03-29T09:12:00Z",
           "reportedTime": "2016-05-04T14:11:29.7598931Z",
           "rootCauseAttributionTime": "2016-03-29T09:13:00Z",
           "resolutionETA": "2016-03-29T09:37:00Z",
diff --git a/specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/stable/2020-05-01/examples/AvailabilityStatuses_List.json b/specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/stable/2020-05-01/examples/AvailabilityStatuses_List.json
@@ -19,7 +19,7 @@
               "reasonType": "Unplanned",
               "reasonChronicity": "Persistent",
               "detailedStatus": "Disk problems are preventing us from automatically recovering your virtual machine",
-              "occurredTime": "2016-03-29T09:12:00Z",
+              "occuredTime": "2016-03-29T09:12:00Z",
               "reportedTime": "2016-05-04T14:11:29.7598931Z",
               "rootCauseAttributionTime": "2016-03-29T09:13:00Z",
               "resolutionETA": "2016-03-29T09:37:00Z",
@@ -51,7 +51,7 @@
               "summary": "This virtual machine is running normally",
               "reasonChronicity": "Persistent",
               "detailedStatus": "There aren’t any known Azure platform problems affecting this virtual machine",
-              "occurredTime": "2016-03-28T16:23:00Z"
+              "occuredTime": "2016-03-28T16:23:00Z"
             }
           }
         ]
diff --git a/specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/stable/2020-05-01/examples/AvailabilityStatuses_ListByResourceGroup.json b/specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/stable/2020-05-01/examples/AvailabilityStatuses_ListByResourceGroup.json
@@ -21,12 +21,12 @@
               "reasonType": "Unplanned",
               "reasonChronicity": "Persistent",
               "detailedStatus": "We have not seen any issues with your virtual machine",
-              "occurredTime": "2016-03-29T09:12:00Z",
+              "occuredTime": "2016-03-29T09:12:00Z",
               "reportedTime": "2016-05-04T14:11:29.7598931Z",
               "recentlyResolved": {
-                "unavailableOccurredTime": "2017-02-28T00:48:00Z",
+                "unavailableOccuredTime": "2017-02-28T00:48:00Z",
                 "resolvedTime": "2017-02-28T00:49:00Z",
-                "unavailabilitySummary": "We are sorry your SQL database is unavailable"
+                "unavailableSummary": "We are sorry your SQL database is unavailable"
               },
               "recommendedActions": [
                 {
@@ -49,7 +49,7 @@
               "reasonType": "Unplanned",
               "reasonChronicity": "Persistent",
               "detailedStatus": "Diskproblemsarepreventingusfromautomaticallyrecoveringyourvirtualmachine",
-              "occurredTime": "2016-03-29T09:12:00Z",
+              "occuredTime": "2016-03-29T09:12:00Z",
               "reportedTime": "2016-05-04T14:11:29.7598931Z",
               "rootCauseAttributionTime": "2016-03-29T09:13:00Z",
               "resolutionETA": "2016-03-29T09:37:00Z",
diff --git a/specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/stable/2020-05-01/examples/AvailabilityStatuses_ListBySubscriptionId.json b/specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/stable/2020-05-01/examples/AvailabilityStatuses_ListBySubscriptionId.json
@@ -20,12 +20,12 @@
               "reasonType": "Unplanned",
               "reasonChronicity": "Persistent",
               "detailedStatus": "We have not seen any issues with your virtual machine",
-              "occurredTime": "2016-03-29T09:12:00Z",
+              "occuredTime": "2016-03-29T09:12:00Z",
               "reportedTime": "2016-05-04T14:11:29.7598931Z",
               "recentlyResolved": {
-                "unavailableOccurredTime": "2017-02-28T00:48:00Z",
+                "unavailableOccuredTime": "2017-02-28T00:48:00Z",
                 "resolvedTime": "2017-02-28T00:49:00Z",
-                "unavailabilitySummary": "We are sorry your SQL database is unavailable"
+                "unavailableSummary": "We are sorry your SQL database is unavailable"
               },
               "recommendedActions": [
                 {
@@ -48,7 +48,7 @@
               "reasonType": "Unplanned",
               "reasonChronicity": "Persistent",
               "detailedStatus": "Diskproblemsarepreventingusfromautomaticallyrecoveringyourvirtualmachine",
-              "occurredTime": "2016-03-29T09:12:00Z",
+              "occuredTime": "2016-03-29T09:12:00Z",
               "reportedTime": "2016-05-04T14:11:29.7598931Z",
               "rootCauseAttributionTime": "2016-03-29T09:13:00Z",
               "resolutionETA": "2016-03-29T09:37:00Z",
diff --git a/specification/resourcehealth/resource-manager/readme.md b/specification/resourcehealth/resource-manager/readme.md
@@ -101,7 +101,7 @@ swagger-to-sdk:
   - repo: azure-sdk-for-node
   - repo: azure-sdk-for-python-track2
   - repo: azure-sdk-for-java
-  - repo: azure-sdk-for-net
+  - repo: azure-sdk-for-net-track2
   - repo: azure-sdk-for-ruby
     after_scripts:
     - bundle install && rake arm:regen_all_profiles['azure_mgmt_resourcehealth']

-Original file line number
+Diff line change
 Thangmi
 Tuvan
 Uyghur
 +occured
 +Occured
 Paramter
 Spza
 metallb
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`"reasonType": "Unplanned",`
`20`	`20`	`"reasonChronicity": "Persistent",`
`21`	`21`	`"detailedStatus": "Disk problems are preventing us from automatically recovering your virtual machine",`
`22`		`- "occurredTime": "2016-03-29T09:12:00Z",`
	`22`	`+ "occuredTime": "2016-03-29T09:12:00Z",`
`23`	`23`	`"reportedTime": "2016-05-04T14:11:29.7598931Z",`
`24`	`24`	`"rootCauseAttributionTime": "2016-03-29T09:13:00Z",`
`25`	`25`	`"resolutionETA": "2016-03-29T09:37:00Z",`
`@@ -51,7 +51,7 @@`
`51`	`51`	`"summary": "This virtual machine is running normally",`
`52`	`52`	`"reasonChronicity": "Persistent",`
`53`	`53`	`"detailedStatus": "There aren’t any known Azure platform problems affecting this virtual machine",`
`54`		`- "occurredTime": "2016-03-28T16:23:00Z"`
	`54`	`+ "occuredTime": "2016-03-28T16:23:00Z"`
`55`	`55`	`}`
`56`	`56`	`}`
`57`	`57`	`]`