Skip to content

Commit 4503223

Browse files
lagalbralagalbra
authored
Microsoft.HanaOnAzure swagger: Update spec to add missing fields (#14879)
* Microsoft.HanaOnAzure swagger: Update spec with missing fields from RP Add HanaSID array to StorageProfile properties * Update ListOperations API to include isDataAction field * Add examples for HanaSID field * correct bool to boolean * Fix LintDiff error introduced by this PR
1 parent cada6f8 commit 4503223

File tree

5 files changed

+134
-10
lines changed

5 files changed

+134
-10
lines changed

‎specification/hanaonazure/resource-manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/examples/HanaInstances_Get.json‎

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,23 @@
3333
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/expressRouteCircuit"
3434
},
3535
"storageProfile": {
36-
"nfsIpAddress": "200.200.200.200"
36+
"nfsIpAddress": "200.200.200.200",
37+
"hanaSids": [
38+
{
39+
"gid": "1001",
40+
"memoryAllocation": "60",
41+
"sid": "mysid1",
42+
"username": "myuser1",
43+
"uid": "101010101"
44+
},
45+
{
46+
"gid": "1002",
47+
"memoryAllocation": "40",
48+
"sid": "mysid2",
49+
"username": "myuser2",
50+
"uid": "101010102"
51+
}
52+
]
3753
},
3854
"osProfile": {
3955
"computerName": "myComputerName",

‎specification/hanaonazure/resource-manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/examples/HanaInstances_List.json‎

Lines changed: 47 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,23 @@
3333
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/expressRouteCircuit"
3434
},
3535
"storageProfile": {
36-
"nfsIpAddress": "200.200.200.200"
36+
"nfsIpAddress": "200.200.200.200",
37+
"hanaSids": [
38+
{
39+
"gid": "1001",
40+
"memoryAllocation": "60",
41+
"sid": "mysid1",
42+
"username": "myuser1",
43+
"uid": "101010101"
44+
},
45+
{
46+
"gid": "1002",
47+
"memoryAllocation": "40",
48+
"sid": "mysid2",
49+
"username": "myuser2",
50+
"uid": "101010102"
51+
}
52+
]
3753
},
3854
"osProfile": {
3955
"computerName": "myComputerName1",
@@ -70,7 +86,16 @@
7086
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/expressRouteCircuit"
7187
},
7288
"storageProfile": {
73-
"nfsIpAddress": "200.200.200.201"
89+
"nfsIpAddress": "200.200.200.201",
90+
"hanaSids": [
91+
{
92+
"gid": "1001",
93+
"memoryAllocation": "100",
94+
"sid": "mysid",
95+
"username": "myuser",
96+
"uid": "101010101"
97+
}
98+
]
7499
},
75100
"osProfile": {
76101
"computerName": "myComputerName2",
@@ -105,7 +130,16 @@
105130
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup2/providers/Microsoft.Network/expressRouteCircuit"
106131
},
107132
"storageProfile": {
108-
"nfsIpAddress": "200.200.200.202"
133+
"nfsIpAddress": "200.200.200.202",
134+
"hanaSids": [
135+
{
136+
"gid": "1001",
137+
"memoryAllocation": "100",
138+
"sid": "mysid",
139+
"username": "myuser",
140+
"uid": "101010101"
141+
}
142+
]
109143
},
110144
"osProfile": {
111145
"computerName": "myComputerName3",
@@ -140,7 +174,16 @@
140174
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup2/providers/Microsoft.Network/expressRouteCircuit"
141175
},
142176
"storageProfile": {
143-
"nfsIpAddress": "200.200.200.203"
177+
"nfsIpAddress": "200.200.200.203",
178+
"hanaSids": [
179+
{
180+
"gid": "1101",
181+
"memoryAllocation": "100",
182+
"sid": "mysid101",
183+
"username": "myuser",
184+
"uid": "10000101"
185+
}
186+
]
144187
},
145188
"osProfile": {
146189
"computerName": "myComputerName4",

‎specification/hanaonazure/resource-manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/examples/HanaInstances_ListByResourceGroup.json‎

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,23 @@
3434
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/expressRouteCircuit"
3535
},
3636
"storageProfile": {
37-
"nfsIpAddress": "200.200.200.200"
37+
"nfsIpAddress": "200.200.200.200",
38+
"hanaSids": [
39+
{
40+
"gid": "1001",
41+
"memoryAllocation": "60",
42+
"sid": "mysid1",
43+
"username": "myuser1",
44+
"uid": "101010101"
45+
},
46+
{
47+
"gid": "1002",
48+
"memoryAllocation": "40",
49+
"sid": "mysid2",
50+
"username": "myuser2",
51+
"uid": "101010102"
52+
}
53+
]
3854
},
3955
"osProfile": {
4056
"computerName": "myComputerName1",
@@ -71,7 +87,16 @@
7187
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/expressRouteCircuit"
7288
},
7389
"storageProfile": {
74-
"nfsIpAddress": "200.200.200.201"
90+
"nfsIpAddress": "200.200.200.201",
91+
"hanaSids": [
92+
{
93+
"gid": "1100",
94+
"memoryAllocation": "100",
95+
"sid": "mysid100",
96+
"username": "myuser",
97+
"uid": "10000100"
98+
}
99+
]
75100
},
76101
"osProfile": {
77102
"computerName": "myComputerName2",

‎specification/hanaonazure/resource-manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/examples/HanaOperations_List.json‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414
"operation": "HanaOp1OperationName",
1515
"description": "HanaOp1Description",
1616
"origin": "HanaOp1Origin"
17-
}
17+
},
18+
"isDataAction": false
1819
},
1920
{
2021
"name": "HanaOp2",
@@ -24,7 +25,8 @@
2425
"operation": "HanaOp2OperationName",
2526
"description": "HanaOp2Description",
2627
"origin": "HanaOp2Origin"
27-
}
28+
},
29+
"isDataAction": false
2830
}
2931
]
3032
}

‎specification/hanaonazure/resource-manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json‎

Lines changed: 39 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -708,7 +708,33 @@
708708
"description": "Specifies the logical unit number of the data disk. This value is used to identify data disks within the VM and therefore must be unique for each data disk attached to a VM."
709709
}
710710
},
711-
"description": "Specifies the disk information fo the HANA instance"
711+
"description": "Specifies the disk information for the HANA instance"
712+
},
713+
"SAPSystemID": {
714+
"type": "object",
715+
"properties": {
716+
"gid": {
717+
"type": "string",
718+
"description": "Group ID of the HANA database user."
719+
},
720+
"memoryAllocation": {
721+
"type": "string",
722+
"description": "Percent of memory to allocate to this SID."
723+
},
724+
"sid": {
725+
"type": "string",
726+
"description": "SAP system ID as database identifier."
727+
},
728+
"username": {
729+
"type": "string",
730+
"description": "Name of the HANA database user."
731+
},
732+
"uid": {
733+
"type": "string",
734+
"description": "User ID of the HANA database user."
735+
}
736+
},
737+
"description": "Specifies information related to a SAP system ID"
712738
},
713739
"StorageProfile": {
714740
"properties": {
@@ -722,6 +748,13 @@
722748
"$ref": "#/definitions/Disk"
723749
},
724750
"description": "Specifies information about the operating system disk used by the hana instance."
751+
},
752+
"hanaSids": {
753+
"type": "array",
754+
"items": {
755+
"$ref": "#/definitions/SAPSystemID"
756+
},
757+
"description": "Specifies information related to SAP system IDs for the hana instance."
725758
}
726759
},
727760
"description": "Specifies the storage settings for the HANA instance disks."
@@ -796,6 +829,11 @@
796829
"display": {
797830
"$ref": "#/definitions/Display",
798831
"description": "Displayed HANA operation information"
832+
},
833+
"isDataAction": {
834+
"readOnly": true,
835+
"type": "boolean",
836+
"description": "Indicates whether the operation applies to data-plane."
799837
}
800838
},
801839
"description": "HANA operation information"

0 commit comments

Comments
 (0)