Fixed Swagger correctness for SourceControls API (#25976)

* Fixed Swagger correctness for SourceControls API

* Fix a typo

* Fix CI errors

* Fixed styling

---------

Co-authored-by: Oleh Formaniuk <oformaniuk@microsoft.com>

Author: oformaniuk

specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2023-10-01-preview/SourceControls.json

@@ -60,7 +60,7 @@
             "$ref": "../../../common/2.0/types.json#/parameters/WorkspaceName"
           },
           {
-            "$ref": "#/parameters/RepoTypeParameter"
+            "$ref": "#/parameters/RepositoryAccess"
           }
         ],
         "responses": {
@@ -307,6 +307,11 @@
           "description": "The name of the repository.",
           "type": "string"
         },
+        "installationId": {
+          "description": "The installation id of the repository.",
+          "type": "integer",
+          "format": "int64"
+        },
         "branches": {
           "description": "Array of branches.",
           "items": {
@@ -347,6 +352,9 @@
         }
       ],
       "description": "Represents a SourceControl in Azure Security Insights.",
+      "required": [
+        "properties"
+      ],
       "properties": {
         "properties": {
           "description": "source control properties",
@@ -462,6 +470,34 @@
         }
       }
     },
+    "RepositoryAccessObject": {
+      "description": "Credentials to access repository.",
+      "type": "object",
+      "required": [
+        "repositoryAccess"
+      ],
+      "properties": {
+        "repositoryAccess": {
+          "description": "RepositoryAccess properties",
+          "$ref": "#/definitions/RepositoryAccess",
+          "x-ms-client-flatten": true
+        }
+      }
+    },
+    "RepositoryAccessProperties": {
+      "description": "Credentials to access repository.",
+      "type": "object",
+      "required": [
+        "properties"
+      ],
+      "properties": {
+        "properties": {
+          "description": "RepositoryAccess properties",
+          "$ref": "#/definitions/RepositoryAccessObject",
+          "x-ms-client-flatten": true
+        }
+      }
+    },
     "Repository": {
       "type": "object",
       "required": [
@@ -490,7 +526,6 @@
       }
     },
     "ServicePrincipal": {
-      "readOnly": true,
       "type": "object",
       "description": "Service principal metadata.",
       "properties": {
@@ -508,6 +543,11 @@
           "description": "App id of service principal.",
           "type": "string",
           "readOnly": true
+        },
+        "credentialsExpireOn": {
+          "format": "date-time",
+          "description": "Expiration time of service principal credentials.",
+          "type": "string"
         }
       }
     },
@@ -959,11 +999,7 @@
         "required": [
           "repositoryAccess"
         ],
-        "properties": {
-          "repositoryAccess": {
-            "$ref": "#/definitions/RepositoryAccess"
-          }
-        }
+        "$ref": "#/definitions/RepositoryAccessProperties"
       },
       "x-ms-parameter-location": "method"
     }

specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2023-10-01-preview/examples/repositories/GetRepositories.json

@@ -4,7 +4,18 @@
     "repoType": "Github",
     "subscriptionId": "d0cfe6b2-9ac0-4464-9919-dccaee2e48c0",
     "resourceGroupName": "myRg",
-    "workspaceName": "myWorkspace"
+    "workspaceName": "myWorkspace",
+    "repositoryAccess": {
+      "etag": "\"0300bf09-0000-0000-0000-5c37296e0000\"",
+      "properties": {
+        "repositoryAccess": {
+          "kind": "OAuth",
+          "code": "939fd7c6caf754f4f41f",
+          "state": "state",
+          "clientId": "54b3c2c0-1f48-4a1c-af9f-6399c3240b73"
+        }
+      }
+    }
   },
   "responses": {
     "200": {
@@ -13,6 +24,7 @@
           {
             "url": "https://api.github.com/repos/user/reponame",
             "fullName": "reponame",
+            "installationId": 42424242,
             "branches": [
               "master",
               "develop"

specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2023-10-01-preview/examples/sourcecontrols/DeleteSourceControl.json

@@ -6,11 +6,13 @@
     "workspaceName": "myWorkspace",
     "sourceControlId": "789e0c1f-4a3d-43ad-809c-e713b677b04a",
     "repositoryAccess": {
-      "repositoryAccess": {
-        "kind": "OAuth",
-        "code": "939fd7c6caf754f4f41f",
-        "state": "state",
-        "clientId": "54b3c2c0-1f48-4a1c-af9f-6399c3240b73"
+      "properties": {
+        "repositoryAccess": {
+          "kind": "OAuth",
+          "code": "939fd7c6caf754f4f41f",
+          "state": "state",
+          "clientId": "54b3c2c0-1f48-4a1c-af9f-6399c3240b73"
+        }
       }
     }
   },