Minor Fixes for TrafficController 2022-10-01-preview (#22888)

* regex changes

* enum errors

* reverting enum changes, uupdating cadl, updating regex

* reverting example enum changes

Author: malpaniHMC

specification/servicenetworking/resource-manager/Microsoft.ServiceNetworking/cadl/TrafficController.cadl

@@ -42,7 +42,7 @@ model FrontendProperties {
   @doc("Frontend Public IP Address (Optional).")
   publicIPAddress?: FrontendPropertiesIPAddress;
   @visibility("read")
-  @doc("test doc")
+  @doc("Provisioning State of Traffic Controller Frontend Resource")
   provisioningState?: ProvisioningState;
 }
 
@@ -79,7 +79,7 @@ model AssociationProperties {
   @doc("Association Subnet")
   subnet?: AssociationSubnet;
   @visibility("read")
-  @doc("Provisioning State")
+  @doc("Provisioning State of Traffic Controller Association Resource")
   provisioningState?: ProvisioningState;
 
 }
@@ -120,17 +120,17 @@ model TrafficControllerProperties {
   provisioningState?: ProvisioningState;
 }
 
-@knownValues(ProvisioningStateKV)
-model ProvisioningState is string;
-
 @lroStatus
-enum ProvisioningStateKV {
-  ...ResourceProvisioningStateKV,
+enum ProvisioningState{
   Provisioning,
   Updating,
   Deleting,
   Accepted,
+  Succeeded, 
+  Failed, 
+  Canceled
 }
+
 @doc("Resource ID definition used by parent to reference child resources.")
 model ResourceID{
   @doc("Resource ID of child resource.")
@@ -147,7 +147,7 @@ interface FrontendsInterface extends ResourceInstanceOperations<Frontend, Fronte
 }
 
 @armResourceOperations
-interface TrafficControllerInterface extends ResourceOperations<TrafficController, TrafficControllerProperties>{
+interface TrafficControllerInterface extends ResourceInstanceOperations<TrafficController, TrafficControllerProperties>{
 }
 
 interface Operations extends Azure.ResourceManager.Operations {}

specification/servicenetworking/resource-manager/Microsoft.ServiceNetworking/cadl/examples/AssociationGet.json

@@ -14,7 +14,7 @@
         "id": "/subscriptions/subid/resourcegroups/rg1/providers/Microsoft.ServiceNetworking/trafficControllers/tc1/associations/as1",
         "location": "NorthCentralUS",
         "properties": {
-          "associationType": "Subnet",
+          "associationType": "subnets",
           "subnet": {
             "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet-tc/subnets/tc-subnet"
           },

specification/servicenetworking/resource-manager/Microsoft.ServiceNetworking/cadl/examples/AssociationPatch.json

@@ -7,7 +7,7 @@
     "associationName": "as1",
     "properties": {
       "properties": {
-        "associationType": "Subnet",
+        "associationType": "subnets",
         "subnet": {
           "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet-tc/subnets/tc-subnet"
         }
@@ -22,7 +22,7 @@
         "id": "/subscriptions/subid/resourcegroups/rg1/providers/Microsoft.ServiceNetworking/trafficControllers/tc1/associations/as1",
         "location": "NorthCentralUS",
         "properties": {
-          "associationType": "Subnet",
+          "associationType": "subnets",
           "subnet": {
             "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet-tc/subnets/tc-subnet"
           }

specification/servicenetworking/resource-manager/Microsoft.ServiceNetworking/cadl/examples/AssociationPut.json

@@ -8,7 +8,7 @@
     "resource": {
       "location": "NorthCentralUS",
       "properties": {
-        "associationType": "Subnet",
+        "associationType": "subnets",
         "subnet": {
           "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet-tc/subnets/tc-subnet"
         }
@@ -23,7 +23,7 @@
         "id": "/subscriptions/subid/resourcegroups/rg1/providers/Microsoft.ServiceNetworking/trafficControllers/tc1/associations/as1",
         "location": "NorthCentralUS",
         "properties": {
-          "associationType": "Subnet",
+          "associationType": "subnets",
           "subnet": {
             "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet-tc/subnets/tc-subnet"
           },
@@ -38,7 +38,7 @@
         "id": "/subscriptions/subid/resourcegroups/rg1/providers/Microsoft.ServiceNetworking/trafficControllers/tc1/associations/as1",
         "location": "NorthCentralUS",
         "properties": {
-          "associationType": "Subnet",
+          "associationType": "subnets",
           "subnet": {
             "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet-tc/subnets/tc-subnet"
           }

specification/servicenetworking/resource-manager/Microsoft.ServiceNetworking/cadl/examples/AssociationsGet.json

@@ -15,7 +15,7 @@
             "id": "/subscriptions/subid/resourcegroups/rg1/providers/Microsoft.ServiceNetworking/trafficControllers/tc1/associations/as1",
             "location": "NorthCentralUS",
             "properties": {
-              "associationType": "Subnet",
+              "associationType": "subnets",
               "subnet": {
                 "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/vnet-tc/subnets/tc-subnet"
               },

specification/servicenetworking/resource-manager/Microsoft.ServiceNetworking/preview/2022-10-01-preview/TrafficController.json

@@ -1319,7 +1319,7 @@
       "required": true,
       "description": "Name of Association",
       "type": "string",
-      "pattern": "[A-Za-z0-9]*",
+      "pattern": "[A-Za-z0-9]+[A-Za-z0-9-_.]{0,62}[A-Za-z0-9_]+",
       "x-ms-parameter-location": "method"
     },
     "Frontend.frontendName": {
@@ -1328,7 +1328,7 @@
       "required": true,
       "description": "Frontends",
       "type": "string",
-      "pattern": "[A-Za-z0-9]*",
+      "pattern": "[A-Za-z0-9]+[A-Za-z0-9-_.]{0,62}[A-Za-z0-9_]+",
       "x-ms-parameter-location": "method"
     },
     "TrafficController.trafficControllerName": {
@@ -1337,7 +1337,7 @@
       "required": true,
       "description": "traffic controller name for path",
       "type": "string",
-      "pattern": "[A-Za-z0-9]*",
+      "pattern": "[A-Za-z0-9]+[A-Za-z0-9-_.]{0,62}[A-Za-z0-9_]+",
       "x-ms-parameter-location": "method"
     }
   }