Skip to content

Commit 36172a1

Browse files
authored
HanaOnAzure: correctly annotate read-only properties with readOnly (#15205)
* HanaOnAzure: correctly annotate read-only properties with readOnly * Correct labels on examples * Correct request for Create example * Correct usage of readonly hwRevision in Create exammple
1 parent 4e4d1db commit 36172a1

File tree

2 files changed

+16
-19
lines changed

2 files changed

+16
-19
lines changed

specification/hanaonazure/resource-manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/examples/HanaInstances_Create.json

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,33 +10,18 @@
1010
"key": "value"
1111
},
1212
"properties": {
13-
"hanaInstanceId": "00000000-0000-0000-0000-000000000000",
14-
"powerState": "started",
15-
"proximityPlacementGroup": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Compute/proximityPlacementGroups/myplacementgroup",
16-
"hwRevision": "Rev 3",
17-
"hardwareProfile": {
18-
"hardwareType": "Cisco_UCS",
19-
"hanaInstanceSize": "S72"
20-
},
2113
"networkProfile": {
2214
"networkInterfaces": [
2315
{
2416
"ipAddress": "100.100.100.100"
2517
}
26-
],
27-
"circuitId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.Network/expressRouteCircuit"
28-
},
29-
"storageProfile": {
30-
"nfsIpAddress": "200.200.200.200"
18+
]
3119
},
3220
"osProfile": {
3321
"computerName": "myComputerName",
34-
"osType": "SUSE",
35-
"version": "12 SP1",
3622
"sshPublicKey": "AAAAB3NzaC1yc2EAAAABJQAAAQB/nAmOjTmezNUDKYvEeIRf2YnwM9/uUG1d0BYsc8/tRtx+RGi7N2lUbp728MXGwdnL9od4cItzky/zVdLZE2cycOa18xBK9cOWmcKS0A8FYBxEQWJ/q9YVUgZbFKfYGaGQxsER+A0w/fX8ALuk78ktP31K69LcQgxIsl7rNzxsoOQKJ/CIxOGMMxczYTiEoLvQhapFQMs3FL96didKr/QbrfB1WT6s3838SEaXfgZvLef1YB2xmfhbT9OXFE3FXvh2UPBfN+ffE7iiayQf/2XR+8j4N4bW30DiPtOQLGUrH1y5X/rpNZNlWW2+jGIxqZtgWg7lTy3mXy5x836Sj/6L"
3723
},
38-
"partnerNodeId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.HanaOnAzure/hanaInstances/myHanaInstance2",
39-
"provisioningState": "Succeeded"
24+
"partnerNodeId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroup/providers/Microsoft.HanaOnAzure/hanaInstances/myHanaInstance2"
4025
}
4126
}
4227
},

specification/hanaonazure/resource-manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@
203203
"summary": "Creates a SAP HANA instance.",
204204
"description": "Creates a SAP HANA instance for the specified subscription, resource group, and instance name.",
205205
"x-ms-examples": {
206-
"Get properties of a HANA instance": {
206+
"Create a HANA instance": {
207207
"$ref": "./examples/HanaInstances_Create.json"
208208
}
209209
},
@@ -254,7 +254,7 @@
254254
"summary": "Deletes a SAP HANA instance.",
255255
"description": "Deletes a SAP HANA instance with the specified subscription, resource group, and instance name.",
256256
"x-ms-examples": {
257-
"Get properties of a HANA instance": {
257+
"Delete a HANA instance": {
258258
"$ref": "./examples/HanaInstances_Delete.json"
259259
}
260260
},
@@ -569,10 +569,12 @@
569569
"description": "Specifies the network settings for the HANA instance."
570570
},
571571
"hanaInstanceId": {
572+
"readOnly": true,
572573
"type": "string",
573574
"description": "Specifies the HANA instance unique ID."
574575
},
575576
"powerState": {
577+
"readOnly": true,
576578
"type": "string",
577579
"enum": [
578580
"starting",
@@ -589,10 +591,12 @@
589591
"description": "Resource power state"
590592
},
591593
"proximityPlacementGroup": {
594+
"readOnly": true,
592595
"type": "string",
593596
"description": "Resource proximity placement group"
594597
},
595598
"hwRevision": {
599+
"readOnly": true,
596600
"type": "string",
597601
"description": "Hardware revision of a HANA instance"
598602
},
@@ -601,6 +605,7 @@
601605
"description": "ARM ID of another HanaInstance that will share a network with this HanaInstance"
602606
},
603607
"provisioningState": {
608+
"readOnly": true,
604609
"type": "string",
605610
"enum": [
606611
"Accepted",
@@ -623,6 +628,7 @@
623628
"HardwareProfile": {
624629
"properties": {
625630
"hardwareType": {
631+
"readOnly": true,
626632
"type": "string",
627633
"enum": [
628634
"Cisco_UCS",
@@ -635,6 +641,7 @@
635641
"description": "Name of the hardware type (vendor and/or their product name)"
636642
},
637643
"hanaInstanceSize": {
644+
"readOnly": true,
638645
"type": "string",
639646
"enum": [
640647
"S72m",
@@ -718,6 +725,7 @@
718725
"description": "Group ID of the HANA database user."
719726
},
720727
"memoryAllocation": {
728+
"readOnly": true,
721729
"type": "string",
722730
"description": "Percent of memory to allocate to this SID."
723731
},
@@ -739,6 +747,7 @@
739747
"StorageProfile": {
740748
"properties": {
741749
"nfsIpAddress": {
750+
"readOnly": true,
742751
"type": "string",
743752
"description": "IP Address to connect to storage."
744753
},
@@ -766,10 +775,12 @@
766775
"description": "Specifies the host OS name of the HANA instance."
767776
},
768777
"osType": {
778+
"readOnly": true,
769779
"type": "string",
770780
"description": "This property allows you to specify the type of the OS."
771781
},
772782
"version": {
783+
"readOnly": true,
773784
"type": "string",
774785
"description": "Specifies version of operating system."
775786
},
@@ -790,6 +801,7 @@
790801
"description": "Specifies the network interfaces for the HANA instance."
791802
},
792803
"circuitId": {
804+
"readOnly": true,
793805
"type": "string",
794806
"description": "Specifies the circuit id for connecting to express route."
795807
}

0 commit comments

Comments
 (0)