Skip to content

Commit 2d473c8

Browse files
akashpargatakashpargat
authored andcommitted
Swagger changes for PremiumV2 in DiskRP (#18786)
* Swagger changes for PremiumV2 in DiskRP * Added new property copyCompletionError * Updated description for new property copyCompletionError * Added the type as object for CopyCompletionError * Addressed comment to update the description for CopySourceNotFound Co-authored-by: akashpargat <akashpargat@microsoft.com>
1 parent 5e3a7ca commit 2d473c8

File tree

4 files changed

+103
-2
lines changed

4 files changed

+103
-2
lines changed

specification/compute/resource-manager/Microsoft.Compute/stable/2022-03-02/DiskRP/disk.json

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,9 @@
118118
"Create a managed disk with ssd zrs account type.": {
119119
"$ref": "./examples/diskExamples/Disk_Create_WithSSDZRSAccountType.json"
120120
},
121+
"Create a managed disk with premium v2 account type.": {
122+
"$ref": "./examples/diskExamples/Disk_Create_WithPremiumV2_LRSAccountType.json"
123+
},
121124
"Create a managed disk with security profile": {
122125
"$ref": "./examples/diskExamples/Disk_Create_WithSecurityProfile.json"
123126
},
@@ -532,7 +535,8 @@
532535
"StandardSSD_LRS",
533536
"UltraSSD_LRS",
534537
"Premium_ZRS",
535-
"StandardSSD_ZRS"
538+
"StandardSSD_ZRS",
539+
"PremiumV2_LRS"
536540
],
537541
"x-ms-enum": {
538542
"name": "DiskStorageAccountTypes",
@@ -561,6 +565,10 @@
561565
{
562566
"value": "StandardSSD_ZRS",
563567
"description": "Standard SSD zone redundant storage. Best for web servers, lightly used enterprise applications and dev/test that need storage resiliency against zone failures."
568+
},
569+
{
570+
"value": "PremiumV2_LRS",
571+
"description": "Premium SSD v2 locally redundant storage. Best for production and performance-sensitive workloads that consistently require low latency and high IOPS and throughput."
564572
}
565573
]
566574
},
@@ -572,7 +580,7 @@
572580
"description": "The sku tier."
573581
}
574582
},
575-
"description": "The disks sku name. Can be Standard_LRS, Premium_LRS, StandardSSD_LRS, UltraSSD_LRS, Premium_ZRS, or StandardSSD_ZRS."
583+
"description": "The disks sku name. Can be Standard_LRS, Premium_LRS, StandardSSD_LRS, UltraSSD_LRS, Premium_ZRS, StandardSSD_ZRS, or PremiumV2_LRS."
576584
},
577585
"DiskProperties": {
578586
"properties": {

specification/compute/resource-manager/Microsoft.Compute/stable/2022-03-02/DiskRP/diskRPCommon.json

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -410,6 +410,37 @@
410410
],
411411
"description": "Used for establishing the purchase context of any 3rd Party artifact through MarketPlace."
412412
},
413+
"CopyCompletionError": {
414+
"type": "object",
415+
"properties": {
416+
"errorCode": {
417+
"type": "string",
418+
"description": "Indicates the error code if the background copy of a resource created via the CopyStart operation fails.",
419+
"enum": [
420+
"CopySourceNotFound"
421+
],
422+
"x-ms-enum": {
423+
"name": "CopyCompletionError",
424+
"modelAsString": true,
425+
"values": [
426+
{
427+
"value": "CopySourceNotFound",
428+
"description": "Indicates that the source snapshot was deleted while the background copy of the resource created via CopyStart operation was in progress."
429+
}
430+
]
431+
}
432+
},
433+
"errorMessage": {
434+
"type": "string",
435+
"description": "Indicates the error message if the background copy of a resource created via the CopyStart operation fails."
436+
}
437+
},
438+
"required": [
439+
"errorCode",
440+
"errorMessage"
441+
],
442+
"description": "Indicates the error details if the background copy of a resource created via the CopyStart operation fails."
443+
},
413444
"SupportedCapabilities": {
414445
"type": "object",
415446
"properties": {
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
{
2+
"parameters": {
3+
"subscriptionId": "{subscription-id}",
4+
"resourceGroupName": "myResourceGroup",
5+
"api-version": "2022-03-02",
6+
"diskName": "myPremiumV2Disk",
7+
"disk": {
8+
"location": "West US",
9+
"sku": {
10+
"name": "PremiumV2_LRS"
11+
},
12+
"properties": {
13+
"creationData": {
14+
"createOption": "Empty"
15+
},
16+
"diskSizeGB": 200,
17+
"diskIOPSReadWrite": 125,
18+
"diskMBpsReadWrite": 3000
19+
}
20+
}
21+
},
22+
"responses": {
23+
"202": {
24+
"body": {
25+
"properties": {
26+
"creationData": {
27+
"createOption": "Empty"
28+
},
29+
"diskSizeGB": 200,
30+
"provisioningState": "Updating"
31+
},
32+
"location": "West US",
33+
"name": "myPremiumV2Disk",
34+
"sku": {
35+
"name": "PremiumV2_LRS",
36+
"tier": "Premium"
37+
}
38+
}
39+
},
40+
"200": {
41+
"body": {
42+
"properties": {
43+
"creationData": {
44+
"createOption": "Empty"
45+
},
46+
"diskSizeGB": 200,
47+
"provisioningState": "Updating"
48+
},
49+
"location": "West US",
50+
"name": "myPremiumV2Disk",
51+
"sku": {
52+
"name": "PremiumV2_LRS",
53+
"tier": "Premium"
54+
}
55+
}
56+
}
57+
}
58+
}

specification/compute/resource-manager/Microsoft.Compute/stable/2022-03-02/DiskRP/snapshot.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -587,6 +587,10 @@
587587
"type": "number",
588588
"description": "Percentage complete for the background copy when a resource is created via the CopyStart operation."
589589
},
590+
"copyCompletionError": {
591+
"$ref": "./diskRPCommon.json#/definitions/CopyCompletionError",
592+
"description": "Indicates the error details if the background copy of a resource created via the CopyStart operation fails."
593+
},
590594
"dataAccessAuthMode": {
591595
"$ref": "./diskRPCommon.json#/definitions/DataAccessAuthMode"
592596
}

0 commit comments

Comments
 (0)