Skip to content

Commit 261d642

Browse files
david-msftdavid-msft
authored
AAS - Fix Swagger Correctness Issue V4 (#12531)
* add missing properties and response code * remove default * add default * Revert "add default" This reverts commit 4977c0c. * fix prettier * add readonly field
1 parent 1d99e42 commit 261d642

File tree

4 files changed

+358
-0
lines changed

4 files changed

+358
-0
lines changed

‎specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json‎

Lines changed: 116 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,12 @@
129129
"$ref": "#/definitions/AnalysisServicesServer"
130130
}
131131
},
132+
"202": {
133+
"description": "Preparing. The operation is still completing.",
134+
"schema": {
135+
"$ref": "#/definitions/AnalysisServicesServer"
136+
}
137+
},
132138
"default": {
133139
"description": "Error response describing why the operation failed.",
134140
"schema": {
@@ -569,6 +575,9 @@
569575
"202": {
570576
"description": "Accepted. The operation is ongoing."
571577
},
578+
"204": {
579+
"description": "No Content."
580+
},
572581
"default": {
573582
"description": "Error response describing why the operation failed.",
574583
"schema": {
@@ -708,6 +717,108 @@
708717
"description": "The origin",
709718
"type": "string",
710719
"readOnly": true
720+
},
721+
"properties": {
722+
"description": "Additional properties to expose performance metrics to shoebox.",
723+
"properties": {
724+
"serviceSpecification": {
725+
"description": "Performance metrics to shoebox.",
726+
"properties": {
727+
"metricSpecifications": {
728+
"description": "The metric specifications.",
729+
"type": "array",
730+
"readOnly": true,
731+
"items": {
732+
"$ref": "#/definitions/MetricSpecifications"
733+
}
734+
},
735+
"logSpecifications": {
736+
"description": "The log specifications.",
737+
"type": "array",
738+
"readOnly": true,
739+
"items": {
740+
"$ref": "#/definitions/LogSpecifications"
741+
}
742+
}
743+
}
744+
}
745+
}
746+
}
747+
}
748+
},
749+
"MetricSpecifications": {
750+
"description": "Available operation metric specification for exposing performance metrics to shoebox.",
751+
"type": "object",
752+
"properties": {
753+
"name": {
754+
"description": "The name of metric.",
755+
"type": "string",
756+
"readOnly": true
757+
},
758+
"displayName": {
759+
"description": "The displayed name of metric.",
760+
"type": "string",
761+
"readOnly": true
762+
},
763+
"displayDescription": {
764+
"description": "The displayed description of metric.",
765+
"type": "string",
766+
"readOnly": true
767+
},
768+
"unit": {
769+
"description": "The unit of the metric.",
770+
"type": "string",
771+
"readOnly": true
772+
},
773+
"aggregationType": {
774+
"description": "The aggregation type of metric.",
775+
"type": "string",
776+
"readOnly": true
777+
},
778+
"dimensions": {
779+
"description": "The dimensions of metric.",
780+
"type": "array",
781+
"readOnly": true,
782+
"items": {
783+
"$ref": "#/definitions/MetricDimensions"
784+
}
785+
}
786+
}
787+
},
788+
"LogSpecifications": {
789+
"description": "The log metric specification for exposing performance metrics to shoebox.",
790+
"type": "object",
791+
"properties": {
792+
"name": {
793+
"description": "The name of metric.",
794+
"type": "string",
795+
"readOnly": true
796+
},
797+
"displayName": {
798+
"description": "The displayed name of log.",
799+
"type": "string",
800+
"readOnly": true
801+
},
802+
"blobDuration": {
803+
"description": "The blob duration for the log.",
804+
"type": "string",
805+
"readOnly": true
806+
}
807+
}
808+
},
809+
"MetricDimensions": {
810+
"description": "Metric dimension.",
811+
"type": "object",
812+
"properties": {
813+
"name": {
814+
"description": "Dimension name.",
815+
"type": "string",
816+
"readOnly": true
817+
},
818+
"displayName": {
819+
"description": "Dimension display name.",
820+
"type": "string",
821+
"readOnly": true
711822
}
712823
}
713824
},
@@ -1175,6 +1286,11 @@
11751286
"type": "integer",
11761287
"format": "int32"
11771288
},
1289+
"timeStamp": {
1290+
"description": "the timestamp for the error.",
1291+
"type": "string",
1292+
"readOnly": true
1293+
},
11781294
"details": {
11791295
"readOnly": true,
11801296
"type": "array",

‎specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-07-14/analysisservices.json‎

Lines changed: 102 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -803,6 +803,108 @@
803803
"description": "The origin",
804804
"type": "string",
805805
"readOnly": true
806+
},
807+
"properties": {
808+
"description": "Additional properties to expose performance metrics to shoebox.",
809+
"properties": {
810+
"serviceSpecification": {
811+
"description": "Performance metrics to shoebox.",
812+
"properties": {
813+
"metricSpecifications": {
814+
"description": "The metric specifications.",
815+
"type": "array",
816+
"readOnly": true,
817+
"items": {
818+
"$ref": "#/definitions/MetricSpecifications"
819+
}
820+
},
821+
"logSpecifications": {
822+
"description": "The log specifications.",
823+
"type": "array",
824+
"readOnly": true,
825+
"items": {
826+
"$ref": "#/definitions/LogSpecifications"
827+
}
828+
}
829+
}
830+
}
831+
}
832+
}
833+
}
834+
},
835+
"MetricSpecifications": {
836+
"description": "Available operation metric specification for exposing performance metrics to shoebox.",
837+
"type": "object",
838+
"properties": {
839+
"name": {
840+
"description": "The name of metric.",
841+
"type": "string",
842+
"readOnly": true
843+
},
844+
"displayName": {
845+
"description": "The displayed name of metric.",
846+
"type": "string",
847+
"readOnly": true
848+
},
849+
"displayDescription": {
850+
"description": "The displayed description of metric.",
851+
"type": "string",
852+
"readOnly": true
853+
},
854+
"unit": {
855+
"description": "The unit of the metric.",
856+
"type": "string",
857+
"readOnly": true
858+
},
859+
"aggregationType": {
860+
"description": "The aggregation type of metric.",
861+
"type": "string",
862+
"readOnly": true
863+
},
864+
"dimensions": {
865+
"description": "The dimensions of metric.",
866+
"type": "array",
867+
"readOnly": true,
868+
"items": {
869+
"$ref": "#/definitions/MetricDimensions"
870+
}
871+
}
872+
}
873+
},
874+
"LogSpecifications": {
875+
"description": "The log metric specification for exposing performance metrics to shoebox.",
876+
"type": "object",
877+
"properties": {
878+
"name": {
879+
"description": "The name of metric.",
880+
"type": "string",
881+
"readOnly": true
882+
},
883+
"displayName": {
884+
"description": "The displayed name of log.",
885+
"type": "string",
886+
"readOnly": true
887+
},
888+
"blobDuration": {
889+
"description": "The blob duration for the log.",
890+
"type": "string",
891+
"readOnly": true
892+
}
893+
}
894+
},
895+
"MetricDimensions": {
896+
"description": "Metric dimension.",
897+
"type": "object",
898+
"properties": {
899+
"name": {
900+
"description": "Dimension name.",
901+
"type": "string",
902+
"readOnly": true
903+
},
904+
"displayName": {
905+
"description": "Dimension display name.",
906+
"type": "string",
907+
"readOnly": true
806908
}
807909
}
808910
},

‎specification/analysisservices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json‎

Lines changed: 113 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,12 @@
139139
"$ref": "#/definitions/AnalysisServicesServer"
140140
}
141141
},
142+
"202": {
143+
"description": "Preparing. The operation is still completing.",
144+
"schema": {
145+
"$ref": "#/definitions/AnalysisServicesServer"
146+
}
147+
},
142148
"default": {
143149
"description": "Error response describing why the operation failed.",
144150
"schema": {
@@ -850,6 +856,108 @@
850856
"description": "The origin",
851857
"type": "string",
852858
"readOnly": true
859+
},
860+
"properties": {
861+
"description": "Additional properties to expose performance metrics to shoebox.",
862+
"properties": {
863+
"serviceSpecification": {
864+
"description": "Performance metrics to shoebox.",
865+
"properties": {
866+
"metricSpecifications": {
867+
"description": "The metric specifications.",
868+
"type": "array",
869+
"readOnly": true,
870+
"items": {
871+
"$ref": "#/definitions/MetricSpecifications"
872+
}
873+
},
874+
"logSpecifications": {
875+
"description": "The log specifications.",
876+
"type": "array",
877+
"readOnly": true,
878+
"items": {
879+
"$ref": "#/definitions/LogSpecifications"
880+
}
881+
}
882+
}
883+
}
884+
}
885+
}
886+
}
887+
},
888+
"MetricSpecifications": {
889+
"description": "Available operation metric specification for exposing performance metrics to shoebox.",
890+
"type": "object",
891+
"properties": {
892+
"name": {
893+
"description": "The name of metric.",
894+
"type": "string",
895+
"readOnly": true
896+
},
897+
"displayName": {
898+
"description": "The displayed name of metric.",
899+
"type": "string",
900+
"readOnly": true
901+
},
902+
"displayDescription": {
903+
"description": "The displayed description of metric.",
904+
"type": "string",
905+
"readOnly": true
906+
},
907+
"unit": {
908+
"description": "The unit of the metric.",
909+
"type": "string",
910+
"readOnly": true
911+
},
912+
"aggregationType": {
913+
"description": "The aggregation type of metric.",
914+
"type": "string",
915+
"readOnly": true
916+
},
917+
"dimensions": {
918+
"description": "The dimensions of metric.",
919+
"type": "array",
920+
"readOnly": true,
921+
"items": {
922+
"$ref": "#/definitions/MetricDimensions"
923+
}
924+
}
925+
}
926+
},
927+
"LogSpecifications": {
928+
"description": "The log metric specification for exposing performance metrics to shoebox.",
929+
"type": "object",
930+
"properties": {
931+
"name": {
932+
"description": "The name of metric.",
933+
"type": "string",
934+
"readOnly": true
935+
},
936+
"displayName": {
937+
"description": "The displayed name of log.",
938+
"type": "string",
939+
"readOnly": true
940+
},
941+
"blobDuration": {
942+
"description": "The blob duration for the log.",
943+
"type": "string",
944+
"readOnly": true
945+
}
946+
}
947+
},
948+
"MetricDimensions": {
949+
"description": "Metric dimension.",
950+
"type": "object",
951+
"properties": {
952+
"name": {
953+
"description": "Dimension name.",
954+
"type": "string",
955+
"readOnly": true
956+
},
957+
"displayName": {
958+
"description": "Dimension display name.",
959+
"type": "string",
960+
"readOnly": true
853961
}
854962
}
855963
},
@@ -1439,6 +1547,11 @@
14391547
"type": "integer",
14401548
"format": "int32"
14411549
},
1550+
"timeStamp": {
1551+
"description": "the timestamp for the error.",
1552+
"type": "string",
1553+
"readOnly": true
1554+
},
14421555
"details": {
14431556
"readOnly": true,
14441557
"type": "array",

0 commit comments

Comments
 (0)