Skip to content

Commit 22f1bcd

Browse files
[Hub Generated] Review request for Microsoft.MixedReality to add version preview/2019-02-28-preview (#11626)
* add isDataAction to listOperations spec * check if type is wrong * Type should be boolean * add identity and kind to the spatial accounts def * isDataAction should be an enum * move isDataAction to its own enum * remove kind from list * refer to common types instead of defining inline * update schema to reflect reality * remove extraneous curly brace * add curly brace at the correct location * change nameAvailable to boolean * add a format for integer type * change example * updated wrong file * remove format per breaking change discussion * fix prettier error
1 parent a213469 commit 22f1bcd

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

specification/mixedreality/resource-manager/Microsoft.MixedReality/preview/2019-02-28-preview/examples/CheckLocalNameAvailability.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"responses": {
1212
"200": {
1313
"body": {
14-
"nameAvailable": "false",
14+
"nameAvailable": false,
1515
"reason": "AlreadyExists",
1616
"message": "..."
1717
}

specification/mixedreality/resource-manager/Microsoft.MixedReality/preview/2019-02-28-preview/mixedreality.json

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@
482482
"properties": {
483483
"nameAvailable": {
484484
"description": "if name Available",
485-
"$ref": "#/definitions/NameAvailability"
485+
"type": "boolean"
486486
},
487487
"reason": {
488488
"description": "Resource Name To Verify",
@@ -531,6 +531,10 @@
531531
"display": {
532532
"description": "The object that represents the operation.",
533533
"$ref": "#/definitions/OperationDisplay"
534+
},
535+
"isDataAction": {
536+
"description": "Whether or not this is a data plane operation",
537+
"type": "boolean"
534538
}
535539
}
536540
},
@@ -562,18 +566,6 @@
562566
}
563567
}
564568
},
565-
"NameAvailability": {
566-
"description": "Whether or not the name is available.",
567-
"type": "string",
568-
"enum": [
569-
"true",
570-
"false"
571-
],
572-
"x-ms-enum": {
573-
"name": "NameAvailability",
574-
"modelAsString": true
575-
}
576-
},
577569
"NameUnavailableReason": {
578570
"description": "reason of name unavailable.",
579571
"type": "string",
@@ -615,6 +607,10 @@
615607
"x-ms-client-flatten": true,
616608
"description": "Property bag.",
617609
"$ref": "#/definitions/SpatialAnchorsAccountProperties"
610+
},
611+
"identity": {
612+
"description": "The identity associated with this account",
613+
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/Identity"
618614
}
619615
}
620616
},

0 commit comments

Comments
 (0)