Subscription RP v2021-10-01 endpoint fix, s360 correctness (#17155)

* Copied the last item from private repo and renamed to 2021-10-01

* Updated the version to 2021-10-01

* Error response is updated. It is required by OpenAPI Validation Tools(linter)

* http status response on post method is updated to 201 from 202; required by OpenAPI Validation Tools(linter)

* description is added in #definitions.Operation.properties.display; required by OpenAPI Validation Tools(linter)

* updated error response to match it previous

* systemData properties are added; required by Swagger validation on the PR

* updated readme.md for the new version

* removed a file getSubscriptionOperation.json as long as it is not referenced; required by Swagger Avocado on the PR

* Modified style by npm prettier

* executed npm run prettier; required by prettier check on PR

* added type:object; required by swagger LintDiff

* added type:object; required by swagger LintDiff

* reverted back the post response of acceptOwnership to 202

* http status response on post method is updated to 201 from 202; required by OpenAPI Validation Tools(linter)

* reverted back the post response of acceptOwnership to 202

* Updated property name value to subscriptionId

* Added missing property in response body of Get List of Alias subscription API

* Updated response of default policies from 201 to 200 based on API response

* Updated example for response of default policies from 201 to 200 based on API response

* s360 fix: error response is fixed on managementpartner

* added Microsoft.Subscription/stable/2016-06-01/subscriptions.json in input file list

* Lint diff errors are fixed

* reverting back the changes for 2-16-06-01

* added v2016-06-01 for the new

* executed prettier

Co-authored-by: Ochi <ochisamand@microsoft.com>

Author: Ochirkhuyag

specification/managementpartner/resource-manager/Microsoft.ManagementPartner/preview/2018-02-01/ManagementPartner.json

@@ -322,12 +322,7 @@
     },
     "ErrorResponseCode": {
       "type": "string",
-      "description": "this is the error response code that management partner operations may return",
-      "enum": [
-        "NotFound",
-        "Conflict",
-        "BadRequest"
-      ]
+      "description": "this is the error response code that management partner operations may return"
     },
     "Error": {
       "type": "object",
@@ -336,6 +331,14 @@
         "error": {
           "$ref": "#/definitions/ExtendedErrorInfo",
           "description": "this is the ExtendedErrorInfo property"
+        },
+        "code": {
+          "$ref": "#/definitions/ErrorResponseCode",
+          "description": "this is the error response code"
+        },
+        "message": {
+          "type": "string",
+          "description": "this is the extended error info message"
         }
       }
     },

specification/subscription/resource-manager/Microsoft.Subscription/stable/2021-10-01/examples/cancelSubscription.json

@@ -6,7 +6,7 @@
   "responses": {
     "200": {
       "body": {
-        "value": "83aa47df-e3e9-49ff-877b-94304bf3d3ad"
+        "subscriptionId": "83aa47df-e3e9-49ff-877b-94304bf3d3ad"
       }
     }
   }

specification/subscription/resource-manager/Microsoft.Subscription/stable/2021-10-01/examples/changeTenantPolicy.json

@@ -11,7 +11,7 @@
     }
   },
   "responses": {
-    "201": {
+    "200": {
       "body": {
         "id": "providers/Microsoft.Subscription/policies/default",
         "name": "default",

specification/subscription/resource-manager/Microsoft.Subscription/stable/2021-10-01/examples/enableSubscription.json

@@ -6,7 +6,7 @@
   "responses": {
     "200": {
       "body": {
-        "value": "7948bcee-488c-47ce-941c-38e20ede803d"
+        "subscriptionId": "7948bcee-488c-47ce-941c-38e20ede803d"
       }
     }
   }

specification/subscription/resource-manager/Microsoft.Subscription/stable/2021-10-01/examples/renameSubscription.json

@@ -9,7 +9,7 @@
   "responses": {
     "200": {
       "body": {
-        "value": "83aa47df-e3e9-49ff-877b-94304bf3d3ad"
+        "subscriptionId": "83aa47df-e3e9-49ff-877b-94304bf3d3ad"
       }
     }
   }

specification/subscription/resource-manager/Microsoft.Subscription/stable/2021-10-01/subscriptions.json

@@ -291,7 +291,7 @@
         ]
       }
     },
-    "/providers/Microsoft.Subscription/{subscriptionId}/acceptOwnership": {
+    "/providers/Microsoft.Subscription/subscriptions/{subscriptionId}/acceptOwnership": {
       "post": {
         "description": "Accept subscription ownership.",
         "operationId": "Subscription_AcceptOwnership",
@@ -341,7 +341,7 @@
         ]
       }
     },
-    "/providers/Microsoft.Subscription/{subscriptionId}/acceptOwnershipStatus": {
+    "/providers/Microsoft.Subscription/subscriptions/{subscriptionId}/acceptOwnershipStatus": {
       "get": {
         "description": "Accept subscription ownership status.",
         "operationId": "Subscription_AcceptOwnershipStatus",
@@ -384,7 +384,7 @@
           }
         },
         "responses": {
-          "201": {
+          "200": {
             "description": "Subscription tenant policy has been successfully created/updated.",
             "schema": {
               "$ref": "#/definitions/GetTenantPolicyResponse"
@@ -544,7 +544,7 @@
       "description": "The ID of the canceled subscription",
       "type": "object",
       "properties": {
-        "value": {
+        "subscriptionId": {
           "description": "The ID of the canceled subscription",
           "type": "string",
           "readOnly": true
@@ -555,7 +555,7 @@
       "description": "The ID of the subscriptions that is being renamed",
       "type": "object",
       "properties": {
-        "value": {
+        "subscriptionId": {
           "description": "The ID of the subscriptions that is being renamed",
           "type": "string",
           "readOnly": true
@@ -566,7 +566,7 @@
       "description": "The ID of the subscriptions that is being enabled",
       "type": "object",
       "properties": {
-        "value": {
+        "subscriptionId": {
           "description": "The ID of the subscriptions that is being enabled",
           "type": "string",
           "readOnly": true
@@ -781,6 +781,10 @@
           "description": "The Management Group Id.",
           "type": "string"
         },
+        "createdTime": {
+          "description": "Created Time",
+          "type": "string"
+        },
         "tags": {
           "description": "Tags for the subscription",
           "type": "object",

specification/subscription/resource-manager/readme.md

@@ -40,6 +40,7 @@ These settings apply only when `--tag=package-2021-10` is specified on the comma
 
 ``` yaml $(tag) == 'package-2021-10'
 input-file:
+- Microsoft.Subscription/stable/2016-06-01/subscriptions.json
 - Microsoft.Subscription/stable/2021-10-01/subscriptions.json
 title: SubscriptionClient
 description: The subscription client