update ci and add uri encode

Author: aprilk-ms

.github/workflows/ci.yml

@@ -95,3 +95,12 @@ jobs:
             !TestData/feature-flags3.json
           app-configuration-endpoint: ${{ vars.APP_CONFIGURATION_ENDPOINT }}
           strict: true
+
+      - name: Test Local Action with label
+        id: test-action-label
+        uses: ./
+        with:
+          path: TestData/*.json
+          app-configuration-endpoint: ${{ vars.APP_CONFIGURATION_ENDPOINT }}
+          strict: true
+          label: test label

__tests__/feature-flag-client.test.ts

@@ -87,10 +87,11 @@ describe('Feature Flag Client', () => {
     )
   })
 
-  it('can create or update feature flag with non-empty label', async () => {
+  it('can create or update feature flag with label', async () => {
     const appConfigEndpoint = 'https://example.com'
     const featureFlagId = 'featureFlagId1'
-    const label = 'test-label'
+    // Use a label with special characters to test URL encoding
+    const label = 'test label/with special&chars'
     const value = getDummyFeatureFlagItem(featureFlagId)
 
     const getMock = jest.spyOn(axios, 'put').mockResolvedValue({
@@ -104,7 +105,7 @@ describe('Feature Flag Client', () => {
       label
     )
     expect(getMock).toBeCalledWith(
-      `${appConfigEndpoint}/kv/.appconfig.featureflag%2FfeatureFlagId1?api-version=2023-11-01&label=test-label`,
+      `${appConfigEndpoint}/kv/.appconfig.featureflag%2FfeatureFlagId1?api-version=2023-11-01&label=test%20label%2Fwith%20special%26chars`,
       {
         content_type:
           'application/vnd.microsoft.appconfig.ff+json;charset=utf-8',

src/feature-flag-client.ts

@@ -41,7 +41,7 @@ export const createOrUpdateFeatureFlag = async (
     value: JSON.stringify(value)
   }
   const response = await axios.put(
-    `${appConfigEndpoint}/kv/${getAppConfigKey(featureFlagId)}?api-version=${apiVersion}&label=${label}`,
+    `${appConfigEndpoint}/kv/${getAppConfigKey(encodeURIComponent(featureFlagId))}?api-version=${apiVersion}&label=${encodeURIComponent(label)}`,
     payload,
     { headers: await getHeaders(appConfigEndpoint) }
   )
@@ -59,7 +59,7 @@ export const deleteFeatureFlag = async (
   label: string
 ): Promise<void> => {
   const response = await axios.delete(
-    `${appConfigEndpoint}/kv/${getAppConfigKey(featureFlagId)}?api-version=${apiVersion}&label=${label}`,
+    `${appConfigEndpoint}/kv/${getAppConfigKey(featureFlagId)}?api-version=${apiVersion}&label=${encodeURIComponent(label)}`,
     { headers: await getHeaders(appConfigEndpoint) }
   )