things for next release

Author: benlk

docs/maintainer-notes.md

@@ -28,3 +28,37 @@ The plugin's [version history](https://github.com/INN/pym-shortcode/releases) lo
 - 1.3.2
 - 1.3.2.1: Gutenberg and settings page
 - 1.3.2.2: WordPress 5.0 support
+
+### Testing before release
+
+See also https://github.com/INN/docs/blob/master/projects/wordpress-plugins/release.sh.md
+
+Plugin settings:
+
+- [ ] Does the plugin settings page work?
+
+Shortcode tests:
+
+- [ ] `[pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html"]`
+- [ ] `[pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymsrc="https://pym.nprapps.org/pym.v1.min.js"]`
+- [ ] `[pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymoptions=" xdomain: '\\*\.npr\.org' "]`
+- [ ] `[pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" class="one two three four float-left mw_50"]`
+- [ ] `[pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align=""]`
+- [ ] `[pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="none"]`
+- [ ] `[pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="left"]`
+- [ ] `[pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="center"]`
+- [ ] `[pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="right"]`
+- [ ] `[pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="wide"]`
+- [ ] `[pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="full"]`
+- [ ] `[pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" id="extremely_specific_id"]`
+- [ ] `[pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymsrc="https://pym.nprapps.org/pym.v1.min.js" pymoptions=""]`
+- [ ] `[pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymsrc="https://pym.nprapps.org/pym.v1.min.js" pymoptions=""]`
+
+Gutenberg tests:
+
+- [ ] the block, when inserted, prompts users for a URL
+- [ ] the block's alignment, custom classes, custom ID, and other options are respected.
+- [ ] the block uses the default pymsrc URL if the pymsrc attribute is not set
+- [ ] on a site with Gutenberg not installed, the plugin functions
+- [ ] on a 4.9 site with Gutenberg installed, the plugin functions
+- [ ] on a 5.0 site, the plugin functions

readme.txt

@@ -48,11 +48,16 @@ Mobile view of the WordPress post with the NPR embed using Pym.js Shortcode:
 
 == Changelog ==
 
+= unreleased =
+
+- Adds credit to GitHub user [eidietrich](https://github.com/eidietrich) for [PR #55](https://github.com/INN/pym-shortcode/pull/55) in the 1.3.2.2 release notes.
+
 = 1.3.2.2 =
 
 - Plugin is now tested against WordPress 5.0 beta 3.
 - Adds support for WordPress 5.0.
 - Fixes bug where the Pym.js Embeds block did not work in WordPress 5.0. [PR #58](https://github.com/INN/pym-shortcode/pulls/58) for [issue #57](https://github.com/INN/pym-shortcode/issues/57).
+- Adds advice for where to host graphics files. [PR #55](https://github.com/INN/pym-shortcode/pull/55) from Github user [eidietrich](https://github.com/eidietrich).
 
 = 1.3.2.1 =