Merge pull request #270 from rebeccahum/rebecca/fix-114

Hide catching exceptions

Author: rebeccahum

WordPressVIPMinimum/Tests/Variables/VariableAnalysisUnitTest.inc

@@ -10,4 +10,10 @@ trait bar {
 		$this->bar(); // Undefined $this in trait OK.
 	}
 	function bar() {}
-}
+}
+
+function test() {
+	try {
+		do_something_silly();
+	} catch ( Exception $e ) {} // OK.
+}

WordPressVIPMinimum/Tests/Variables/VariableAnalysisUnitTest.php

@@ -31,9 +31,10 @@ public function getErrorList() {
 	 * @return array <int line number> => <int number of warnings>
 	 */
 	public function getWarningList() {
-		return array(
+		return [
 			5 => 2,
-		);
+			18 => 2,
+		];
 	}
 
 }

WordPressVIPMinimum/ruleset.xml

@@ -176,4 +176,10 @@
 		<severity>0</severity>
 	</rule>
 
+	<rule ref="WordPressVIPMinimum.Variables.VariableAnalysis">
+		<properties>
+			<property name="allowUnusedCaughtExceptions" value="1"/>
+		</properties>
+	</rule>
+
 </ruleset>