Merge pull request #74 from Automattic/fix-67/flag-attachment_url_to_postid

Add attachment_url_to_postid to restricted functions - wpcom_vip_atta…

Author: david-binda

WordPressVIPMinimum/Sniffs/VIP/RestrictedFunctionsSniff.php

@@ -46,6 +46,13 @@ public function getGroups() {
 					'flush_rewrite_rules',
 				),
 			),
+			'attachment_url_to_postid' => array(
+				'type' => 'error',
+				'message' => '%s() is prohibited, please use wpcom_vip_attachment_url_to_postid() instead.',
+				'functions' => array(
+					'attachment_url_to_postid',
+				),
+			),
 		);
 
 		return array_merge( $original_groups, $new_groups );

WordPressVIPMinimum/Tests/VIP/RestrictedFunctionsUnitTest.inc

@@ -8,4 +8,8 @@ wp_cache_get_multi(); // Bad.
 
 get_super_admins(); // Bad.
 
-flush_rewrite_rules(); // Bad.
+flush_rewrite_rules(); // Bad.
+
+attachment_url_to_postid(); // Bad.
+
+wpcom_vip_attachment_url_to_postid(); // OK.

WordPressVIPMinimum/Tests/VIP/RestrictedFunctionsUnitTest.php

@@ -23,6 +23,7 @@ public function getErrorList() {
 			7 => 1,
 			9 => 1,
 			11 => 1,
+			13 => 1,
 		);
 	}
 

ruleset_test.inc

@@ -126,4 +126,6 @@ eval(); // Bad. Error.
 // WordPressVIPMinimum.VIP.RestrictedFunctions
 wpcom_vip_irc(); // Bad. Error.
 
-get_children(); // Bad. Warning. Message.
+get_children(); // Bad. Warning. Message.
+
+attachment_url_to_postid(); // Bad. Error.

ruleset_test.php

@@ -43,6 +43,7 @@
 		124 => 1,
 		127 => 1,
 		129 => 1,
+		131 => 1,
 	),
 	'warnings' => array(
 		9 => 1,